[Bug 42638] New: Cannot delete an identity provider domain
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42638 Bug ID: 42638 Summary: Cannot delete an identity provider domain Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: roman.dolny@jezuici.pl QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com "Delete" buttons are not working in the "Identity provider domains for..." table. To reproduce: 1. Have an identity provider with domain(s). 2. Go to Administration > Identity Providers and click the "Manage domains" button in any row. 3. Try to delete domain with "Delete" button. => Nothing happens. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42638 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42638 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |Athens County Public list of Sponsors| |Libraries Sponsorship status|--- |Sponsored Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42638 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 199265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199265&action=edit Bug 42638: Cannot delete an identity provider domain This patch updates the identity provider domain page so that clicking the "Delete" button from the list of existing identity providers works correctly. There's a lot of unfinished copy and paste from the SMTP servers page, including a missing chuck of modal dialog HTML. To test, apply the patch and go to Administration -> Identity providers. - If necessary, add at least one identity provider. - Click the "Manage domains" button for an identity provider. - If necessary, add at least one identity provider domain. - Click the delete button corresponding to the domain you added. - A confirmation modal should appear. - Clicking "Close" should close the modal without triggering any action. - Clicking "Delete" should delete the domain. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42638 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42638 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199265|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42638 --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 199266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199266&action=edit Bug 42638: Cannot delete an identity provider domain This patch updates the identity provider domain page so that clicking the "Delete" button from the list of existing identity providers works correctly. There's a lot of unfinished copy and paste from the SMTP servers page, including a missing chuck of modal dialog HTML. To test, apply the patch and go to Administration -> Identity providers. - If necessary, add at least one identity provider. - Click the "Manage domains" button for an identity provider. - If necessary, add at least one identity provider domain. - Click the delete button corresponding to the domain you added. - A confirmation modal should appear. - Clicking "Close" should close the modal without triggering any action. - Clicking "Delete" should delete the domain. Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42638 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42638 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199266|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42638 --- Comment #3 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 199305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199305&action=edit Bug 42638: Cannot delete an identity provider domain This patch updates the identity provider domain page so that clicking the "Delete" button from the list of existing identity providers works correctly. There's a lot of unfinished copy and paste from the SMTP servers page, including a missing chuck of modal dialog HTML. To test, apply the patch and go to Administration -> Identity providers. - If necessary, add at least one identity provider. - Click the "Manage domains" button for an identity provider. - If necessary, add at least one identity provider domain. - Click the delete button corresponding to the domain you added. - A confirmation modal should appear. - Clicking "Close" should close the modal without triggering any action. - Clicking "Delete" should delete the domain. Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42638 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42638 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42638 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42638 --- Comment #5 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org