[Bug 28340] New: Provide improved display of ILL request metadata in notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28340 Bug ID: 28340 Summary: Provide improved display of ILL request metadata in notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherwood@ptfs-europe.com Currently ILL notices that contain a request's metadata just print the metadata in a random order. At the very least we should alphabetise the metadata by key. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28340 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28340 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28340 --- Comment #1 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 120914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120914&action=edit Bug 28340: Alphabetise metadata for notices This commit sorts metadata by key prior to preparing a notice with it Test plan: - Do not apply patch - Create a report with the following SQL: SELECT * FROM message_queue; - Create an ILL request with plenty of metadata - Go to "Manage request" - Send a notice to a patron - Run the report created earlier => TEST: - Observe that the metadata is in random order - Apply the patch - Create an ILL request with plenty of metadata - Go to "Manage request" - Send a notice to a patron - Run the report created earlier => TEST: - Observe that the metadata is now sorted alphabetically by key -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28340 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28340 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28340 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120914|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 122631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122631&action=edit Bug 28340: Alphabetise metadata for notices This commit sorts metadata by key prior to preparing a notice with it Test plan: - Do not apply patch - Create a report with the following SQL: SELECT * FROM message_queue; - Create an ILL request with plenty of metadata - Go to "Manage request" - Send a notice to a patron - Run the report created earlier => TEST: - Observe that the metadata is in random order - Apply the patch - Create an ILL request with plenty of metadata - Go to "Manage request" - Send a notice to a patron - Run the report created earlier => TEST: - Observe that the metadata is now sorted alphabetically by key Signed-off-by: Jill Tivey <Jill.Tivey@sasa.gov.scot> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28340 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Attached signed off patch on behalf of Jill Tavey from Scottish Government. She's tested this thoroughly and is happy to sign-off.. being ILL it's difficult to test with a sandbox so it was set up on a test system for her and she asked me to update bugzilla on her behalf. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28340 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28340 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123336&action=edit Bug 28340: Unit test Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28340 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122631|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123337&action=edit Bug 28340: Alphabetise metadata for notices This commit sorts metadata by key prior to preparing a notice with it Test plan: - Do not apply patch - Create a report with the following SQL: SELECT * FROM message_queue; - Create an ILL request with plenty of metadata - Go to "Manage request" - Send a notice to a patron - Run the report created earlier => TEST: - Observe that the metadata is in random order - Apply the patch - Create an ILL request with plenty of metadata - Go to "Manage request" - Send a notice to a patron - Run the report created earlier => TEST: - Observe that the metadata is now sorted alphabetically by key Signed-off-by: Jill Tivey <Jill.Tivey@sasa.gov.scot> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28340 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com QA Contact| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28340 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123336|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 125120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125120&action=edit Bug 28340: Unit test Signed-off-by: Nick Clemens <nick@bywatersolutions.com> JD amended patch: remove commented line -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28340 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28340 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28340 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28340 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28340 Andrew Isherwood <bugzilla@warmlight.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bugzilla@warmlight.co.uk |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28340 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org