[Bug 16146] New: ACQ: Previewed records in Z39.50 search results are wrong
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16146 Bug ID: 16146 Summary: ACQ: Previewed records in Z39.50 search results are wrong Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: christian.stelzenmueller@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When searching for records via Z39.50 in Aquisitions the context menu links display the wrong records (probably the last one on the list). This was fixed by bug 15318 on master. But not backported as it is an enhancement. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16146 Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15318 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15318 [Bug 15318] Use Bootstrap modal for MARC and Card preview when ordering an external source -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16146 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16146 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16146 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49540&action=edit Bug 16146 - ACQ: Previewed records in Z39.50 search results are wrong For 3.22.x only: This patch fixes a bug which was fixed in cataloging by Bug 6367 and fixed in master by Bug 15318. A misplaced line of JavaScript means that the popup menu of options shown when clicking in a table cell links to the wrong record. To test: 1. Apply the patch and navigate to Acquisitions. 2. Locate an exsiting basket or create a new one. 3. Add to the basket using the option to order from an external source.. 4. Perform a search which will return multiple results. 5. Test the "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. 6. Click anywhere in the results table to show the hidden menu and test the "Preview MARC," "Preview card," and "Order" links it displays, confirming that the actions complete using the correct record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16146 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|15318 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15318 [Bug 15318] Use Bootstrap modal for MARC and Card preview when ordering an external source -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16146 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Both MARC and Card look good on 3.22.x for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16146 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #2)
Both MARC and Card look good on 3.22.x for me.
It's not the links in the last table cell in each row, but in the little menu which appears if you click within one of the other table cells. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16146 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16146 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49540|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49558&action=edit Bug 16146 - ACQ: Previewed records in Z39.50 search results are wrong For 3.22.x only: This patch fixes a bug which was fixed in cataloging by Bug 6367 and fixed in master by Bug 15318. A misplaced line of JavaScript means that the popup menu of options shown when clicking in a table cell links to the wrong record. To test: 1. Apply the patch and navigate to Acquisitions. 2. Locate an exsiting basket or create a new one. 3. Add to the basket using the option to order from an external source.. 4. Perform a search which will return multiple results. 5. Test the "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. 6. Click anywhere in the results table to show the hidden menu and test the "Preview MARC," "Preview card," and "Order" links it displays, confirming that the actions complete using the correct record. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16146 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #3)
(In reply to Jonathan Druart from comment #2)
Both MARC and Card look good on 3.22.x for me.
It's not the links in the last table cell in each row, but in the little menu which appears if you click within one of the other table cells.
Indeed! Sorry not to read commit messages with attention... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16146 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16146 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49558|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 49566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49566&action=edit [PASSED QA] Bug 16146 - ACQ: Previewed records in Z39.50 search results are wrong For 3.22.x only: This patch fixes a bug which was fixed in cataloging by Bug 6367 and fixed in master by Bug 15318. A misplaced line of JavaScript means that the popup menu of options shown when clicking in a table cell links to the wrong record. To test: 1. Apply the patch and navigate to Acquisitions. 2. Locate an exsiting basket or create a new one. 3. Add to the basket using the option to order from an external source.. 4. Perform a search which will return multiple results. 5. Test the "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. 6. Click anywhere in the results table to show the hidden menu and test the "Preview MARC," "Preview card," and "Order" links it displays, confirming that the actions complete using the correct record. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16146 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|ACQ: Previewed records in |[3.22] ACQ: Previewed |Z39.50 search results are |records in Z39.50 search |wrong |results are wrong -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16146 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Passed QA |Pushed to Stable --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.6. Thanks everyone -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org