[Bug 27696] New: Allow choice between ISSUESLIP and ISSUEQSLIP when printing a SCO receipt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27696 Bug ID: 27696 Summary: Allow choice between ISSUESLIP and ISSUEQSLIP when printing a SCO receipt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Some libraries like to print the issue quick slip from the SCO page, others like to print the regular issue slip here. We should allow for librarians to choose which one they'd like their patrons to get. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27696 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27696 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 116840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116840&action=edit Bug 27696: add SCOSlipChoice system pref To test: 1. Apply patch, updatedatabase. 2. Look for the new system preference SCOSlipChoice. 3. Make sure your ISSUESLIP and ISSUEQSLIP have different info in them so you can differentiate between the two. 3. Switch SCOSlipChoice to ISSUESLIP, make sure the SCO now prints the issue slip. 4. Switch SCOSlipChoice to ISSUEQSLIP, make sure the SCO now prints the issue quick slip. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27696 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27696 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27696 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116840|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 117349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117349&action=edit Bug 27696: add SCOSlipChoice system pref To test: 1. Apply patch, updatedatabase. 2. Look for the new system preference SCOSlipChoice. 3. Make sure your ISSUESLIP and ISSUEQSLIP have different info in them so you can differentiate between the two. 3. Switch SCOSlipChoice to ISSUESLIP, make sure the SCO now prints the issue slip. 4. Switch SCOSlipChoice to ISSUEQSLIP, make sure the SCO now prints the issue quick slip. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27696 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- I hate to complicate things, but would it be simpler to give SCO it's own slip? I've got no problem with this solution as it stands. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27696 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Kyle M Hall from comment #3)
I hate to complicate things, but would it be simpler to give SCO it's own slip? I've got no problem with this solution as it stands.
It is more complicated but I do like this idea. +1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27696 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES [...] +('SCOSlipChoice' , '0', 'issueqlsip', 'issueqslip|issueslip', 'Allow choice for SCO receipt print', 'Choice' ), The fields do not match! Value 0 is not correct. The options are not correct too etc. Please make sure that the former default == qslip is inserted. Note that it is confusing too that the sco script tests for qslip and our values are issueslip and issueqslip. sco script contains: if (my $letter = IssueSlip ($session->param('branch') || $branch, $borrowernumber, $print eq "qslip")) { We even have wrong calls in a test like: t/db_dependent/Members/IssueSlip.t: $slip = IssueSlip( $branchcode, $borrowernumber, 'quickslip' ); I would recommend to correct that too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27696 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Lucas Gass from comment #4)
(In reply to Kyle M Hall from comment #3)
I hate to complicate things, but would it be simpler to give SCO it's own slip? I've got no problem with this solution as it stands.
It is more complicated but I do like this idea. +1
+1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27696 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow choice between |Make a dedicated SCO issue |ISSUESLIP and ISSUEQSLIP |slip |when printing a SCO receipt | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27696 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make a dedicated SCO issue |Add a dedicated self |slip |checkout (SCO) issue slip --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Still valid. Lucas, this is assigned to you - is this correct? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27696 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27696 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- We should just have SCO-dedicated slips, IMHO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27696 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|lucas@bywatersolutions.com |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org