[Bug 30577] New: Item specific holds location can be missed when placing title level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577 Bug ID: 30577 Summary: Item specific holds location can be missed when placing title level holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 133539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133539&action=edit Bug 30577: Move item specific pickup locations to the left When placing holds, staff will set the pickup location at the top, choose an item, then place the hold. It is easy not to notice the item specific locations dropdown. This patch moves it in line with the other selction areas on the request screen. To test: 1 - Find a record on staff client, place hold 2 - Select a patron to load the request screen 3 - Note the location dropdown for next available hold 4 - Note the item specific locations on the far right 5 - Apply patch 6 - Reload the page 7 - Note the item specific location dropdowns are now moved to the left 8 - Place the hold, verify it works with the dropdowns 9 - Verify title levelholds still work as expected 10 - Verify multi-holds still work -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 133540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133540&action=edit Bug 30577: Fix a missing closing tag This didn't affect table display, but when there was a biblioloo.warn we were not closing the first <td> tag Confirm multi-holds table loads correctly when one (or more) records cannot be held -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30579 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 [Bug 30579] When placing item level hold, some options that are not used are not disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133539|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 133572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133572&action=edit Bug 30577: Move item specific pickup locations to the left When placing holds, staff will set the pickup location at the top, choose an item, then place the hold. It is easy not to notice the item specific locations dropdown. This patch moves it in line with the other selction areas on the request screen. To test: 1 - Find a record on staff client, place hold 2 - Select a patron to load the request screen 3 - Note the location dropdown for next available hold 4 - Note the item specific locations on the far right 5 - Apply patch 6 - Reload the page 7 - Note the item specific location dropdowns are now moved to the left 8 - Place the hold, verify it works with the dropdowns 9 - Verify title levelholds still work as expected 10 - Verify multi-holds still work Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133540|0 |1 is obsolete| | --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 133573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133573&action=edit Bug 30577: Fix a missing closing tag This didn't affect table display, but when there was a biblioloo.warn we were not closing the first <td> tag Confirm multi-holds table loads correctly when one (or more) records cannot be held Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577 Marie <marie.hedbom@musikverket.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie.hedbom@musikverket.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133572|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 133687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133687&action=edit Bug 30577: Move item specific pickup locations to the left When placing holds, staff will set the pickup location at the top, choose an item, then place the hold. It is easy not to notice the item specific locations dropdown. This patch moves it in line with the other selction areas on the request screen. To test: 1 - Find a record on staff client, place hold 2 - Select a patron to load the request screen 3 - Note the location dropdown for next available hold 4 - Note the item specific locations on the far right 5 - Apply patch 6 - Reload the page 7 - Note the item specific location dropdowns are now moved to the left 8 - Place the hold, verify it works with the dropdowns 9 - Verify title levelholds still work as expected 10 - Verify multi-holds still work Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133573|0 |1 is obsolete| | --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 133688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133688&action=edit Bug 30577: Fix a missing closing tag This didn't affect table display, but when there was a biblioloo.warn we were not closing the first <td> tag Confirm multi-holds table loads correctly when one (or more) records cannot be held Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- A change to ysearch.pl crept in here Nick.. I'll fix it up for you whilst QAing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133687|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133896&action=edit Bug 30577: Move item specific pickup locations to the left When placing holds, staff will set the pickup location at the top, choose an item, then place the hold. It is easy not to notice the item specific locations dropdown. This patch moves it in line with the other selction areas on the request screen. To test: 1 - Find a record on staff client, place hold 2 - Select a patron to load the request screen 3 - Note the location dropdown for next available hold 4 - Note the item specific locations on the far right 5 - Apply patch 6 - Reload the page 7 - Note the item specific location dropdowns are now moved to the left 8 - Place the hold, verify it works with the dropdowns 9 - Verify title levelholds still work as expected 10 - Verify multi-holds still work Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133688|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133897&action=edit Bug 30577: Fix a missing closing tag This didn't affect table display, but when there was a biblioloo.warn we were not closing the first <td> tag Confirm multi-holds table loads correctly when one (or more) records cannot be held Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Looks good, works as expceted.. QA scripts happy. PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.jonsson@kreablo.se --- Comment #11 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Why is there even an item specific location selector? Do we not always place exactly one hold and the pickup location is specific to the hold, regardless of whether it is an item hold or biblio hold? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Andreas Jonsson from comment #11)
Why is there even an item specific location selector?
Do we not always place exactly one hold and the pickup location is specific to the hold, regardless of whether it is an item hold or biblio hold?
I think not the number of holds is the issue here, but the valid pickup locations. The pull down for 'next available' can take into account what the sum of items allows for pickup-location, but for each item there might be differences depending on where it's coming from. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577 --- Comment #13 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Andreas Jonsson from comment #11)
Why is there even an item specific location selector?
Do we not always place exactly one hold and the pickup location is specific to the hold, regardless of whether it is an item hold or biblio hold?
The item-specific pickup location dropdowns were added in Bug 28338. As Katrin says, these don't impact how many holds one is placing. They allow Koha to correctly provide only valid pickup locations in a situation where specific items are limited in where they can be transferred for a hold. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577 --- Comment #14 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Wouldn't it be better to disable the radio button and grey out the items that cannot be picked when you select a specific pickup location, and conversely, grey out and disable pickup locations in the drop down menu when selecting an item? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577 --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Andreas Jonsson from comment #14)
Wouldn't it be better to disable the radio button and grey out the items that cannot be picked when you select a specific pickup location, and conversely, grey out and disable pickup locations in the drop down menu when selecting an item?
That adjustment is taking place on bug 30579 This bug is simply addressing the fact that all other selections are made on the left hand side of the screen - having the pickup location on the far right means it is not obvious when selecting an item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Makes sens. In addition, we may replace column name "Allowed pickup locations" with something like "Choose pickup locations". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577 --- Comment #17 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30577 --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 135017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135017&action=edit Bug 30577: [21.11.x] Move item specific pickup locations to the left When placing holds, staff will set the pickup location at the top, choose an item, then place the hold. It is easy not to notice the item specific locations dropdown. This patch moves it in line with the other selction areas on the request screen. To test: 1 - Find a record on staff client, place hold 2 - Select a patron to load the request screen 3 - Note the location dropdown for next available hold 4 - Note the item specific locations on the far right 5 - Apply patch 6 - Reload the page 7 - Note the item specific location dropdowns are now moved to the left 8 - Place the hold, verify it works with the dropdowns 9 - Verify title levelholds still work as expected 10 - Verify multi-holds still work Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 30577: Fix a missing closing tag This didn't affect table display, but when there was a biblioloo.warn we were not closing the first <td> tag Confirm multi-holds table loads correctly when one (or more) records cannot be held Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org