[Bug 33703] New: Bug in Date of Birth Field Entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Bug ID: 33703 Summary: Bug in Date of Birth Field Entry Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: kkrueger@cuyahogalibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Created attachment 150894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150894&action=edit DateNoSlash_1 Description: When using the Koha Date of Birth field to add a new patron, entering a date without punctuation (/ or -) causes the date to change to an incorrect date. Steps to reproduce: 1. From Koha Patron module > add new patron > patron identity section, Date of birth field, enter a birthdate for 24 May 1964 as 05241964 (DateNoSlash_1.png) manually. 2. Tab or hit enter, and the birth date that is recorded changes to 06/10/1964 or June 10 1964 (DateNoSlash_2.png). Similar behavior happens whenever the date is entered without punctuation. Expected Results: If data is entered in this field without slashes or hyphens, the slashes would be input without changing the intended date. Suggesting here a correction to correctly assign birthdates as entered with or without punctuation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #1 from Kristi <kkrueger@cuyahogalibrary.org> --- Created attachment 150895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150895&action=edit DateNoSlash_2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Kristi <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 lthorrat@cuyahogalibrary.org <lthorrat@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lthorrat@cuyahogalibrary.or | |g Priority|P5 - low |P3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Which Dateformat are you using? I am not sure how easy it would be to implement this as the MM DD and YY parts can be in a different position depending on the DateFormat. Do you know if this worked with the old date picker widget? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Bug in Date of Birth Field |Entering dates should be |Entry |more flexible accepting | |different entry formats -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #3 from Kristi <kkrueger@cuyahogalibrary.org> --- (In reply to Katrin Fischer from comment #2)
Which Dateformat are you using?
I am not sure how easy it would be to implement this as the MM DD and YY parts can be in a different position depending on the DateFormat. Do you know if this worked with the old date picker widget?
Our dateformat is set to mm/dd/yyyy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- This is definitely not a bug in the sense of something not working the way it's designed to. Koha doesn't have code that automatically formats entry into dates, that's why the date picker widget is used. However, it is certainly becoming increasingly common for date fields to accept and automatically format text entry, and adding that should be something we look into. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- So what appears to be happening is that the date is being parsed as if the expected separators are there. i.e: 05241964 is being read as: 05/41/64 The 41st day of May becomes the 10th of June -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- cleave.js looks like a stable and popular library that handles this very well. It is licensed as "Apache License Version 2.0". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 155719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155719&action=edit Bug 33703: Add cleave.js for direct input dateformatting To test: 1. Apply patch 2. Restart all, clear browser cache 3. In the staff interface start testing some flatpickr instances with direct inputs. 4. Try entering your dates without delimiters, '/' or '-', or '.'. 5. Make sure the dates are well formed. 6. Test with each of dateformat's Koha supports. ( system preference 'dateformat'). Some places to test: -Patron record date of birth -Patron record registration date -Patron record expiry date -Checkouts, manually set a due date -Patron category, enrollment period -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 155720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155720&action=edit Bug 33703: (follow-up) declare variables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Looks very cool! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155720|0 |1 is obsolete| | --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 155861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155861&action=edit Bug 33703: (follow-up) declare variables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 155862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155862&action=edit Bug 33703: Add cleave.js (OPAC) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #12 from David Nind <david@davidnind.com> --- I had a go at testing, but haven't signed off. Some things I noted - don't think any are show stoppers: 0. Took a little getting used to - but seems OK overall. For example, if you are used to typing the separators such as 25/ and having it come up automatically. 1. Entering dates: - if you start, but don't finish (for example, you get interrupted), the date clears after about 14-15 seconds (for some date fields only). For example: Patron date of birth, type 2023 (where date format = YYYY-MM-DD). - if you partially complete a date, for example 20.02.2 then click away (for example another tab or application window) it autocompletes the date using what is in the date picker - in the example it would add it as 2023. Another example: 20. and then click on another window, makes it 20.01.2023. If date picker doesn't have Yesterday or Today options, and you click away on another tab/window, it is cleared. - acquisitions - adding an item from an existing record: item details - date acquired - autocompletes, when you click away, doesn't time out; accounting details - estimated date of delivery - same behavour. - cataloguing - dateaccessioned.pl plugin (added to a tag for a framework): defaults to today's date (as expected), you can change. - log viewer: as per acquisitions. 2. Dates with time: for example, checkouts and specifying the due date - from the date picker if you select any date (including Yesterday, Today, and Tomorrow) it puts the time as 23:59; entering it manually, it automatically makes it 00, and you can't enter the seconds (I vaguely remember testing for a bug where the time was important and caused "issues", but I can't remember what). 3. Koha About > Licenses page: I think we normally add the license information for libraries used in Koha. 4. OPAC - there doesn't seem to be too many places where there is a date field, but this may just depend on modules enabled: - Placing a hold: doesn't seem to work, for example: for a record select Place a hold, then show more options - can't manually enter the date (note that there are no Yesterday Today Tomorrow options - only today's date and future dates). - Your account > Personal details > Date of birth: doesn't time out, if you click away it autocompletes if it can. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34923 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34923 [Bug 34923] OPAC hold page flatpickr does not allow direct input of dates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- David, I appreciate your very through testing!
0. Took a little getting used to - but seems OK overall. For example, if you are used to typing the separators such as 25/ and having it come up automatically. This is the intent of the patch. And I think this is OK because if you manually type the separator/delimiter nothing happens, since it is automatically added.
1. Entering dates:
- if you start, but don't finish (for example, you get interrupted), the date clears after about 14-15 seconds (for some date fields only). For example: Patron date of birth, type 2023 (where date format = YYYY-MM-DD).
- if you partially complete a date, for example 20.02.2 then click away (for example another tab or application window) it autocompletes the date using what is in the date picker - in the example it would add it as 2023. Another example: 20. and then click on another window, makes it 20.01.2023. If date picker doesn't have Yesterday or Today options, and you click away on another tab/window, it is cleared. Correct me if I am wrong but it appears like this happens with or without my patch, right?
2. Dates with time: for example, checkouts and specifying the due date - from the date picker if you select any date (including Yesterday, Today, and Tomorrow) it puts the time as 23:59; entering it manually, it automatically makes it 00, and you can't enter the seconds (I vaguely remember testing for a bug where the time was important and caused "issues", but I can't remember what). Maybe Bug 29477? Again, this allow happens without this patchset. But if you think I should deal with it here I am happy to do so!
3. Koha About > Licenses page: I think we normally add the license information for libraries used in Koha. Good call, this should be added and I will do so.
4. OPAC - there doesn't seem to be too many places where there is a date field, but this may just depend on modules enabled:
- Placing a hold: doesn't seem to work, for example: for a record select Place a hold, then show more options - can't manually enter the date (note that there are no Yesterday Today Tomorrow options - only today's date and future dates). I have filed and patched Bug 34923.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #14 from David Nind <david@davidnind.com> --- (In reply to Lucas Gass from comment #13)
1. Entering dates:
- if you start, but don't finish (for example, you get interrupted), the date clears after about 14-15 seconds (for some date fields only). For example: Patron date of birth, type 2023 (where date format = YYYY-MM-DD).
- if you partially complete a date, for example 20.02.2 then click away (for example another tab or application window) it autocompletes the date using what is in the date picker - in the example it would add it as 2023. Another example: 20. and then click on another window, makes it 20.01.2023. If date picker doesn't have Yesterday or Today options, and you click away on another tab/window, it is cleared.
You are right, this happens without the patch. So no change in behavour.
2. Dates with time: for example, checkouts and specifying the due date - from the date picker if you select any date (including Yesterday, Today, and Tomorrow) it puts the time as 23:59; entering it manually, it automatically makes it 00, and you can't enter the seconds (I vaguely remember testing for a bug where the time was important and caused "issues", but I can't remember what).
Maybe Bug 29477? Again, this allow happens without this patchset. But if you think I should deal with it here I am happy to do so!
That looks like the bug. Before this patch, you can enter the time manually and the default time when you select from date picker has the time as 23:59. After this patch, you can't manually enter the time and the time defaults to 00:00 using the date picker. As this is the current behavour, it will probably need to be addressed at some stage. I've only tested on the checkout form.
3. Koha About > Licenses page: I think we normally add the license information for libraries used in Koha. Good call, this should be added and I will do so.
Thanks!
4. OPAC - there doesn't seem to be too many places where there is a date field, but this may just depend on modules enabled:
- Placing a hold: doesn't seem to work, for example: for a record select Place a hold, then show more options - can't manually enter the date (note that there are no Yesterday Today Tomorrow options - only today's date and future dates). I have filed and patched Bug 34923.
Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #15 from David Nind <david@davidnind.com> --- (In reply to David Nind from comment #14)
(In reply to Lucas Gass from comment #13) ...
After this patch, you can't manually enter the time and the time defaults to 00:00 using the date picker.
As this is the current behavour, it will probably need to be addressed at some stage.
I double-checked, and I was wrong here. The time when you use the date picker defaults to 23:59. However, the rest still applies - you can't manually enter the time and it defaults to 00:00. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to David Nind from comment #15)
(In reply to David Nind from comment #14)
(In reply to Lucas Gass from comment #13) ...
After this patch, you can't manually enter the time and the time defaults to 00:00 using the date picker.
As this is the current behavour, it will probably need to be addressed at some stage.
I double-checked, and I was wrong here. The time when you use the date picker defaults to 23:59. However, the rest still applies - you can't manually enter the time and it defaults to 00:00.
Since this happens with or without these patches I have filed and patched Bug 34939. I will make this one dependent on Bug 34939. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34939 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34939 [Bug 34939] When manually entering dates in flatPickr the hour and minute get set to 00:00 not 23:59 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #17 from David Nind <david@davidnind.com> --- The patch no longer applies 8-(.. 155719 - Bug 33703: Add cleave.js for direct input dateformatting 155861 - Bug 33703: (follow-up) declare variables 155862 - Bug 33703: Add cleave.js (OPAC) Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 33703: Add cleave.js for direct input dateformatting Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 33703: Add cleave.js for direct input dateformatting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155719|0 |1 is obsolete| | --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 156411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156411&action=edit Bug 33703: Add cleave.js for direct input dateformatting To test: 1. Apply patch 2. Restart all, clear browser cache 3. In the staff interface start testing some flatpickr instances with direct inputs. 4. Try entering your dates without delimiters, '/' or '-', or '.'. 5. Make sure the dates are well formed. 6. Test with each of dateformat's Koha supports. ( system preference 'dateformat'). Some places to test: -Patron record date of birth -Patron record registration date -Patron record expiry date -Checkouts, manually set a due date -Patron category, enrollment period -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155861|0 |1 is obsolete| | --- Comment #19 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 156412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156412&action=edit Bug 33703: (follow-up) declare variables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155862|0 |1 is obsolete| | --- Comment #20 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 156413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156413&action=edit Bug 33703: Add cleave.js (OPAC) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #21 from Lucas Gass <lucas@bywatersolutions.com> --- Rebased on top of Bug 34939. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #22 from David Nind <david@davidnind.com> --- Hi Lucas. I tried a few other areas, and this seemed to work OK: acquisitions, statistics reports, calendar tool, log viewer, patron categories, circulate and fine rules, budgets. One area that didn't work was on the add or edit item forms (these use the dateaccessioned.pl plugin). Should it work here? Also, there is no license information on the About > Licenses page. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33886 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #23 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 157132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157132&action=edit Bug 33703: (follow-up) Add license information -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #24 from Lucas Gass <lucas@bywatersolutions.com> ---
One area that didn't work was on the add or edit item forms (these use the dateaccessioned.pl plugin). Should it work here?
It looks like the flatpickr on that page does not allow for the direct input of dates. Should it? If so I am happy to fix that in a seperate bug report.
Also, there is no license information on the About > Licenses page. I have added this.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Forcing users to use the calendar widget is an accessiblity issue (hard on screen readers for example). We should allow direct entry always. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #26 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 157135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157135&action=edit Bug 33703: Add cleave to dateaccessioned.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #27 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #25)
Forcing users to use the calendar widget is an accessiblity issue (hard on screen readers for example). We should allow direct entry always.
I was mistaken, you can directly input dates with the dateaccessioned plugin. Therefore I have added the ability for formatting on this bug. This is ready for testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157135|0 |1 is obsolete| | --- Comment #28 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 157206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157206&action=edit Bug 33703: Add cleave to dateaccessioned.pl Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #29 from Kristi <kkrueger@cuyahogalibrary.org> --- Reviewed these scenarios for all 4 dateformats: -Patron record date of birth -Patron record registration date -Patron record expiry date -Checkouts, manually set a due date -Patron category, enrollment period -Date fields in add to order from existing record (acquisitions) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Kristi <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #30 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 157746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157746&action=edit Bug 33703: Remove call to cleave.js in additem.tt This removes the extra call to the cleave library in additem.tt. Since calender.inc is called here this is not needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I really like this.. but I'm a little worried about cleave.js. It appears to be abandoned by the author since May 2020 (with a few people asking since if there's a prevalent fork or anyone happy to take on the maintenance). There's an open merge request for datetime support too, which I think would be important for this. I think perhaps we should investigate other masking libraries, unfortunately? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #32 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #31)
I really like this.. but I'm a little worried about cleave.js. It appears to be abandoned by the author since May 2020 (with a few people asking since if there's a prevalent fork or anyone happy to take on the maintenance).
There's an open merge request for datetime support too, which I think would be important for this.
I think perhaps we should investigate other masking libraries, unfortunately?
I'd be happy to rework this with a different library, however I'd like some general consensus/agreement on that library before proceeding. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #33 from Lucas Gass <lucas@bywatersolutions.com> --- If we cannot use cleave.js maybe the next best thing is simply using HTML5's date input: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/date -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #34 from David Cook <dcook@prosentient.com.au> --- (In reply to Lucas Gass from comment #33)
If we cannot use cleave.js maybe the next best thing is simply using HTML5's date input:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/date
I suggested that as well on a different bug but it was rejected for some reason I can't remember... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm, I don't know why we opted for flatpickr over the native date type.. though I do use options within flatpickr extensively in he bookings work and I don't think the native picker would support all the options we use? As did some research and it would appear the most well maintained, tried and tested libraries are: * InputMask (https://robinherbots.github.io/Inputmask/#/documentation) which seems to be maintained by one maintainer, and started out in the jQuery days.. you can see it's still got some jQuery style to it today.. but it is very wide spread and has pretty consistent maintanence. * iMask.js (https://imask.js.org/guide.html) which is a bit more modern, but doesn't appear to do datetime out of the box :(. Seems well maintained by a group of contributors. * Maskito (https://maskito.dev/kit/date-time) which is the newest kid to the block, has datetime handling out of the box and seems to be well maintained and very open in their development being part of Taiga UI kit. I think the simplest to switch to feels like Maskito to me.. though iMask also looks fairly trivial. Both also have Vue support baked in so would appear to be a bit future proofed given our current direction of travel. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe it could have been 118N issues that turned us away from HTML5. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #37 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #36)
I believe it could have been 118N issues that turned us away from HTML5.
I also see that the HTML5 stuff does not support datetime in the way we need it to. I do like Maskito. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #38 from Lucas Gass <lucas@bywatersolutions.com> --- Cleave.js has been revived/reborn as cleave-zen: https://github.com/nosir/cleave-zen https://github.com/nosir/cleave.js/issues/723 In my opinion this is the best, and smartest, masking library available. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #39 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 161619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161619&action=edit Bug 33703: Add Masikto core/kit for date masking -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #40 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 161663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161663&action=edit Bug 33703: Add time support -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #41 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 162722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162722&action=edit Bug 33703: Don't use Maskito when picking a range -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #42 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 162723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162723&action=edit Bug 33703: Add Maskito to dateaccessioned.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156411|0 |1 is obsolete| | Attachment #156412|0 |1 is obsolete| | Attachment #156413|0 |1 is obsolete| | Attachment #157132|0 |1 is obsolete| | Attachment #157206|0 |1 is obsolete| | Attachment #157746|0 |1 is obsolete| | --- Comment #43 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 162724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162724&action=edit Bug 33703: Add Maskito support for OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #44 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 162725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162725&action=edit Bug 33703: Add Maskito to about.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161619|0 |1 is obsolete| | --- Comment #45 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 162726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162726&action=edit Bug 33703: Add Masikto core/kit for date masking To test: 1. Apply patch 2. Restart all, clear browser cache 3. In the staff interface start testing some flatpickr instances with direct inputs. 4. Try entering your dates without delimiters, '/' or '-', or '.'. 5. Make sure the dates are well formed. 6. Test with each of dateformat's Koha supports. ( system preference 'dateformat'). 7. Add/edit an item with the dateaccessioned.pl plugin loaded, making the dates are well formed. 8. Make an item bookable by going to the item tab of a record and setting at least 1 item to "Bookable:". 9. Now "Place booking", which should trigger a modal. 10. In the "Period" date picker, which is a range, the dates should NOT be formatted. 11. Log in to the OPAC and try some date pickers ( self reg/borrower mod/ect ) Some places to test: -Patron record date of birth -Patron record registration date -Patron record expiry date -Checkouts, manually set a due date -Patron category, enrollment period -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161663|0 |1 is obsolete| | --- Comment #46 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 162727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162727&action=edit Bug 33703: Add time support -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162722|0 |1 is obsolete| | --- Comment #47 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 162728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162728&action=edit Bug 33703: Don't use Maskito when picking a range -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162723|0 |1 is obsolete| | --- Comment #48 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 162729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162729&action=edit Bug 33703: Add Maskito to dateaccessioned.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162724|0 |1 is obsolete| | --- Comment #49 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 162730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162730&action=edit Bug 33703: Add Maskito support for OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162725|0 |1 is obsolete| | --- Comment #50 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 162731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162731&action=edit Bug 33703: Add Maskito to about.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Kristi <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #51 from Kristi <kkrueger@cuyahogalibrary.org> --- I tested all four dateformat settings with the following: -Patron record date of birth -Patron record registration date -Patron record expiry date -Checkouts, manually set a due date -Patron category, enrollment period as well as Hold expires on date Suspend hold date Renewal due date These all formatted the dates as expected. I looked at all 4 dateformats in the OPAC for patron birthdate, hold not needed after, and suspend hold dates, and those all formatted as expected. I also tested the bookings modal. While entering a date does not format automatically, clicking away does create an unexpected, formatted start date. For example, with the mm/dd/yyyy format, instead of picking a date on the calendar in the modal, if I type in 07012024 for an July 01 start, the calendar start date formats to 07/12/2024 and the picker on the calendar moves to Friday, July 12. Since booking seems to be beyond the scope of this bug, signing off here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #52 from Kristi <kkrueger@cuyahogalibrary.org> --- Also reviewed the Date acquired field when adding new bib items in all 4 dateformats, which formatted as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #53 from Kristi <kkrueger@cuyahogalibrary.org> --- Also reviewed Patron record date of birth and Patron record expiry date when duplicating a patron and formatting was as expected in all 4 date formats. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162726|0 |1 is obsolete| | --- Comment #54 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 163078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163078&action=edit Bug 33703: Add Masikto core/kit for date masking To test: 1. Apply patch 2. Restart all, clear browser cache 3. In the staff interface start testing some flatpickr instances with direct inputs. 4. Try entering your dates without delimiters, '/' or '-', or '.'. 5. Make sure the dates are well formed. 6. Test with each of dateformat's Koha supports. ( system preference 'dateformat'). 7. Add/edit an item with the dateaccessioned.pl plugin loaded, making the dates are well formed. 8. Make an item bookable by going to the item tab of a record and setting at least 1 item to "Bookable:". 9. Now "Place booking", which should trigger a modal. 10. In the "Period" date picker, which is a range, the dates should NOT be formatted. 11. Log in to the OPAC and try some date pickers ( self reg/borrower mod/ect ) Some places to test: -Patron record date of birth -Patron record registration date -Patron record expiry date -Checkouts, manually set a due date -Patron category, enrollment period -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162727|0 |1 is obsolete| | --- Comment #55 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 163079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163079&action=edit Bug 33703: Add time support -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162728|0 |1 is obsolete| | --- Comment #56 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 163080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163080&action=edit Bug 33703: Don't use Maskito when picking a range -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162729|0 |1 is obsolete| | --- Comment #57 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 163081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163081&action=edit Bug 33703: Add Maskito to dateaccessioned.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162730|0 |1 is obsolete| | --- Comment #58 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 163082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163082&action=edit Bug 33703: Add Maskito support for OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162731|0 |1 is obsolete| | --- Comment #59 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 163083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163083&action=edit Bug 33703: Add Maskito to about.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #60 from Lucas Gass <lucas@bywatersolutions.com> --- Rebased for current master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163078|0 |1 is obsolete| | --- Comment #61 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163319&action=edit Bug 33703: Add Masikto core/kit for date masking To test: 1. Apply patch 2. Restart all, clear browser cache 3. In the staff interface start testing some flatpickr instances with direct inputs. 4. Try entering your dates without delimiters, '/' or '-', or '.'. 5. Make sure the dates are well formed. 6. Test with each of dateformat's Koha supports. ( system preference 'dateformat'). 7. Add/edit an item with the dateaccessioned.pl plugin loaded, making the dates are well formed. 8. Make an item bookable by going to the item tab of a record and setting at least 1 item to "Bookable:". 9. Now "Place booking", which should trigger a modal. 10. In the "Period" date picker, which is a range, the dates should NOT be formatted. 11. Log in to the OPAC and try some date pickers ( self reg/borrower mod/ect ) Some places to test: -Patron record date of birth -Patron record registration date -Patron record expiry date -Checkouts, manually set a due date -Patron category, enrollment period Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163079|0 |1 is obsolete| | --- Comment #62 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163320&action=edit Bug 33703: Add time support Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163080|0 |1 is obsolete| | --- Comment #63 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163321&action=edit Bug 33703: Don't use Maskito when picking a range Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163081|0 |1 is obsolete| | --- Comment #64 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163322&action=edit Bug 33703: Add Maskito to dateaccessioned.pl Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163082|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163323&action=edit Bug 33703: Add Maskito support for OPAC Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163083|0 |1 is obsolete| | --- Comment #66 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163324&action=edit Bug 33703: Add Maskito to about.tt Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize@ptfs-europe |testopia@bugs.koha-communit |.com |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #67 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This all looks great to me and works in my testing... it would be food to get a final QA as the implementation library changed during all the work but I think that can be fairly quick.. I'd also happily take a signoff from Owen to be a QA tick as someone familiar with the UI/Ux challenges this helps resolve. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36342 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36342 [Bug 36342] Allow entering date ranges directly in bookings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163319|0 |1 is obsolete| | Attachment #163320|0 |1 is obsolete| | Attachment #163321|0 |1 is obsolete| | Attachment #163322|0 |1 is obsolete| | Attachment #163323|0 |1 is obsolete| | Attachment #163324|0 |1 is obsolete| | --- Comment #68 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 163978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163978&action=edit Bug 33703: Add Masikto core/kit for date masking To test: 1. Apply patch 2. Restart all, clear browser cache 3. In the staff interface start testing some flatpickr instances with direct inputs. 4. Try entering your dates without delimiters, '/' or '-', or '.'. 5. Make sure the dates are well formed. 6. Test with each of dateformat's Koha supports. ( system preference 'dateformat'). 7. Add/edit an item with the dateaccessioned.pl plugin loaded, making the dates are well formed. 8. Make an item bookable by going to the item tab of a record and setting at least 1 item to "Bookable:". 9. Now "Place booking", which should trigger a modal. 10. In the "Period" date picker, which is a range, the dates should NOT be formatted. 11. Log in to the OPAC and try some date pickers ( self reg/borrower mod/ect ) Some places to test: -Patron record date of birth -Patron record registration date -Patron record expiry date -Checkouts, manually set a due date -Patron category, enrollment period Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #69 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 163979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163979&action=edit Bug 33703: Add time support Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #70 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 163980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163980&action=edit Bug 33703: Don't use Maskito when picking a range Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #71 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 163981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163981&action=edit Bug 33703: Add Maskito to dateaccessioned.pl Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #72 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 163982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163982&action=edit Bug 33703: Add Maskito support for OPAC Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #73 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 163983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163983&action=edit Bug 33703: Add Maskito to about.tt Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32693 Keywords| |rel_24_05_candidate Status|Passed QA |Patch doesn't apply --- Comment #74 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe we have a conflict with the just to be pushed bug 32693 here on the about page - could you please resolve? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 [Bug 32693] The 'About Koha' page loads slowly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163978|0 |1 is obsolete| | --- Comment #75 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165307&action=edit Bug 33703: Add Masikto core/kit for date masking To test: 1. Apply patch 2. Restart all, clear browser cache 3. In the staff interface start testing some flatpickr instances with direct inputs. 4. Try entering your dates without delimiters, '/' or '-', or '.'. 5. Make sure the dates are well formed. 6. Test with each of dateformat's Koha supports. ( system preference 'dateformat'). 7. Add/edit an item with the dateaccessioned.pl plugin loaded, making the dates are well formed. 8. Make an item bookable by going to the item tab of a record and setting at least 1 item to "Bookable:". 9. Now "Place booking", which should trigger a modal. 10. In the "Period" date picker, which is a range, the dates should NOT be formatted. 11. Log in to the OPAC and try some date pickers ( self reg/borrower mod/ect ) Some places to test: -Patron record date of birth -Patron record registration date -Patron record expiry date -Checkouts, manually set a due date -Patron category, enrollment period Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163979|0 |1 is obsolete| | --- Comment #76 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165308&action=edit Bug 33703: Add time support Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163980|0 |1 is obsolete| | --- Comment #77 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165309&action=edit Bug 33703: Don't use Maskito when picking a range Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163981|0 |1 is obsolete| | --- Comment #78 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165310&action=edit Bug 33703: Add Maskito to dateaccessioned.pl Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163982|0 |1 is obsolete| | --- Comment #79 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165311&action=edit Bug 33703: Add Maskito support for OPAC Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163983|0 |1 is obsolete| | --- Comment #80 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165312&action=edit Bug 33703: Add Maskito to about.tt Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #81 from Lucas Gass <lucas@bywatersolutions.com> --- rebased for current main and back to PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |jonathan.druart@gmail.com --- Comment #82 from Jonathan Druart <jonathan.druart@gmail.com> --- Last patch does not apply. I also spotted a typo in calendar.inc: + var delimter = ""; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #83 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165399&action=edit Bug 33703: (follow-up) Fix typo in calendar.inc Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #84 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #82)
Last patch does not apply.
I also spotted a typo in calendar.inc: + var delimter = "";
I fixed the typo, thanks. This is applying cleanly for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #85 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #86 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This makes entering dates release notes| |directly into the date | |field a bit more flexible | |by allowing to omit the | |delimiters ('/' or '-', or | |'.') for the set date | |format. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Bug 33703 depends on bug 32693, which changed state. Bug 32693 Summary: The 'About Koha' page loads slowly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32693 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37371 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37371 [Bug 37371] Direct input of dates not working when editing dates manually -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #87 from Lucas Gass <lucas@bywatersolutions.com> --- This patchset needs to be removed from main and 24.05, see Bug 37371. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #88 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I would say we should attempt to fix the issue highlighted rather than remove it ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 --- Comment #89 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #88)
I would say we should attempt to fix the issue highlighted rather than remove it ;)
I agree, I will look into a fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37643 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37643 [Bug 37643] Check for NaN instead of truthiness if calendar.inc accepts_time -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33703 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41061 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41061 [Bug 41061] No longer needed to validate dates manually -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org