[Bug 39081] New: Fix date and title sorting on batch extend due dates page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 Bug ID: 39081 Summary: Fix date and title sorting on batch extend due dates page Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 26553 Date columns should be configured to sort by unformatted date, and the title column should ignore articles when sorting. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26553 [Bug 26553] Remove KohaTable (columns_settings.inc) and use kohaTable (datatables.js) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177709&action=edit Bug 39081: Fix date and title sorting on batch extend due dates page This patch updates sorting of the batch extend due dates page so that dates and titles are sorted correctly. To test, apply the patch and go to Tools -> Batch extend due dates. - Submit parameters which will return multiple results - On the "Confirm selection" page, test the sorting of these columns: - Due date - Title - Checked out on - New due date Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177709|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177947&action=edit Bug 39081: Fix date and title sorting on batch extend due dates page This patch updates sorting of the batch extend due dates page so that dates and titles are sorted correctly. To test, apply the patch and go to Tools -> Batch extend due dates. - Submit parameters which will return multiple results - On the "Confirm selection" page, test the sorting of these columns: - Due date - Title - Checked out on - New due date Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart@gmail.com --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Not sure what's happening but it's not working for me, at least for due dates: https://snipboard.io/kZD0qz.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jonathan.druart@gmail.com Status|Failed QA |ASSIGNED --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- ok, I found something. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179122&action=edit Bug 39081: Fix order by due dates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179123&action=edit Bug 39081: Adjust the result table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179124&action=edit Bug 39081: Allow sort on item type There is no reason to not allow ordering on item type. We can now use the same parameters for both tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Assignee|jonathan.druart@gmail.com |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Found bug 39289 when working on this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39289 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39289 [Bug 39289] Batch extend due date tools only display the first 20 checkouts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #9 from Phil Ringnalda <phil@chetcolibrary.org> --- Not the end of the world, but it's a little odd to allow sorting by the column with the checkboxes when it doesn't actually sort the way you would hope, by whether or not they are checked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 --- Comment #10 from Magnus Enger <magnus@libriotech.no> --- Created attachment 180192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180192&action=edit Bug 39081: Fix date and title sorting on batch extend due dates page This patch updates sorting of the batch extend due dates page so that dates and titles are sorted correctly. To test, apply the patch and go to Tools -> Batch extend due dates. - Submit parameters which will return multiple results - On the "Confirm selection" page, test the sorting of these columns: - Due date - Title - Checked out on - New due date Sponsored-by: Athens County Public Libraries Signed-off-by: Magnus Enger <magnus@libriotech.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179122|0 |1 is obsolete| | --- Comment #11 from Magnus Enger <magnus@libriotech.no> --- Created attachment 180193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180193&action=edit Bug 39081: Fix order by due dates Signed-off-by: Magnus Enger <magnus@libriotech.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179123|0 |1 is obsolete| | --- Comment #12 from Magnus Enger <magnus@libriotech.no> --- Created attachment 180194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180194&action=edit Bug 39081: Adjust the result table Signed-off-by: Magnus Enger <magnus@libriotech.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179124|0 |1 is obsolete| | --- Comment #13 from Magnus Enger <magnus@libriotech.no> --- Created attachment 180195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180195&action=edit Bug 39081: Allow sort on item type There is no reason to not allow ordering on item type. We can now use the same parameters for both tables Signed-off-by: Magnus Enger <magnus@libriotech.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Attachment #177947|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180192|0 |1 is obsolete| | --- Comment #14 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180845&action=edit Bug 39081: Fix date and title sorting on batch extend due dates page This patch updates sorting of the batch extend due dates page so that dates and titles are sorted correctly. To test, apply the patch and go to Tools -> Batch extend due dates. - Submit parameters which will return multiple results - On the "Confirm selection" page, test the sorting of these columns: - Due date - Title - Checked out on - New due date Sponsored-by: Athens County Public Libraries Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180193|0 |1 is obsolete| | --- Comment #15 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180846&action=edit Bug 39081: Fix order by due dates Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180194|0 |1 is obsolete| | --- Comment #16 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180847&action=edit Bug 39081: Adjust the result table Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180195|0 |1 is obsolete| | --- Comment #17 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180848&action=edit Bug 39081: Allow sort on item type There is no reason to not allow ordering on item type. We can now use the same parameters for both tables Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA QA Contact|testopia@bugs.koha-communit |baptiste.wojtkowski@biblibr |y.org |e.com --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- In light of bug 38984 and bug 39015 - is it data-sort or data-order we want for dates? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 180960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180960&action=edit Bug 39081: (follow-up) Use "data-order" instead of "data-sort" Both attribute names work the same but "data-order" is more frequent in our templates. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks Owen! With all the new datatables work, is there a place we should start documenting or updating documentation? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can you please rebase on latest main? Conflicts probably due to: Bug 38984 - DataTables's columnDefs cleanup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180845|0 |1 is obsolete| | Attachment #180846|0 |1 is obsolete| | Attachment #180847|0 |1 is obsolete| | Attachment #180848|0 |1 is obsolete| | Attachment #180960|0 |1 is obsolete| | --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181253&action=edit Bug 39081: Fix date and title sorting on batch extend due dates page This patch updates sorting of the batch extend due dates page so that dates and titles are sorted correctly. To test, apply the patch and go to Tools -> Batch extend due dates. - Submit parameters which will return multiple results - On the "Confirm selection" page, test the sorting of these columns: - Due date - Title - Checked out on - New due date Sponsored-by: Athens County Public Libraries Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 --- Comment #23 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181254&action=edit Bug 39081: Fix order by due dates Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 --- Comment #24 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181255&action=edit Bug 39081: Adjust the result table Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 --- Comment #25 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181256&action=edit Bug 39081: Allow sort on item type There is no reason to not allow ordering on item type. We can now use the same parameters for both tables Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 --- Comment #26 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 181257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181257&action=edit Bug 39081: (follow-up) Use "data-order" instead of "data-sort" Both attribute names work the same but "data-order" is more frequent in our templates. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks for the quick rebase, Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #29 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 26553 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |david@davidnind.com Status|Needs documenting |RESOLVED --- Comment #30 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39081 Bug 39081 depends on bug 26553, which changed state. Bug 26553 Summary: Remove KohaTable (columns_settings.inc) and use kohaTable (datatables.js) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26553 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org