[Bug 11819] New: Don't show catalog edit menu if user has no edit permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11819 Bug ID: 11819 Summary: Don't show catalog edit menu if user has no edit permissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org When viewing a bibliographic detail page in the staff client the "Edit" toolbar menu button should not appear if the user doesn't have permission to perform any of the actions listed. Currently such a user will see an empty dropdown. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11819 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11819 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25550&action=edit Bug 11819 - Don't show catalog edit menu if user has no edit permissions Currently if the logged in user lacks any cataloging permissions the bibliographic detail page (catalogue/detail.pl) still shows the Edit button, but with an empty dropdown menu. This patch corrects the toolbar include so that the button will not appear at all. To test, view the biblio detail page as a user with various combinations of the following permissions: - edit_items - edit_catalogue - items_batchmod - items_batchdel The edit button should appear with the correct set of links when the user has any combination of the above permissions. If user has none the button should not appear. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11819 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11821 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11819 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 25557 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25557&action=edit [Signed-off]Bug 11819 - Don't show catalog edit menu if user has no edit permissions Currently if the logged in user lacks any cataloging permissions the bibliographic detail page (catalogue/detail.pl) still shows the Edit button, but with an empty dropdown menu. This patch corrects the toolbar include so that the button will not appear at all. To test, view the biblio detail page as a user with various combinations of the following permissions: - edit_items - edit_catalogue - items_batchmod - items_batchdel The edit button should appear with the correct set of links when the user has any combination of the above permissions. If user has none the button should not appear. Followed test plan, patch behaves as expected Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11819 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25550|0 |1 is obsolete| | CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11819 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11819 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 25564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25564&action=edit [PASSED QA] Bug 11819 - Don't show catalog edit menu if user has no edit permissions Currently if the logged in user lacks any cataloging permissions the bibliographic detail page (catalogue/detail.pl) still shows the Edit button, but with an empty dropdown menu. This patch corrects the toolbar include so that the button will not appear at all. To test, view the biblio detail page as a user with various combinations of the following permissions: - edit_items - edit_catalogue - items_batchmod - items_batchdel The edit button should appear with the correct set of links when the user has any combination of the above permissions. If user has none the button should not appear. Followed test plan, patch behaves as expected Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as expected, passes all tests and QA script. Template only change. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11819 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11819 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25557|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11819 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11819 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #5 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.07 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11819 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 3.12.x will be in 3.12.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org