[Bug 30404] New: Enlarge all patron searches pop-up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30404 Bug ID: 30404 Summary: Enlarge all patron searches pop-up Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Patrons Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The guarantor one has been enlarged because it contains a lot of columns but we could enlarge all others as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30404 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30063 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 [Bug 30063] Make the main patron search use the /patrons REST API route -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30404 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Now that patron searches will all be API-based it might be the time to switch to using a modal for all of the pop-up patron searches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30404 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30404 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30404 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132662&action=edit Bug 30404: Enlarge all patron search pop-ups Enlarging the pop-ups will hide the scrollbars (at least the horizontal one). Test plan: Search for patrons (when a new pop-up is opened) and confirm that the pop-up is bigger than without this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30404 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Owen Leonard from comment #1)
Now that patron searches will all be API-based it might be the time to switch to using a modal for all of the pop-up patron searches.
Yes definitely, that one of my plans :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30404 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30404 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132662|0 |1 is obsolete| | --- Comment #4 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 132750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132750&action=edit Bug 30404: Enlarge all patron search pop-ups Enlarging the pop-ups will hide the scrollbars (at least the horizontal one). Test plan: Search for patrons (when a new pop-up is opened) and confirm that the pop-up is bigger than without this patch. Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30404 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #5 from Séverine Queune <severine.queune@bulac.fr> --- Works perfectly for : - patrons to notify on receiving - select suggestion's manager - Patron's card batch - select funds owner - select funds users - select manager of an acquisition basket - serial routing list Remains the same for guarantor selection as expected Well done Jonathan ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30404 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132750|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132780&action=edit Bug 30404: Enlarge all patron search pop-ups Enlarging the pop-ups will hide the scrollbars (at least the horizontal one). Test plan: Search for patrons (when a new pop-up is opened) and confirm that the pop-up is bigger than without this patch. Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30404 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- So simple, so great! PQA Side note.. we should do the other popups too.. but after taking a look I decided not to do them inline here.. at least some may need to remain deliberately small (and possibly become modals instead of popouts) z3950 searches in particular seem like a good candidate for expansion.. some marc doc stuff in addbiblio maybe not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30404 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30404 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30404 Bug 30404 depends on bug 30063, which changed state. Bug 30063 Summary: Make the main patron search use the /patrons REST API route https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30404 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org