[Bug 27136] New: Add languages and avoid displaying nothing in facet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Bug ID: 27136 Summary: Add languages and avoid displaying nothing in facet Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: alexis.ripetti@inLibro.com Adding some languages : Cree, Afrikaans and Multiple languages, Undetermined and No linguistic content. Also adding a way to avoid displaying nothing in facet for opac and client staff when using elasticsearch as SearchEngine. Test plan: 1) Do a search, like 'a' 2) Look in the bottom of the sidebar on the left and see that there is an empty language 3) Apply patch 4) Update database 5) Do the same research 6) See that there is now "No information provided" You can test translation : TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR:
cd misc/translator perl translate update fr-FR
- Open the corresponding .po file for opac, e.g. misc/translator/po/fr-FR-opac-bootstrap.po - Locate strings pulled from koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc for translation, e.g.: msgid "%s%s%sNo information provided%s" msgstr "" - Edit the "msgstr" string however you want (it's just for testing), example : msgstr "%s%s%sAucune information fournie%s" Do the same for the client staff : - Open the corresponding .po file for opac, e.g. misc/translator/po/fr-FR-staff-prog.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc for translation, e.g.: msgid "%s%s%sNo information provided%s" msgstr "" - Edit the "msgstr" string however you want (it's just for testing), example : msgstr "%s%s%sAucune information fournie%s" - Install the updated translation:
perl translate install fr-FR
-- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 --- Comment #1 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 114107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114107&action=edit Bug 27136 - Add languages and avoid displaying nothing in facet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114107|0 |1 is obsolete| | --- Comment #2 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 114119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114119&action=edit Bug 27136 - Add languages and avoid displaying nothing in facet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alexis.ripetti@inLibro.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29561 CC| |nick@bywatersolutions.com --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- The update database here needs to be updated to use skeleton.perl as a base Moving the removal of blank facet to bug 29561 - we should not display anything as the facet cannot be searched. We don't include blank searches for any of the facets -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Changed status to Failed QA - see comment #3. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114119|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 137748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137748&action=edit Bug 27136 - Add languages and avoid displaying nothing in facet -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Alexis Ripetti <alexis.ripetti@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137748|0 |1 is obsolete| | --- Comment #6 from Alexis Ripetti <alexis.ripetti@inLibro.com> --- Created attachment 137785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137785&action=edit Bug 27136 - Add languages and avoid displaying nothing in facet Signed-off-by: Alexis Ripetti <alexis.ripetti@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Oups you also need to add languages in : installer/data/mysql/mandatory/subtag_registry.sql I suggest you split into 2 patches, one for languages and one for facet display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 139998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139998&action=edit Bug 27136: Add additional languages for facet display This patch adds two missing languages, Cree & Afrikaans, as well as some necessary linguistic definitions for faceting: Multi language, undetermined, no linguistic content Signed-off-by: Alexis Ripetti <alexis.ripetti@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 139999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139999&action=edit Bug 27136: Avoid displaying nothing in facet This patch displays 'No information provided' if a facet value/description cannot be found, rather than displaying an empty/hidden facet Signed-off-by: Alexis Ripetti <alexis.ripetti@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137785|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi, thx for the patch! Some things: 1) The database update is not idempotent, meaning that you cannot run it a second time without it causing an error: DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bz27136-Add_languages_for_facet.pl [22:55:29]: Bug 27136 - Add missing language information for facets ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry 'cr-language' for key 'uniq_lang' at /kohadevbox/koha/C4/Installer.pm line 739 As we had some issues with that in recent update (bug 30951), I think it would be better to implement some kind of check. 2) Next time it would be better to have these in 2 separate bugs: * Add languages * Avoid displaying nothing in facets Both are distinct issues and in separate patches it gives better advertising in release notes and better chances one or the other might get backported. A strategy of small granular steps usually also works to make your patches move faster. Maybe a suggestion: We could make this one about adding the languages only as the patches are nice and separate. I tihnk I agree with Nick about not displayin the empty ones, as they can't be searched for - but this discussion could be continued on bug 29561. OK? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139998|0 |1 is obsolete| | Attachment #139999|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 141239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141239&action=edit Bug 27136: Add additional languages for facet display This patch adds two missing languages, Cree & Afrikaans, as well as some necessary linguistic definitions for faceting: Multi language, undetermined, no linguistic content Signed-off-by: Alexis Ripetti <alexis.ripetti@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 141241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141241&action=edit Bug 27136: (follow-up) Make update idempotent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add languages and avoid |Add language |displaying nothing in facet | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31668 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add language |Add additional languages Text to go in the| |Adds Cree, Afrikaans and release notes| |Multiple languages, | |Undetermined and No | |linguistic content to our | |language definitions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141518&action=edit Bug 27136: (QA follow-up) Remove reference to facets, add languages to update description The new languages will also effect other pages in Koha, like the language list on the advanced search page. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Searching - Elasticsearch |Searching QA Contact| |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31715 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31715 [Bug 31715] Add missing German translations for language descriptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141522&action=edit Bug 27136: (QA follow-up) Fix entries for multiple und undetermined language(s) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- While working on translations for bug 31715 I noticed some more little changes are needed here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #15)
While working on translations for bug 31715 I noticed some more little changes are needed here.
... were needed: see second follow-up patch :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org