[Bug 9062] New: Tax and discount should be formatted the same
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 Priority: P5 - low Change sponsored?: --- Bug ID: 9062 Assignee: koha-bugs@lists.koha-community.org Summary: Tax and discount should be formatted the same Severity: trivial Classification: Unclassified OS: All Reporter: katrin.fischer@bsz-bw.de Hardware: All Status: NEW Version: master Component: Acquisitions Product: Koha Created attachment 13407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13407&action=edit screenshot On the vendor summary and vendor edit screen tax and discount percentages are fomratted differently. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13407|0 |1 is obsolete| | --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 13408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13408&action=edit screenshot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 Hugh Davenport <hugh@davenport.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 --- Comment #2 from Hugh Davenport <hugh@davenport.net.nz> --- Created attachment 14641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14641&action=edit bug 9062 Fix format for discount rate for vendors On the vendor display and edit screens, the tax rate information was formatted to 1 decimal point, while the discount rate was not. This patch adds a format string to the discount information so that it is formatted in the same way. Signed-off-by: Hugh Davenport <hugh@davenport.net.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 Hugh Davenport <hugh@davenport.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hugh@davenport.net.nz Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14641|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 14642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14642&action=edit bug 9062 Fix format for discount rate for vendors On the vendor display and edit screens, the tax rate information was formatted to 1 decimal point, while the discount rate was not. This patch adds a format string to the discount information so that it is formatted in the same way. Signed-off-by: Hugh Davenport <hugh@davenport.net.nz> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 --- Comment #4 from Hugh Davenport <hugh@davenport.net.nz> --- Actually, would this need changing for other languages? or is that done by translators? I only have an en directory. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- That's done by the translation scripts, they build other directories from the .po files. So all good. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 Hugh Davenport <hugh@davenport.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 --- Comment #6 from Hugh Davenport <hugh@davenport.net.nz> --- Created attachment 14643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14643&action=edit bug 9062 Fix spacing next to tax rate On the supplier view screen, there was a space after the discount and before the % sign, but there was none for the tax rate. This patch adds in a patch, so they look similar. Signed-off-by: Hugh Davenport <hugh@davenport.net.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14643|0 |1 is obsolete| | --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 14644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14644&action=edit bug 9062 Fix spacing next to tax rate On the supplier view screen, there was a space after the discount and before the % sign, but there was none for the tax rate. This patch adds in a patch, so they look similar. Signed-off-by: Hugh Davenport <hugh@davenport.net.nz> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 Hugh Davenport <hugh@davenport.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |hugh@davenport.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 --- Comment #8 from Hugh Davenport <hugh@davenport.net.nz> --- Just wondering whether the number of decimal points for the discount feild should be 1 or 2, it is shown as 2 in some other places, but my patch puts it to 1 here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Actually that is a good question ... 2 I think probably makes more sense. Any other opinions? It's for percentages right? 2dp makes sense to me for that -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 --- Comment #10 from Hugh Davenport <hugh@davenport.net.nz> --- Yeh, and then most of the Tax percentages I've seen are just 1dp -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think even if there is some need for discussion about how many decimals should be shown, those patches are nice little improvments to consistency. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14642|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 14686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14686&action=edit [SIGNED-OFF] Bug 9062 Fix format for discount rate for vendors On the vendor display and edit screens, the tax rate information was formatted to 1 decimal point, while the discount rate was not. This patch adds a format string to the discount information so that it is formatted in the same way. Signed-off-by: Hugh Davenport <hugh@davenport.net.nz> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Makes display on vendor detail page more consistent and passes all tests. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14644|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 14687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14687&action=edit [SIGNED-OFF] Bug 9062 Fix spacing next to tax rate On the supplier view screen, there was a space after the discount and before the % sign, but there was none for the tax rate. This patch adds in a patch, so they look similar. Signed-off-by: Hugh Davenport <hugh@davenport.net.nz> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tiny follow-up, fixes spacing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. Welcome to our newest developer! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9062 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #15 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x, will be in 3.10.3 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org