[Bug 10515] New: The prototype for GetBranchCategory and GetBranchCategories is not consistent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10515 Bug ID: 10515 Summary: The prototype for GetBranchCategory and GetBranchCategories is not consistent Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@biblibre.com The prototype is not consistent, GetBranchCategory should return only 1 result and GetBranchCategories should not have a categorycode argument. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10515 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10515 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 19275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19275&action=edit Bug 10515: The prototype for GetBranchCategory and GetBranchCategories is not consistent The prototype is not consistent, GetBranchCategory should return only 1 result and GetBranchCategories should not have a categorycode argument. This patch fixes that. Test plan: 1/ Try to add/remove/modify a library. 2/ Add some groups 3/ Add these groups to a library -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10515 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10515 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10508 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10515 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10515 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19275|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 19535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19535&action=edit [SIGNED-OFF] Bug 10515: The prototype for GetBranchCategory and GetBranchCategories is not consistent The prototype is not consistent, GetBranchCategory should return only 1 result and GetBranchCategories should not have a categorycode argument. This patch fixes that. Test plan: 1/ Try to add/remove/modify a library. 2/ Add some groups 3/ Add these groups to a library Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10515 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10515 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19535|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19597&action=edit Bug 10515: The prototype for GetBranchCategory and GetBranchCategories is not consistent The prototype is not consistent, GetBranchCategory should return only 1 result and GetBranchCategories should not have a categorycode argument. This patch fixes that. Test plan: 1/ Try to add/remove/modify a library. 2/ Add some groups 3/ Add these groups to a library Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, works as advertised. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10515 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master, along with two follow-ups to add a regression test and to fix the call to GetBranchCategories in C4/Auth.pm. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10515 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch (along with Galen's regression tests) has been pushed to 3.12.x, will be in 3.12.4. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org