[Bug 19465] New: Allow choosing Elasticsearch server on instance creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 Bug ID: 19465 Summary: Allow choosing Elasticsearch server on instance creation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz An --elasticsearch-server option switch should be added to 'koha-create'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 68094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68094&action=edit Bug 19465: Add --elasticsearch-server option to koha-create This patch adds the --elasticsearch-server option switch to koha-create. It allows choosing a different Elasticsearch configuration. It defaults to the current 'localhost:9200' value. To test: - Apply this patches - Run: $ reset_all $ man koha-create => SUCCESS: The man page shows correct information about the added option switch - Run: $ sudo koha-create --create-db test => SUCCESS: /etc/koha/sites/test/koha-conf.xml contains the default value (i.e. the current behaviour is kept) - Run: $ sudo koha-create --create-db --elasticsearch-server tomas:1234 test2 => SUCCESS: /etc/koha/sites/test2/koha-conf.xml contains the passed value in the <elasticsearch><server> section. - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 68095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68095&action=edit Bug 19465: Document koha-create --elasticsearch-server option switch Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | CC| |jonathan.druart@bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19462 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 Bouzid Fergani <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |bouzid.fergani@inlibro.com --- Comment #3 from Bouzid Fergani <bouzid.fergani@inlibro.com> --- Hi Tomas, Patch doesn't apply because it contain conflict in debian/scripts/koha-create Thanks. Bouzid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68094|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 73953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73953&action=edit Bug 19465: Add --elasticsearch-server option to koha-create This patch adds the --elasticsearch-server option switch to koha-create. It allows choosing a different Elasticsearch configuration. It defaults to the current 'localhost:9200' value. To test: - Apply this patches - Run: $ reset_all $ man koha-create => SUCCESS: The man page shows correct information about the added option switch - Run: $ sudo koha-create --create-db test => SUCCESS: /etc/koha/sites/test/koha-conf.xml contains the default value (i.e. the current behaviour is kept) - Run: $ sudo koha-create --create-db --elasticsearch-server tomas:1234 test2 => SUCCESS: /etc/koha/sites/test2/koha-conf.xml contains the passed value in the <elasticsearch><server> section. - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68095|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 73954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73954&action=edit Bug 19465: Document koha-create --elasticsearch-server option switch Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_18_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Also, please amend the test plan to include: kshell kohadev prove -v xt/verify-debian-docbook.t -- koha-create will have passed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73953|0 |1 is obsolete| | Attachment #73954|0 |1 is obsolete| | --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 80748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80748&action=edit Bug 19465: Add --elasticsearch-server option to koha-create This patch adds the --elasticsearch-server option switch to koha-create. It allows choosing a different Elasticsearch configuration. It defaults to the current 'localhost:9200' value. To test: - Apply this patches - Run: $ reset_all $ man koha-create => SUCCESS: The man page shows correct information about the added option switch - Run: $ sudo koha-create --create-db test => SUCCESS: /etc/koha/sites/test/koha-conf.xml contains the default value (i.e. the current behaviour is kept) - Run: $ sudo koha-create --create-db --elasticsearch-server tomas:1234 test2 => SUCCESS: /etc/koha/sites/test2/koha-conf.xml contains the passed value in the <elasticsearch><server> section. - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 80749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80749&action=edit Bug 19465: Document koha-create --elasticsearch-server option switch Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 Bouzid Fergani <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80749|0 |1 is obsolete| | --- Comment #9 from Bouzid Fergani <bouzid.fergani@inlibro.com> --- Created attachment 90074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90074&action=edit Bug 19465: Document koha-create --elasticsearch-server option switch Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 Bouzid Fergani <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80748|0 |1 is obsolete| | Attachment #90074|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96046&action=edit Bug 19465: Add --elasticsearch-server option to koha-create This patch adds the --elasticsearch-server option switch to koha-create. It allows choosing a different Elasticsearch configuration. It defaults to the current 'localhost:9200' value. To test: - Apply this patches - Run: $ reset_all $ man koha-create => SUCCESS: The man page shows correct information about the added option switch - Run: $ sudo koha-create --create-db test => SUCCESS: /etc/koha/sites/test/koha-conf.xml contains the default value (i.e. the current behaviour is kept) - Run: $ sudo koha-create --create-db --elasticsearch-server tomas:1234 test2 => SUCCESS: /etc/koha/sites/test2/koha-conf.xml contains the passed value in the <elasticsearch><server> section. - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96047&action=edit Bug 19465: Document koha-create --elasticsearch-server option switch Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.02 released in| | --- Comment #13 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.07 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org