http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14136 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 38812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38812&action=edit Bug 14136 - Remove superfluous template parameters from members/member-flags.pl This bug was triggered because intranet-error.log had entries like the following: member-flags.pl: Use of uninitialized value $roadtype in concatenation (.) or string at /usr/share/kohaclone/members/member-flags.pl line 176. To reproduce: Have a patron without roadtype and go to Home > Patrons > Set permissions for ... There are some template parameters that are not used in the template member-flags.tt ( $roadtype is used while preparing $address ) Unused template params are: cardnumber othernames categorycode category_type categoryname address address2 city state zipcode country phone phonepro mobile email emailpro branchcode branchname loop is_child activeBorrowerRelationship RoutingSerials To test: - Verify that you get the warning above in intranet-error.log - Verify that the parameters above are not used in the template member-flags.tt - Apply patch - Verify that setting permissions for patrons still works Note: There are a lot of indenting issues in this file. This patch does not intend to resolve them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14136 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38812|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 38951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38951&action=edit [SIGNED-OFF] Bug 14136: Remove superfluous template parameters from members/member-flags.pl This bug was triggered because intranet-error.log had entries like the following: member-flags.pl: Use of uninitialized value $roadtype in concatenation (.) or string at /usr/share/kohaclone/members/member-flags.pl line 176. To reproduce: Have a patron without roadtype and go to Home > Patrons > Set permissions for ... There are some template parameters that are not used in the template member-flags.tt ( $roadtype is used while preparing $address ) Unused template params are: cardnumber othernames categorycode category_type categoryname address address2 city state zipcode country phone phonepro mobile email emailpro branchcode branchname loop <--- this is used is_child activeBorrowerRelationship RoutingSerials To test: - Verify that you get the warning above in intranet-error.log - Verify that the parameters above are not used in the template member-flags.tt - Apply patch - Verify that setting permissions for patrons still works Note: There are a lot of indenting issues in this file. This patch does not intend to resolve them. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Warn exists, now removed. No errors -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14136 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle@bywatersolutions.com --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Those parameters are used in circ-menu.inc which is used by this template. Without them that data does not display. -- You are receiving this mail because: You are watching all bug changes.