[Bug 21796] New: Patron Restriction do not restrict checkouts if patron also has a fee/fine on their account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Bug ID: 21796 Summary: Patron Restriction do not restrict checkouts if patron also has a fee/fine on their account Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Created attachment 82109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82109&action=edit with both restriction and fine, checkout box is visible. Prior behavior: when a patron has a restriction added to their account, the ability of checking out has been removed. The checkout box is replaced by a "View restriction" box and an "Override Restriction Temporarily" box option. If Override is chosen, then the patron's checkout box will reappear for that session. Currently in Koha 18.05.05, when a patron has a restriction, this behavior described above happens correctly. However, if a patron also has a fine of a dollar amount in addition to the restriction, the checkout box is now visible allowing checkouts to occur. The fine/fee amount can be any amount- this does not seem to correlate with the noissuecharge system preference. For an example, system preference Noissuecharge set at 20.00, the value of $2.00 fine was attached to the patron and a restriction, the checkout box still appeared. If a fine/fee was above the noissuecharge, this same behavior occurred- the checkout box appears. See screenshot of bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Confirmed on master, having a look. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Did git bisect for the fun of it... lead me here: commit bddfed75913a2302c19c00b00a6fe86538af6f9f Author: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Date: Sun Jan 7 14:57:23 2018 -0300 Bug 19933: Remove patronflags - tricky ones -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the problem is here: $noissues = ( not C4::Context->preference("AllowFineOverride") and ( $owing > $noissuescharge ) ); It can reset noissues, even if it has already been set to 1 before. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 82121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82121&action=edit Bug 21796: Don't unlock checkouts if restriction exists but fines are below limit The checkout form will be removed if various conditions are met: Restrictions, a fine above noissuescharge etc. Bug 19933 changed the conditions, so a restriction will no longer block checkouts, if the fines are below the set limit. To test: - Add a restriction - Confirm the checkouts form is replaced by a message - Add a fine below the noissuescharge limit - Confirm that the form reappears - Apply the patch - Check that the checkout form is gone now - Remove restriction - form should reappear - Add to the fine, so it's above the limit - Form should disappear -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Version|18.05 |master Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre-marc.thibault@inlibr | |o.com --- Comment #5 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- It works, but I saw the form at the final step because AllowFineOverride was set at "Allow". That's just a remainder for future reviewers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82121|0 |1 is obsolete| | --- Comment #6 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 82201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82201&action=edit Bug 21796: Don't unlock checkouts if restriction exists but fines are below limit The checkout form will be removed if various conditions are met: Restrictions, a fine above noissuescharge etc. Bug 19933 changed the conditions, so a restriction will no longer block checkouts, if the fines are below the set limit. To test: - Add a restriction - Confirm the checkouts form is replaced by a message - Add a fine below the noissuescharge limit - Confirm that the form reappears - Apply the patch - Check that the checkout form is gone now - Remove restriction - form should reappear - Add to the fine, so it's above the limit - Form should disappear Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Pierre-Marc Thibault from comment #5)
It works, but I saw the form at the final step because AllowFineOverride was set at "Allow". That's just a remainder for future reviewers.
Thx for pointing this out! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82201|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 82377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82377&action=edit Bug 21796: Don't unlock checkouts if restriction exists but fines are below limit The checkout form will be removed if various conditions are met: Restrictions, a fine above noissuescharge etc. Bug 19933 changed the conditions, so a restriction will no longer block checkouts, if the fines are below the set limit. To test: - Add a restriction - Confirm the checkouts form is replaced by a message - Add a fine below the noissuescharge limit - Confirm that the form reappears - Apply the patch - Check that the checkout form is gone now - Remove restriction - form should reappear - Add to the fine, so it's above the limit - Form should disappear Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |19933 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 19933 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Andrew <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #12 from Andrew <andrew@bywatersolutions.com> --- This is sort of moot, since this is already resolved, but it looks like this bug isn't/wasn't actually allowing checkout. Koha gives you a checkout box, but when you actually try to check something out it blocks it, tells you the patron has a restriction, and doesn't give an override option. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org