[Bug 22381] New: Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Bug ID: 22381 Summary: Wording on Calendar-related system preferences not standardized Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Target Milestone: --- We've got four very similar system preferences with very different wording, which fosters confusion. ExcludeHolidaysFromMaxPickUpDelay is worded is "(Allow/Don't Allow) Closed days to be taken into account in reserves max pickup delay." OverdueNoticeCalendar is worded as "(Use Calendar/Ignore Calendar) when working out the period for overdue notices." useDaysMode is "Calculate the due date using (the calendar to skip days the library is closed/the calendar to push the due date to the next open day/circulation rules only)" finesCalendar is "Calculate fines based on days overdue (directly/not including days the library is closed." Standardizing wording across these four would make them all clearer as a group. If nothing else, I'd love to see the word "calendar" included somewhere in ExcludeHolidaysFromMaxPickUpDelay so it comes up in an easy search with the others. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Margaret <margaret@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |margaret@bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #1 from Andrew <andrew@bywatersolutions.com> --- Furthermore "closed days to be taken into account" on ExcludeHolidaysFromMaxPickUpDelay is very much open to two contradictory readings. Does taking closed days "into account" mean we are *counting* those days? Or does it mean we *are* using the calendar and therefore *not counting* those days? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Andrew, do you want to make a suggestion for rewording? I could write up a patch from that or maybe you would want to do it? I'd read it like that: Allow closed days to be taken into account = we are not counting them, using the calendar, counting days the library is open) Don't allow closed days to be taken into account = we are counting them, ignoring the calendar, only counting 'days') -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I'd go with: useDaysMode: (Use the calendar to skip days the library is closed / Use the calendar to push the due date to the next open day / Ignore the calendar) when calculating the date due. OverdueNoticeCalendar: (Use the calendar/Ignore the calendar) when calculating the period for overdue notices. finesCalendar: (Use the calendar/Ignore the calendar) when calculating the period for fines. ExcludeHolidaysFromMaxPickUpDelay: (Use the calendar/Ignore the calendar) when calculating the period for reserves max pickup delay. This makes all four follow the general syntax that's currently used for OverdueNoticeCalendar, which is really clear. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 94791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94791&action=edit Bug 22381: Change wording on Calendar-related system preferences TEST PLAN: 1. Apply Patch 2. Look at the 4 sysprefs (useDaysMode, OverdueNoticeCalendar, finesCalendar, ExcludeHolidaysFromMaxPickUpDelay) 3. Make sure the wording and options all make sense 4. Make sure the options are properly ignoring or using the calendar. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version|18.05 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 94925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94925&action=edit Bug 22381: Change wording on Calendar-related system preferences Rebased this patch so it will apply with bz15260, test plan remains the same TEST PLAN: 1. Apply Patch 2. Look at the 4 sysprefs (useDaysMode, OverdueNoticeCalendar, finesCalendar, ExcludeHolidaysFromMaxPickUpDelay) 3. Make sure the wording and options all make sense 4. Make sure the options are properly ignoring or using the calendar. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94791|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 [Bug 15260] Option for extended loan with useDaysMode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94925|0 |1 is obsolete| | --- Comment #6 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 95127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95127&action=edit Bug 22381: Change wording on Calendar-related system preferences Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Conflict with bug 13958, please rebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95127|0 |1 is obsolete| | --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 95241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95241&action=edit Bug 22381: Change wording on Calendar-related system preferences TEST PLAN: 1. Apply Patch 2. Look at the 4 sysprefs (useDaysMode, OverdueNoticeCalendar, finesCalendar, ExcludeHolidaysFromMaxPickUpDelay) 3. Make sure the wording and options all make sense 4. Make sure the options are properly ignoring or using the calendar. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Bill Carroll <bcarroll@dubuque.lib.ia.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bcarroll@dubuque.lib.ia.us Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I think you need to update the recently added SuspensionsCalendar as well 844 - Calculate suspension expiration based on days overdue 845 - pref: SuspensionsCalendar 846 type: choice 847 choices: 848 ignoreCalendar: directly. 849 noSuspensionsWhenClosed: not including days the library is closed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Good catch! Thanks, Jonathan! So, following the wording used above, that's be: (Use the calendar/Ignore the calendar) when calculating the period for suspension expiration. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95241|0 |1 is obsolete| | --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 96002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96002&action=edit Bug 22381: Change wording on Calendar-related system TEST PLAN: 1. Apply Patch 2. Look at the 5 sysprefs (useDaysMode, OverdueNoticeCalendar, finesCalendar, ExcludeHolidaysFromMaxPickUpDelay, SuspensionsCalendar) 3. Make sure the wording and options all make sense 4. Make sure the options are properly ignoring or using the calendar. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96002|0 |1 is obsolete| | --- Comment #12 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 96262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96262&action=edit Bug 22381: Change wording on Calendar-related system TEST PLAN: 1. Apply Patch 2. Look at the 5 sysprefs (useDaysMode, OverdueNoticeCalendar, finesCalendar, ExcludeHolidaysFromMaxPickUpDelay, SuspensionsCalendar) 3. Make sure the wording and options all make sense 4. Make sure the options are properly ignoring or using the calendar. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Fixed double 'when' on line 740 No errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96262|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96316&action=edit Bug 22381: Change wording on Calendar-related system TEST PLAN: 1. Apply Patch 2. Look at the 5 sysprefs (useDaysMode, OverdueNoticeCalendar, finesCalendar, ExcludeHolidaysFromMaxPickUpDelay, SuspensionsCalendar) 3. Make sure the wording and options all make sense 4. Make sure the options are properly ignoring or using the calendar. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Fixed double 'when' on line 740 No errors Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- We have a quick long option now, may be problematic for translated interface (?) https://snipboard.io/4cwWXl.jpg Passing QA anyway, not blocker (hopefully) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com --- Comment #16 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x for 19.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable --- Comment #17 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- Oops, I was too hasty with my backport. This bug has a dependency that is not in 19.05.x, reverting this. No backported to 19.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I think there is something wrong: About the pref ExcludeHolidaysFromMaxPickUpDelay, we switch "yes" (value=1) from "Allow Closed days to be taken into account in reserves max pickup delay" to "Ignore the calendar when calculating the period for reserves max pickup delay." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #20 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Just testing this and Jonathan is correct. To verify in master: - mark your library closed today and tomorrow - set ReservesMaxPickUpDelay to 1 day - set ExcludeHolidaysFromMaxPickUpDelay to "Ignore the calendar" - place hold, capture hold - hold expiration date is set to the day after tomorrow (skips closed days) - Set ExcludeHolidaysFromMaxPickUpDelay to "Use the calendar" - Place hold, capture hold - hold expiration date is set to tomorrow (doesn't skip closed days) This is 100% my error, thanks for catching it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Andrew, did you open a bug report? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24858 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858 [Bug 24858] Incorrect labels on wording in ExcludeHolidaysFromMaxPickUpDelay system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #22 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I have now. Bug 24858. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org