[Bug 33278] New: Advanced search page first tab not activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278 Bug ID: 33278 Summary: Advanced search page first tab not activated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 32683 The JS which triggers the display of a default tab on the advanced search page uses a selector which isn't specific enough now that the header search tabs are Bootstrap too. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32683 [Bug 32683] Convert header search tabs to Bootstrap -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Advanced search page first |Correct JS for activating |tab not activated |default tab on various | |pages --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- There are other pages which need the same correction, so I'm re-titling the bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 148420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148420&action=edit Bug 33278: Correct JS for activating default tab on various pages The conversion of the header search tabs to Bootstrap resulted in a bug on several staff interface pages: The first tab isn't selected by default. The jQuery selector isn't specific enough. The patch also corrects a template error which was introduced to merge-record.inc by Bug 32683. To test, apply the patch and test the following pages to confirm that the first tab on each page is selected by default: - Catalog -> Advanced search - Catalog -> MARC details - Catalog -> Search results -> Merge - Administration -> Authorized values -> Edit - Administratoin -> Library transfer limits - Administration -> Item types -> Edit - Authorities -> Authority details - Authorities -> Search -> Merge -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148420|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 148468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148468&action=edit Bug 33278: Correct JS for activating default tab on various pages The conversion of the header search tabs to Bootstrap resulted in a bug on several staff interface pages: The first tab isn't selected by default. The jQuery selector isn't specific enough. The patch also corrects a template error which was introduced to merge-record.inc by Bug 32683. To test, apply the patch and test the following pages to confirm that the first tab on each page is selected by default: - Catalog -> Advanced search - Catalog -> MARC details - Catalog -> Search results -> Merge - Administration -> Authorized values -> Edit - Administratoin -> Library transfer limits - Administration -> Item types -> Edit - Authorities -> Authority details - Authorities -> Search -> Merge Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off --- Comment #4 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works as described, thanks for the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33181 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33181 [Bug 33181] Use template wrapper for tabs on record merge pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148468|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 148549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148549&action=edit Bug 33278: Correct JS for activating default tab on various pages The conversion of the header search tabs to Bootstrap resulted in a bug on several staff interface pages: The first tab isn't selected by default. The jQuery selector isn't specific enough. The patch also corrects a template error which was introduced to merge-record.inc by Bug 32683. To test, apply the patch and test the following pages to confirm that the first tab on each page is selected by default: - Catalog -> Advanced search - Catalog -> MARC details - Catalog -> Search results -> Merge - Administration -> Authorized values -> Edit - Administratoin -> Library transfer limits - Administration -> Item types -> Edit - Authorities -> Authority details - Authorities -> Search -> Merge Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com Version(s)|23.05.00,22.11.04 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278 Bug 33278 depends on bug 32683, which changed state. Bug 32683 Summary: Convert header search tabs to Bootstrap https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32683 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org