[Bug 27726] New: OPACProblemReports cuts off message text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 Bug ID: 27726 Summary: OPACProblemReports cuts off message text Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: hannah.co@northwestu.edu QA Contact: testopia@bugs.koha-community.org OPACProblemReport text is truncated to 255 characters, in both database and email. I tested and confirmed that the patron-facing form does not limit the amount of text entered, at least not before more than 500 characters. The form should either limit characters and warn patrons of the character limit, or the database field should be expanded to allow more data storage. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Version|20.11 |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 117383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117383&action=edit Bug 27726: Add maxlength attribute to OPACProblemReport textarea This patch adds a maxlength attribute to the OPACProblemReport textarea. This will prevent the user from entering more characters than the table column limit (255). To test, apply the patch and enable the OPACProblemReport system preference. - Log into the OPAC - Click the "Report a problem" link at the bottom of the page. - You should see a hint below the textarea, "255 characters maximum." - Enter enough text in the textarea to confirm that it is cut off at 255 characters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stalkernoid@gmail.com --- Comment #2 from Peter Vashchuk <stalkernoid@gmail.com> --- Small note about testing, I didn't find "OPACProblemReport" in my sysprefs but found "OPACReportProblem" instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117383|0 |1 is obsolete| | --- Comment #3 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 118020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118020&action=edit Bug 27726: Add maxlength attribute to OPACProblemReport textarea This patch adds a maxlength attribute to the OPACProblemReport textarea. This will prevent the user from entering more characters than the table column limit (255). To test, apply the patch and enable the OPACProblemReport system preference. - Log into the OPAC - Click the "Report a problem" link at the bottom of the page. - You should see a hint below the textarea, "255 characters maximum." - Enter enough text in the textarea to confirm that it is cut off at 255 characters. Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm, is this going the right way? 255 characters is around 50 words.. is that enough to describe your average problem? I wonder if we aught to increase the char count of the column in the db as well as Owens hinting (but obviously updated to the new char limit) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 118811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118811&action=edit Bug 27726: (ALTERNATIVE) Increase 'content' field size This alternate patch increases the field size from a 255 character varchar to a 65535 character text field. This allows for more detailed problem reports to be submitted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Alternative attached that increases the storage size for the field instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118020|0 |1 is obsolete| | Attachment #118811|0 |1 is obsolete| | CC| |amitddng135@gmail.com --- Comment #7 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 118838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118838&action=edit Bug 27726: Add maxlength attribute to OPACProblemReport textarea To test, apply the patch and enable the OPACProblemReport system preference. - Log into the OPAC - Click the "Report a problem" link at the bottom of the page. - You should see a hint below the textarea, "255 characters maximum." - Enter enough text in the textarea to confirm that it is cut off at 255 characters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 --- Comment #8 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 118839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118839&action=edit Bug 27726: (ALTERNATIVE) Increase 'content' field size This alternate patch increases the field size from a 255 character varchar to a 65535 character text field. This allows for more detailed problem reports to be submitted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 --- Comment #9 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 118840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118840&action=edit Bug 27726: Add maxlength attribute to OPACProblemReport textarea This patch adds a maxlength attribute to the OPACProblemReport textarea. This will prevent the user from entering more characters than the table column limit (255). To test, apply the patch and enable the OPACProblemReport system preference. - Log into the OPAC - Click the "Report a problem" link at the bottom of the page. - You should see a hint below the textarea, "255 characters maximum." - Enter enough text in the textarea to confirm that it is cut off at 255 characters. Signed-off-by: Amit Gupta <amitddng135@gmail.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118839|0 |1 is obsolete| | --- Comment #10 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 118841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118841&action=edit Bug 27726: (ALTERNATIVE) Increase 'content' field size This alternate patch increases the field size from a 255 character varchar to a 65535 character text field. This allows for more detailed problem reports to be submitted. Signed-off-by: Amit Gupta <amitddng135@gmail.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118838|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118840|0 |1 is obsolete| | Attachment #118841|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 118905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118905&action=edit Bug 27726: (ALTERNATIVE) Increase 'content' field size This alternate patch increases the field size from a 255 character varchar to a 65535 character text field. This allows for more detailed problem reports to be submitted. Signed-off-by: Amit Gupta <amitddng135@gmail.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am in favor of the database change here. We don't have to worry about that space and I prefer people describing their problems without worrying about character limits :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am getting an error: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: BLOB/TEXT column 'content' can't have a default value [for Statement "ALTER TABLE problem_reports MODIFY content TEXT NOT NULL DEFAULT ''"] at /usr/share/perl5/DBIx/Class/Schema.pm line 1118. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #13)
I am getting an error:
{UNKNOWN}: DBI Exception: DBD::mysql::db do failed: BLOB/TEXT column 'content' can't have a default value [for Statement "ALTER TABLE problem_reports MODIFY content TEXT NOT NULL DEFAULT ''"] at /usr/share/perl5/DBIx/Class/Schema.pm line 1118.
Interesting.. that's a super easy fix, just drop the default as it doesn't make sense anyway.. but I'm surprised you got that.. what SQL server are you using? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Same error: DEV atomic update: bug_27726.perl Atomic update generated errors: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: BLOB/TEXT column 'content' can't have a default value [for Statement "ALTER TABLE problem_reports MODIFY content TEXT NOT NULL DEFAULT ''"] at /usr/share/perl5/DBIx/Class/Schema.pm line 1118. DBIx::Class::Schema::throw_exception(Koha::Schema=HASH(0x562f6298c240), "DBI Exception: DBD::mysql::db do failed: BLOB/TEXT column 'co"...) called at /usr/share/perl5/DBIx/Class/Storage.pm line 113 DBIx::Class::Storage::throw_exception(DBIx::Class::Storage::DBI::mysql=HASH(0x562f62b267c8), "DBI Exception: DBD::mysql::db do failed: BLOB/TEXT column 'co"...) called at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1501 DBIx::Class::Storage::DBI::__ANON__("DBD::mysql::db do failed: BLOB/TEXT column 'content' can't ha"..., DBI::db=HASH(0x562f631329c0), undef) called at (eval 1457) line 3 eval '$DBversion = \'XXX\'; # will be replaced by the RM if( CheckVersion( $DBversion ) ) { $dbh->do("ALTER TABLE problem_reports MODIFY content TEXT NOT NULL DEFAULT \'\'"); NewVersion( $DBversion, 27726, "Increase field size for problem_reports.content"); } ' called at /kohadevbox/koha/installer/data/mysql/updatedatabase.pl line 23755 Server version: 10.1.48-MariaDB-1~bionic mariadb.org binary distribution -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 119344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119344&action=edit Bug 27726: Increase 'content' field size This alternate patch increases the field size from a 255 character varchar to a 65535 character text field. This allows for more detailed problem reports to be submitted. Signed-off-by: Amit Gupta <amitddng135@gmail.com> Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118905|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Patch amended to drop the 'DEFAULT' definition.. worked in testing on the various Maria and MySQL versions available in k-t-d. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.05 released in| | --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.05 |21.05.00,20.11.05,20.05.11 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #20 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27726 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor@tuxayo.net --- Comment #21 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org