https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40556 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |baptiste.wojtkowski@biblibr |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40556 --- Comment #1 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 184899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184899&action=edit Bug 40556 - Subfields names in control fields should not be displayed/editable In cataloguing/addbiblio.pl, there is a conditionnal display of the subfield name field. However, it is depending on subfield_loo.fixedfield, which is never set up. However, the field corresponding information is available in innerloo.fixedfield. <input type="text" title="[% subfield_loo.marc_lib | $raw %]" style=" [% IF ( subfield_loo.fixedfield ) %]display:none; [% END %]" name="tag_[% subfield_loo.tag | html %]_code_[% subfield_loo.subfield | html %]_[% subfield_loo.index | html %]_[% subfield_loo.index_subfield | html %]" value="[% subfield_loo.subfield | html %]" size="1" Moreover, following code does not make sense for control fields: <span class="handle"></span> TEST PLAN: 1 - Edit any record. Note that you can grab subfields, note you can edit the 00 in the subfield input 2 - Apply patch 3 - On the same page, you should not be able to grab or edit subfield titles. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40556 Lin Wei <lin-wei.li@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184899|0 |1 is obsolete| | --- Comment #2 from Lin Wei <lin-wei.li@inLibro.com> --- Created attachment 186174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186174&action=edit Bug 40556 - Subfields names in control fields should not be displayed/editable In cataloguing/addbiblio.pl, there is a conditionnal display of the subfield name field. However, it is depending on subfield_loo.fixedfield, which is never set up. However, the field corresponding information is available in innerloo.fixedfield. <input type="text" title="[% subfield_loo.marc_lib | $raw %]" style=" [% IF ( subfield_loo.fixedfield ) %]display:none; [% END %]" name="tag_[% subfield_loo.tag | html %]_code_[% subfield_loo.subfield | html %]_[% subfield_loo.index | html %]_[% subfield_loo.index_subfield | html %]" value="[% subfield_loo.subfield | html %]" size="1" Moreover, following code does not make sense for control fields: <span class="handle"></span> TEST PLAN: 1 - Edit any record. Note that you can grab subfields, note you can edit the 00 in the subfield input 2 - Apply patch 3 - On the same page, you should not be able to grab or edit subfield titles. Signed-off-by: Ludovic julien <ludovic.julien@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40556 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@gmail.com --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- - <span class="handle"></span> + [% UNLESS ( innerloo.fixedfield ) %] <span class="handle"></span> [% END %] Please tidy (missing space before '[%' then you have 2 extra spaces around the span) and run the QA script -- You are receiving this mail because: You are watching all bug changes.