[Bug 27471] New: Improve link text when successfully merging authorities and remove JS redirect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27471 Bug ID: 27471 Summary: Improve link text when successfully merging authorities and remove JS redirect Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org <script>window.location.href="/cgi-bin/koha/authorities/detail.pl?authid=[% recordid1 | html %]";</script> koha-tmpl/intranet-tmpl/prog/en/modules/authorities/merge.tt: <p>The merging was successful. <a href="/cgi-bin/koha/authorities/detail.pl?authid=[% recordid1 | uri %]">Click here to see the merged record.</a></p> "Here" should not be used as a link text as it doesn't contain any helpful information for people scanning the page for information and also is a problem for blind users using screen readers jumping from link to link on a page. To reproduce: 1. Create or have two authorities 2. Do a search in Authorities 3. Click Actions -> merge for one authority 4. After the page reloads to show we are merging, click Actions -> Merge for the next authority 5. Go Next until the merge is complete Notice you don't even see the 'The merging was successful' message, because of the javascript that redirects you. To patch: delete the script line and reword the 'Click here' message -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27471 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26722 Keywords| |Academy Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26722 [Bug 26722] [Omnibus] Use descriptive link texts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27471 Amy King <amyking386@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amyking386@gmail.com Assignee|oleonard@myacpl.org |amyking386@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27471 Amy King <amyking386@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27471 --- Comment #1 from Amy King <amyking386@gmail.com> --- Created attachment 115399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115399&action=edit Bug 27471: Link text change so is more helpful. Test PLan: 1. Complete the above steps to reproduce, specially noting the last step 2. Apply the patch 3. Complete step 1 again, but now notice how the links says "This sentence is the link to ..." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27471 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- "This sentence is the link to see the merged record." doesn't make sense to me. How about "View the merged record" ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27471 Amy King <amyking386@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27471 Amy King <amyking386@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115399|0 |1 is obsolete| | --- Comment #3 from Amy King <amyking386@gmail.com> --- Created attachment 115457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115457&action=edit Bug 27471: changed link text Test plan: 1. Complete the steps above to reproduce, specially noting the last step 2. Apply the path 3. Complete step 1 again, but now notice how the link says "View the merged record" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27471 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27471 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115457|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115480&action=edit Bug 27471: changed link text Test plan: 1. Complete the steps above to reproduce, specially noting the last step 2. Apply the path 3. Complete step 1 again, but now notice how the link says "View the merged record" Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27471 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27471 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- The description of this bug indicates the javascript redirect would be removed. Please implement that change in the patch set, or alter the bug description to match the patch behavior. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27471 Amy King <amyking386@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27471 Amy King <amyking386@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115480|0 |1 is obsolete| | --- Comment #6 from Amy King <amyking386@gmail.com> --- Created attachment 115622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115622&action=edit Bug 27471: redirects user to page, link text changed Test Plan: 1. Follow the steps above to reproduce 2. Notice how there is no message telling the user that the merge was successsful 3. Apply patch 4. Repeat step 1 5. Now notice how the user is redirected to a page with a message that says that the merge was successful, and there is a link with helpful text to view the merged record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27471 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I wonder if the link and the redirect where thought to work as some kind of non-Javascript fallback? If Javascript is enabled, redirect automatically... if not, display the link. But seeing a success message is nice too! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27471 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27471 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115622|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 115639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115639&action=edit Bug 27471: Change auth merge success link text and don't redirect Test Plan: 1. Follow the steps above to reproduce 2. Notice how there is no message telling the user that the merge was successsful 3. Apply patch 4. Repeat step 1 5. Now notice how the user is redirected to a page with a message that says that the merge was successful, and there is a link with helpful text to view the merged record Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27471 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27471 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115639|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 115678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115678&action=edit Bug 27471: Change auth merge success link text and don't redirect Test Plan: 1. Follow the steps above to reproduce 2. Notice how there is no message telling the user that the merge was successsful 3. Apply patch 4. Repeat step 1 5. Now notice how the user is redirected to a page with a message that says that the merge was successful, and there is a link with helpful text to view the merged record Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27471 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27471 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27471 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27471 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org