[Bug 27324] New: Use Koha.Preference() for intranetbookbag everywhere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27324 Bug ID: 27324 Summary: Use Koha.Preference() for intranetbookbag everywhere Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org By using Koha.Preference() in the templates everywhere, we can remove the variable from Auth.pm in the end. After bug 27031, it looks like the remaining instances are: C4/Auth.pm: intranetbookbag => C4::Context->preference("intranetbookbag"), koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt: [% IF ( intranetbookbag ) %] koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt: [% IF ( intranetbookbag ) %] koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc:[% IF ( virtualshelves && intranetbookbag ) %] koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc:[% ELSIF ( intranetbookbag ) %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27324 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27324 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27031 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 [Bug 27031] Koha.Preference() should be used more often in header.inc and js_includes.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27324 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Sounds good to me -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27324 Mazen Khallaf <mazen.i.khallaf@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mazen.i.khallaf@gmail.com Assignee|oleonard@myacpl.org |mazen.i.khallaf@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27324 Mazen Khallaf <mazen.i.khallaf@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27324 --- Comment #2 from Mazen Khallaf <mazen.i.khallaf@gmail.com> --- Created attachment 115287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115287&action=edit Bug 27324: Use Koha.Preference() for intranetbookbag everywhere Test Plan: 1. Check the shelves and results page in the intranet 2. Apply the page 3. Check theres no change -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27324 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- We can then remove the 2 following occurrences: C4/Auth.pm: intranetbookbag => C4::Context->preference("intranetbookbag"), C4/Auth.pm: intranetbookbag => C4::Context->preference("intranetbookbag"), -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27324 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27324 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115287|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115336&action=edit Bug 27324: Use Koha.Preference() for intranetbookbag everywhere Test Plan: 1. Check the shelves and results page in the intranet 2. Apply the page 3. Check theres no change Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27324 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115337&action=edit Bug 27324: (follow-up) Remove references to intranetbookbag from Auth.pm This patch removes references to intranetbookbag from Auth.pm. Now that the templates use Koha.Preference("intranetbookbag") everywhere it is unnecessary. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27324 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115336|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115339&action=edit Bug 27324: Use Koha.Preference() for intranetbookbag everywhere Test Plan: 1. Check the shelves and results page in the intranet 2. Apply the page 3. Check theres no change Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27324 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115337|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115340&action=edit Bug 27324: (follow-up) Remove references to intranetbookbag from Auth.pm This patch removes references to intranetbookbag from Auth.pm. Now that the templates use Koha.Preference("intranetbookbag") everywhere it is unnecessary. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27324 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27324 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as expected, no regressions. Thanks for your contribution Mazen, welcome to Koha :) Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27324 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27324 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27324 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26707 CC| |fridolin.somers@biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26707 [Bug 26707] Split cart and lists button on bibliographic detail pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27324 --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Does not apply en 20.11.x because of Bug 26707 Not pushed to 20.11.x. It is a small plumbing change so I think there is no need to create a rebased patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27324 Mazen Khallaf <mazen.i.khallaf@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|mazen.i.khallaf@gmail.com |oleonard@myacpl.org CC|mazen.i.khallaf@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27324 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org