[Bug 9556] New: Changing patron category does not fully update patron messaging preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9556 Bug ID: 9556 Summary: Changing patron category does not fully update patron messaging preferences Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: gmcharlt@gmail.com CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If EnhancedMessagingPreferences is enabled, changing the patron category in the patron editor should change the messaging preferences that are assigned to the category defaults. However, this works only incompletely; numeric drop-downs are changed, but checkboxes are not. This is a result of one of the patches for bug 5462, which changed some HTML IDs without also updating the JavaScript that uses them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9556 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |gmcharlt@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9556 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9529 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9556 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9556 --- Comment #1 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 15110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15110&action=edit bug 9556: fix setting messaging prefs when changing patron category As a result of accumulated changes to field names returned by the members/default_messageprefs.pl service, the JavaScript to change the patron messaging preferences to the category default when changing a patron's category in the patron editor stopped working. To test: [1] Turn on the EnhancedMessagingPreferences feature. [2] Set message preference defaults for at least two patron categories. [3] Before applying the patch, create a new patron record using one of the categories you set prefs for, then change the category, then change it back again. You will see that numeric settings like the number of days for advanced notices will change, but checkboxes won't change. [4] Apply the patch, then create a new patron record and try changing the patron category. You will see that all of the preferences will get updated to the category default each time you change the category. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9556 --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> --- Testing note: this patch assumes that the patch for bug 9529 is applied. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9556 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9556 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15110|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15112&action=edit [SIGNED-OFF] Bug 9556: fix setting messaging prefs when changing patron category As a result of accumulated changes to field names returned by the members/default_messageprefs.pl service, the JavaScript to change the patron messaging preferences to the category default when changing a patron's category in the patron editor stopped working. To test: [1] Turn on the EnhancedMessagingPreferences feature. [2] Set message preference defaults for at least two patron categories. [3] Before applying the patch, create a new patron record using one of the categories you set prefs for, then change the category, then change it back again. You will see that numeric settings like the number of days for advanced notices will change, but checkboxes won't change. [4] Apply the patch, then create a new patron record and try changing the patron category. You will see that all of the preferences will get updated to the category default each time you change the category. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9556 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: This patch fixes the described issue. Simple patch. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9556 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15112|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15134 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15134&action=edit Bug 9556: fix setting messaging prefs when changing patron category As a result of accumulated changes to field names returned by the members/default_messageprefs.pl service, the JavaScript to change the patron messaging preferences to the category default when changing a patron's category in the patron editor stopped working. To test: [1] Turn on the EnhancedMessagingPreferences feature. [2] Set message preference defaults for at least two patron categories. [3] Before applying the patch, create a new patron record using one of the categories you set prefs for, then change the category, then change it back again. You will see that numeric settings like the number of days for advanced notices will change, but checkboxes won't change. [4] Apply the patch, then create a new patron record and try changing the patron category. You will see that all of the preferences will get updated to the category default each time you change the category. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9556 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9556 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org