[Bug 19807] New: IntranetCatalogSearchPulldown doesn' t honor IntranetNumbersPreferPhrase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807 Bug ID: 19807 Summary: IntranetCatalogSearchPulldown doesn't honor IntranetNumbersPreferPhrase Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: victor.grousset@biblibre.com QA Contact: testopia@bugs.koha-community.org With IntranetCatalogSearchPulldown and IntranetNumbersPreferPhrase enabled. Doing a search in the intranet from the search pulldown for the call number searches "callnum,wrdl: foobar". But it should search "callnum,phr: foobar" === Going further === It's very likely to also affect the OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807 --- Comment #1 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Created attachment 69782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69782&action=edit Bug 19807: Make IntranetCatalogSearchPulldown honor IntranetNumbersPreferPhrase This patch - fixes callnum and sn - Removes unecessary syspref transmission to the template. As the template directly reads the syspref Test plan: 1. Set sysprefs IntranetCatalogSearchPulldown and IntranetNumbersPreferPhrase to true 2. Go to staff:/cgi-bin/koha/catalogue/search.pl 3. "search for" → "call number" and write anything that won't match a call number in the field 4. Then you should see «No results match your search for 'callnum,phr: [...]» 5. Go to the staff homepage 6. Click on "Search the catalog" 7. Do the same search as previouly 8. Then you should see «No results match your search for 'callnum,wrdl: [...]» This shows that IntranetNumbersPreferPhrase isn't honored 9. Apply this patch 10. Redo the same two searches and see that phr will now be always used. So IntranetNumbersPreferPhrase is honored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |victor.grousset@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69782|0 |1 is obsolete| | --- Comment #2 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Created attachment 70180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70180&action=edit Bug 19807: Make IntranetCatalogSearchPulldown honor IntranetNumbersPreferPhrase This patch - fixes callnum and sn - Removes unecessary syspref transmission to the template. As the template directly reads the syspref Test plan: 1. Set sysprefs IntranetCatalogSearchPulldown and IntranetNumbersPreferPhrase to true 2. Go to staff:/cgi-bin/koha/catalogue/search.pl 3. "search for" → "call number" and write anything that won't match a call number in the field 4. Then you should see «No results match your search for 'callnum,phr: [...]» 5. Go to the staff homepage 6. Click on "Search the catalog" 7. Do the same search as previouly 8. Then you should see «No results match your search for 'callnum,wrdl: [...]» This shows that IntranetNumbersPreferPhrase isn't honored 9. Apply this patch 10. Redo the same two searches and see that phr will now be always used. So IntranetNumbersPreferPhrase is honored Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70180|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 70197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70197&action=edit Bug 19807: Make IntranetCatalogSearchPulldown honor IntranetNumbersPreferPhrase This patch - fixes callnum and sn - Removes unecessary syspref transmission to the template. As the template directly reads the syspref Test plan: 1. Set sysprefs IntranetCatalogSearchPulldown and IntranetNumbersPreferPhrase to true 2. Go to staff:/cgi-bin/koha/catalogue/search.pl 3. "search for" → "call number" and write anything that won't match a call number in the field 4. Then you should see «No results match your search for 'callnum,phr: [...]» 5. Go to the staff homepage 6. Click on "Search the catalog" 7. Do the same search as previouly 8. Then you should see «No results match your search for 'callnum,wrdl: [...]» This shows that IntranetNumbersPreferPhrase isn't honored 9. Apply this patch 10. Redo the same two searches and see that phr will now be always used. So IntranetNumbersPreferPhrase is honored Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I do not recreate the bug, and I do not understand the fix. Could you detail please? (In reply to Victor Grousset/tuxayo from comment #0)
It's very likely to also affect the OPAC
Does it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It doesn't effect the OPAC from what I could tell when testing. It just switches the indexes in the new search options pull down on the simple search according to the pref from ,wrdl to ,phr for callnumber, copying the existing behaviour for advanced search. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Note to myself: the variable is not sent from all the scripts that include search_indexes.inc. Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick@bywatersolutions.com --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org