[Bug 35283] New: XSLT 583 Action note is missing subfield h in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35283 Bug ID: 35283 Summary: XSLT 583 Action note is missing subfield h in staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org In the staff interface, the 583 action note should show subfield "h". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35283 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29470 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35283 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|XSLT 583 Action note is |XSLT 583 Action note is |missing subfield h in staff |missing subfield h and x in |interface |staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35283 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from David Cook <dcook@prosentient.com.au> --- *** Bug 29470 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35283 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- It's also missing subfield x. Rather than make 2 patches for bug 35283 and bug 29470 we may as well get it done in 1 fell swoop (with fewer merge conflicts). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35283 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35283 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35283 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Created attachment 158642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158642&action=edit Bug 35283: Add missing subfields h and x to field 583 for staff XSLT This change adds the missing subfields h and x to field 583 for the detail XSLT in the staff interface. Test plan: 0. Apply the patch and koha-plack --reload kohadev 1. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=29 2. Click on tab "5" 3. Scroll down to 583 and click on "ACTION NOTE" to expand subfields 4. Fill in using the following example: 583 0#$adowngraded$c19910110$hJoe Smith$otitle$xfrom secret FRD to confidential NSI 5. Click "Save" 6. Note that the "Action note" now shows "Joe Smith" and "from secret FRD to confidentail NSI" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35283 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35283 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158642|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 158749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158749&action=edit Bug 35283: Add missing subfields h and x to field 583 for staff XSLT This change adds the missing subfields h and x to field 583 for the detail XSLT in the staff interface. Test plan: 0. Apply the patch and koha-plack --reload kohadev 1. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=29 2. Click on tab "5" 3. Scroll down to 583 and click on "ACTION NOTE" to expand subfields 4. Fill in using the following example: 583 0#$adowngraded$c19910110$hJoe Smith$otitle$xfrom secret FRD to confidential NSI 5. Click "Save" 6. Note that the "Action note" now shows "Joe Smith" and "from secret FRD to confidentail NSI" Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35283 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Note that by design if you fill in 583$z the other subfields will not display. When testing leave subfield z empty. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35283 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35283 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35283 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158749|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158773&action=edit Bug 35283: Add missing subfields h and x to field 583 for staff XSLT This change adds the missing subfields h and x to field 583 for the detail XSLT in the staff interface. Test plan: 0. Apply the patch and koha-plack --reload kohadev 1. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=29 2. Click on tab "5" 3. Scroll down to 583 and click on "ACTION NOTE" to expand subfields 4. Fill in using the following example: 583 0#$adowngraded$c19910110$hJoe Smith$otitle$xfrom secret FRD to confidential NSI 5. Click "Save" 6. Note that the "Action note" now shows "Joe Smith" and "from secret FRD to confidentail NSI" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35283 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158774&action=edit Bug 35283: Add missing subfield h to action note 583 in OPAC detail page $x is nonpublic note, so it makes sense to only display it in staff, but $h is Jurisdiction and we should show it in OPAC and staff alike. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35283 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35283 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35283 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.06 released in| | --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35283 --- Comment #10 from David Cook <dcook@prosentient.com.au> --- While it's possible that "h" could have private information, this field has an indicator that prevents the note from showing if it's private, plus the subfield can be hidden from the OPAC using the MARC bibliographic frameworks, so sounds good about including it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35283 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Cook from comment #10)
While it's possible that "h" could have private information, this field has an indicator that prevents the note from showing if it's private, plus the subfield can be hidden from the OPAC using the MARC bibliographic frameworks, so sounds good about including it.
But then couldn't have any field private information? There is no note on the field that indicates any internal use in the documentation and from the example it seems like you'd want to see that (if you want your 583 to display): $h - Jurisdiction Name of a person, an institution, or a position or function within an institution, in whom or in which responsibility for an action is vested. 583 ##$atransfer$c19770613$huniversity archives -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35283 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.06 |23.11.00,23.05.06,22.11.12 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35283 --- Comment #12 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35283 --- Comment #13 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #11)
But then couldn't have any field private information? There is no note on the field that indicates any internal use in the documentation and from the example it seems like you'd want to see that (if you want your 583 to display):
$h - Jurisdiction
Name of a person, an institution, or a position or function within an institution, in whom or in which responsibility for an action is vested. 583 ##$atransfer$c19770613$huniversity archives
The "Name of a person" part is what bothers me. It seems strange for the name of a staff member to be shown to the public. It just seems implicitly internal to me. But I think I see what you're saying. Yeah, I think a number of these subfields could have private information. That's why I think it's not a problem hehe. I think that's why they have the First Indicator controlling "Private" and "Not private". -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org