[Bug 16577] New: Improve call number browser plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16577 Bug ID: 16577 Summary: Improve call number browser plugin Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_na me=cn_browser.pl&popup&q=X OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Bug 13364 added a call number browser cataloging plugin which can be used to check for duplicate call numbers when adding an item. I have several markup fixes and style improvements for the template. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16577 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16577 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 51740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51740&action=edit Bug 16577 - Improve call number browser plugin This patch makes several markup and style improvements to the call number browser plugin added by Bug 13364. Some of the changes: - The size of the pop-up window has been increased slightly for a less cramped display. - Page structure has been updated to match similar pop-up windows. - Page structure has been improved to further accommodate the option of viewing the call number browser as a full page rather than a pop-up window (although as far as I can tell it is not linked to in this mode anywhere). - Row highlighting has been updated so that page styles are not being passed explicitly by the script. Highlight colors have been changed to make things more readable. - DataTables-related markup has been removed because it was not being used. It doesn't make sense to re-order table rows when the purpose of the table is to display call number order. To test, apply the patch and edit a framework so that the item call number field uses the 'cn_browser.pl' plugin. - Create or edit an item in cataloging. - Enter an existing call number into the call number field. - Click the '...' link next to the call number. - In the call number browser pop-up, verify that items matching your call number are highlighted in red. - Verify that the new 'Close' button at the bottom of the page works correctly. - Enter a call number which doesn't exist in the call number field - Click the '...' link to trigger the browser. - Verify that there is a row highlighted in green marking the sort order of the call number you chose. - Navigate directly to /cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=cn_browser.pl - The page should appear like a normal full page, with header search, breadcrumbs, etc. Performing a search for call numbers should work like it did in the pop-up context. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16577 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51740|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 51895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51895&action=edit Bug 16577 - Improve call number browser plugin This patch makes several markup and style improvements to the call number browser plugin added by Bug 13364. Some of the changes: - The size of the pop-up window has been increased slightly for a less cramped display. - Page structure has been updated to match similar pop-up windows. - Page structure has been improved to further accommodate the option of viewing the call number browser as a full page rather than a pop-up window (although as far as I can tell it is not linked to in this mode anywhere). - Row highlighting has been updated so that page styles are not being passed explicitly by the script. Highlight colors have been changed to make things more readable. - DataTables-related markup has been removed because it was not being used. It doesn't make sense to re-order table rows when the purpose of the table is to display call number order. To test, apply the patch and edit a framework so that the item call number field uses the 'cn_browser.pl' plugin. - Create or edit an item in cataloging. - Enter an existing call number into the call number field. - Click the '...' link next to the call number. - In the call number browser pop-up, verify that items matching your call number are highlighted in red. - Verify that the new 'Close' button at the bottom of the page works correctly. - Enter a call number which doesn't exist in the call number field - Click the '...' link to trigger the browser. - Verify that there is a row highlighted in green marking the sort order of the call number you chose. - Navigate directly to /cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=cn_browser.pl - The page should appear like a normal full page, with header search, breadcrumbs, etc. Performing a search for call numbers should work like it did in the pop-up context. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Works as described. Pleasing to the eye -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16577 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |frederic@tamil.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16577 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |13364 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 [Bug 13364] Add a call number browser to add item page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16577 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16577 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51895|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52283&action=edit Bug 16577 - Improve call number browser plugin This patch makes several markup and style improvements to the call number browser plugin added by Bug 13364. Some of the changes: - The size of the pop-up window has been increased slightly for a less cramped display. - Page structure has been updated to match similar pop-up windows. - Page structure has been improved to further accommodate the option of viewing the call number browser as a full page rather than a pop-up window (although as far as I can tell it is not linked to in this mode anywhere). - Row highlighting has been updated so that page styles are not being passed explicitly by the script. Highlight colors have been changed to make things more readable. - DataTables-related markup has been removed because it was not being used. It doesn't make sense to re-order table rows when the purpose of the table is to display call number order. To test, apply the patch and edit a framework so that the item call number field uses the 'cn_browser.pl' plugin. - Create or edit an item in cataloging. - Enter an existing call number into the call number field. - Click the '...' link next to the call number. - In the call number browser pop-up, verify that items matching your call number are highlighted in red. - Verify that the new 'Close' button at the bottom of the page works correctly. - Enter a call number which doesn't exist in the call number field - Click the '...' link to trigger the browser. - Verify that there is a row highlighted in green marking the sort order of the call number you chose. - Navigate directly to /cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=cn_browser.pl - The page should appear like a normal full page, with header search, breadcrumbs, etc. Performing a search for call numbers should work like it did in the pop-up context. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Works as described. Pleasing to the eye Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16577 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52284&action=edit Bug 16577: Minor improvement on else if statements Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16577 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #1)
- DataTables-related markup has been removed because it was not being used. It doesn't make sense to re-order table rows when the purpose of the table is to display call number order.
But we could have kept the constructor anyway :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16577 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for Koha 16.11, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org