http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7876 --- Comment #1 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 8784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8784&action=edit Bug 7876 - Add ids to divs and spans with ids in opac-user.tt This commit adds an id to each div, and adds spans where there are no appropriate divs to add. In addition, non-static text such as the expiration date are wrapped in a special sub-span so that data can be pulled and reused when customizing via jQuery. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7876 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8784|0 |1 is obsolete| | --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 8839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8839&action=edit Bug 7876 - Add ids to divs and spans with ids in opac-user.tt This commit adds an id to each div, and adds spans where there are no appropriate divs to add. In addition, non-static text such as the expiration date are wrapped in a special sub-span so that data can be pulled and reused when customizing via jQuery. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7876 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Ian Walls <koha.sekjal@gmail.com> --- Span and Div ids are consistent with variable names, so they are easier to use. I'm not 100% sure a new tag is exactly required in all cases; some of those list elements could have gotten ids and kept the DOM a little simpler, but that's really not a big deal at all, and always using spans is consistent and simple. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7876 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- OK, with the help of http://blog.bigballofwax.co.nz/2011/12/15/fixing-whitespace-when-apply-patch... I've found how to automatically change tabs into 4 spaces: git config --global core.whitespace trailing-space,space-before-tab,tab-in-indent,tabwidth=4 so, passed QA and pushed ! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7876 --- Comment #6 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 8877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8877&action=edit Bug 7876 - Followup - Fix closing span tag, add fine amount spans. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7876 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7876 --- Comment #7 from Kyle M Hall <kyle.m.hall@gmail.com> --- I decided to read the diff on my patch and noticed that the closing tag on one the spans for missing its slash ( <span> instead of </span> ). I also noticed that there were no sub-spans for the the fine amount, so that data wouldn't be re-usable with jQuery. Attached is a new patch to resolve those issues. One small bugfix, and one small enhancement. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7876 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8877|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9081&action=edit Bug 7876 - Followup - Fix span tag position, add fine amount spans. Span was outside, the if statement, could possible cause problems with jQuery customizations, moved span to inside the conditional. Also added span for the fine amount itself, so that it may be re-used for jQuery customizations. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7876 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9081|0 |1 is obsolete| | --- Comment #10 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 9094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9094&action=edit Bug 7876 - Followup - Fix span tag position, add fine amount spans. Span was outside, the if statement, could possible cause problems with jQuery customizations, moved span to inside the conditional. Also added span for the fine amount itself, so that it may be re-used for jQuery customizations. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Passed tests, spans appear to be correct. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7876 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #11 from Ian Walls <koha.sekjal@gmail.com> --- Template only changing moving <spans> around; marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7876 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version|rel_3_8 |rel_3_6 --- Comment #13 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This bug will be included in the Koha 3.6.5 release. -- You are receiving this mail because: You are watching all bug changes.