[Bug 16246] New: Return all reserves columns in ILS-DI GetRecords response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246 Bug ID: 16246 Summary: Return all reserves columns in ILS-DI GetRecords response Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Web services Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org The list of reserves fields returned in ILS-DI GetRecords response is arbitrary. Instead we should return all the fields available in reserves table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 50143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50143&action=edit Bug 16246: Return all reserves columns in ILS-DI GetRecords response The list of reserves fields returned in ILS-DI GetRecords response is arbitrary. Instead we should return all the fields available in reserves table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246 --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 50144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50144&action=edit Bug 16246: Add tests for ILS-DI GetRecords + remove some warnings in C4/ILSDI/Services.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246 --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- Test plan: 1. Go to http://OPAC/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=XXX where XXX is the biblionumber of a record that have at least one hold. 2. Confirm that you have all non-NULL fields displayed in //record/reserves/reserve (compare with what you have in DB) 3. prove t/db_dependent/ILSDI_Services.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246 Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.hedstrom.mace@sub.s | |u.se --- Comment #4 from Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> --- Patch did not apply for me. Needs a rebase? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50143|0 |1 is obsolete| | --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 56829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56829&action=edit Bug 16246: Return all reserves columns in ILS-DI GetRecords response The list of reserves fields returned in ILS-DI GetRecords response is arbitrary. Instead we should return all the fields available in reserves table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50144|0 |1 is obsolete| | --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 56830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56830&action=edit Bug 16246: Add tests for ILS-DI GetRecords -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246 --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Patches rebased on master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56829|0 |1 is obsolete| | --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 61032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61032&action=edit Bug 16246: Return all reserves columns in ILS-DI GetRecords response The list of reserves fields returned in ILS-DI GetRecords response is arbitrary. Instead we should return all the fields available in reserves table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56830|0 |1 is obsolete| | --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 61033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61033&action=edit Bug 16246: Add tests for ILS-DI GetRecords -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246 --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Patches rebased on master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #11 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Sonia BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61032|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61033|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246 --- Comment #12 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 61329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61329&action=edit Bug 16246: Return all reserves columns in ILS-DI GetRecords response The list of reserves fields returned in ILS-DI GetRecords response is arbitrary. Instead we should return all the fields available in reserves table Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246 --- Comment #13 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 61330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61330&action=edit Bug 16246: Add tests for ILS-DI GetRecords Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #14 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Tried with several holds : they are all displayed in the XML file produced by http://OPAC/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=XXX with the same values than in DB (check by a SQL report) There's no NULL value. When we change an information, XML produced by ILSDI is updated. cf : <reserves><reserve><timestamp>2017-03-20 17:06:29</timestamp><borrowernumber>4024</borrowernumber><reserve_id>1424</reserve_id><biblionumber>979</biblionumber><reservedate>2017-03-20</reservedate><suspend>1</suspend><lowestPriority>0</lowestPriority><rtimestamp>2017-03-20 17:06:29</rtimestamp><priority>1</priority><suspend_until>2017-03-22 00:00:00</suspend_until><branchcode>MAURES</branchcode><reservenotes/></reserve><reserve><biblionumber>979</biblionumber><lowestPriority>1</lowestPriority><suspend>0</suspend><reservedate>2017-03-20</reservedate><borrowernumber>6128</borrowernumber><timestamp>2017-03-20 17:06:29</timestamp><reserve_id>1425</reserve_id><reservenotes>test</reservenotes><branchcode>MAURES</branchcode><priority>2</priority><rtimestamp>2017-03-20 17:06:29</rtimestamp></reserve></reserves> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Julian, on but 17736 I remove occurrences of GetReservesFromBiblionumber. See patch: Bug 17736: Replace GetReservesFromBiblionumber with Koha::Biblio->holds I needed to create a new method, Koha::Holds->search is not identical as GetReservesFromBiblionumber. Your patch will introduce a change with existing behaviour that does not look expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |FIXED --- Comment #16 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Jonathan Druart from comment #15)
Julian, on but 17736 I remove occurrences of GetReservesFromBiblionumber.
Bug 17736 also removed completely the usefulness of this bug :) Changing status to RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org