[Bug 40497] New: Item add form does not respect framework maxlength setting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40497 Bug ID: 40497 Summary: Item add form does not respect framework maxlength setting Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl The item add form uses the wrong template variable to set the maxlength attribute on a text input field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40497 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40497 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40497 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184598&action=edit Bug 40497: Item add form does not respect framework maxlength setting This patch corrects the template variable which populates the maxlenth attribute on text fields in the add/edit item form. To test, apply the patch and go Administratoin -> MARC bibliographic frameworks -> (framework) -> Tag 952 -> Edit subfields. - Click the "p" tab and set the "Max length" field to "20" - Save the framework and go to Cataloging. - Locate a bibliographic record that uses the framework you edited. - Add or edit an item on that bibliographic record. - Check the "Barcode" field. The input tag should limit your entry to 20 characters. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40497 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40508 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40508 [Bug 40508] Set maxlength in marc21_framework_DEFAULT.yml -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40497 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40497 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184598|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 184776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184776&action=edit Bug 40497: Item add form does not respect framework maxlength setting This patch corrects the template variable which populates the maxlenth attribute on text fields in the add/edit item form. To test, apply the patch and go Administratoin -> MARC bibliographic frameworks -> (framework) -> Tag 952 -> Edit subfields. - Click the "p" tab and set the "Max length" field to "20" - Save the framework and go to Cataloging. - Locate a bibliographic record that uses the framework you edited. - Add or edit an item on that bibliographic record. - Check the "Barcode" field. The input tag should limit your entry to 20 characters. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40497 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #3 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- I cannot recreate the issue before the patch, if I alter the maxlength of a field it is respected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40497 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40497 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184776|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 185894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185894&action=edit Bug 40497: Item add form does not respect framework maxlength setting This patch corrects the template variable which populates the maxlenth attribute on text fields in the add/edit item form. To test, apply the patch and go Administratoin -> MARC bibliographic frameworks -> (framework) -> Tag 952 -> Edit subfields. - Click the "p" tab and set the "Max length" field to "20" - Save the framework and go to Cataloging. - Locate a bibliographic record that uses the framework you edited. - Add or edit an item on that bibliographic record. - Check the "Barcode" field. The input tag should limit your entry to 20 characters. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40497 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40497 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40497 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40497 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40497 --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40497 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- I prefer not impact 24.11.x for behavior stability -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org