[Bug 5848] New: Same position for the tabs of Normal, MARC and ISBD view in opac detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5848 Bug #: 5848 Summary: Same position for the tabs of Normal, MARC and ISBD view in opac detail Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: ASSIGNED Severity: enhancement Priority: PATCH-Sent Component: OPAC AssignedTo: m.de.rooy@rijksmuseum.nl ReportedBy: m.de.rooy@rijksmuseum.nl QAContact: koha-bugs@lists.koha-community.org The tabs Normal View, MARC and ISBD are shown below the title in OPAC normal view. For MARC and ISBD view the name of the view is added to the left of the tabs. This proposed patch puts the three tabs at the same position for Normal, MARC and ISBD view. The text of the current view is made bold; additional titles for MARC/ISBD are not needed anymore and thus removed. A few hardcoded styles have been moved from the template to opac.css allowing improved customization. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5848 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-03-10 13:49:52 UTC --- Please test all three views 1) with OPACXSLTDetailsDisplay enabled [MARC View: Test also "View plain" here] 2) with OPACXSLTDetailsDisplay disabled. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5848 --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-03-10 13:50:34 UTC --- Created attachment 3280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3280 Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5848 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5848 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-03-13 20:09:25 UTC --- Created attachment 3286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3286 normal view like it is now -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5848 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-03-13 20:09:52 UTC --- Created attachment 3287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3287 normal view after patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5848 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Signed Off --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-03-13 20:13:11 UTC --- Signing-off on this, it works like described. I like the new display, it seems more consistent and a bit cleaner to me. Not sure if this is the majority opinion though. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5848 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Signed Off |Patch Pushed --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-14 07:54:10 UTC --- Pushed, please test and mark resolved -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5848 --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-03-14 08:17:24 UTC --- Works for me. Anyone else to close it? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5848 --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> 2011-03-14 15:02:28 UTC --- Created attachment 3292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3292 duplicated tabs On Normal view I see the tabs twice (see screenshot). Marc/Plain/ISBD views display well. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5848 --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-03-15 11:55:13 UTC --- I notice that the tabs are not the same. Are you using a custom xslt stylesheet? The stylesheet for MARC21 opac details was adjusted in the patch. Is it possible that these views are still in your Unimarc xslt file? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5848 --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-03-15 12:27:07 UTC --- Julian, I see that lines 55 up to 69 still contain the views in a div tag in the UNIMARCslim2OPACDetail.xsl in koha-tmpl/opac-tmpl/prog/en/xslt. Could you please test removing them? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5848 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> 2011-03-16 09:57:45 UTC --- (In reply to comment #10)
Julian, I see that lines 55 up to 69 still contain the views in a div tag in the UNIMARCslim2OPACDetail.xsl in koha-tmpl/opac-tmpl/prog/en/xslt. Could you please test removing them?
That's it! Preparing a patch for Unimarc stylesheet... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5848 --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> 2011-03-16 10:04:44 UTC --- Created attachment 3321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3321 Patch for Unimarc stylesheet -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5848 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Patch Pushed |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5848 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-17 21:53:19 UTC --- Follow up patch for UNIMARC pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5848 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #14 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-04-03 23:19:24 UTC --- This bug is mentioned in: Bug 5848: Same position for the tabs of Normal, MARC and ISBD view in opac detail http://lists.koha-community.org/pipermail/koha-patches/2011-March/014035.htm... Bug 5848: Remove duplicated tabs in opac details for Unimarc http://lists.koha-community.org/pipermail/koha-patches/2011-March/014079.htm... Bug 5848: Remove duplicated tabs in opac details for Unimarc http://lists.koha-community.org/pipermail/koha-patches/2011-March/014100.htm... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org