[Bug 34124] New: Improve in-page navigation on table settings page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34124 Bug ID: 34124 Summary: Improve in-page navigation on table settings page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org We have in-page navigation to jump to specific pages, but we could use in-page navigation to jump directly to tables within pages too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34124 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34124 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152703&action=edit Bug 34124: Improve in-page navigation on table settings page This patch adds links to the table settings page so that the user can jump directly to a particular table within a page section. The patch also changes the logic of when in-page links are displayed: I think it makes sense not to show a "Jump to page" link when there is only one page. The page will show a "Jump to table" link only if there is only one table. To test, apply the patch and go to Adinistration -> Table settings. - Expand and check multiple sections. - In the "Administration" section, there are multiple pages. - Check that the "Jump to page" links work correctly. - In the "Catalog" section, there is only one page: "detail." - Check that the "Jump to table" links work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34124 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34124 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152703|0 |1 is obsolete| | --- Comment #2 from Sam Lau <samalau@gmail.com> --- Created attachment 152872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152872&action=edit Bug 34124: Improve in-page navigation on table settings page This patch adds links to the table settings page so that the user can jump directly to a particular table within a page section. The patch also changes the logic of when in-page links are displayed: I think it makes sense not to show a "Jump to page" link when there is only one page. The page will show a "Jump to table" link only if there is only one table. To test, apply the patch and go to Adinistration -> Table settings. - Expand and check multiple sections. - In the "Administration" section, there are multiple pages. - Check that the "Jump to page" links work correctly. - In the "Catalog" section, there is only one page: "detail." - Check that the "Jump to table" links work correctly. Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34124 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28917 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34124 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152872|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152926&action=edit Bug 34124: Improve in-page navigation on table settings page This patch adds links to the table settings page so that the user can jump directly to a particular table within a page section. The patch also changes the logic of when in-page links are displayed: I think it makes sense not to show a "Jump to page" link when there is only one page. The page will show a "Jump to table" link only if there is only one table. To test, apply the patch and go to Administration -> Table settings. - Expand and check multiple sections. - In the "Administration" section, there are multiple pages. - Check that the "Jump to page" links work correctly. - In the "Catalog" section, there is only one page: "detail." - Check that the "Jump to table" links work correctly. Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34124 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34124 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152926|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153115&action=edit Bug 34124: Improve in-page navigation on table settings page This patch adds links to the table settings page so that the user can jump directly to a particular table within a page section. The patch also changes the logic of when in-page links are displayed: I think it makes sense not to show a "Jump to page" link when there is only one page. The page will show a "Jump to table" link only if there is only one table. To test, apply the patch and go to Administration -> Table settings. - Expand and check multiple sections. - In the "Administration" section, there are multiple pages. - Check that the "Jump to page" links work correctly. - In the "Catalog" section, there is only one page: "detail." - Check that the "Jump to table" links work correctly. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34124 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34124 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34124 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.02 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34124 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34124 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34124 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #8 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Nothing to change in the manual that I can see. Feel free to reopen with details if I'm wrong. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org