[Bug 40704] New: When item is deleted, title disappears from reading history creating a useless entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40704 Bug ID: 40704 Summary: When item is deleted, title disappears from reading history creating a useless entry Change sponsored?: --- Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When an item that was formerly checked out to a user is deleted, it leaves an empty entry in their circulation history in the OPAC. Star ratings and date will display, the rest of the cells, including the title information, will be empty. To test: * Activate opacreadinghistory * Check out an item to your user * Confirm circulation history in OPAC shows it * Check in the item and delete it * Verify that now the reading history has an (almost) empty line -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40704 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33948 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40704 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Is this a regression? What do you expect? BTW it's the same on the staff interface. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40704 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We ran into this because of our cover service exploding when there was no biblionumber when preparing for the update, so I believe it's tied to a change between 22.11 and 24.11. I think it could be changes relating to showing deleted entries, where we just didn't show them before, but couldn't dig much deeper than finding these bugs: Bug 3397 - Deleting item record leaves a hole in patron's reading history Bug 33948 - Replace GetAllIssues with Koha::Checkouts - staff I suspect the second bug (23.11), but didn't confirm. I have patched locally to remove entries without biblionumber - an empty line has no usable information. The star ratings shown are broken etc. Ideally we should pull the information from the deleted tables, if not possible, we should not show the entries. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40704 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Katrin Fischer from comment #2)
Ideally we should pull the information from the deleted tables, if not possible, we should not show the entries.
It's not possible, old_issues.itemnumber is always null in this case CONSTRAINT `old_issues_ibfk_2` FOREIGN KEY (`itemnumber`) REFERENCES `items` (`itemnumber`) ON DELETE SET NULL ON UPDATE SET NULL, Don’t you think it’s better to show an "empty" line indicating that the item has been deleted, rather than omitting it entirely (which would distort the total number of checkouts)? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40704 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186717&action=edit Bug 40704: Display 'item deleted' in checkout history Instead of an empty line we can show that the item has been deleted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40704 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- I was going to submit another version which would remove the checkouts with deleted item but then remembered this: """ Bug 33948: Replace GetAllIssues with Koha::Checkouts - staff However there is one change! And it's a bug fix (or an enhancement, it depends on how you see things). It includes checkouts with deleted items, which is a long standing bug (see bug 8483). """ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40704 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- I've tried 'td colspan="5"' for the staff table, but DT does not allow it. https://datatables.net/manual/installation#HTML """ Please also note that while DataTables supports colspan and rowspan in the table's header and footer, they are not supported in the table's tbody and must not be present. """ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40704 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Version|24.11 |unspecified Assignee|oleonard@myacpl.org |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40704 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Joubu, thanks for having a look! If I understand correctly, we would now show that the item has been deleted. But that might just leave a long list of deleted entries - is it really useful for the end user? It also bugs me a bit that we rely on the item instead of the record. If one of 20 copies is replaced for wear, you will already have a hole in your reading history, although the record is still there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40704 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #3)
(In reply to Katrin Fischer from comment #2)
Ideally we should pull the information from the deleted tables, if not possible, we should not show the entries.
It's not possible, old_issues.itemnumber is always null in this case
CONSTRAINT `old_issues_ibfk_2` FOREIGN KEY (`itemnumber`) REFERENCES `items` (`itemnumber`) ON DELETE SET NULL ON UPDATE SET NULL,
Don’t you think it’s better to show an "empty" line indicating that the item has been deleted, rather than omitting it entirely (which would distort the total number of checkouts)?
If the users delete their reading history or the library does, the number might not be so reliable anyway. I think a note at the top would be more useful then: Note: X items on your list are no longer available at the library. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40704 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40704 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- It's really something people have asked for years, see the bug 8483 and bug 3397. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40704 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- The dates might provide useful info as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40704 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #9)
It's really something people have asked for years, see the bug 8483 and bug 3397.
I agree, but I think they really wanted to see what is was :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40704 --- Comment #12 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I recently had this problem with a new client for whom we migrated the circulation history. I think they had done a lot of weeding before the migration and also we didn't migrate part of the collection which belonged to the school attached to the library. The result was a really long list of empty lines (I'll attach a censored screenshot). They told us to simply delete the NULL entries. They didn't really care for the numbers. At least not in the patron's reading history. What they really wanted was the history of a particular title for weeding purposes. But the many empty lines in the patron history was grating for them. I think the best case scenario would be to show the title, with no link. Kind of like what we do in acquisitions, I think? I understand that might not be possible with the current schema, but I think that's what would be most useful for the patron. Bar that, maybe filtering out the empty lines would be the next best? Like with an option to show all lines? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40704 --- Comment #13 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 186728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186728&action=edit Patron history in 24.05 As promised, the screenshot. This was taken in production in 24.05, before I deleted all the empty lines. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40704 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186784&action=edit Bug 40704: DB changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40704 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186785&action=edit Bug 40704: DBIC schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40704 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186786&action=edit Bug 40704: Store and display deleted item for checkouts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40704 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- With the last patches we could retain the old_issues.itemnumber (in a separate column: deleted_itemnumber). What do you think? Please test and tell me if we continue (the patches are not ready for inclusion). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40704 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Joubu, that's awesome, thank you. I am not sure I will be able to test this week, but maybe it would be a good one for the German hackfest next week. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40704 Cheryl <clackman@fargolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman@fargolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40704 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #19 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Shouldn't this be NSO ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40704 --- Comment #20 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- (In reply to Jonathan Druart from comment #17)
With the last patches we could retain the old_issues.itemnumber (in a separate column: deleted_itemnumber).
What do you think?
Please test and tell me if we continue (the patches are not ready for inclusion).
Looks fine to me, isn't there also a case where the whole biblio is deleted ? It will still break, right ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40704 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Baptiste Wojtkowski (bwoj) from comment #19)
Shouldn't this be NSO ?
I think it was waiting for my testing :( I hope to find some time next week at the hackfest. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40704 --- Comment #22 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- I'd be happy to help and follow-up during the hackfest if you need -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40704 Cécile Garcia-Belmonte <cecilegarciabelmonte@loireforez.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cecilegarciabelmonte@loiref | |orez.fr -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org