[Bug 12914] New: Wrong message 'Patron(..) is blocked for 2014-09-30 day(s).
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 Bug ID: 12914 Summary: Wrong message 'Patron(..) is blocked for 2014-09-30 day(s). Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If a patron has a manual restriction, /cgi-bin/koha/circ/circulation.pl can display a message similar to the following: Patron has had overdue items and is blocked for 2014-09-30 day(s). This is related to sub IsMemberBlocked in C4/Members.pm that returns a date but is expected to return a number of days. It should have an additional status for returning dates instead of days to use in C4/Circulation.pm and circulation.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 31574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31574&action=edit Bug 12914 - Wrong message 'Patron(..) is blocked for 2014-09-30 day(s). The message in circulation.tt assumed to get days but date is given. Updated comments and message depending on expiration date or no expiration of restriction. The message shows up on top of Bug 643 Allow override of 'debarred' status if a patron has a restriction. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | --- Comment #2 from Marc Véron <veron@veron.ch> --- Test plan Apply patch on top of Bug 643 Add manual restriction with expiration date to patron A Add manual restriction without expiration date to patron B For both try to check out an item and override restriction (Bug 643) The message for patron A should now be similar to: Patron has a restriction until 04/12/2014. The message for patron B should now read: Patron has a restriction (no expiry date). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31574|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 32000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32000&action=edit [SIGNED OFF] Bug 12914 - Wrong message 'Patron(..) is blocked for 2014-09-30 day(s). The message in circulation.tt assumed to get days but date is given. Updated comments and message depending on expiration date or no expiration of restriction. The message shows up on top of Bug 643 Allow override of 'debarred' status if a patron has a restriction. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Depends on| |643 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- I cannot reproduce this bug on master with bug 643 applied. I think perhaps the wording of the message has changed to correct this already. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 32283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32283&action=edit This Screenshots shows the message "Patron has had overdue items and is blocked for 2014-10-31 day(s)." I did a new test on curret master 3.17.00.027 The test was done after applying patches for bug 643. The message appears after checking out to a debarred patron using "Override debarment temorarily". Without patch for Bug 12914 the message reads: "Patron has had overdue items and is blocked for 2014-10-31 day(s)." With patch, it reads: "Patron has a restriction until 31/10/2014." The patch was signed off by Nick Clemens. I kindly ask to switch back status from "Failed QA" to "Signed off" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Marc, looking at this patch I think it should not be using format_date but the Dates template plugin instead. Could you provide a new patch? As this won't change the logic you can set it back to 'signed off'. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 --- Comment #7 from Marc Véron <veron@veron.ch> --- Hi Katrin, I had a look at C4/Circulation.pm There are a more calls to the function format_date (that's why I followed this pattern). I suppose that those calls should be replaced as well? If yes, I propose to move the replacement to a separate bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- You are right that the other ones should be removed as well, but I'd like to not introduce new ones if possible :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 --- Comment #9 from Marc Véron <veron@veron.ch> --- Created attachment 32322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32322&action=edit Bug 12914 - Wrong message 'Patron(..) is blocked for 2014-09-30 day(s). The message in circulation.tt assumed to get days but date is given. Updated comments and message depending on expiration date or no expiration of restriction. The message shows up on top of Bug 643 Allow override of 'debarred' status if a patron has a restriction. New patch with replacement of format_date with date template (Comment #6) Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32322|0 |1 is obsolete| | --- Comment #10 from Marc Véron <veron@veron.ch> --- Comment on attachment 32322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32322 Bug 12914 - Wrong message 'Patron(..) is blocked for 2014-09-30 day(s). Oh, something went wront with this patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 --- Comment #11 from Marc Véron <veron@veron.ch> --- Created attachment 32323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32323&action=edit Bug 12914 - Wrong message 'Patron(..) is blocked for 2014-09-30 day(s). The message in circulation.tt assumed to get days but date is given. Updated comments and message depending on expiration date or no expiration of restriction. The message shows up on top of Bug 643 Allow override of 'debarred' status if a patron has a restriction. Replaced date_format with date template (see comment #6) Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32000|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #12 from Marc Véron <veron@veron.ch> --- Setting back to Signed-off (see comment #6) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Marc, I can't reproduce what I can see in your screenshot. The messages I get look quite different and don't include the date (which they should?). I am attaching a screenshot, could you take a look? How are you setting the restriction? I have tested on top of bug 643. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32403&action=edit Screenshot showing messages when overriding debarment -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 --- Comment #15 from Marc Véron <veron@veron.ch> --- Hi Katrin, It seems that my test plan was not precise enough, sorry... It should read: Add manual restriction with expiration date to patron A Add manual restriction without expiration date to patron B For both: Step a) go to check out Step b) override restriction (Bug 643) Result of this step: like screenshot 2014-10-16 by Katrin Step c) check out an item Result: like Marc's screenshot 2014-10-14 with wrong text. This is fixed by the patch. The message for patron A should now be similar to: Patron has a restriction until 04/12/2014. The message for patron B should now read: Patron has a restriction (no expiry date). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32323|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32506&action=edit [PASSED QA] Bug 12914 - Wrong message 'Patron(..) is blocked for 2014-09-30 day(s). The message in circulation.tt assumed to get days but date is given. Updated comments and message depending on expiration date or no expiration of restriction. The message shows up on top of Bug 643 Allow override of 'debarred' status if a patron has a restriction. Replaced date_format with date template (see comment #6) Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Looks good! I was also looking in the wrong place when I marked as failed qa. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Marc! Note: It feels it's time to refactor CanBookBeIsued. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org