https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19593 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I verified the problem in 16.11.x, but might need some help in order to fix it. The template expects a variable basketcount to contain the number of linked baskets. It's undefined in 16.11.x. The problem is in the API rewrite: Bug 12896: Move the bookseller-related code into Koha::Acquisition::Bookseller Changed the code from using GetBookSellerFromId which returned the count, to use the new API: $supplier = Koha::Acquisition::Bookseller->fetch({ id => $booksellerid }); This doesn't return the counts. The problem doesn't appear in 17.05, because in December after 16.11.x was released, another heavy change was made that fixed things in the 17.05 branch: Bug 13726 - Koha::Acquisition::Bookseller should use Koha::Object It added Koha::Acquisition::Booksellers and fixed the count variables for baskets and subscriptions. How to fix? GetBookSellerFromId is no longer there, but I am also missing the newer methods used in 17.05: + $supplier = Koha::Acquisition::Booksellers->find( $booksellerid ); basketcount => $supplier->baskets->count, Dependency trees from that far back are hard to unravel and trying to do so might cause new bad side effects. I think a 16.11.x specific fix for this problem only would be preferrable at this point in time. Can someone help? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19593 --- Comment #2 from Gwendal JONCOUR <gwendal.joncour@univ-rennes2.fr> --- Created attachment 69178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69178&action=edit Rennes 2 local correction for basketcount and subscriptioncount calls Here's my local correction. A little bit nasty but it make its job and works on each calls of basketcount and subscriptioncount. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19593 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19593 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Gwendal and Chris! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19593 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69708|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 69761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69761&action=edit Bug 19593 Basketcount correction on Bookseller.pm To test: 1/ go to /cgi-bin/koha/acqui/booksellers.pl or /cgi-bin/koha/acqui/supplier.pl 2/ Note that it displays the delete vendor button instead of the receive shipments button 3/ Apply patch 4/ Reload the page and notice the button is fixed Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19593 Gwendal JONCOUR <gwendal.joncour@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69761|0 |1 is obsolete| | --- Comment #7 from Gwendal JONCOUR <gwendal.joncour@univ-rennes2.fr> --- Created attachment 69769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69769&action=edit Bug 19593 Basketcount correction on Bookseller.pm Arf, default user/email on our preprod server. Here's the corrected version. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19593 --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> ---

Thats Gwendal

That should be Thanks Gwendal :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19593 --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to Jonathan Druart from comment #10)

This change broke 3 tests: https://jenkins.koha-community.org/job/Koha_16.11_D8/lastCompletedBuild/ testReport/

Yup, the tests are wrong so they should break. I'll fix them this afternoon ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19593 --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- Ok, discount is a float(6,4) .. and tax_rate is a decimal(6,4), $VAR1 = { 'bookselleremail' => undef, 'notes' => 'notes2', 'address2' => 'address2-2', 'booksellerurl' => undef, 'booksellerfax' => undef, 'url' => 'url2', 'address1' => 'address1_2', 'phone' => 'phone2', 'listprice' => undef, 'fax' => 'fax2', 'id' => 44, 'invoiceincgst' => 1, 'currency' => '', 'accountnumber' => 'accountnumber2', 'name' => 'Name2', 'deliverytime' => 2, 'postal' => 'postal2', 'tax_rate' => '2.0000', 'gstreg' => 1, 'listincgst' => 1, 'invoiceprice' => undef, 'address4' => 'address4_2', 'discount' => '2', 'othersupplier' => undef, 'address3' => 'address3_2', 'active' => 1 }; It's handing back 2 instead of 2.0000 but fine for tax_rate, if I change the db to be decimal, it works Not to do with this bug, ill fix the basketcount thing, and push that, but this test needs looking into more -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.