https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |cbrannon@cdalibrary.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Christopher Brannon <cbrannon@cdalibrary.org> --- I've tracked the actual location change to course-details.tt. I also did some enhancements of the temporary changes and regular states so it is more obvious. I am also noting a couple flaws in the module: Notes can be changed by the course reserves, but should be appended to temporarily. The course reserves appears to permanently change the notes. Also, once an item is added to the reserve, editing the item will not produce any changes. You have to delete the item and add it again with the new changes for it to take. These items should be addressed in a new bug. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- Scratch the comment about the notes. They seem to operate differently from the rest of the fields. This should be noted in the manual. Notes entered in course reserves do not replace notes in the item record as the other fields do. These notes only appear to show up in the course reserve modules. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Permanent location should |Permanent location should |instead of cart location - |instead of cart location - |course-details.pl |course-details.tt -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |alexbuckley@catalyst.net.nz --- Comment #5 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi there Could you please rebase your patches as they are not applying cleanly on master. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 21446: Correct perm location and enhance Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt Failed to merge in the changes. Patch failed at 0001 Bug 21446: Correct perm location and enhance The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-21446-Correct-perm-location-and-enhance-6FL5FL.patch Cheers, Alex -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79618|0 |1 is obsolete| | Attachment #82104|0 |1 is obsolete| | --- Comment #7 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 82105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82105&action=edit Bug 21446: Correct perm location and enhance TO TEST: 1) Set ReturnToShelvingCart on. 2) Create a Course Reserve and make inactive. 3) Add an item, changing Item type, Collection code, Shelving location, and Holding library. 4) Note these four fields in the item list. 5) Activate course reserve. 6) Note subtle/no difference in these fiels in the list. 7) Check in the item. 8) Go back to course reserves and note that the cart is listed in the field instead of permanent location. 9) Deactivate course reserve. 10) Reset permanent location on item manually. 11) Apply patch. 12) Repeat steps 4-9 noting that the permanent location is showing instead of current location. Also, if a change is assigned to the item, the change AND the regular state always show. The active state will be in bold. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82104|0 |1 is obsolete| | --- Comment #8 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 82106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82106&action=edit Bug 21446: Remove fix comment Fix is not needed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 helene <hickeyhe@wgc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82106|0 |1 is obsolete| | --- Comment #10 from helene <hickeyhe@wgc.school.nz> --- Created attachment 84113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84113&action=edit Bug 21446: Remove fix comment Fix is not needed. Signed-off-by: helene hickey <hickeyhe@wgc.school.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84113|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84676&action=edit Bug 21446: Remove fix comment Fix is not needed. Signed-off-by: helene hickey <hickeyhe@wgc.school.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- CC| |mkstephens@lancasterseminar | |y.edu Status|RESOLVED |REOPENED --- Comment #15 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- I have noticed a typo that I think is related to this bug. In course reserves, when a course is inactive, the normal item type is lacking a closing parentheses in the item table. To Test: 1) Create a course in course reserves, make it inactive 2) Add an item to it, changing item type and location 3) Note that the normal item type is in bold with an opening parentheses but no closing parentheses; Note that the normal location is in bold with both opening and closing parentheses. 4) Make the course active 5) Note that the normal item type is no longer bold and has both opening and closing parentheses; Note that the normal location is also not bold and has both opening and closing parentheses. Please fix to add closing parentheses to the normal item type when a course is inactive. Thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25609 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25609 [Bug 25609] Use of permanent location instead of location -- You are receiving this mail because: You are watching all bug changes.