https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26239 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Depends on| |15770 Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15770 [Bug 15770] Number::Format issues with large numbers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26239 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26239 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108528|0 |1 is obsolete| | --- Comment #2 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 108530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108530&action=edit Bug 26239: Do not format large negative numbers Test plan: - Add a manual credit to a patron of 100000000000000 - ISE! - Apply patch - Restart all the things ------------------------------- Checked and worked OK. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26239 --- Comment #3 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 108531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108531&action=edit Error screenshot -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26239 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108530|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108560&action=edit Bug 26239: Do not format large negative numbers At several places we got the following error if we use numbers too big for Number::Format Template process failed: undef error - round() overflow. Try smaller precision or use Math::BigFloat at /home/koha/src/Koha/Number/Price.pm line 44 It make the app explodes. The goal here is to handle these errors gracefully and easily. We fixed it for positive numbers in bug 15770, but we neglected the case of negative numbers Test plan: - Add a manual credit to a patron of 100000000000000 - ISE! - Apply patch - Restart all the things Works perfectly. Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26239 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.