[Bug 7932] New: twitter share doesn't work with socialnetworks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 Priority: P5 - low Change sponsored?: --- Bug ID: 7932 Assignee: oleonard@myacpl.org Summary: twitter share doesn't work with socialnetworks QA Contact: koha.sekjal@gmail.com Severity: normal Classification: Unclassified OS: All Reporter: nengard@gmail.com Hardware: All Status: NEW Version: master Component: OPAC Product: Koha The Twitter share button added by the socialnetworks preference doesn't take the url of the page you're sharing - it just opens a blank twitter status window. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 9624 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9624&action=edit Bug 7932 - twitter share doesn't work with socialnetworks The only way I can get this to work consistently is to use Twitter's own code as documented here: https://dev.twitter.com/docs/tweet-button This requires that we use the tweet button generated by Twitter rather than the smaller image we were using before. Using the documented options for generating a custom button produced the same inconsistent behavior this patch attempts to fix. Because of the change of appearance I moved the Twitter button to last in line so that similarly-sized buttons were grouped. I also changed the configuration of the Google+ button to exclude the count, saving some horizontal space. This fix will have to be manually merged with the social networks followup for Bug 7500 (image sprites) if and when that patch is approved. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- The proposed patch (attachment 8955) for Bug 7470 does not fix this issue ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Sorry Jonathan, maybe so. I saw this because it was assigned to me. I didn't realize there was a follow-up to Bug 7470 waiting to be tested. I'll do so now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9624|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 9687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9687&action=edit Bug 7932 - [SIGNED-OFF] twitter share doesn't work with socialnetworks This patch will be apply AFTER attachment 9680 (from Bug 7500) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no --- Comment #5 from Magnus Enger <magnus@enger.priv.no> --- Should the status here be set to "signed off", or am I missing something? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Yes Magnus, sorry -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment : tiny patch, nothing to notice, passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- Yikes, trying to apply the patch after reading/QAing it, I see it does not apply: Bug 7932 - [SIGNED-OFF] twitter share doesn't work with socialnetworks Apply? [yn] y Applying: Bug 7932 - twitter share doesn't work with socialnetworks fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 7932 - twitter share doesn't work with socialnetworks When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/Bug-7932---SIGNED-OFF-twitter-share-doesnt-work-wi-iOQjv8.patch [new/bug_7932 dd8725c] Bug 8095 - Printed lists in the OPAC not easy to read Author: Owen Leonard <oleonard@myacpl.org> 1 file changed, 11 insertions(+), 1 deletion(-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #8)
Yikes, trying to apply the patch after reading/QAing it, I see it does not apply: Yikes again = I missed to see comment 4 = this patch must be applied after 7500
back to signed-off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Ian Walls <koha.sekjal@gmail.com> --- URL is hardcoded to https://, even if that's not the way the library is currently configured. Also tries to set data-lang = [% en %], which I do not believe is a valid template parameter (and if it is, it needs a different name). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED Version|rel_3_8 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9687|0 |1 is obsolete| | --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13179&action=edit Bug 7932 - twitter share doesn't work with socialnetworks The only way I can get this to work consistently is to use Twitter's own code as documented here: https://dev.twitter.com/docs/tweet-button This requires that we use the tweet button generated by Twitter rather than the smaller image we were using before. Using the documented options for generating a custom button produced the same inconsistent behavior this patch attempts to fix. Because of the change of appearance I moved the Twitter button to last in line so that similarly-sized buttons were grouped. I also changed the configuration of the Google+ button to exclude the count, saving some horizontal space. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_12 --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- String changes. Will hold for post-3.10.0. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 --- Comment #13 from Nicole C. Engard <nengard@gmail.com> --- Owen, the twitter button works now but doesn't appear to include a link - shouldn't it have a link to the record I'm clicking the button on? Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 --- Comment #14 from Nicole C. Engard <nengard@gmail.com> --- https://twitter.com/intent/tweet?original_referer=http%3A%2F%2Fkohavm%2Fcgi-bin%2Fkoha%2Fopac-detail.pl%3Fbiblionumber%3D5072%26query_desc%3Dkw%2Cwrdl%3A%2520systems%2520librarian&source=tweetbutton&text=The%20accidental%20systems%20librarian%20%2F&url=kohavm%2Fcgi-bin%2Fkoha%2Fopac-detail.pl%3Fbiblionumber%3D5072 Is it possible that the missing http in this part: url=kohavm%2Fcgi-bin%2Fkoha%2Fopac-detail.pl%3Fbiblionumber%3D5072 is why it's not linking? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 --- Comment #15 from Nicole C. Engard <nengard@gmail.com> --- Is that cause of this bug: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 --- Comment #16 from Nicole C. Engard <nengard@gmail.com> --- Nope, it's not that - I tested this url: https://twitter.com/intent/tweet?original_referer=http%3A%2F%2Fkohavm%2Fcgi-bin%2Fkoha%2Fopac-detail.pl%3Fbiblionumber%3D5072%26query_desc%3Dkw%2Cwrdl%3A%2520systems%2520librarian&source=tweetbutton&text=The%20accidental%20systems%20librarian%20%2F&url=http:%2F%2Fkohavm%2Fcgi-bin%2Fkoha%2Fopac-detail.pl%3Fbiblionumber%3D5072 and it still doesn't put the link in the tweet. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8952 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|8952 | QA Contact|koha.sekjal@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13179|0 |1 is obsolete| | --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13397&action=edit Bug 7932 [Revised] Twitter share doesn't work with socialnetworks The only way I can get this to work consistently is to use Twitter's own code as documented here: https://dev.twitter.com/docs/tweet-button This requires that we use the tweet button generated by Twitter rather than the smaller image we were using before. Using the documented options for generating a custom button produced the same inconsistent behavior this patch attempts to fix. Because of the change of appearance I moved the Twitter button to last in line so that similarly-sized buttons were grouped. I also changed the configuration of the Google+ button to exclude the count, saving some horizontal space. Revision removes explicit declaration of share URL. I think when testing this previously I assumed it was required when in fact the share URL wasn't working because it was a localhost address. Localhost addresses are apparently rejected by Twitter. Testers beware. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13397|0 |1 is obsolete| | --- Comment #18 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 13400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13400&action=edit [SIGNED-OFF] Bug 7932 [Revised] Twitter share doesn't work with socialnetworks The only way I can get this to work consistently is to use Twitter's own code as documented here: https://dev.twitter.com/docs/tweet-button This requires that we use the tweet button generated by Twitter rather than the smaller image we were using before. Using the documented options for generating a custom button produced the same inconsistent behavior this patch attempts to fix. Because of the change of appearance I moved the Twitter button to last in line so that similarly-sized buttons were grouped. I also changed the configuration of the Google+ button to exclude the count, saving some horizontal space. Revision removes explicit declaration of share URL. I think when testing this previously I assumed it was required when in fact the share URL wasn't working because it was a localhost address. Localhost addresses are apparently rejected by Twitter. Testers beware. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 MJ Ray (software.coop) <mjr@software.coop> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mjr@software.coop --- Comment #19 from MJ Ray (software.coop) <mjr@software.coop> --- (In reply to comment #18)
The only way I can get this to work consistently is to use Twitter's own code as documented here:
https://dev.twitter.com/docs/tweet-button
This requires that we use the tweet button generated by Twitter rather than the smaller image we were using before. Using the documented options for generating a custom button produced the same inconsistent behavior this patch attempts to fix.
Does it require it (which would suggest a critical permission/licensing problem) or is it just that we can't get it to work with anything else yet? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Version|3.12 |3.10 QA Contact| |paul.poulain@biblibre.com --- Comment #20 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * despite its size, this patch is tiny, the longest part is the documentation ! * no string change, except the "share on twitter" alt removed, not a problem for 3.10.0 passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jcamins@cpbibliography.com --- Comment #21 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 --- Comment #22 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to branch 3.10.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |chris@bigballofwax.co.nz Resolution|--- |FIXED --- Comment #23 from Chris Cormack <chris@bigballofwax.co.nz> --- Released in 3.10.0 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org