[Bug 20948] New: Hold requests on detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Bug ID: 20948 Summary: Hold requests on detail.pl Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The next hold request showing on the detail.pl page next to items is useless and should be removed or fixed. The information for requests on an item is misleading. It shows the next item level hold rather than showing the next hold it will fulfill. I understand how this might be useful in some obscure circumstances, but for the most part it leads staff to believe that this is the next hold it will fill, and that is not the case. Case in point...we have a new item, only one in the collection. 33 next available holds, and 1 item level hold at the very end of the list, going to a different library. With all the other holds ahead of it, and the fact that we have local holds priority enabled, this looks very wrong, and leads staff to confusion and panic. It might be helpful to some libraries to see that there is a specific hold on a particular item, but around here, most libraries will view this as misleading. There should be a setting to change the behavior, or turn it off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Lisette <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Does it concern 17.05 only? I do not understand what you are referring to on master, can you provide screenshots? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #2 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 76145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76145&action=edit Misleading Hold Info Screenshot of misleading hold. Shows the only item-level hold in the 35 current holds. This is not who the item will be going to when checked in. Would prefer to not show this information if it is meaningless to us. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- I realize that it may be impossible to display next available holds, but if there are next available holds and local hold priorities, I fail to see how showing the next item level hold helps. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #4 from Lisette <lisetteslatah@gmail.com> --- Created attachment 76216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76216&action=edit Misleading Hold Info - In Transit I noticed today that there is also misleading hold info on the 'Holds' table on moremembers.pl and circulation.pl. It will list "In Transit from X branch since Y" even if that patron is not the next patron. This also only happens with item level holds. I'm happy to fill out a different bug, but I thought it might be related based on how the information is getting pulled. Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I would be happy to have a look at this one if someone can provide a step-by-step plan to recreate the problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #6 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Jonathan Druart from comment #5)
I would be happy to have a look at this one if someone can provide a step-by-step plan to recreate the problem.
Place several next available holds on a single item record. Then place an item level hold on the item. Look at the detail.pl page. The item will show the item level hold. Many staff interpret this to mean this is where the hold is going next. It is preferred if it just said "There is an item level hold on this item", without any specific details. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.05 |master Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95476&action=edit Bug 20948: Simplify existing code No changes expected here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95477&action=edit Bug 20948: Only display item-level hold info if first hold On the item list of the catalogue detail page we display next item-level hold info even if it is not the next hold. That leads to confusion as it will not necessarily be the accurate info. This patch makes the following changes: - Display the item-level hold only if it is the next hold (priority == 1) - Display "There is an item level hold on this item (priority=X)" if there is at least 1 item-level hold placed on this item Test plan: - Place several next available holds on a single item record - Place an item level hold on the item - Go the the biblio detail page => Without this patch, the item will show the item level hold => With the patch you see "There is an item level hold on this item" - Check the item in, confirm the hold => No changes, the item will show the waiting hold info - Cancel all the holds except the item-level one => No changes, the item will how the item-level one -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Hold requests on detail.pl |Item-level hold info | |displayed regardless its | |priority (detail.pl) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95476|0 |1 is obsolete| | --- Comment #9 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 95636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95636&action=edit Bug 20948: Simplify existing code No changes expected here. Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95477|0 |1 is obsolete| | --- Comment #10 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 95637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95637&action=edit Bug 20948: Only display item-level hold info if first hold On the item list of the catalogue detail page we display next item-level hold info even if it is not the next hold. That leads to confusion as it will not necessarily be the accurate info. This patch makes the following changes: - Display the item-level hold only if it is the next hold (priority == 1) - Display "There is an item level hold on this item (priority=X)" if there is at least 1 item-level hold placed on this item Test plan: - Place several next available holds on a single item record - Place an item level hold on the item - Go the the biblio detail page => Without this patch, the item will show the item level hold => With the patch you see "There is an item level hold on this item" - Check the item in, confirm the hold => No changes, the item will show the waiting hold info - Cancel all the holds except the item-level one => No changes, the item will how the item-level one Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt FAIL filters missing_filter at line 365 ( There is an item level hold on this item (priority = [% hold.priority %]).) Work on qa tools ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- There is an item level hold on this item (priority = 2). Personally, I think we'd better not show this at all. Please explain why we need this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #12)
There is an item level hold on this item (priority = 2).
Personally, I think we'd better not show this at all. Please explain why we need this.
I used Christopher's suggestion: (In reply to Christopher Brannon from comment #6)
It is preferred if it just said "There is an item level hold on this item", without any specific details.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #13)
(In reply to Marcel de Rooy from comment #12)
There is an item level hold on this item (priority = 2).
Personally, I think we'd better not show this at all. Please explain why we need this.
I used Christopher's suggestion:
(In reply to Christopher Brannon from comment #6)
It is preferred if it just said "There is an item level hold on this item", without any specific details.
Well, Christopher is invited to reply too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #15 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Marcel de Rooy from comment #12)
There is an item level hold on this item (priority = 2).
Personally, I think we'd better not show this at all. Please explain why we need this.
I would have suggested removing it altogether, but there are those that want to know if there are item level holds on items. Particularly if items are lost or missing or damaged. That way they can easily see them and do something about the holds. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #16 from Lisette Scheer <lisetteslatah@gmail.com> --- (In reply to Christopher Brannon from comment #15)
I would have suggested removing it altogether, but there are those that want to know if there are item level holds on items. Particularly if items are lost or missing or damaged. That way they can easily see them and do something about the holds.
This is why I would find the message helpful as well. Are there any performance issues from having it show? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Is this similar/related to Bug 19288? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19288 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #17)
Is this similar/related to Bug 19288?
Yes, at first glance they refer to the same problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Lisette Scheer from comment #16)
(In reply to Christopher Brannon from comment #15)
I would have suggested removing it altogether, but there are those that want to know if there are item level holds on items. Particularly if items are lost or missing or damaged. That way they can easily see them and do something about the holds.
This is why I would find the message helpful as well. Are there any performance issues from having it show?
Absolutely not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95636|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 95870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95870&action=edit Bug 20948: Simplify existing code No changes expected here. Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95637|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 95871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95871&action=edit Bug 20948: Only display item-level hold info if first hold On the item list of the catalogue detail page we display next item-level hold info even if it is not the next hold. That leads to confusion as it will not necessarily be the accurate info. This patch makes the following changes: - Display the item-level hold only if it is the next hold (priority == 1) - Display "There is an item level hold on this item (priority=X)" if there is at least 1 item-level hold placed on this item Test plan: - Place several next available holds on a single item record - Place an item level hold on the item - Go the the biblio detail page => Without this patch, the item will show the item level hold => With the patch you see "There is an item level hold on this item" - Check the item in, confirm the hold => No changes, the item will show the waiting hold info - Cancel all the holds except the item-level one => No changes, the item will how the item-level one Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- *** Bug 19288 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19288 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288 [Bug 19288] Holds placed on a specific item after a next available hold will show varied results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96137&action=edit Bug 20948: Add missing html filter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for catching that Jonathan.. you beat me to it :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.05.00 |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com --- Comment #28 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.02 Thanks, joy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #29 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z Version(s)|20.05.00, 19.11.02 |20.05.00, 19.11.02, released in| |18.11.13 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #30 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Backported to 18.11.x for 18.11.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.02, |20.05.00, 19.11.02, released in|18.11.13 |19.05.07, 18.11.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bugzilla@koha-us.org | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org