[Bug 18942] New: Acquisitions module fails to load with an error when hash created on empty values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942 Bug ID: 18942 Summary: Acquisitions module fails to load with an error when hash created on empty values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: ldjamison@marywood.edu QA Contact: testopia@bugs.koha-community.org Under certain circumstances, the Acquisitions module fails to load at CanUserUseBudget in C4::Budgets. To replicate (assuming using kohadevbox): 1. Login as koha_kohadev 2. Attempt to load the Acquisitions module 3. Notice Internal Server Error 4. Check plack log which shows Can't call method "unblessed" on an undefined value at /home/vagrant/kohaclone/C4/Budgets.pm line 919. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Summary|Acquisitions module fails |Acquisitions module fails |to load with an error when |to load with an error when |hash created on empty |using system user |values | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Acquisitions module fails |t/Budget/CanUserUseBudget.t |to load with an error when |missing system user test |using system user |case -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mtompset@hotmail.com |ity.org | Summary|t/Budget/CanUserUseBudget.t |CanUserUseBudget.t and |missing system user test |CanUserModifyBudget.t |case |missing system user test | |cases --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Given there is an easy way to trigger this problem. I changed the title. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- -- and expanded scope a little: same file, same tweak. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 65051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65051&action=edit Bug 18942: Add test case to prove change -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 65052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65052&action=edit Bug 18942: Internal Server Error symptomatic of using system user TEST PLAN --------- 1) sudo koha-shell -c bash kohadev 2) prove -v t/Budgets/CanUserUseBudget.t -- works 3) prove -v t/Budgets/CanUserModifyBudget.t -- works 4) exit 5) git bz apply 18942 -- interactive just the test patch 6) repeat steps 1-4 -- prove fails (similar message with 919 in comment #0) 7) git bz apply 18942 -- interactive just the actual fix 8) repeat steps 1-4 -- works 9) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65051|0 |1 is obsolete| | --- Comment #5 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 65055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65055&action=edit Bug 18942: Add test case to prove change Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Works as directed following test plan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65052|0 |1 is obsolete| | --- Comment #6 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 65056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65056&action=edit Bug 18942: Internal Server Error symptomatic of using system user TEST PLAN --------- 1) sudo koha-shell -c bash kohadev 2) prove -v t/Budgets/CanUserUseBudget.t -- works 3) prove -v t/Budgets/CanUserModifyBudget.t -- works 4) exit 5) git bz apply 18942 -- interactive just the test patch 6) repeat steps 1-4 -- prove fails (similar message with 919 in comment #0) 7) git bz apply 18942 -- interactive just the actual fix 8) repeat steps 1-4 -- works 9) run koha qa test tools Signed-off-by: Lee Jamison <ldjamison@marywood.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17829 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 [Bug 17829] Move GetMember to Koha::Patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Login with DB user is not allowed, the only 2 available actions are 1. Create a patron and 2. Set the superlibrarian permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65078&action=edit Bug 18942: Simplify syntax -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65055|0 |1 is obsolete| | --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 65079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65079&action=edit Bug 18942: Add test case to prove change Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65056|0 |1 is obsolete| | --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 65080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65080&action=edit Bug 18942: Internal Server Error symptomatic of using system user TEST PLAN --------- 1) sudo koha-shell -c bash kohadev 2) prove -v t/Budgets/CanUserUseBudget.t -- works 3) prove -v t/Budgets/CanUserModifyBudget.t -- works 4) exit 5) git bz apply 18942 -- interactive just the test patch 6) repeat steps 1-4 -- prove fails (similar message with 919 in comment #0) 7) git bz apply 18942 -- interactive just the actual fix 8) repeat steps 1-4 -- works 9) run koha qa test tools Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65078|0 |1 is obsolete| | --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 65081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65081&action=edit Bug 18942: Simplify syntax Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 65082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65082&action=edit Bug 18942: (QA followup) Add new tests descriptions Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |tomascohen@gmail.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942 Bug 18942 depends on bug 17829, which changed state. Bug 17829 Summary: Move GetMember to Koha::Patron https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #14 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Not pushed to 17.05.x because depends on Bug 17829 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org