[Bug 37969] New: Add missing language code nor (Norwegian/inclusive)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37969 Bug ID: 37969 Summary: Add missing language code nor (Norwegian/inclusive) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: lari.taskula@hypernova.fi QA Contact: testopia@bugs.koha-community.org Norway has two official forms of written language, nynorsk (nno) and bokmål (nob). However an inclusive ISO 639-2 language code also exists (nor) and is missing from Koha. https://www.loc.gov/standards/iso639-2/php/code_list.php -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37969 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37969 --- Comment #1 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 171807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171807&action=edit Bug 37969: Add missing language code nor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37969 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lari.taskula@hypernova.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37969 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- Thanks for thinking about us! :-) This seems to be adding more than just "nor". Is that a mistake or is the name of the bug a little misleading? Or am I missing something? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37969 --- Comment #3 from Lari Taskula <lari.taskula@hypernova.fi> --- (In reply to Magnus Enger from comment #2)
Thanks for thinking about us! :-) We love our Norwegian neighbours.
This seems to be adding more than just "nor". Is that a mistake or is the name of the bug a little misleading? Or am I missing something? Our issue is that facets display just "nor" instead of a human-readable language name.
The way I came up with this patch was that I copy-pasted one of the other official written forms in subtag_registry.sql and adjusted the ISO 639-1/2 codes accordingly. Not sure if something is unnecessary in this patch but if there is I am happy to fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37969 --- Comment #4 from Magnus Enger <magnus@libriotech.no> --- Ah, I get it now, I think. I was wondering why you were adding things like this: $dbh->do(q{ INSERT INTO language_descriptions(subtag, type, lang, description) VALUES ( 'no', 'language', 'pl', 'Norweski'); }); But I guess "no" is a two letter version of "nor". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37969 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37969 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171807|0 |1 is obsolete| | --- Comment #5 from Magnus Enger <magnus@libriotech.no> --- Created attachment 171870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171870&action=edit Bug 37969: Add missing language code nor Signed-off-by: Magnus Enger <magnus@libriotech.no> Test plan: - Start KTD with Elastic: ktd --es7 up - Edit a record, e.g. "Dom Casmurro : a novel" and change the language code in 008/35-37 from "eng" to "nor": Before: 980914s1997 nyu 00011 eng b After: 980914s1997 nyu 00011 nor b - Do a search that finds the edited record and some other records, so you can see the list of resulots and the facets, e.g. "dom" - Verify that "nor" is shown in the languages facet - Apply this patch and run koha-upgrade-schema kohadev - Do the search again and verify that "Norwegian" is now shown instead of "nor" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37969 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171870|0 |1 is obsolete| | --- Comment #6 from Thomas Klausner <domm@plix.at> --- Created attachment 173006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173006&action=edit Bug 37969: Add missing language code nor Signed-off-by: Magnus Enger <magnus@libriotech.no> Test plan: - Start KTD with Elastic: ktd --es7 up - Edit a record, e.g. "Dom Casmurro : a novel" and change the language code in 008/35-37 from "eng" to "nor": Before: 980914s1997 nyu 00011 eng b After: 980914s1997 nyu 00011 nor b - Do a search that finds the edited record and some other records, so you can see the list of resulots and the facets, e.g. "dom" - Verify that "nor" is shown in the languages facet - Apply this patch and run koha-upgrade-schema kohadev - Do the search again and verify that "Norwegian" is now shown instead of "nor" Signed-off-by: Thomas Klausner <domm@plix.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37969 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |domm@plix.at --- Comment #7 from Thomas Klausner <domm@plix.at> --- Works as advertised => Passed QA! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37969 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |domm@plix.at |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37969 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Fixed when moving to dbrev: WARN installer/data/mysql/atomicupdate/bug_37969_add_missing_language_code_nor.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 11) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37969 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37969 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Switched database update to use say_success and made it sure it could be run multiple times by using INSERT IGNORE. Also tested running it twice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37969 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37969 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37969 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37969 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds the release notes| |language code nor for the | |Norwegian inclusive | |language ISO 639-2 to Koha. CC| |lisette@bywatersolutions.co | |m Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37969 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Enhancement, no 24.05.x backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37969 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #12 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Internal architecture, nothing to add/edit in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org