[Bug 37080] New: Cannot delete a MARC bibliographic framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37080 Bug ID: 37080 Summary: Cannot delete a MARC bibliographic framework Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl On current main (and 24.05) you cannot delete a MARC bibliographic framework. Reported on chat (13 June 2024) for 24.05.00 and reproduced on main. Steps to reproduce: 1. Go to Koha administration > Catalog > MARC bibliographic frameworks. 2. For a framework, select Actions > Delete. 3. Message displayed: "Confirm deletion of framework '' ()?" (with options under this - "Yes, delete this framework" and "No, do not delete") (note that the URL has the framework code /cgi-bin/koha/admin/biblio_framework.pl?op=delete_confirm&frameworkcode=ACQ) 4. Click "Yes, delete this framework". 5. Error message displayed: "An error occurred when deleting this framework. Check the logs for details." 6. Nothing in the logs that seems of any help (/var/logs/koha/kohadev/* - where kohadev is the instance name). Other observations: 1. If you create a new framework (without adding any MARC structure) and attempt to delete, you get the same error. So not related records using the framework. 2. No JavaScript or other browser console errors using the browser's web development tools. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37080 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37080 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37080 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36192 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37080 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37080 --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 167680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167680&action=edit Bug 37080: Cannot delete MARC bibliographic frameworks or authority types The scripts for managing both bib and authority frameworks are now expecting an op 'cud-delete_confirm' but delete_confirm isn't cud, it's just a GET of a page asking if you are sure. The scripts just need to expect the op they are actually getting, delete_confirm. Test plan: 1. Administration - MARC bibliographic framework - New framework 2. Give the framework any code and description and Submit 3. Actions menu for your new framework - Delete 4. Note the message says 'Confirm deletion of framework '' ()?" rather than having the code and description included. 5. Click Yes, note that deleting failed 6. Administration - Authority types - New authority type 7. Give the authority type any type and description and Submit 8. Actions menu for your authority type - Delete 9. Note the message again says '' () rather than 'desc' (FOO) 10. Click yes, note that deleting failed 11. Finally! Apply patch, reset_all 12. Repeat steps 1-10, this time noting that you get 'desc' (FOO) rather than '' (), and that deleting works. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37080 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |phil@chetcolibrary.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37080 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37080 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167680|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 167682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167682&action=edit Bug 37080: Cannot delete MARC bibliographic frameworks or authority types The scripts for managing both bib and authority frameworks are now expecting an op 'cud-delete_confirm' but delete_confirm isn't cud, it's just a GET of a page asking if you are sure. The scripts just need to expect the op they are actually getting, delete_confirm. Test plan: 1. Administration - MARC bibliographic framework - New framework 2. Give the framework any code and description and Submit 3. Actions menu for your new framework - Delete 4. Note the message says 'Confirm deletion of framework '' ()?" rather than having the code and description included. 5. Click Yes, note that deleting failed 6. Administration - Authority types - New authority type 7. Give the authority type any type and description and Submit 8. Actions menu for your authority type - Delete 9. Note the message again says '' () rather than 'desc' (FOO) 10. Click yes, note that deleting failed 11. Finally! Apply patch, reset_all 12. Repeat steps 1-10, this time noting that you get 'desc' (FOO) rather than '' (), and that deleting works. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37080 --- Comment #3 from David Nind <david@davidnind.com> --- Thanks Phil for creating a patch so quickly! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37080 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37080 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cannot delete a MARC |Cannot delete a MARC |bibliographic framework |bibliographic framework or | |authority type -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37080 --- Comment #4 from David Nind <david@davidnind.com> --- Can confirm that the patch fixes the issue for both MARC frameworks and authority types. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37080 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167682|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 167711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167711&action=edit Bug 37080: Cannot delete MARC bibliographic frameworks or authority types The scripts for managing both bib and authority frameworks are now expecting an op 'cud-delete_confirm' but delete_confirm isn't cud, it's just a GET of a page asking if you are sure. The scripts just need to expect the op they are actually getting, delete_confirm. Test plan: 1. Administration - MARC bibliographic framework - New framework 2. Give the framework any code and description and Submit 3. Actions menu for your new framework - Delete 4. Note the message says 'Confirm deletion of framework '' ()?" rather than having the code and description included. 5. Click Yes, note that deleting failed 6. Administration - Authority types - New authority type 7. Give the authority type any type and description and Submit 8. Actions menu for your authority type - Delete 9. Note the message again says '' () rather than 'desc' (FOO) 10. Click yes, note that deleting failed 11. Finally! Apply patch, reset_all 12. Repeat steps 1-10, this time noting that you get 'desc' (FOO) rather than '' (), and that deleting works. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37080 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for the quick correction here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37080 --- Comment #7 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Thanks, all! Looks like there are a few more pages where this correction needs to be made...filing additional bugs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37080 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37089 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37080 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37090 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37080 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37091 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37080 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37080 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37080 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.02 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to main |Pushed to stable --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37080 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the forms so release notes| |that you can now delete | |MARC bibliographic | |frameworks and authority | |types. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37080 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Full CSRF not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37080 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the forms so |This fixes the forms so release notes|that you can now delete |that you can now delete |MARC bibliographic |MARC bibliographic |frameworks and authority |frameworks and authority |types. |types. (This is related to | |the CSRF changes added in | |Koha 24.05 to improve form | |security.) Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #11 from David Nind <david@davidnind.com> --- No changes required to the manual. This fixes forms so that they work. No screenshots need updating, and the task for deleting a framework (bibliographic or authority type) is not explicitly covered. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37080 Bug 37080 depends on bug 36192, which changed state. Bug 36192 Summary: [OMNIBUS] CSRF Protection for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org