[Bug 28044] New: Calendar: Tables with closed days are no longer color coded
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28044 Bug ID: 28044 Summary: Calendar: Tables with closed days are no longer color coded Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: oleonard@myacpl.org Maybe I missed a recent change here, but the tables on the calendar page no longer appear color coded. When you reload the page, you can see the color is there for a second and then disappears. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28044 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28044 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 118947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118947&action=edit Bug 28044: Increase specificity of calendar tables CSS This patch adds increased specificity to the CSS which should add colors to the tables of holidays. The default DataTable CSS was overriding the custom color-coding. This patch also moves the calendar CSS into a separate file. To test, apply the patch and go to Tools -> Calendar. If necessary, add at least one of the following: - Unique holiday - Holiday repeating weekly - Holiday repeating monthly - Holiday exception In the table listing each kind of holiday, the color of the table header should match the colors in the "Key" section under Hints. The color should be correct regardless of how the table is sorted. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28044 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28044 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28044 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118947|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 119058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119058&action=edit Bug 28044: Increase specificity of calendar tables CSS This patch adds increased specificity to the CSS which should add colors to the tables of holidays. The default DataTable CSS was overriding the custom color-coding. This patch also moves the calendar CSS into a separate file. To test, apply the patch and go to Tools -> Calendar. If necessary, add at least one of the following: - Unique holiday - Holiday repeating weekly - Holiday repeating monthly - Holiday exception In the table listing each kind of holiday, the color of the table header should match the colors in the "Key" section under Hints. The color should be correct regardless of how the table is sorted. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28044 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28044 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119058|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119138&action=edit Bug 28044: Increase specificity of calendar tables CSS This patch adds increased specificity to the CSS which should add colors to the tables of holidays. The default DataTable CSS was overriding the custom color-coding. This patch also moves the calendar CSS into a separate file. To test, apply the patch and go to Tools -> Calendar. If necessary, add at least one of the following: - Unique holiday - Holiday repeating weekly - Holiday repeating monthly - Holiday exception In the table listing each kind of holiday, the color of the table header should match the colors in the "Key" section under Hints. The color should be correct regardless of how the table is sorted. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28044 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28044 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28044 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28044 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Version(s)|21.05.00,20.11.05 |21.05.00,20.11.05,20.05.11 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Fixed info about backport to oldstable, 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28044 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org