https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 51585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51585&action=edit Bug 16539 - Koha::Cache is incorrectly caching single holidays This makes the loop add holidays for each bracnh instead of the calling branch To test: I used memcached-tools to view the cache, clear the cache, and wait for holidays to regnerate Have a branches with different holidays Clear the cache Do a checkout View the cache - one libraries holidays are repeated for all branches Apply patch Clear the cache Do a checkout Library holidays are correctly cached -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51585|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 51587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51587&action=edit Bug 16539 - Koha::Cache is incorrectly caching single holidays This makes the loop add holidays for each bracnh instead of the calling branch To test: I used memcached-tools to view the cache, clear the cache, and wait for holidays to regnerate Have a branches with different holidays Clear the cache Do a checkout View the cache - one libraries holidays are repeated for all branches Apply patch Clear the cache Do a checkout Library holidays are correctly cached Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51587|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 51588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51588&action=edit Bug 16539 - Koha::Cache is incorrectly caching single holidays This makes the loop add holidays for each bracnh instead of the calling branch To test: I used memcached-tools to view the cache, clear the cache, and wait for holidays to regnerate Have a branches with different holidays Clear the cache Do a checkout View the cache - one libraries holidays are repeated for all branches Apply patch Clear the cache Do a checkout Library holidays are correctly cached Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51593&action=edit Bug 16539: Try to provide tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- For me tests fail without patch and pass with it, back to signed off (In reply to Jonathan Druart from comment #5)

Nick, I have tried to provide tests for this change, but they pass even without your patch. Could you have a look?

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51588|0 |1 is obsolete| | Attachment #51664|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51665&action=edit Bug 16539 - Koha::Cache is incorrectly caching single holidays This makes the loop add holidays for each bracnh instead of the calling branch To test: I used memcached-tools to view the cache, clear the cache, and wait for holidays to regnerate Have a branches with different holidays Clear the cache Do a checkout View the cache - one libraries holidays are repeated for all branches Apply patch Clear the cache Do a checkout Library holidays are correctly cached Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.05. Thanks Nick, Jonathan! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.7 -- You are receiving this mail because: You are watching all bug changes.