http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12134 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12134 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27544&action=edit Bug 12134 - Members are restricted even if the debarment is ended Test Plan: 1) Modify borrowers.debarred for a borrower and set the date in the past 2) Try to check out an item to that patron 3) Note you cannot 4) Apply this patch 5) Repeat step 2 6) Note you can now check out items the patron -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12134 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27544|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 27546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27546&action=edit Bug 12134 - Members are restricted even if the debarment is ended Test Plan: 1) Modify borrowers.debarred for a borrower and set the date in the past 2) Try to check out an item to that patron 3) Note you cannot 4) Apply this patch 5) Repeat step 2 6) Note you can now check out items the patron Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12134 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Good candidate for 3.14.6! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12134 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27546|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 27581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27581&action=edit [PASSED QA] Bug 12134 - Members are restricted even if the debarment is ended Test Plan: 1) Modify borrowers.debarred for a borrower and set the date in the past 2) Try to check out an item to that patron 3) Note you cannot 4) Apply this patch 5) Repeat step 2 6) Note you can now check out items the patron Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12134 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27547|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 27582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27582&action=edit [PASSED QA] Bug 12134: Add unit tests to reflect the change in IsDebarred Before Kyle's patch, the test failed. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12134 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 27607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27607&action=edit Bug 12134: (follow-up) Add unit tests to reflect the change in IsDebarred Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12134 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master, along with a follow-up that repairs one of the new tests. Thanks, Jonathan and Kyle! I think serious thought should be given to removing borrowers.debarred, by the way, in favor of consulting borrower_debarments directly. borrowers.debarred was retained as a performance measure, but I'd like to see proof that querying borrower_debarments is too slow to be worth the risk of bugs like this one. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12134 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12292 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12134 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13107 -- You are receiving this mail because: You are watching all bug changes.