[Bug 33945] New: Add ability to delay the loading of the current checkouts table on the checkouts page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 Bug ID: 33945 Summary: Add ability to delay the loading of the current checkouts table on the checkouts page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If a librarian has opted to load the checkouts table automatically on the checkouts page, it will trigger a call to svc/checkouts. If a librarian is checkout out 10 items to a patron, that means svc/checkouts is called uselessly 9 times, with only the 10th time being used to display the checkouts table. It would be useful to add a delay such that the table only load if the page has been display for a given number of seconds. That way the continuous scanning does not trigger useless svc/checkouts calls, but the librarian also does not need to click the load checkouts button manually. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 152130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152130&action=edit Bug 33945: Add ability to delay the loading of the current checkouts table on the checkouts page If a librarian has opted to load the checkouts table automatically on the checkouts page, it will trigger a call to svc/checkouts. If a librarian is checkout out 10 items to a patron, that means svc/checkouts is called uselessly 9 times, with only the 10th time being used to display the checkouts table. It would be useful to add a delay such that the table only load if the page has been display for a given number of seconds. That way the continuous scanning does not trigger useless svc/checkouts calls, but the librarian also does not need to click the load checkouts button manually. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Verify "Always show checkouts immediately" retains its' original behavior of loading the checkouts table immediately 4) Set LoadIssuesTableDelay to a non-zero integer 5) Verify the automatic table loading is delayed by that number of seconds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152130|0 |1 is obsolete| | --- Comment #2 from Sam Lau <samalau@gmail.com> --- Created attachment 152134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152134&action=edit Bug 33945: Add ability to delay the loading of the current checkouts table on the checkouts page If a librarian has opted to load the checkouts table automatically on the checkouts page, it will trigger a call to svc/checkouts. If a librarian is checkout out 10 items to a patron, that means svc/checkouts is called uselessly 9 times, with only the 10th time being used to display the checkouts table. It would be useful to add a delay such that the table only load if the page has been display for a given number of seconds. That way the continuous scanning does not trigger useless svc/checkouts calls, but the librarian also does not need to click the load checkouts button manually. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Verify "Always show checkouts immediately" retains its' original behavior of loading the checkouts table immediately 4) Set LoadIssuesTableDelay to a non-zero integer 5) Verify the automatic table loading is delayed by that number of seconds Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I understand that this is to fix a serious problem, but the solution doesn't feel quite right. I am not going to block this, but it feels like there should be a better solution. Could we differentiate between loading the whole table and adding an additional line to it somehow? So the call would not be as extensive? Or maybe load the full checkouts list immediately but have an (optional) update button that will load the rest of the table after checkouts? Brain storming, will still continue QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> ---
Could we differentiate between loading the whole table and adding an additional line to it somehow? So the call would not be as extensive?
Or maybe load the full checkouts list immediately but have an (optional) update button that will load the rest of the table after checkouts?
Brain storming, will still continue QA.
Unfortunately, those solutions cannot work with circulation.pl as it currently is. That page reloads for each checkout, so we cannot have an kind of persistence. The best solution is in line with your thoughts. We need circulation.pl to use API calls to check out items and build the table from those API call responses. This is big work and something I fully intend to make happen, but in the mean time this is our best solution. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) LoadIssuesTableDelay should be LoadCheckoutsTableDelay All descriptions etc. use checkouts, it was only missed in the pref name itself. 2) It's a little irritating that the table disappears during the delay and only reappears after the delay. Maybe we could do better with some spinning thing and keeping the table visible until reloaded? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx for the reply Kyle, can you have a look at my 2 testing comments? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152134|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 152170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152170&action=edit Bug 33945: Add ability to delay the loading of the current checkouts table on the checkouts page If a librarian has opted to load the checkouts table automatically on the checkouts page, it will trigger a call to svc/checkouts. If a librarian is checkout out 10 items to a patron, that means svc/checkouts is called uselessly 9 times, with only the 10th time being used to display the checkouts table. It would be useful to add a delay such that the table only load if the page has been display for a given number of seconds. That way the continuous scanning does not trigger useless svc/checkouts calls, but the librarian also does not need to click the load checkouts button manually. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Verify "Always show checkouts immediately" retains its' original behavior of loading the checkouts table immediately 4) Set LoadCheckoutsTableDelay to a non-zero integer 5) Verify the automatic table loading is delayed by that number of seconds Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 152171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152171&action=edit Bug 33945: (QA follow-up) Add delay spinner and message -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #5)
1) LoadIssuesTableDelay should be LoadCheckoutsTableDelay All descriptions etc. use checkouts, it was only missed in the pref name itself.
Fixed! Changed in the original patch.
2) It's a little irritating that the table disappears during the delay and only reappears after the delay. Maybe we could do better with some spinning thing and keeping the table visible until reloaded?
Added as a followup patch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152170|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 152173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152173&action=edit Bug 33945: Add ability to delay the loading of the current checkouts table on the checkouts page If a librarian has opted to load the checkouts table automatically on the checkouts page, it will trigger a call to svc/checkouts. If a librarian is checkout out 10 items to a patron, that means svc/checkouts is called uselessly 9 times, with only the 10th time being used to display the checkouts table. It would be useful to add a delay such that the table only load if the page has been display for a given number of seconds. That way the continuous scanning does not trigger useless svc/checkouts calls, but the librarian also does not need to click the load checkouts button manually. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Verify "Always show checkouts immediately" retains its' original behavior of loading the checkouts table immediately 4) Set LoadCheckoutsTableDelay to a non-zero integer 5) Verify the automatic table loading is delayed by that number of seconds Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152171|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 152174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152174&action=edit Bug 33945: (QA follow-up) Add delay spinner and message Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 152180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152180&action=edit Bug 33945: (follow-up) Avoid breaking checkouts table when pref is empty When the pref is empty, the checkouts table would break. This avoids it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 152181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152181&action=edit Bug 33945: (QA follow-up) Don't show delay message on patron details page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152173|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 152184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152184&action=edit Bug 33945: Add ability to delay the loading of the current checkouts table on the checkouts page If a librarian has opted to load the checkouts table automatically on the checkouts page, it will trigger a call to svc/checkouts. If a librarian is checkout out 10 items to a patron, that means svc/checkouts is called uselessly 9 times, with only the 10th time being used to display the checkouts table. It would be useful to add a delay such that the table only load if the page has been display for a given number of seconds. That way the continuous scanning does not trigger useless svc/checkouts calls, but the librarian also does not need to click the load checkouts button manually. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Verify "Always show checkouts immediately" retains its' original behavior of loading the checkouts table immediately 4) Set LoadCheckoutsTableDelay to a non-zero integer 5) Verify the automatic table loading is delayed by that number of seconds Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152174|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 152185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152185&action=edit Bug 33945: (QA follow-up) Add delay spinner and message Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152180|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 152186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152186&action=edit Bug 33945: (follow-up) Avoid breaking checkouts table when pref is empty When the pref is empty, the checkouts table would break. This avoids it. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152181|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 152187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152187&action=edit Bug 33945: (QA follow-up) Don't show delay message on patron details page Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to master |Needs documenting --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Opting not to backport this enhancement to 23.05.x series (although I do love it, it certainly falls into the enhancement category) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33528 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33528 [Bug 33528] Use template wrapper for tabs: Patron details and circulation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35506 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 [Bug 35506] selenium/regressions.t is failing randomly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|35506 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 [Bug 35506] selenium/regressions.t is failing randomly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/852 Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | --- Comment #20 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I added the new syspref in the manual to the best of my comprehension of it. It's a bit technical for me. Feel free to let me know if it's totally wrong! Here is what I wrote, in case the gitlab merge request is not easy to understand. - This system preference is used to delay the loading of the checkouts table in a patron's account to prevent too many service queries when checking out a number of items in a row. - Enter a positive integer, such as 5, to delay the loading of the table and prevent it from reloading after each check out. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33945 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36540 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36540 [Bug 36540] Consider modernising the checkout page to be an Vue page -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org