[Bug 19532] New: Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Bug ID: 19532 Summary: Recalls for Koha Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P3 Component: Staff Client Assignee: aleisha@catalyst.net.nz Reporter: liz@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, liz@catalyst.net.nz Deadline: 2017-12-01 Preface: I know this will be quite an interesting feature for lots of people. Catalyst is doing a working proof of concept for this feature. The requirements we have given to Aleisha are firm, and we will not be scope creeping them. Additional features are welcome once this initial development is either accepted or supplanted by something else. That said, we welcome comment and suggestions on the patches we will attach here, and view this as a starting point instead of a complete solution. Expected scope of the feature to include: - Ability for borrowers to place a recall on a book from the OPAC results and detail, if it is checked out (question, do we offer to issue a recall if only one copy of say 3 is checked out?) - Ability for borrowers to see their requested recalls, and the when the book is expected to be returned back - An interface similar to holds for recalls, that alerts librarians that a book needs to go on the recall shelf (Recall for User, confirm or cancel) - An interface similar to holds waiting to show recalls that are currently on the shelf, and recalls that are requested but overdue, and ones that have expired and need to be reshelved. - A view in the intranet user interface for librarians to see a borrower's recalls (similar to holds) - Notices for borrower who has the recalled book on issue, to notify that the book's due date has changed and for the recaller, to let them know when the recalled item is ready for pick up. - Something in the circ rules that defines whether an item type/borrower category is allowed to place recalls on an item. - Sysprefs for "days from now that item is now due" and "how long do I let this recall languish on the recall shelf before reshelving" Current implementation notes: * DB: recalls table • DB: old_recalls table • notices: to user who has an item checked out that a recall request has been placed on, saying request has been made and due date has been updated (may use or build upon existing code from 17509) • notices: to user who made the recall request when it has been checked in, saying the item is awaiting pickup and must be picked up within X days (may use or build upon existing code from 17509) • OPAC: in checked out tab on user summary page, show your item has a recall placed on it, highlighting the new due date • OPAC: recall button under availability on record detail page and results page • OPAC: recalls tab on user summary page Per item type/borrower category combination: • circ rules: recall due date interval - what is the new due date of the item being recalled? How many days from the date of recall do we set the new due date? • circ rules: recall overdue fine - Do we have a special fine on an item that was recalled but not returned on time? (this may be a phase two feature) • circ rules: recall shelf time (how long can it be awaiting pickup before it needs to be reshelved) • circ rules OR syspref: do recalls automatically expire? (this may be a phase two feature) • circ reports: overdue recalls • circ reports: recalls awaiting pickup / recalls waiting over X days • circ reports: recalls queue • intranet: recalls tab on member detail page, showing recalls that the borrower has requested. • intranet: highlight on checkout and detail page items with a recall due date. • intranet: alert when checking in an item with a recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 68569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68569&action=edit Bug 19532: Database updates Adding the recalls table and the old_recalls table. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 68570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68570&action=edit Bug 19532: Notices for recalls The notices: -RETURN_RECALLED_ITEM -PICKUP_RECALLED_ITEM have been created and added to sample_notices.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68570|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 68571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68571&action=edit Bug 19532: Notices for recalls The notices: -RETURN_RECALLED_ITEM -PICKUP_RECALLED_ITEM have been created and added to sample_notices.sql Changed tools/letter.pl to use recalls table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #4 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 68572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68572&action=edit Bug 19532: Module files for Recall and OldRecall Koha/Recall.pm Koha/Recalls.pm Koha/Old/Recall.pm Koha/Old/Recalls.pm and the schema files for Recall and OldRecall. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Liz Rea from comment #0)
Current implementation notes:
* DB: recalls table • DB: old_recalls table
Regarding the number of critical issues we had the last few months, I do not think it is a good idea to reuse this pattern. We should not move data from one table to another but add a deleted/old flag instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 68642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68642&action=edit Bug 19532: Some DB fixes Removing the old_recalls table, as suggested in Comment 5 Renaming 'found' column to 'status' Adding 'old' column -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68642|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 68643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68643&action=edit Bug 19532: Some DB fixes Removing the old_recalls table, as suggested in Comment 5 Renaming 'found' column to 'status' Adding 'old' column -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68642|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68643|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68642|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68643|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68643|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 68644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68644&action=edit Bug 19532: Some DB fixes Removing the old_recalls table, as suggested in Comment 5 Renaming 'found' column to 'status' Adding 'old' column -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #9 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 68645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68645&action=edit Bug 19532: Some module fixes Removing files related to OldRecall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 68653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68653&action=edit Bug 19532: Circulation rules Adding 3 new rules and columns to issuingrules - recall_due_date_interval - recall_overdue_fine - recall_shelf_time -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #11 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69100&action=edit Bug 19532: Recall an item in OPAC This patch: - adds the 'Recall' button to the item on it's detail page - adds ability to place a recall - the recall is stored in the recalls table - the due date for the checkout is updated to whatever has been set in the issuing rule under recall_due_date_interval - error messages for if the user isn't logged in, the user tries to place a recall on an item they have already recalled, or if storing the recall in the db fails for any reason -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #12 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69102&action=edit Bug 19532: Cancel recall and see recalls in OPAC This patch adds ability for user to cancel a recall They can also see their recalls in the user summary -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #13 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69147&action=edit Bug 19532: Show recalls on intranet side This patch - adds Recall tab to the Check out section of member account, and to the Details section of member account - Functionality to cancel recalls on staff side - Fixing cancel on OPAC side (before I was deleting the whole recall instead of cancelling) - Fixing validation when checking whether a recall can be placed on an item that has been recalled by this borrower before. If the old recall is expired or cancelled then they can make a recall again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #14 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69148&action=edit Bug 19532: Fixing broken OPAC recalls table Forgot to add <tr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #15 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69149&action=edit Bug 19532: recalls history this patch - adds recalls history (similar to holds history) to OPAC and intranet - edits the tables in opac-user.pl (OPAC), moremember.pl and circulation.pl (staff) so that it only shows active recalls (recalls that have been requested or are waiting) - some extra datatables fixes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #16 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69170&action=edit Bug 19532: Recalls queue This patch adds a recalls queue page to the circulation reports You can see all recalls made in the system, who requested them, their status and other relevant info. you can cancel individual or multiple recalls. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #17 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69172&action=edit Bug 19532: Overdue recalls report -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #18 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69221&action=edit Bug 19532: Recalls awaiting pickup report this patch adds reports for all recalls awaiting pickup, and recalls that have been waiting more than X days. a syspref, RecallsMaxPickUpDelay, is added to give a general max shelf time for recalls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #19 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69222&action=edit Bug 19532: Only recall items checked out by other users ... shouldn't be able to recall items that are currently checked out by yourself. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #20 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69223&action=edit Bug 19532: UseRecalls syspref This patch adds a syspref to control the usability of the recalls feature Test the following: Staff side /includes/circ-menu.inc /includes/circ-nav.inc /includes/members-menu.inc /admin/preferences/circulation.pref /circ/circulation-home.tt /circ/circulation.tt /circ/recalls_overdue.tt /circ/recalls_queue.tt /circ/recalls_waiting.tt /members/moremember.tt /members/recallshistory.tt OPAC /includes/usermenu.inc /opac-recall.tt /opac-recalls.tt /opac-user.tt /members/recallshistory.pl /opac/opac-detail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #21 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69322&action=edit Bug 19532: Recall pop up when checking in an item When checking in an item on the staff side, the staff member will see a pop up if there is a recall attached to that item. From here, they can confirm the recall, setting the status to 'Waiting' and updating the waitingdate. The item will still be checked in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #22 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69353&action=edit Bug 19532: Send notice to user to return a recalled item When the recall is placed in the OPAC, a RETURN_RECALLED_ITEM notice is sent to the user who has the item checked out, with the updated due date. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #23 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69354&action=edit Bug 19532: Send notice to user to pickup recalled returned item Send a PICKUP_RECALLED_ITEM notice to the user who requested a recall when the item is checked in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #24 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69405&action=edit Bug 19532: Flagging recall as 'old' when expired or cancelled Set 'old' flag to 1 if cancelling or expiring a recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #25 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69409&action=edit Bug 19532: Cronjob to check for overdue recalls This patch adds a check to the overdue_notices cronjob, so if any of the overdue issues are also recalls, the status will be set to O (overdue) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #26 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69410&action=edit Bug 19532: Tests for Koha/Recalls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #27 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69411&action=edit Bug 19532: Nice message if no recalls for opac recalls history -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #28 from Aleisha Amohia <aleisha@catalyst.net.nz> --- I believe that this feature is now ready to test. I'll be away for the next couple of weeks, but feel free to test and leave any feedback/comments/questions/ideas that I can come back to when I return. Note: when testing, it will be very helpful to keep the OPAC and the Staff Client open in 2 separate tabs or browsers. you will also need 2 borrowers, where at least one has superlibrarian privileges. TEST PLAN: 1. Enable the UseRecalls syspref 2. Go to Circulation and Fines Rules. Put some numbers in the recalls fields (recall due date interval, recall overdue fine amount, recall pickup period) 3. Put a number in the RecallsMaxPickUpDelay syspref. This will be the default number of days used if the recall pickup period isn't set in Step 2 4. Check out an item to a patron 5. Go to that item's detail page in the OPAC. Notice the holdings table says 'Checked out' 6. Log in to the OPAC with another patron and go back to that detail page. The holdings table should now have a Recall link next to the 'Checked out' text 7. Click the Recall button and confirm the Recall 8. Go to the user's opac summary and confirm there is now a Recalls tab, with the correct number of recalls (should be 1). 9. Test cancelling the recall by clicking Cancel. Confirm the recall has been cancelled. Repeat steps 6 and 7. 10. In the left navigation, there will also be a 'recalls history' tab. Click it. There should be a log, similar to reading history, with the cancelled recall and the new recall in it. Confirm all information is correct 11. Again, test cancelling the recall. Repeat steps 6 and 7. 12. In the staff interface, go to the logged in user's checkouts. Confirm you can see a new Recalls tab, with the active (not cancelled) recall in the table. Should be the same for the details tab also. 13. Test cancelling works for both of these again, and making new recalls again. 14. Check in the recalled item. You should see a pop up, asking to confirm the recall as waiting. Click confirm. 15. Go to the Circulation main page. You should see 3 new reports: recalls queue, overdue recalls and recalls awaiting pickup 16. Go to the recalls queue, confirm you can see an entire history of recalls at your library. Confirm cancel works when selecting checkboxes and clicking the multiple button. If you do this, you'll need to place the recall again and check the item in again 17. Go to recalls awaiting pickup. You should see the recall under the recalls waiting tab 18. in Mysql, set the waitingdate for your recall to be more than 'recall pickup period' days before today's date 19. Refresh the recalls awaiting pickup page. You should see the recall under the recalls waiting tab, and the recalls waiting more than X days tab. 20. expire the recall. confirm this is expired by checking the recalls queue 21. place another recall, but do not check it in 22. in mysql, set the date_due of the checkout (issues table) to be at least 'recall due date interval' number of days before today's date 23. run the overdue_notices.pl cronjob 24. go to the overdue recalls circ report and confirm your recall shows there 25. try cancelling the recall here also 26. in mysql, check the message_queue and confirm there have been the appropriate number of RETURN_RECALLED_ITEM and PICKUP_RECALLED_ITEM notices sent with the correct to and from addresses and other content 27. test t/db_dependent/Koha/Recalls.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Petter Goksøyr Åsen <boutrosboutrosboutros@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |boutrosboutrosboutros@gmail | |.com --- Comment #29 from Petter Goksøyr Åsen <boutrosboutrosboutros@gmail.com> --- Quick comment: Given the troubles we have with duplicate primary keys in old/deleted tables, would't it be better to drop the old_recalls table, and keep it in one table, with a flag denoting if the recall is deleted or not? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Petter Goksøyr Åsen from comment #29)
Quick comment: Given the troubles we have with duplicate primary keys in old/deleted tables, would't it be better to drop the old_recalls table, and keep it in one table, with a flag denoting if the recall is deleted or not?
Yes, see comment 5 as well. Aleisha, did you consider this alternative? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #31 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to Jonathan Druart from comment #30)
(In reply to Petter Goksøyr Åsen from comment #29)
Quick comment: Given the troubles we have with duplicate primary keys in old/deleted tables, would't it be better to drop the old_recalls table, and keep it in one table, with a flag denoting if the recall is deleted or not?
Yes, see comment 5 as well. Aleisha, did you consider this alternative?
We did, but the reason old_issues exists, is because keeping it one massive table becomes really slow quite fast. With recalls this probably will take longer to be a problem, but having circulation stuff slowed down (specifically returns) by having millions of rows to check through was the reason the issues table was split in the first place. I don't believe one table that grows forever for circulation is a viable fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #32 from Petter Goksøyr Åsen <boutrosboutrosboutros@gmail.com> --- Fair enough, but optimizing by allowing for potential data corruption seems the wrong way to optimize to me :) Isn't data integrity is more important? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #33 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to Petter Goksøyr Åsen from comment #32)
Fair enough, but optimizing by allowing for potential data corruption seems the wrong way to optimize to me :)
Isn't data integrity is more important?
It was fine for 15 years, until mysql changed things. And after that we didn't have any data loss until we rushed a fix. A combined table is not a valid fix, you can have all the data integrity you want if the system is too slow to use. We should come up with an actual solution. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #34 from Petter Goksøyr Åsen <boutrosboutrosboutros@gmail.com> --- Yeah, this probably needs a broader discussion, best handeled elsewhere. I'll leave it for now and let this bug be about recalls :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #35 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Comment on attachment 68572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68572 Bug 19532: Module files for Recall and OldRecall
Koha/Recall.pm Koha/Recalls.pm Koha/Old/Recall.pm Koha/Old/Recalls.pm and the schema files for Recall and OldRecall.
I agree we should avoid old_*, probably index definitions are relevant for performance (speed, because they will eat more hard disk space of course).
+=head2 Class Methods
This are usually labeled 'Internal methods', to distinguish them from public 'Class methods'. Fix the case.
+=head3 type + +=cut + +sub type { + return 'OldRecall'; +}
This should be called '_type'. Look at Koha/Object.pm:260, a sample place it is used. If it is not well documented, please file a bug for it!
+=head2 found + + data_type: 'varchar' + is_nullable: 1 + size: 1
Please use tinyint(1) for booleans. While it is not a real type (it is an integer with a mask), it clearly denotes its use. If you plan to expose this through the api, having it be VARCHAR will make our stack consider it a string. If you set it a numeric type, then we can add: __PACKAGE_->add_columns({ '+found' => { is_boolean => 1 } }); to the schema file, and thus it is considered a Boolean when rendering on the API. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #36 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Comment on attachment 69102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69102 Bug 19532: Cancel recall and see recalls in OPAC
+=head3 branch + +Returns the related Koha::Library object for this Hold + +=cut + +sub branch { + my ($self) = @_; + + $self->{_branch} ||= Koha::Libraries->find( $self->branchcode() ); + + return $self->{_branch}; +}
Please call this method 'library' instead, and 'patron' instead of 'borrower' on the followup. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #37 from Liz Rea <liz@catalyst.net.nz> --- These are functionality notes for Aleisha OPAC client view: We probably want to show the borrower when the book is now expected to be returned by on /cgi-bin/koha/opac-recalls.pl Staff views: - syspref needs to be defaulted to off please :) /cgi-bin/koha/circ/recalls_queue.pl - probably want to see the new due date here as well /cgi-bin/koha/catalogue/detail.pl?biblionumber=16 - do we want to see what the old due date was here? (to think about, not required) - Probably want to show somewhere in the item table that there is a recall, and for whom (kinda like we do with holds) - do we want a tab on the detail page that shows all of the recalls for this biblio, and who they are for? General questions: - If we add an item with the same item type to a biblio that has a recall, should checking in this newly available item trigger the recall to be filled? I'm out of time for this run at it, but honestly what a great first whack at it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #38 from Owen Leonard <oleonard@myacpl.org> --- I can't get this to apply! Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 19532: Database updates Applying: Bug 19532: Notices for recalls Applying: Bug 19532: Module files for Recall and OldRecall Applying: Bug 19532: Some DB fixes Applying: Bug 19532: Some module fixes Applying: Bug 19532: Circulation rules fatal: sha1 information is lacking or useless (Koha/Schema/Result/Issuingrule.pm). Repository lacks necessary blobs to fall back on 3-way merge. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #39 from Liz Rea <liz@catalyst.net.nz> --- Hi Owen, This patch: Bug 19532: Circulation rules (8.52 KB, patch) Is out of band and doesn't work properly. We did some heroics at Catalyst because we needed to do some testing on this bug, but that patch will need to be fixed by Aleisha. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #40 from Liz Rea <liz@catalyst.net.nz> --- (Basically, if you skip that one, the rest will apply. Then you just have to sort out what the bad patch was trying to do, and add that back in.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #41 from Kyle M Hall <kyle@bywatersolutions.com> ---
We did, but the reason old_issues exists, is because keeping it one massive table becomes really slow quite fast.
I think maybe we need to check our assumptions. We may have be running on best practices that are out of date. I think that happens to us all from time to time. MySQL is capable of dealing with tens or even hundreds of millions of rows very speedily, as long as the correct indexes are in place. For example, I picked out a database to test with from a Koha consortium. They have 1,456,666 old_issues rows, and 50122 issues rows. Searching on a column with no index ( such as issuedate ) returned a single record from almost 1.5 million records in 1.04 seconds. Not terrible, but definitely not great. However, searching for the same row using an indexed column took less time than mysql could measure! It reported back taking 0.00 seconds ; ) I've done some digging and it appears that many people are using mysql for tables with tens to hundreds of millions of rows with no adverse effects. Perhaps that was an issue during the early years of Koha, when MySQL was much less mature, but I don't think it is anymore. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #42 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Kyle M Hall from comment #41)
We did, but the reason old_issues exists, is because keeping it one massive table becomes really slow quite fast.
I think maybe we need to check our assumptions. We may have be running on best practices that are out of date. I think that happens to us all from time to time.
MySQL is capable of dealing with tens or even hundreds of millions of rows very speedily, as long as the correct indexes are in place.
For example, I picked out a database to test with from a Koha consortium. They have 1,456,666 old_issues rows, and 50122 issues rows.
Searching on a column with no index ( such as issuedate ) returned a single record from almost 1.5 million records in 1.04 seconds. Not terrible, but definitely not great. However, searching for the same row using an indexed column took less time than mysql could measure! It reported back taking 0.00 seconds ; )
I've done some digging and it appears that many people are using mysql for tables with tens to hundreds of millions of rows with no adverse effects.
Perhaps that was an issue during the early years of Koha, when MySQL was much less mature, but I don't think it is anymore.
I think this was introduced at some point to ease the use of TRUNCATE as opposed to DELETE when wiping old data. There are other ways to deal with fragmentation already (OPTIMIZE?), so I'd suggest the tables are joined and a proper use of tinyint for the flags. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #43 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Hi all, sorry for the delay in getting back to you, I've been away. I removed the old_recalls table and added an 'old' flag to the recalls table in the 'Some DB fixes' patch. I'll now get on to fixing all of the other comments. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #44 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69841&action=edit Bug 19532: Fixing merge conflicts etc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69411|0 |1 is obsolete| | --- Comment #45 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69872&action=edit Bug 19532: Nice message if no recalls for opac recalls history https://bugs.koha-community.org/show_bug.cgi?id=19523 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69841|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68653|0 |1 is obsolete| | --- Comment #46 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69873&action=edit Bug 19532: Circulation rules Adding 3 new rules and columns to issuingrules - recall_due_date_interval - recall_overdue_fine - recall_shelf_time -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69100|0 |1 is obsolete| | --- Comment #47 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69874&action=edit Bug 19532: Recall an item in OPAC This patch: - adds the 'Recall' button to the item on it's detail page - adds ability to place a recall - the recall is stored in the recalls table - the due date for the checkout is updated to whatever has been set in the issuing rule under recall_due_date_interval - error messages for if the user isn't logged in, the user tries to place a recall on an item they have already recalled, or if storing the recall in the db fails for any reason -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69102|0 |1 is obsolete| | --- Comment #48 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69875&action=edit Bug 19532: Cancel recall and see recalls in OPAC This patch adds ability for user to cancel a recall They can also see their recalls in the user summary -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69147|0 |1 is obsolete| | --- Comment #49 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69876&action=edit Bug 19532: Show recalls on intranet side This patch - adds Recall tab to the Check out section of member account, and to the Details section of member account - Functionality to cancel recalls on staff side - Fixing cancel on OPAC side (before I was deleting the whole recall instead of cancelling) - Fixing validation when checking whether a recall can be placed on an item that has been recalled by this borrower before. If the old recall is expired or cancelled then they can make a recall again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69148|0 |1 is obsolete| | --- Comment #50 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69877&action=edit Bug 19532: Fixing broken OPAC recalls table Forgot to add <tr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69149|0 |1 is obsolete| | --- Comment #51 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69878&action=edit Bug 19532: recalls history this patch - adds recalls history (similar to holds history) to OPAC and intranet - edits the tables in opac-user.pl (OPAC), moremember.pl and circulation.pl (staff) so that it only shows active recalls (recalls that have been requested or are waiting) - some extra datatables fixes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69170|0 |1 is obsolete| | --- Comment #52 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69879&action=edit Bug 19532: Recalls queue This patch adds a recalls queue page to the circulation reports You can see all recalls made in the system, who requested them, their status and other relevant info. you can cancel individual or multiple recalls. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69172|0 |1 is obsolete| | --- Comment #53 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69880&action=edit Bug 19532: Overdue recalls report -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69221|0 |1 is obsolete| | --- Comment #54 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69881&action=edit Bug 19532: Recalls awaiting pickup report this patch adds reports for all recalls awaiting pickup, and recalls that have been waiting more than X days. a syspref, RecallsMaxPickUpDelay, is added to give a general max shelf time for recalls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69222|0 |1 is obsolete| | --- Comment #55 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69882&action=edit Bug 19532: Only recall items checked out by other users ... shouldn't be able to recall items that are currently checked out by yourself. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69223|0 |1 is obsolete| | --- Comment #56 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69883&action=edit Bug 19532: UseRecalls syspref This patch adds a syspref to control the usability of the recalls feature Test the following: Staff side /includes/circ-menu.inc /includes/circ-nav.inc /includes/members-menu.inc /admin/preferences/circulation.pref /circ/circulation-home.tt /circ/circulation.tt /circ/recalls_overdue.tt /circ/recalls_queue.tt /circ/recalls_waiting.tt /members/moremember.tt /members/recallshistory.tt OPAC /includes/usermenu.inc /opac-recall.tt /opac-recalls.tt /opac-user.tt /members/recallshistory.pl /opac/opac-detail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69322|0 |1 is obsolete| | --- Comment #57 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69884&action=edit Bug 19532: Recall pop up when checking in an item When checking in an item on the staff side, the staff member will see a pop up if there is a recall attached to that item. From here, they can confirm the recall, setting the status to 'Waiting' and updating the waitingdate. The item will still be checked in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69353|0 |1 is obsolete| | --- Comment #58 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69885&action=edit Bug 19532: Send notice to user to return a recalled item When the recall is placed in the OPAC, a RETURN_RECALLED_ITEM notice is sent to the user who has the item checked out, with the updated due date. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69354|0 |1 is obsolete| | --- Comment #59 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69886&action=edit Bug 19532: Send notice to user to pickup recalled returned item Send a PICKUP_RECALLED_ITEM notice to the user who requested a recall when the item is checked in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69405|0 |1 is obsolete| | --- Comment #60 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69887&action=edit Bug 19532: Flagging recall as 'old' when expired or cancelled Set 'old' flag to 1 if cancelling or expiring a recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69409|0 |1 is obsolete| | --- Comment #61 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69888&action=edit Bug 19532: Cronjob to check for overdue recalls This patch adds a check to the overdue_notices cronjob, so if any of the overdue issues are also recalls, the status will be set to O (overdue) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69410|0 |1 is obsolete| | --- Comment #62 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69889&action=edit Bug 19532: Tests for Koha/Recalls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69872|0 |1 is obsolete| | --- Comment #63 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69890&action=edit Bug 19532: Nice message if no recalls for opac recalls history https://bugs.koha-community.org/show_bug.cgi?id=19523 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #64 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Sorry for the gazillions of emails! This should now apply cleanly on master. I should've added in the original test plan to update the database and the schema after applying patches, so make sure you do that first! Here's the test plan again. TEST PLAN: 0. Update database and schema 1. Enable the UseRecalls syspref 2. Go to Circulation and Fines Rules. Put some numbers in the recalls fields (recall due date interval, recall overdue fine amount, recall pickup period) 3. Put a number in the RecallsMaxPickUpDelay syspref. This will be the default number of days used if the recall pickup period isn't set in Step 2 4. Check out an item to a patron 5. Go to that item's detail page in the OPAC. Notice the holdings table says 'Checked out' 6. Log in to the OPAC with another patron and go back to that detail page. The holdings table should now have a Recall link next to the 'Checked out' text 7. Click the Recall button and confirm the Recall 8. Go to the user's opac summary and confirm there is now a Recalls tab, with the correct number of recalls (should be 1). 9. Test cancelling the recall by clicking Cancel. Confirm the recall has been cancelled. Repeat steps 6 and 7. 10. In the left navigation, there will also be a 'recalls history' tab. Click it. There should be a log, similar to reading history, with the cancelled recall and the new recall in it. Confirm all information is correct 11. Again, test cancelling the recall. Repeat steps 6 and 7. 12. In the staff interface, go to the logged in user's checkouts. Confirm you can see a new Recalls tab, with the active (not cancelled) recall in the table. Should be the same for the details tab also. 13. Test cancelling works for both of these again, and making new recalls again. 14. Check in the recalled item. You should see a pop up, asking to confirm the recall as waiting. Click confirm. 15. Go to the Circulation main page. You should see 3 new reports: recalls queue, overdue recalls and recalls awaiting pickup 16. Go to the recalls queue, confirm you can see an entire history of recalls at your library. Confirm cancel works when selecting checkboxes and clicking the multiple button. If you do this, you'll need to place the recall again and check the item in again 17. Go to recalls awaiting pickup. You should see the recall under the recalls waiting tab 18. in Mysql, set the waitingdate for your recall to be more than 'recall pickup period' days before today's date 19. Refresh the recalls awaiting pickup page. You should see the recall under the recalls waiting tab, and the recalls waiting more than X days tab. 20. expire the recall. confirm this is expired by checking the recalls queue 21. place another recall, but do not check it in 22. in mysql, set the date_due of the checkout (issues table) to be at least 'recall due date interval' number of days before today's date 23. run the overdue_notices.pl cronjob 24. go to the overdue recalls circ report and confirm your recall shows there 25. try cancelling the recall here also 26. in mysql, check the message_queue and confirm there have been the appropriate number of RETURN_RECALLED_ITEM and PICKUP_RECALLED_ITEM notices sent with the correct to and from addresses and other content 27. test t/db_dependent/Koha/Recalls.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #65 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 69986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69986&action=edit Bug 19532: POD fix, renaming methods Tomas's comments: - renaming 'Class methods' to 'internal methods' - renaming 'borrower' and 'branch' methods to 'patron' and 'library' other comments are out of date with current patches and do not need to be actioned when testing, confirm all data still shows as expected and nothing is broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #66 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 70093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70093&action=edit Bug 19532: Extra fixes This patch addresses some of Liz's comments in Comment 37 - shows new due date on opac-recall.pl when the recall is requested - shows new due date on opac-recalls.pl recalls history - shows new due date on circ/recalls_queue.pl - syspref is default off - recalls tab on catalogue/detail.pl - show that there is a recall on an item on catalogue/detail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #67 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Liz Rea from comment #37)
These are functionality notes for Aleisha
OPAC client view:
We probably want to show the borrower when the book is now expected to be returned by on /cgi-bin/koha/opac-recalls.pl
done
Staff views:
- syspref needs to be defaulted to off please :)
done
/cgi-bin/koha/circ/recalls_queue.pl - probably want to see the new due date here as well
done
/cgi-bin/koha/catalogue/detail.pl?biblionumber=16 - do we want to see what the old due date was here? (to think about, not required)
i think having the old and the new due date might cause some confusion
- Probably want to show somewhere in the item table that there is a recall, and for whom (kinda like we do with holds)
done
- do we want a tab on the detail page that shows all of the recalls for this biblio, and who they are for?
done
General questions:
- If we add an item with the same item type to a biblio that has a recall, should checking in this newly available item trigger the recall to be filled?
i'm not too sure about this. recalls are item-level not record-level so i haven't quite thought about how other available items could fill the recall. perhaps a future cronjob? maybe after this base feature gets through?
I'm out of time for this run at it, but honestly what a great first whack at it.
i've now implemented all of the discussed comments etc and i believe this is ready to test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #68 from Nick Clemens <nick@bywatersolutions.com> --- Hi Aleisha, Overall things work well and are pretty intuitive. Can you squash some of the patches to ease readability? (e.e. the removed old_recalls stuff) Couple errors: The db uppdate tries to insert after 'notes' in issuing rules, but this doesn't exist When placing recall I always get a warning: <p><strong>Warning</strong>: Your library does not allow recalls for x item types.</p> Cancelling recall from 'Recall history tab' doesn't work If patron has no recalls there is 'Patron has no current recalls' message at bottom of tabs on checkout and details tabs for patron When confirming a recall if the item is from another branch I get a transfer generated as well as confirming hold for recall On recalls awaiting pickup: need to update recall.borrower to recall.patron - causing internal server error When placing a recall - if I hit 'back' after confirming and confirm again I get a second recall on the same item Recalls queue should have waiting date information Recalls queue should have a way to hide cancelled, I would expect closed recalls to be hidden by default Could overdue recalls be a tab/filter on the recalls queue? When viewing a patrons account in the staff side we should see that a checkout has an active recall Checking out the recall doesn't seem to close the recall Question - should canceling a recall extend the due date? or notify patron somehow? is calendar used to calculate new due date for recall? I think it should be I think circ rules should include 'number of open recalls' to (optionally) limit how many a patron can have Is it valid for two patrons to recall the second item? I would think the second one not be a hold? -Nick -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68571|0 |1 is obsolete| | --- Comment #69 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 71409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71409&action=edit Bug 19532: Notices for recalls The notices: -RETURN_RECALLED_ITEM -PICKUP_RECALLED_ITEM have been created and added to sample_notices.sql Changed tools/letter.pl to use recalls table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #70 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Aleihsa, please keep in mind that the notices need to be added to all the translated installers as well. It's ok to add them in English, but they should be there to ease translation and don't have different behaviour. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69876|0 |1 is obsolete| | --- Comment #71 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 71574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71574&action=edit Bug 19532: Show recalls on intranet side This patch - adds Recall tab to the Check out section of member account, and to the Details section of member account - Functionality to cancel recalls on staff side - Fixing cancel on OPAC side (before I was deleting the whole recall instead of cancelling) - Fixing validation when checking whether a recall can be placed on an item that has been recalled by this borrower before. If the old recall is expired or cancelled then they can make a recall again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69877|0 |1 is obsolete| | --- Comment #72 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 71575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71575&action=edit Bug 19532: Fixing broken OPAC recalls table Forgot to add <tr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69878|0 |1 is obsolete| | --- Comment #73 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 71576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71576&action=edit Bug 19532: recalls history this patch - adds recalls history (similar to holds history) to OPAC and intranet - edits the tables in opac-user.pl (OPAC), moremember.pl and circulation.pl (staff) so that it only shows active recalls (recalls that have been requested or are waiting) - some extra datatables fixes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69879|0 |1 is obsolete| | --- Comment #74 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 71577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71577&action=edit Bug 19532: Recalls queue This patch adds a recalls queue page to the circulation reports You can see all recalls made in the system, who requested them, their status and other relevant info. you can cancel individual or multiple recalls. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69880|0 |1 is obsolete| | --- Comment #75 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 71578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71578&action=edit Bug 19532: Overdue recalls report -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69881|0 |1 is obsolete| | --- Comment #76 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 71579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71579&action=edit Bug 19532: Recalls awaiting pickup report this patch adds reports for all recalls awaiting pickup, and recalls that have been waiting more than X days. a syspref, RecallsMaxPickUpDelay, is added to give a general max shelf time for recalls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69882|0 |1 is obsolete| | --- Comment #77 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 71580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71580&action=edit Bug 19532: Only recall items checked out by other users ... shouldn't be able to recall items that are currently checked out by yourself. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69883|0 |1 is obsolete| | --- Comment #78 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 71581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71581&action=edit Bug 19532: UseRecalls syspref This patch adds a syspref to control the usability of the recalls feature Test the following: Staff side /includes/circ-menu.inc /includes/circ-nav.inc /includes/members-menu.inc /admin/preferences/circulation.pref /circ/circulation-home.tt /circ/circulation.tt /circ/recalls_overdue.tt /circ/recalls_queue.tt /circ/recalls_waiting.tt /members/moremember.tt /members/recallshistory.tt OPAC /includes/usermenu.inc /opac-recall.tt /opac-recalls.tt /opac-user.tt /members/recallshistory.pl /opac/opac-detail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69884|0 |1 is obsolete| | --- Comment #79 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 71582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71582&action=edit Bug 19532: Recall pop up when checking in an item When checking in an item on the staff side, the staff member will see a pop up if there is a recall attached to that item. From here, they can confirm the recall, setting the status to 'Waiting' and updating the waitingdate. The item will still be checked in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69885|0 |1 is obsolete| | --- Comment #80 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 71583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71583&action=edit Bug 19532: Send notice to user to return a recalled item When the recall is placed in the OPAC, a RETURN_RECALLED_ITEM notice is sent to the user who has the item checked out, with the updated due date. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69886|0 |1 is obsolete| | --- Comment #81 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 71584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71584&action=edit Bug 19532: Send notice to user to pickup recalled returned item Send a PICKUP_RECALLED_ITEM notice to the user who requested a recall when the item is checked in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69887|0 |1 is obsolete| | --- Comment #82 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 71585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71585&action=edit Bug 19532: Flagging recall as 'old' when expired or cancelled Set 'old' flag to 1 if cancelling or expiring a recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69888|0 |1 is obsolete| | --- Comment #83 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 71586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71586&action=edit Bug 19532: Cronjob to check for overdue recalls This patch adds a check to the overdue_notices cronjob, so if any of the overdue issues are also recalls, the status will be set to O (overdue) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69889|0 |1 is obsolete| | --- Comment #84 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 71587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71587&action=edit Bug 19532: Tests for Koha/Recalls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69890|0 |1 is obsolete| | --- Comment #85 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 71588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71588&action=edit Bug 19532: Nice message if no recalls for opac recalls history https://bugs.koha-community.org/show_bug.cgi?id=19523 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69986|0 |1 is obsolete| | --- Comment #86 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 71589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71589&action=edit Bug 19532: POD fix, renaming methods Tomas's comments: - renaming 'Class methods' to 'internal methods' - renaming 'borrower' and 'branch' methods to 'patron' and 'library' other comments are out of date with current patches and do not need to be actioned when testing, confirm all data still shows as expected and nothing is broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70093|0 |1 is obsolete| | --- Comment #87 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 71590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71590&action=edit Bug 19532: Extra fixes This patch addresses some of Liz's comments in Comment 37 - shows new due date on opac-recall.pl when the recall is requested - shows new due date on opac-recalls.pl recalls history - shows new due date on circ/recalls_queue.pl - syspref is default off - recalls tab on catalogue/detail.pl - show that there is a recall on an item on catalogue/detail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71409|0 |1 is obsolete| | --- Comment #88 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 71591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71591&action=edit Bug 19532: Notices for recalls The notices: -RETURN_RECALLED_ITEM -PICKUP_RECALLED_ITEM have been created and added to sample_notices.sql Changed tools/letter.pl to use recalls table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71591|0 |1 is obsolete| | --- Comment #89 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 71592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71592&action=edit Bug 19532: Notices for recalls The notices: -RETURN_RECALLED_ITEM -PICKUP_RECALLED_ITEM have been created and added to sample_notices.sql Changed tools/letter.pl to use recalls table Added notices to translated installers https://bugs.koha-community.org/show_bug.cgi?id=19523 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 paxed <pasi.kallinen@joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen@joensuu.fi --- Comment #90 from paxed <pasi.kallinen@joensuu.fi> --- These two messages in recalls.js don't seem to be translatable: message = "The recall may have already been cancelled. Please refresh the page."; message = "Cancelled" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #91 from Nick Clemens <nick@bywatersolutions.com> --- Is this ready for testing? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #92 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Nick Clemens from comment #91)
Is this ready for testing?
Not yet, still working on fixes from Comment 68. Been having some trouble with my devbox but the patch is coming! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m --- Comment #93 from Brendan Gallagher <brendan@bywatersolutions.com> --- Any update on this one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #94 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 72244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72244&action=edit Bug 19532: Extra fixes from Comment 68 This patch fixes the following: The db uppdate tries to insert after 'notes' in issuing rules, but this doesn't exist When placing recall I always get a warning: <p><strong>Warning</strong>: Your library does not allow recalls for x item types.</p> Cancelling recall from 'Recall history tab' doesn't work If patron has no recalls there is 'Patron has no current recalls' message at bottom of tabs on checkout and details tabs for patron When confirming a recall if the item is from another branch I get a transfer generated as well as confirming hold for recall Feature now checks if the recall branch is the same as the item holding branch when checking in item to determine if transfer is required On recalls awaiting pickup: need to update recall.borrower to recall.patron - causing internal server error When placing a recall - if I hit 'back' after confirming and confirm again I get a second recall on the same item Recalls queue should have waiting date information Recalls queue should have a way to hide cancelled, I would expect closed recalls to be hidden by default Recalls queue now hides old (cancelled/expired/finished) recalls by default and has a checkbox to toggle this When viewing a patrons account in the staff side we should see that a checkout has an active recall Checking out the recall doesn't seem to close the recall Added an 'F' status for finished/closed recalls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #95 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Nick Clemens from comment #68) ...
Can you squash some of the patches to ease readability? (e.e. the removed old_recalls stuff)
Will do after fixes ...
Could overdue recalls be a tab/filter on the recalls queue?
I already have overdue recalls as a separate report page, do you mean moving this to a tab on the recalls queue page or having both the separate report and the tab on the recalls queue? ...
Question - should canceling a recall extend the due date? or notify patron somehow? is calendar used to calculate new due date for recall? I think it should be I think circ rules should include 'number of open recalls' to (optionally) limit how many a patron can have Is it valid for two patrons to recall the second item? I would think the second one not be a hold?
All very good points but with all due respect I'd love to get this base feature through, then we can start thinking about these additional things. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68569|0 |1 is obsolete| | Attachment #68572|0 |1 is obsolete| | Attachment #68644|0 |1 is obsolete| | Attachment #68645|0 |1 is obsolete| | Attachment #69873|0 |1 is obsolete| | Attachment #69874|0 |1 is obsolete| | Attachment #69875|0 |1 is obsolete| | Attachment #71574|0 |1 is obsolete| | Attachment #71575|0 |1 is obsolete| | Attachment #71576|0 |1 is obsolete| | Attachment #71577|0 |1 is obsolete| | Attachment #71578|0 |1 is obsolete| | Attachment #71579|0 |1 is obsolete| | Attachment #71580|0 |1 is obsolete| | Attachment #71581|0 |1 is obsolete| | Attachment #71582|0 |1 is obsolete| | Attachment #71583|0 |1 is obsolete| | Attachment #71584|0 |1 is obsolete| | Attachment #71585|0 |1 is obsolete| | Attachment #71586|0 |1 is obsolete| | Attachment #71587|0 |1 is obsolete| | Attachment #71588|0 |1 is obsolete| | Attachment #71589|0 |1 is obsolete| | Attachment #71590|0 |1 is obsolete| | Attachment #71592|0 |1 is obsolete| | Attachment #72244|0 |1 is obsolete| | --- Comment #96 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72311&action=edit Bug 19532: Database updates Adding the recalls table and the old_recalls table. Sponsored-by: Catalyst IT Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #97 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72312&action=edit Bug 19532: Module files for Recall and OldRecall Koha/Recall.pm Koha/Recalls.pm Koha/Old/Recall.pm Koha/Old/Recalls.pm and the schema files for Recall and OldRecall. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #98 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72313&action=edit Bug 19532: Some DB fixes Removing the old_recalls table, as suggested in Comment 5 Renaming 'found' column to 'status' Adding 'old' column Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #99 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72314&action=edit Bug 19532: Some module fixes Removing files related to OldRecall Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #100 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72315&action=edit Bug 19532: Circulation rules Adding 3 new rules and columns to issuingrules - recall_due_date_interval - recall_overdue_fine - recall_shelf_time Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #101 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72316&action=edit Bug 19532: Recall an item in OPAC This patch: - adds the 'Recall' button to the item on it's detail page - adds ability to place a recall - the recall is stored in the recalls table - the due date for the checkout is updated to whatever has been set in the issuing rule under recall_due_date_interval - error messages for if the user isn't logged in, the user tries to place a recall on an item they have already recalled, or if storing the recall in the db fails for any reason Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #102 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72317&action=edit Bug 19532: Cancel recall and see recalls in OPAC This patch adds ability for user to cancel a recall They can also see their recalls in the user summary Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #103 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72318&action=edit Bug 19532: Show recalls on intranet side This patch - adds Recall tab to the Check out section of member account, and to the Details section of member account - Functionality to cancel recalls on staff side - Fixing cancel on OPAC side (before I was deleting the whole recall instead of cancelling) - Fixing validation when checking whether a recall can be placed on an item that has been recalled by this borrower before. If the old recall is expired or cancelled then they can make a recall again. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #104 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72319&action=edit Bug 19532: Fixing broken OPAC recalls table Forgot to add <tr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #105 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72320&action=edit Bug 19532: recalls history this patch - adds recalls history (similar to holds history) to OPAC and intranet - edits the tables in opac-user.pl (OPAC), moremember.pl and circulation.pl (staff) so that it only shows active recalls (recalls that have been requested or are waiting) - some extra datatables fixes Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #106 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72321&action=edit Bug 19532: Recalls queue This patch adds a recalls queue page to the circulation reports You can see all recalls made in the system, who requested them, their status and other relevant info. you can cancel individual or multiple recalls. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #107 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72322&action=edit Bug 19532: Overdue recalls report Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #108 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72323&action=edit Bug 19532: Recalls awaiting pickup report this patch adds reports for all recalls awaiting pickup, and recalls that have been waiting more than X days. a syspref, RecallsMaxPickUpDelay, is added to give a general max shelf time for recalls Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #109 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72324&action=edit Bug 19532: Only recall items checked out by other users ... shouldn't be able to recall items that are currently checked out by yourself. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #110 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72325&action=edit Bug 19532: UseRecalls syspref This patch adds a syspref to control the usability of the recalls feature Test the following: Staff side /includes/circ-menu.inc /includes/circ-nav.inc /includes/members-menu.inc /admin/preferences/circulation.pref /circ/circulation-home.tt /circ/circulation.tt /circ/recalls_overdue.tt /circ/recalls_queue.tt /circ/recalls_waiting.tt /members/moremember.tt /members/recallshistory.tt OPAC /includes/usermenu.inc /opac-recall.tt /opac-recalls.tt /opac-user.tt /members/recallshistory.pl /opac/opac-detail.pl Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #111 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72326&action=edit Bug 19532: Recall pop up when checking in an item When checking in an item on the staff side, the staff member will see a pop up if there is a recall attached to that item. From here, they can confirm the recall, setting the status to 'Waiting' and updating the waitingdate. The item will still be checked in. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #112 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72327&action=edit Bug 19532: Send notice to user to return a recalled item When the recall is placed in the OPAC, a RETURN_RECALLED_ITEM notice is sent to the user who has the item checked out, with the updated due date. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #113 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72328&action=edit Bug 19532: Send notice to user to pickup recalled returned item Send a PICKUP_RECALLED_ITEM notice to the user who requested a recall when the item is checked in. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #114 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72329&action=edit Bug 19532: Flagging recall as 'old' when expired or cancelled Set 'old' flag to 1 if cancelling or expiring a recall Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #115 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72330&action=edit Bug 19532: Cronjob to check for overdue recalls This patch adds a check to the overdue_notices cronjob, so if any of the overdue issues are also recalls, the status will be set to O (overdue) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #116 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72331&action=edit Bug 19532: Tests for Koha/Recalls Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #117 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72332&action=edit Bug 19532: Nice message if no recalls for opac recalls history https://bugs.koha-community.org/show_bug.cgi?id=19523 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #118 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72333&action=edit Bug 19532: POD fix, renaming methods Tomas's comments: - renaming 'Class methods' to 'internal methods' - renaming 'borrower' and 'branch' methods to 'patron' and 'library' other comments are out of date with current patches and do not need to be actioned when testing, confirm all data still shows as expected and nothing is broken Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #119 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72334&action=edit Bug 19532: Extra fixes This patch addresses some of Liz's comments in Comment 37 - shows new due date on opac-recall.pl when the recall is requested - shows new due date on opac-recalls.pl recalls history - shows new due date on circ/recalls_queue.pl - syspref is default off - recalls tab on catalogue/detail.pl - show that there is a recall on an item on catalogue/detail.pl Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #120 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72335&action=edit Bug 19532: Notices for recalls The notices: -RETURN_RECALLED_ITEM -PICKUP_RECALLED_ITEM have been created and added to sample_notices.sql Changed tools/letter.pl to use recalls table Added notices to translated installers https://bugs.koha-community.org/show_bug.cgi?id=19523 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #121 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72336&action=edit Bug 19532: Extra fixes from Comment 68 This patch fixes the following: The db uppdate tries to insert after 'notes' in issuing rules, but this doesn't exist When placing recall I always get a warning: <p><strong>Warning</strong>: Your library does not allow recalls for x item types.</p> Cancelling recall from 'Recall history tab' doesn't work If patron has no recalls there is 'Patron has no current recalls' message at bottom of tabs on checkout and details tabs for patron When confirming a recall if the item is from another branch I get a transfer generated as well as confirming hold for recall Feature now checks if the recall branch is the same as the item holding branch when checking in item to determine if transfer is required On recalls awaiting pickup: need to update recall.borrower to recall.patron - causing internal server error When placing a recall - if I hit 'back' after confirming and confirm again I get a second recall on the same item Recalls queue should have waiting date information Recalls queue should have a way to hide cancelled, I would expect closed recalls to be hidden by default Recalls queue now hides old (cancelled/expired/finished) recalls by default and has a checkbox to toggle this When viewing a patrons account in the staff side we should see that a checkout has an active recall Checking out the recall doesn't seem to close the recall Added an 'F' status for finished/closed recalls Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #122 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72337&action=edit Bug 19532 (follow-up) Update characterset for recalls table Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #123 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72338&action=edit Bug 19532 - Improve and refine recalls functionality Only allow 1 recall per item When checking in only check for holds if no reserves found Add a T/transferring status for recalls, only confirm them once arrived Improve message when checking in recall Fix clashing ids on recall-history Check if patron can hold item before allowing recall Prevent multiple recalls when pressing back button Select/fill only active recall when issuing To test: 1 - Repeat major test plan - verify all points 2 - Attempt to place multiple recallsusing back button, should fail 3 - Set all item level holds to not allowed, should not be able to place recall 4 - Check-in recall at branch other than destination, should be in transit 5 - Confirm at correct branch, should send message and get expiration date etc. 6 - Return to another branch, should eb in transit again 7 - Play with circ rules and verify only allowed patrons can place recall Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #124 from Nick Clemens <nick@bywatersolutions.com> --- Rebased, tested and added some follow-ups to refine the functionality here - Aleisha can you sign off on my patch? This implements basic recall functionality and leaves room for improvements, this is a good starting point and I think can be QAed with an eye toward building refinement and extending functionality in future patchsets. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72338|0 |1 is obsolete| | --- Comment #125 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 72527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72527&action=edit Bug 19532 - Improve and refine recalls functionality Only allow 1 recall per item When checking in only check for holds if no reserves found Add a T/transferring status for recalls, only confirm them once arrived Improve message when checking in recall Fix clashing ids on recall-history Check if patron can hold item before allowing recall Prevent multiple recalls when pressing back button Select/fill only active recall when issuing To test: 1 - Repeat major test plan - verify all points 2 - Attempt to place multiple recallsusing back button, should fail 3 - Set all item level holds to not allowed, should not be able to place recall 4 - Check-in recall at branch other than destination, should be in transit 5 - Confirm at correct branch, should send message and get expiration date etc. 6 - Return to another branch, should eb in transit again 7 - Play with circ rules and verify only allowed patrons can place recall Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Hugh Rundle <hughr@brimbank.vic.gov.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hughr@brimbank.vic.gov.au --- Comment #126 from Hugh Rundle <hughr@brimbank.vic.gov.au> --- This sounds like a great feature! Just wondering about 'recall due date interval'. Will there be an option to not change the due date at all? i.e. we just want to recall the item to cataloguing maintenance when it's returned (and cut the queue if there are holds on the title/item), but we're not in a huge hurry. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alain Dussert <adussert@pacifica.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adussert@pacifica.edu --- Comment #127 from Alain Dussert <adussert@pacifica.edu> --- Hi All, Has there been any updated ETA or target release date for this holds recall development? Thanks, Alain -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #128 from Liz Rea <liz@catalyst.net.nz> --- Aleisha has been away on holiday, but this patch looks to be signed off and just waiting for QA? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #129 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We are in hard feature freeze now, so it won't make it into 18.05 (only a few days left to release), but maybe 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #130 from Nick Clemens <nick@bywatersolutions.com> --- We talked about this one a lot at hackfest and have been working on recall functionality for one of our partners. While I agree on the strategy of starting small and avoiding scope creep I do think that we need a path forward and would really like to see an RFC that provides a roadmap to the final feature ensuring that this base allows for work towards that end. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #131 from Alain Dussert <adussert@pacifica.edu> --- Hi All, I agree that an RFC would be ideal. It would be great for this feature to be put in production in Koha 18.11 Thanks, Alain -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #132 from Chris Cormack <chris@bigballofwax.co.nz> --- I actually find this incredibly disappointing. We could have had a working feature in 18.05 except for people consistently trying to scope creep it. Now we won't until at least 18.11 and it will probably be over specced, over ambitious and fragile. This has to stop. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #133 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It was too later for 18.05 anyway. We are in feature freeze for a week already. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #134 from Chris Cormack <chris@bigballofwax.co.nz> --- Yes, because of the months of stuff before. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin@rot13.org --- Comment #135 from Dobrica Pavlinusic <dpavlin@rot13.org> --- (In reply to Chris Cormack from comment #132)
I actually find this incredibly disappointing. We could have had a working feature in 18.05 except for people consistently trying to scope creep it. Now we won't until at least 18.11 and it will probably be over specced, over ambitious and fragile. This has to stop.
I have to throw in my $0.02 here: we just implemented recall notices on reservations using simple cron script: https://github.com/dpavlin/Koha/blob/koha_ffzg/ffzg/recall_notices.pl I would love to replace hard-coded values in it with circulation rules, but currently this bug doesn't apply, and squashing some of fixes into more manageable chunks would be great first step. Due to our library circulation rules, OPAC parts of this patch are not interesting to us, but I would love to have intranet part in upstream Koha so that I can contribute cron script similar to ours. Does it make sense to split this bug into two halfs opac and intranet? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #136 from Chris Cormack <chris@bigballofwax.co.nz> --- While reserves might work for one use case, they won't for others. So instead of people turning this set of patches into the mess they've made it. There should have just been 2 different features. We (Catalyst) are unlikely to put any more work into rebasing these for the 400th time until people figure out what they actually want. Even though we have the feature in production already -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz --- Comment #137 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi everyone on the CC list Just a heads up that you will be receiving a lot of emails while I obsolete and attach newly rebased patches onto this bug report. I have rebased the rebase patches against master (as of 11 July 2018). As we are already using recalls in production we have been able to identify several bugs in the recalls which had not been previously found, and I have written patches to fix these bugs which I am also attaching to this bug report: * Transfer recall modal always appears upon the return of a recalled item even if it is being returned to the library where it is to be picked up from. * When recall fields in the circulation rules are empty when a patron tries to confirm a recall on the OPAC an 'Internal Server Error' is thrown. i.e. There are no default values for the recall circ fields. * At present if recalls and course reserves are both enabled then if you try to view the opac-course-details.pl page for a course with a currently issued course reserve then an 'Internal Server Error' is thrown. The root cause of this is: Koha::Item->avail_for_recall does not have tests. avail_for_recall is used in the item-status.inc used by both opac-course-details.pl and opac-detail.pl and the error is caused by course reserves not handing back an avail_for_recall value as opac-detail.pl does. Hopefully with rebased recalls patches + new bug fix patches we can action this recalls feature along and get it into 18.11 release. Cheers, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72311|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72312|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72313|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72314|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72315|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72316|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72317|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72318|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72319|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72320|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72321|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72322|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72323|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72324|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72325|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72326|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72327|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72328|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72329|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72330|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72331|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72332|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72333|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72334|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72335|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72336|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72337|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72527|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #138 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76817&action=edit Bug 19532: Database updates Adding the recalls table and the old_recalls table. Sponsored-by: Catalyst IT Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #139 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76818&action=edit Bug 19532: Module files for Recall and OldRecall Koha/Recall.pm Koha/Recalls.pm Koha/Old/Recall.pm Koha/Old/Recalls.pm and the schema files for Recall and OldRecall. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #140 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76819&action=edit Bug 19532: Some DB fixes Removing the old_recalls table, as suggested in Comment 5 Renaming 'found' column to 'status' Adding 'old' column Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #141 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76820&action=edit Bug 19532: Some module fixes Removing files related to OldRecall Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #142 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76821&action=edit Bug 19532: Circulation rules Adding 3 new rules and columns to issuingrules - recall_due_date_interval - recall_overdue_fine - recall_shelf_time Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #143 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76822&action=edit Bug 19532: Recall an item in OPAC This patch: - adds the 'Recall' button to the item on it's detail page - adds ability to place a recall - the recall is stored in the recalls table - the due date for the checkout is updated to whatever has been set in the issuing rule under recall_due_date_interval - error messages for if the user isn't logged in, the user tries to place a recall on an item they have already recalled, or if storing the recall in the db fails for any reason Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #144 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76823&action=edit Bug 19532: Cancel recall and see recalls in OPAC This patch adds ability for user to cancel a recall They can also see their recalls in the user summary Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #145 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76824&action=edit Bug 19532: Show recalls on intranet side This patch - adds Recall tab to the Check out section of member account, and to the Details section of member account - Functionality to cancel recalls on staff side - Fixing cancel on OPAC side (before I was deleting the whole recall instead of cancelling) - Fixing validation when checking whether a recall can be placed on an item that has been recalled by this borrower before. If the old recall is expired or cancelled then they can make a recall again. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #146 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76825&action=edit Bug 19532: Fixing broken OPAC recalls table Forgot to add <tr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #147 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76826&action=edit Bug 19532: recalls history this patch - adds recalls history (similar to holds history) to OPAC and intranet - edits the tables in opac-user.pl (OPAC), moremember.pl and circulation.pl (staff) so that it only shows active recalls (recalls that have been requested or are waiting) - some extra datatables fixes Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #148 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76827&action=edit Bug 19532: Recalls queue This patch adds a recalls queue page to the circulation reports You can see all recalls made in the system, who requested them, their status and other relevant info. you can cancel individual or multiple recalls. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #149 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76828&action=edit Bug 19532: Overdue recalls report Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #150 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76829&action=edit Bug 19532: Recalls awaiting pickup report this patch adds reports for all recalls awaiting pickup, and recalls that have been waiting more than X days. a syspref, RecallsMaxPickUpDelay, is added to give a general max shelf time for recalls Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #151 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76830&action=edit Bug 19532: Only recall items checked out by other users ... shouldn't be able to recall items that are currently checked out by yourself. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #152 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76831&action=edit Bug 19532: UseRecalls syspref This patch adds a syspref to control the usability of the recalls feature Test the following: Staff side /includes/circ-menu.inc /includes/circ-nav.inc /includes/members-menu.inc /admin/preferences/circulation.pref /circ/circulation-home.tt /circ/circulation.tt /circ/recalls_overdue.tt /circ/recalls_queue.tt /circ/recalls_waiting.tt /members/moremember.tt /members/recallshistory.tt OPAC /includes/usermenu.inc /opac-recall.tt /opac-recalls.tt /opac-user.tt /members/recallshistory.pl /opac/opac-detail.pl Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #153 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76832&action=edit Bug 19532: Recall pop up when checking in an item When checking in an item on the staff side, the staff member will see a pop up if there is a recall attached to that item. From here, they can confirm the recall, setting the status to 'Waiting' and updating the waitingdate. The item will still be checked in. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #154 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76833&action=edit Bug 19532: Send notice to user to return a recalled item When the recall is placed in the OPAC, a RETURN_RECALLED_ITEM notice is sent to the user who has the item checked out, with the updated due date. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #155 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76834&action=edit Bug 19532: Send notice to user to pickup recalled returned item Send a PICKUP_RECALLED_ITEM notice to the user who requested a recall when the item is checked in. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #156 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76835&action=edit Bug 19532: Flagging recall as 'old' when expired or cancelled Set 'old' flag to 1 if cancelling or expiring a recall Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #157 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76836&action=edit Bug 19532: Cronjob to check for overdue recalls This patch adds a check to the overdue_notices cronjob, so if any of the overdue issues are also recalls, the status will be set to O (overdue) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #158 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76837&action=edit Bug 19532: Tests for Koha/Recalls Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #159 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76838&action=edit Bug 19532: Nice message if no recalls for opac recalls history https://bugs.koha-community.org/show_bug.cgi?id=19523 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #160 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76839&action=edit Bug 19532: POD fix, renaming methods Tomas's comments: - renaming 'Class methods' to 'internal methods' - renaming 'borrower' and 'branch' methods to 'patron' and 'library' other comments are out of date with current patches and do not need to be actioned when testing, confirm all data still shows as expected and nothing is broken Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #161 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76840&action=edit Bug 19532: Extra fixes This patch addresses some of Liz's comments in Comment 37 - shows new due date on opac-recall.pl when the recall is requested - shows new due date on opac-recalls.pl recalls history - shows new due date on circ/recalls_queue.pl - syspref is default off - recalls tab on catalogue/detail.pl - show that there is a recall on an item on catalogue/detail.pl Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #162 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76841&action=edit Bug 19532: Notices for recalls The notices: -RETURN_RECALLED_ITEM -PICKUP_RECALLED_ITEM have been created and added to sample_notices.sql Changed tools/letter.pl to use recalls table Added notices to translated installers https://bugs.koha-community.org/show_bug.cgi?id=19523 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #163 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76842&action=edit Bug 19532: Extra fixes from Comment 68 This patch fixes the following: The db uppdate tries to insert after 'notes' in issuing rules, but this doesn't exist When placing recall I always get a warning: <p><strong>Warning</strong>: Your library does not allow recalls for x item types.</p> Cancelling recall from 'Recall history tab' doesn't work If patron has no recalls there is 'Patron has no current recalls' message at bottom of tabs on checkout and details tabs for patron When confirming a recall if the item is from another branch I get a transfer generated as well as confirming hold for recall Feature now checks if the recall branch is the same as the item holding branch when checking in item to determine if transfer is required On recalls awaiting pickup: need to update recall.borrower to recall.patron - causing internal server error When placing a recall - if I hit 'back' after confirming and confirm again I get a second recall on the same item Recalls queue should have waiting date information Recalls queue should have a way to hide cancelled, I would expect closed recalls to be hidden by default Recalls queue now hides old (cancelled/expired/finished) recalls by default and has a checkbox to toggle this When viewing a patrons account in the staff side we should see that a checkout has an active recall Checking out the recall doesn't seem to close the recall Added an 'F' status for finished/closed recalls Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Conflicts: Koha/Schema/Result/Borrower.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #164 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76843&action=edit Bug 19532 (follow-up) Update characterset for recalls table Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #165 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76844&action=edit Bug 19532 - Improve and refine recalls functionality Only allow 1 recall per item When checking in only check for holds if no reserves found Add a T/transferring status for recalls, only confirm them once arrived Improve message when checking in recall Fix clashing ids on recall-history Check if patron can hold item before allowing recall Prevent multiple recalls when pressing back button Select/fill only active recall when issuing To test: 1 - Repeat major test plan - verify all points 2 - Attempt to place multiple recallsusing back button, should fail 3 - Set all item level holds to not allowed, should not be able to place recall 4 - Check-in recall at branch other than destination, should be in transit 5 - Confirm at correct branch, should send message and get expiration date etc. 6 - Return to another branch, should eb in transit again 7 - Play with circ rules and verify only allowed patrons can place recall Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #166 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76845&action=edit Bug 19532 - Fixes to stop transfer recall modal from being displayed incorrectly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #167 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76846&action=edit Bug 19532 - Recalls for Course Reserves. This ptach fixes the 'Template process error Koha::Item->avail_for_recall' which is thrown when loading a Course pgae in opac-course-details.pl with course reserves which are currently issued. It also allows recalls to be placed from Course reserves Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #168 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 76847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76847&action=edit Bug 19532 - Fix for recall OPAC confirmation failing when recall circ rule is empty Sponsored-BY: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #169 from Alex Buckley <alexbuckley@catalyst.net.nz> --- All of my rebased patches + additional fixes are attached now. I just double checked applying all of the patches on this bug report to master as of 11 July 2018 and they all apply correctly. I am setting this bug report to 'Needs signoff' to try and get it moving now it can be tested more easily as it applies on master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #170 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 77177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77177&action=edit Bug 19532 - Stopping an recalled item currently awaiting pickup from being able to be checked out to patrons other than the recall requester. Test plan: 1. Ensure 'UseRecalls' sypref is enabled and you have inputted values for recalls fields in the circulation rules (Administration->Circulation and fines rules) 2. Check item out to patron 1 3. Log into the OPAC as patron 2 and place a recall on the checked out item 4. Return the item and confirm the recall 5. In the staff client go to Circulation->Recalls queue, notice the recall has a status of 'Ready for pickup' 6. Try issuing the item to patron 3 and notice without this patch applied you can issue a recall awaiting pickup to a patron who did not place the recall. 7. Apply patch 8. Restart memcached and plack 9. Using a new item repeat steps 1,2,3,4,5,6 and notice you get a yellow message displayed stating: 'This item is awaiting pickup by another patron who recalled it.' The issuing has not taken place to a patron who is not the patron who placed the recall as the item is awaiting pickup by the recall requester. 10. Issue the item to patron 2 and notice the issuing takes place successfully Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #171 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 77178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77178&action=edit Bug 19532 - Make the Recall confirmation popup appear everytime a recalled item is put through returns until it is checked out to recall requester Previously the confirm recall popup was only displayed the first time the recalled item was out through returns. However it is useful for the Confirm recall popup to appear if the item is put through the returns multiple times due to library staff being interrupted. This ensures library staff are informed that the item has been recalled. Test plan: 1. Ensure 'UseRecalls' sypref is enabled and you have inputted values for recalls fields in the circulation rules (Administration->Circulation and fines rules) 2. Check item out to patron 1 3. Log into the OPAC as patron 2 and place a recall on the checked out item 4. Return the item and notice the 'Confirm recall' popup appears. Click confirm 5. Now check the item in again and notice the popup is not displayed this time. 6. Apply this patch 7. Restart memcached and plack 8. Using a new item repeat steps 2,3,4,5 and notice in step 5 the 'Confirm recall' popup is displayed this time. Click 'Confirm' 9. Check the item out to patron 2 10. Return the item and notice no popup is displayed. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #172 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 77179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77179&action=edit Bug 19532 - New RECALL_REQUESTER_DET notice and print option on confirm recall popup This patch adds a new notice RECALL_REQUESTER_DET which like HOLD_SLIP outlines borrower and item information so the item can be put aside for the requester. This patch also adds a 'Print and confirm' button to the 'Confirm recall' popup that appears when returning a recalled item. This functionality works the same as the 'Print and confirm' functionality for the Hold slip: A print modal popup will appear for the user to choose print settings, and choose to print or cancel. Test plan: 1. Ensure 'UseRecalls' sypref is enabled and you have inputted values for recalls fields in the circulation rules (Administration->Circulation and fines rules) 2. Check item out to patron 1 3. Log into the OPAC as patron 2 and place a recall on the checked out item 4. Return the item in the staff client 5. Notice there are only two buttons on the 'Confirm recall' popup which appears: 'Confirm' and 'Cancel' 6. Apply patch, run updatedatabase.pl (as there is a SQL atomicupdate file to be run), and restart memcached and plack 7. Using a new item repeat steps 2,3 8. In a new tab, in the staff client go to Circulation->Recalls queue, and notice the recall has a status of 'Requested' 8. Back in your first tab return the item and notice that a new button 'Print and confirm' is on the 'Confirm recall' popup. Select this button and notice two new popup windows appear: Browsers print window, and a window showing what the notice to be print looks like. 9. If you have a printer available print the notice. Otherwise you can look at what the notice would look like in the notice window, observing the notice outlines the following information: * Current date and time * Recall pickup branch * Borrowers first name and surname * Borrowers cardnumber, phonenumber, address, address2, city, zipcode, email * Recalled item title, author, barcode, callnumber. * Recall waiting date, and recall notes Some of these values will not be displayed on the notice if they are not set. For example the patron may not have set an address, or email. 10. After either printing the notice, or selecting 'Cancel' in the print window. Go back to your second tab and refresh the page and notice the status of the recall has changed to 'Ready for pickup' this shows the 'Print and confirm' button does actually confirm the recall. 11. Making sure the changes implemented in the previous commit (Bug 19532 - Make the Recall confirmation popup appear everytime a recalled item is put through returns) still work. Try returning the item again and notice the 'Confirm recall' popup with the 'Print and confirm' button is displayed again and you can choose to print the notice again if you want. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #173 from Owen Leonard <oleonard@myacpl.org> --- I'm trying to test this and running into trouble: Other comments: The changes to sample_notices.sql don't apply cleanly, but that can wait for a rebase. Easy to ignore at this stage of testing. I get this error in the staff client: Missing right curly or square bracket at /home/vagrant/kohaclone/C4/Circulation.pm line 4144, at end of line It looks like there is a missing curly bracket at line 2064, so I added that before continuing. Then: Checked-out items in the OPAC don't show a "recall" link on the detail page. I'm logged in as a different user than the one who has it checked out. Is there more I need to do to make something "available" for recall? Or was my correction to Circulation.pm incorrect, causing some other problems? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply --- Comment #174 from Chris Cormack <chris@bigballofwax.co.nz> --- Applying: Bug 19532: recalls history error: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt). error: could not build fake ancestor Patch failed at 0001 Bug 19532: recalls history I can't get past this one sorry Alex, can you try a rebase please -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76817|0 |1 is obsolete| | --- Comment #175 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78755&action=edit Bug 19532: Database updates Adding the recalls table and the old_recalls table. Sponsored-by: Catalyst IT Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76818|0 |1 is obsolete| | --- Comment #176 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78757&action=edit Bug 19532: Module files for Recall and OldRecall Koha/Recall.pm Koha/Recalls.pm Koha/Old/Recall.pm Koha/Old/Recalls.pm and the schema files for Recall and OldRecall. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76819|0 |1 is obsolete| | --- Comment #177 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78759&action=edit Bug 19532: Some DB fixes Removing the old_recalls table, as suggested in Comment 5 Renaming 'found' column to 'status' Adding 'old' column Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76820|0 |1 is obsolete| | --- Comment #178 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78761&action=edit Bug 19532: Some module fixes Removing files related to OldRecall Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76821|0 |1 is obsolete| | --- Comment #179 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78763&action=edit Bug 19532: Circulation rules Adding 3 new rules and columns to issuingrules - recall_due_date_interval - recall_overdue_fine - recall_shelf_time Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76822|0 |1 is obsolete| | --- Comment #180 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78765&action=edit Bug 19532: Recall an item in OPAC This patch: - adds the 'Recall' button to the item on it's detail page - adds ability to place a recall - the recall is stored in the recalls table - the due date for the checkout is updated to whatever has been set in the issuing rule under recall_due_date_interval - error messages for if the user isn't logged in, the user tries to place a recall on an item they have already recalled, or if storing the recall in the db fails for any reason Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76823|0 |1 is obsolete| | --- Comment #181 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78766&action=edit Bug 19532: Cancel recall and see recalls in OPAC This patch adds ability for user to cancel a recall They can also see their recalls in the user summary Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76824|0 |1 is obsolete| | --- Comment #182 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78768&action=edit Bug 19532: Show recalls on intranet side This patch - adds Recall tab to the Check out section of member account, and to the Details section of member account - Functionality to cancel recalls on staff side - Fixing cancel on OPAC side (before I was deleting the whole recall instead of cancelling) - Fixing validation when checking whether a recall can be placed on an item that has been recalled by this borrower before. If the old recall is expired or cancelled then they can make a recall again. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76825|0 |1 is obsolete| | --- Comment #183 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78770&action=edit Bug 19532: Fixing broken OPAC recalls table Forgot to add <tr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76826|0 |1 is obsolete| | --- Comment #184 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78772&action=edit Bug 19532: recalls history this patch - adds recalls history (similar to holds history) to OPAC and intranet - edits the tables in opac-user.pl (OPAC), moremember.pl and circulation.pl (staff) so that it only shows active recalls (recalls that have been requested or are waiting) - some extra datatables fixes Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76827|0 |1 is obsolete| | --- Comment #185 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78773&action=edit Bug 19532: Recalls queue This patch adds a recalls queue page to the circulation reports You can see all recalls made in the system, who requested them, their status and other relevant info. you can cancel individual or multiple recalls. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76828|0 |1 is obsolete| | --- Comment #186 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78774&action=edit Bug 19532: Overdue recalls report Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76829|0 |1 is obsolete| | --- Comment #187 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78775&action=edit Bug 19532: Recalls awaiting pickup report this patch adds reports for all recalls awaiting pickup, and recalls that have been waiting more than X days. a syspref, RecallsMaxPickUpDelay, is added to give a general max shelf time for recalls Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76830|0 |1 is obsolete| | --- Comment #188 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78776&action=edit Bug 19532: Only recall items checked out by other users ... shouldn't be able to recall items that are currently checked out by yourself. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76831|0 |1 is obsolete| | --- Comment #189 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78777&action=edit Bug 19532: UseRecalls syspref This patch adds a syspref to control the usability of the recalls feature Test the following: Staff side /includes/circ-menu.inc /includes/circ-nav.inc /includes/members-menu.inc /admin/preferences/circulation.pref /circ/circulation-home.tt /circ/circulation.tt /circ/recalls_overdue.tt /circ/recalls_queue.tt /circ/recalls_waiting.tt /members/moremember.tt /members/recallshistory.tt OPAC /includes/usermenu.inc /opac-recall.tt /opac-recalls.tt /opac-user.tt /members/recallshistory.pl /opac/opac-detail.pl Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76832|0 |1 is obsolete| | --- Comment #190 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78778&action=edit Bug 19532: Recall pop up when checking in an item When checking in an item on the staff side, the staff member will see a pop up if there is a recall attached to that item. From here, they can confirm the recall, setting the status to 'Waiting' and updating the waitingdate. The item will still be checked in. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76833|0 |1 is obsolete| | --- Comment #191 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78780&action=edit Bug 19532: Send notice to user to return a recalled item When the recall is placed in the OPAC, a RETURN_RECALLED_ITEM notice is sent to the user who has the item checked out, with the updated due date. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76834|0 |1 is obsolete| | --- Comment #192 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78782&action=edit Bug 19532: Send notice to user to pickup recalled returned item Send a PICKUP_RECALLED_ITEM notice to the user who requested a recall when the item is checked in. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76835|0 |1 is obsolete| | --- Comment #193 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78785&action=edit Bug 19532: Flagging recall as 'old' when expired or cancelled Set 'old' flag to 1 if cancelling or expiring a recall Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76836|0 |1 is obsolete| | --- Comment #194 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78787&action=edit Bug 19532: Cronjob to check for overdue recalls This patch adds a check to the overdue_notices cronjob, so if any of the overdue issues are also recalls, the status will be set to O (overdue) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76837|0 |1 is obsolete| | --- Comment #195 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78789&action=edit Bug 19532: Tests for Koha/Recalls Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76838|0 |1 is obsolete| | --- Comment #196 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78790&action=edit Bug 19532: Nice message if no recalls for opac recalls history https://bugs.koha-community.org/show_bug.cgi?id=19523 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76839|0 |1 is obsolete| | --- Comment #197 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78792&action=edit Bug 19532: POD fix, renaming methods Tomas's comments: - renaming 'Class methods' to 'internal methods' - renaming 'borrower' and 'branch' methods to 'patron' and 'library' other comments are out of date with current patches and do not need to be actioned when testing, confirm all data still shows as expected and nothing is broken Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76840|0 |1 is obsolete| | --- Comment #198 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78794&action=edit Bug 19532: Extra fixes This patch addresses some of Liz's comments in Comment 37 - shows new due date on opac-recall.pl when the recall is requested - shows new due date on opac-recalls.pl recalls history - shows new due date on circ/recalls_queue.pl - syspref is default off - recalls tab on catalogue/detail.pl - show that there is a recall on an item on catalogue/detail.pl Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76841|0 |1 is obsolete| | --- Comment #199 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78797&action=edit Bug 19532: Notices for recalls The notices: -RETURN_RECALLED_ITEM -PICKUP_RECALLED_ITEM have been created and added to sample_notices.sql Changed tools/letter.pl to use recalls table Added notices to translated installers https://bugs.koha-community.org/show_bug.cgi?id=19523 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76842|0 |1 is obsolete| | --- Comment #200 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78800&action=edit Bug 19532: Extra fixes from Comment 68 This patch fixes the following: The db uppdate tries to insert after 'notes' in issuing rules, but this doesn't exist When placing recall I always get a warning: <p><strong>Warning</strong>: Your library does not allow recalls for x item types.</p> Cancelling recall from 'Recall history tab' doesn't work If patron has no recalls there is 'Patron has no current recalls' message at bottom of tabs on checkout and details tabs for patron When confirming a recall if the item is from another branch I get a transfer generated as well as confirming hold for recall Feature now checks if the recall branch is the same as the item holding branch when checking in item to determine if transfer is required On recalls awaiting pickup: need to update recall.borrower to recall.patron - causing internal server error When placing a recall - if I hit 'back' after confirming and confirm again I get a second recall on the same item Recalls queue should have waiting date information Recalls queue should have a way to hide cancelled, I would expect closed recalls to be hidden by default Recalls queue now hides old (cancelled/expired/finished) recalls by default and has a checkbox to toggle this When viewing a patrons account in the staff side we should see that a checkout has an active recall Checking out the recall doesn't seem to close the recall Added an 'F' status for finished/closed recalls Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Conflicts: Koha/Schema/Result/Borrower.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76843|0 |1 is obsolete| | --- Comment #201 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78801&action=edit Bug 19532 (follow-up) Update characterset for recalls table Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76844|0 |1 is obsolete| | --- Comment #202 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78802&action=edit Bug 19532 - Improve and refine recalls functionality Only allow 1 recall per item When checking in only check for holds if no reserves found Add a T/transferring status for recalls, only confirm them once arrived Improve message when checking in recall Fix clashing ids on recall-history Check if patron can hold item before allowing recall Prevent multiple recalls when pressing back button Select/fill only active recall when issuing To test: 1 - Repeat major test plan - verify all points 2 - Attempt to place multiple recallsusing back button, should fail 3 - Set all item level holds to not allowed, should not be able to place recall 4 - Check-in recall at branch other than destination, should be in transit 5 - Confirm at correct branch, should send message and get expiration date etc. 6 - Return to another branch, should eb in transit again 7 - Play with circ rules and verify only allowed patrons can place recall Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76845|0 |1 is obsolete| | --- Comment #203 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78803&action=edit Bug 19532 - Fixes to stop transfer recall modal from being displayed incorrectly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76846|0 |1 is obsolete| | --- Comment #204 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78804&action=edit Bug 19532 - Recalls for Course Reserves. This ptach fixes the 'Template process error Koha::Item->avail_for_recall' which is thrown when loading a Course pgae in opac-course-details.pl with course reserves which are currently issued. It also allows recalls to be placed from Course reserves Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76847|0 |1 is obsolete| | --- Comment #205 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78805&action=edit Bug 19532 - Fix for recall OPAC confirmation failing when recall circ rule is empty Sponsored-BY: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77177|0 |1 is obsolete| | --- Comment #206 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78806&action=edit Bug 19532 - Stopping an recalled item currently awaiting pickup from being able to be checked out to patrons other than the recall requester. Test plan: 1. Ensure 'UseRecalls' sypref is enabled and you have inputted values for recalls fields in the circulation rules (Administration->Circulation and fines rules) 2. Check item out to patron 1 3. Log into the OPAC as patron 2 and place a recall on the checked out item 4. Return the item and confirm the recall 5. In the staff client go to Circulation->Recalls queue, notice the recall has a status of 'Ready for pickup' 6. Try issuing the item to patron 3 and notice without this patch applied you can issue a recall awaiting pickup to a patron who did not place the recall. 7. Apply patch 8. Restart memcached and plack 9. Using a new item repeat steps 1,2,3,4,5,6 and notice you get a yellow message displayed stating: 'This item is awaiting pickup by another patron who recalled it.' The issuing has not taken place to a patron who is not the patron who placed the recall as the item is awaiting pickup by the recall requester. 10. Issue the item to patron 2 and notice the issuing takes place successfully Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77178|0 |1 is obsolete| | --- Comment #207 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78807&action=edit Bug 19532 - Make the Recall confirmation popup appear everytime a recalled item is put through returns until it is checked out to recall requester Previously the confirm recall popup was only displayed the first time the recalled item was out through returns. However it is useful for the Confirm recall popup to appear if the item is put through the returns multiple times due to library staff being interrupted. This ensures library staff are informed that the item has been recalled. Test plan: 1. Ensure 'UseRecalls' sypref is enabled and you have inputted values for recalls fields in the circulation rules (Administration->Circulation and fines rules) 2. Check item out to patron 1 3. Log into the OPAC as patron 2 and place a recall on the checked out item 4. Return the item and notice the 'Confirm recall' popup appears. Click confirm 5. Now check the item in again and notice the popup is not displayed this time. 6. Apply this patch 7. Restart memcached and plack 8. Using a new item repeat steps 2,3,4,5 and notice in step 5 the 'Confirm recall' popup is displayed this time. Click 'Confirm' 9. Check the item out to patron 2 10. Return the item and notice no popup is displayed. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77179|0 |1 is obsolete| | --- Comment #208 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78808&action=edit Bug 19532 - New RECALL_REQUESTER_DET notice and print option on confirm recall popup This patch adds a new notice RECALL_REQUESTER_DET which like HOLD_SLIP outlines borrower and item information so the item can be put aside for the requester. This patch also adds a 'Print and confirm' button to the 'Confirm recall' popup that appears when returning a recalled item. This functionality works the same as the 'Print and confirm' functionality for the Hold slip: A print modal popup will appear for the user to choose print settings, and choose to print or cancel. Test plan: 1. Ensure 'UseRecalls' sypref is enabled and you have inputted values for recalls fields in the circulation rules (Administration->Circulation and fines rules) 2. Check item out to patron 1 3. Log into the OPAC as patron 2 and place a recall on the checked out item 4. Return the item in the staff client 5. Notice there are only two buttons on the 'Confirm recall' popup which appears: 'Confirm' and 'Cancel' 6. Apply patch, run updatedatabase.pl (as there is a SQL atomicupdate file to be run), and restart memcached and plack 7. Using a new item repeat steps 2,3 8. In a new tab, in the staff client go to Circulation->Recalls queue, and notice the recall has a status of 'Requested' 8. Back in your first tab return the item and notice that a new button 'Print and confirm' is on the 'Confirm recall' popup. Select this button and notice two new popup windows appear: Browsers print window, and a window showing what the notice to be print looks like. 9. If you have a printer available print the notice. Otherwise you can look at what the notice would look like in the notice window, observing the notice outlines the following information: * Current date and time * Recall pickup branch * Borrowers first name and surname * Borrowers cardnumber, phonenumber, address, address2, city, zipcode, email * Recalled item title, author, barcode, callnumber. * Recall waiting date, and recall notes Some of these values will not be displayed on the notice if they are not set. For example the patron may not have set an address, or email. 10. After either printing the notice, or selecting 'Cancel' in the print window. Go back to your second tab and refresh the page and notice the status of the recall has changed to 'Ready for pickup' this shows the 'Print and confirm' button does actually confirm the recall. 11. Making sure the changes implemented in the previous commit (Bug 19532 - Make the Recall confirmation popup appear everytime a recalled item is put through returns) still work. Try returning the item again and notice the 'Confirm recall' popup with the 'Print and confirm' button is displayed again and you can choose to print the notice again if you want. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #209 from Owen Leonard <oleonard@myacpl.org> --- Sorry, this doesn't apply anymore. I had begun testing just before master changed and was getting an error in Circulation.pm which I'm thinking may have been a merge error? Missing right curly or square bracket at /home/vagrant/kohaclone/C4/Circulation.pm line 4147, at end of line -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED --- Comment #210 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi all I have gone through and fixed the conflicts when applying these patches, and will attach the fixed patches. Apologies for the email deluge. Cheers, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78808|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78807|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78806|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78805|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78804|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78803|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78802|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78801|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78800|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78797|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78794|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78792|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78790|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78789|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78787|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78785|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78782|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78780|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78778|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78777|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #211 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80763&action=edit Bug 19532: UseRecalls syspref This patch adds a syspref to control the usability of the recalls feature Test the following: Staff side /includes/circ-menu.inc /includes/circ-nav.inc /includes/members-menu.inc /admin/preferences/circulation.pref /circ/circulation-home.tt /circ/circulation.tt /circ/recalls_overdue.tt /circ/recalls_queue.tt /circ/recalls_waiting.tt /members/moremember.tt /members/recallshistory.tt OPAC /includes/usermenu.inc /opac-recall.tt /opac-recalls.tt /opac-user.tt /members/recallshistory.pl /opac/opac-detail.pl Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #212 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80764&action=edit Bug 19532: Recall pop up when checking in an item When checking in an item on the staff side, the staff member will see a pop up if there is a recall attached to that item. From here, they can confirm the recall, setting the status to 'Waiting' and updating the waitingdate. The item will still be checked in. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #213 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80765&action=edit Bug 19532: Send notice to user to return a recalled item When the recall is placed in the OPAC, a RETURN_RECALLED_ITEM notice is sent to the user who has the item checked out, with the updated due date. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #214 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80766&action=edit Bug 19532: Send notice to user to pickup recalled returned item Send a PICKUP_RECALLED_ITEM notice to the user who requested a recall when the item is checked in. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #215 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80767&action=edit Bug 19532: Flagging recall as 'old' when expired or cancelled Set 'old' flag to 1 if cancelling or expiring a recall Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #216 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80768&action=edit Bug 19532: Cronjob to check for overdue recalls This patch adds a check to the overdue_notices cronjob, so if any of the overdue issues are also recalls, the status will be set to O (overdue) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #217 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80769&action=edit Bug 19532: Tests for Koha/Recalls Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #218 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80770&action=edit Bug 19532: Nice message if no recalls for opac recalls history https://bugs.koha-community.org/show_bug.cgi?id=19523 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #219 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80771&action=edit Bug 19532: POD fix, renaming methods Tomas's comments: - renaming 'Class methods' to 'internal methods' - renaming 'borrower' and 'branch' methods to 'patron' and 'library' other comments are out of date with current patches and do not need to be actioned when testing, confirm all data still shows as expected and nothing is broken Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #220 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80772&action=edit Bug 19532: Extra fixes This patch addresses some of Liz's comments in Comment 37 - shows new due date on opac-recall.pl when the recall is requested - shows new due date on opac-recalls.pl recalls history - shows new due date on circ/recalls_queue.pl - syspref is default off - recalls tab on catalogue/detail.pl - show that there is a recall on an item on catalogue/detail.pl Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #221 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80773&action=edit Bug 19532: Notices for recalls The notices: -RETURN_RECALLED_ITEM -PICKUP_RECALLED_ITEM have been created and added to sample_notices.sql Changed tools/letter.pl to use recalls table Added notices to translated installers https://bugs.koha-community.org/show_bug.cgi?id=19523 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #222 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80774&action=edit Bug 19532: Extra fixes from Comment 68 This patch fixes the following: The db uppdate tries to insert after 'notes' in issuing rules, but this doesn't exist When placing recall I always get a warning: <p><strong>Warning</strong>: Your library does not allow recalls for x item types.</p> Cancelling recall from 'Recall history tab' doesn't work If patron has no recalls there is 'Patron has no current recalls' message at bottom of tabs on checkout and details tabs for patron When confirming a recall if the item is from another branch I get a transfer generated as well as confirming hold for recall Feature now checks if the recall branch is the same as the item holding branch when checking in item to determine if transfer is required On recalls awaiting pickup: need to update recall.borrower to recall.patron - causing internal server error When placing a recall - if I hit 'back' after confirming and confirm again I get a second recall on the same item Recalls queue should have waiting date information Recalls queue should have a way to hide cancelled, I would expect closed recalls to be hidden by default Recalls queue now hides old (cancelled/expired/finished) recalls by default and has a checkbox to toggle this When viewing a patrons account in the staff side we should see that a checkout has an active recall Checking out the recall doesn't seem to close the recall Added an 'F' status for finished/closed recalls Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Conflicts: Koha/Schema/Result/Borrower.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #223 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80775&action=edit Bug 19532 (follow-up) Update characterset for recalls table Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #224 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80776&action=edit Bug 19532 - Improve and refine recalls functionality Only allow 1 recall per item When checking in only check for holds if no reserves found Add a T/transferring status for recalls, only confirm them once arrived Improve message when checking in recall Fix clashing ids on recall-history Check if patron can hold item before allowing recall Prevent multiple recalls when pressing back button Select/fill only active recall when issuing To test: 1 - Repeat major test plan - verify all points 2 - Attempt to place multiple recallsusing back button, should fail 3 - Set all item level holds to not allowed, should not be able to place recall 4 - Check-in recall at branch other than destination, should be in transit 5 - Confirm at correct branch, should send message and get expiration date etc. 6 - Return to another branch, should eb in transit again 7 - Play with circ rules and verify only allowed patrons can place recall Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #225 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80777&action=edit Bug 19532 - Fixes to stop transfer recall modal from being displayed incorrectly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #226 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80778&action=edit Bug 19532 - Recalls for Course Reserves. This ptach fixes the 'Template process error Koha::Item->avail_for_recall' which is thrown when loading a Course pgae in opac-course-details.pl with course reserves which are currently issued. It also allows recalls to be placed from Course reserves Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #227 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80779&action=edit Bug 19532 - Fix for recall OPAC confirmation failing when recall circ rule is empty Sponsored-BY: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #228 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80780&action=edit Bug 19532 - Stopping an recalled item currently awaiting pickup from being able to be checked out to patrons other than the recall requester. Test plan: 1. Ensure 'UseRecalls' sypref is enabled and you have inputted values for recalls fields in the circulation rules (Administration->Circulation and fines rules) 2. Check item out to patron 1 3. Log into the OPAC as patron 2 and place a recall on the checked out item 4. Return the item and confirm the recall 5. In the staff client go to Circulation->Recalls queue, notice the recall has a status of 'Ready for pickup' 6. Try issuing the item to patron 3 and notice without this patch applied you can issue a recall awaiting pickup to a patron who did not place the recall. 7. Apply patch 8. Restart memcached and plack 9. Using a new item repeat steps 1,2,3,4,5,6 and notice you get a yellow message displayed stating: 'This item is awaiting pickup by another patron who recalled it.' The issuing has not taken place to a patron who is not the patron who placed the recall as the item is awaiting pickup by the recall requester. 10. Issue the item to patron 2 and notice the issuing takes place successfully Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #229 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80781&action=edit Bug 19532 - Make the Recall confirmation popup appear everytime a recalled item is put through returns until it is checked out to recall requester Previously the confirm recall popup was only displayed the first time the recalled item was out through returns. However it is useful for the Confirm recall popup to appear if the item is put through the returns multiple times due to library staff being interrupted. This ensures library staff are informed that the item has been recalled. Test plan: 1. Ensure 'UseRecalls' sypref is enabled and you have inputted values for recalls fields in the circulation rules (Administration->Circulation and fines rules) 2. Check item out to patron 1 3. Log into the OPAC as patron 2 and place a recall on the checked out item 4. Return the item and notice the 'Confirm recall' popup appears. Click confirm 5. Now check the item in again and notice the popup is not displayed this time. 6. Apply this patch 7. Restart memcached and plack 8. Using a new item repeat steps 2,3,4,5 and notice in step 5 the 'Confirm recall' popup is displayed this time. Click 'Confirm' 9. Check the item out to patron 2 10. Return the item and notice no popup is displayed. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #230 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80782&action=edit Bug 19532 - New RECALL_REQUESTER_DET notice and print option on confirm recall popup This patch adds a new notice RECALL_REQUESTER_DET which like HOLD_SLIP outlines borrower and item information so the item can be put aside for the requester. This patch also adds a 'Print and confirm' button to the 'Confirm recall' popup that appears when returning a recalled item. This functionality works the same as the 'Print and confirm' functionality for the Hold slip: A print modal popup will appear for the user to choose print settings, and choose to print or cancel. Test plan: 1. Ensure 'UseRecalls' sypref is enabled and you have inputted values for recalls fields in the circulation rules (Administration->Circulation and fines rules) 2. Check item out to patron 1 3. Log into the OPAC as patron 2 and place a recall on the checked out item 4. Return the item in the staff client 5. Notice there are only two buttons on the 'Confirm recall' popup which appears: 'Confirm' and 'Cancel' 6. Apply patch, run updatedatabase.pl (as there is a SQL atomicupdate file to be run), and restart memcached and plack 7. Using a new item repeat steps 2,3 8. In a new tab, in the staff client go to Circulation->Recalls queue, and notice the recall has a status of 'Requested' 8. Back in your first tab return the item and notice that a new button 'Print and confirm' is on the 'Confirm recall' popup. Select this button and notice two new popup windows appear: Browsers print window, and a window showing what the notice to be print looks like. 9. If you have a printer available print the notice. Otherwise you can look at what the notice would look like in the notice window, observing the notice outlines the following information: * Current date and time * Recall pickup branch * Borrowers first name and surname * Borrowers cardnumber, phonenumber, address, address2, city, zipcode, email * Recalled item title, author, barcode, callnumber. * Recall waiting date, and recall notes Some of these values will not be displayed on the notice if they are not set. For example the patron may not have set an address, or email. 10. After either printing the notice, or selecting 'Cancel' in the print window. Go back to your second tab and refresh the page and notice the status of the recall has changed to 'Ready for pickup' this shows the 'Print and confirm' button does actually confirm the recall. 11. Making sure the changes implemented in the previous commit (Bug 19532 - Make the Recall confirmation popup appear everytime a recalled item is put through returns) still work. Try returning the item again and notice the 'Confirm recall' popup with the 'Print and confirm' button is displayed again and you can choose to print the notice again if you want. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #231 from Alex Buckley <alexbuckley@catalyst.net.nz> --- All attached. I just tested and all commits apply cleanly on master as of 18 oct 2018. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #232 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Just a note that I will be attaching a few more additional patches to this bug report in the next hour or so. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #233 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80783&action=edit Bug 19532: Fixing Internal Server Error thrown on C4/Circulation.pm Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #234 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80784&action=edit Bug 19532: Implemented check if recall status equals 'R' before recall popup is shown This stops the 'confirm recall' popup message being displayed upon item return when the item has a recall with any status other than 'R' (recalled). Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #235 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80785&action=edit Bug 19532: Added conditional to check the recall has a status = 'W' before setting it to closed This solves a bug I found that if the same borrower number and itemnumber combination occur more than once in the recalls database table then when the item is checked out to the patron who recalled the item then the recall is not updated to have a status of closed. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #236 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80786&action=edit Bug 19532: Fixed display of recall buttons on opac-course-details.pl Recall button now displayed on items in opac-course-details.pl which are issued to another user. No internal server error being thrown on courses with issued course reserves. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #237 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80787&action=edit Bug 19532: Stopping recalls awaiting pickup to be issued to patrons other than the patron who recalled. Also fixed the display of item status in the holdings table on detail.pl on staff client so it doesn't say an item has been recalled when the recall has the status of 'F' (fulfilled) or 'C' (cancelled) Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #238 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80788&action=edit Bug 19532: Amended the detail.pl call to retrieve recalls so now it retrieves recalls with the status of 'R' or 'W' This means the 'Item recalled by' text is displayed in the holdings table in detail.pl for items with a recall with the status of recalled or waiting. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #239 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80789&action=edit Bug 19532: Stopping recalled items (recall status='R') from being renewed Test plan: 1. Check out an item to a borrower and note the due date 2. Recall the item and note the updated due date 3. Try renewing the item and notice you can't. A message appears telling you the item has been recalled and cannot be renewed. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #240 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80793&action=edit Bug 19532: Fixed Internal Server error thrown upon returning recalled item Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #241 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi all I've added the additional patches now. All patches apply cleanly on master as of 18th of Oct 2018. I am setting this to 'Needs signoff'. Just a note I have noticed some DB errors (e.g. when paying fees on paycollect.pl, and upon returning items). I found from using git bisect these errors were being caused by the regressions introduced by one of the patches on bug 20521: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73683&action=diff You may have also seen the emails regarding bug 20521 in the Koha-devel mailing list. I've filed another bug report for the DB error on paycollect.pl - Bug 21593 (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21593) - which Nick Clements has just attached a fix for. So in short if you experience DB errors during testing they may be due to 20521, not neccessarily recalls. Cheers, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #242 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 80878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80878&action=edit Bug 19532: Fix t/db_dependent/Koha/Recalls.t Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #243 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi all I have gone through and rebased again and will be attaching the rebased patches now. I will also be adding further enhancement patches. Apologies for the email deluge. Cheers, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80878|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80793|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80789|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80788|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80787|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80786|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80785|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80784|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80783|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80782|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80781|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80780|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80779|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80778|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80777|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80776|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80775|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80774|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80773|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80772|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80771|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80770|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80769|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80768|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80767|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80766|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80765|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80764|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80763|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78776|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78775|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78774|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78773|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78772|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78770|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78768|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78766|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78765|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78763|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #244 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81204&action=edit Bug 19532: Circulation rules Adding 3 new rules and columns to issuingrules - recall_due_date_interval - recall_overdue_fine - recall_shelf_time Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #245 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81205&action=edit Bug 19532: Recall an item in OPAC This patch: - adds the 'Recall' button to the item on it's detail page - adds ability to place a recall - the recall is stored in the recalls table - the due date for the checkout is updated to whatever has been set in the issuing rule under recall_due_date_interval - error messages for if the user isn't logged in, the user tries to place a recall on an item they have already recalled, or if storing the recall in the db fails for any reason Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #246 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81206&action=edit Bug 19532: Cancel recall and see recalls in OPAC This patch adds ability for user to cancel a recall They can also see their recalls in the user summary Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #247 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81207&action=edit Bug 19532: Show recalls on intranet side This patch - adds Recall tab to the Check out section of member account, and to the Details section of member account - Functionality to cancel recalls on staff side - Fixing cancel on OPAC side (before I was deleting the whole recall instead of cancelling) - Fixing validation when checking whether a recall can be placed on an item that has been recalled by this borrower before. If the old recall is expired or cancelled then they can make a recall again. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #248 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81208&action=edit Bug 19532: Fixing broken OPAC recalls table Forgot to add <tr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #249 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81209&action=edit Bug 19532: recalls history this patch - adds recalls history (similar to holds history) to OPAC and intranet - edits the tables in opac-user.pl (OPAC), moremember.pl and circulation.pl (staff) so that it only shows active recalls (recalls that have been requested or are waiting) - some extra datatables fixes Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #250 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81210&action=edit Bug 19532: Recalls queue This patch adds a recalls queue page to the circulation reports You can see all recalls made in the system, who requested them, their status and other relevant info. you can cancel individual or multiple recalls. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #251 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81211&action=edit Bug 19532: Overdue recalls report Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #252 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81212&action=edit Bug 19532: Recalls awaiting pickup report this patch adds reports for all recalls awaiting pickup, and recalls that have been waiting more than X days. a syspref, RecallsMaxPickUpDelay, is added to give a general max shelf time for recalls Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #253 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81213&action=edit Bug 19532: Only recall items checked out by other users ... shouldn't be able to recall items that are currently checked out by yourself. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #254 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81214&action=edit Bug 19532: UseRecalls syspref This patch adds a syspref to control the usability of the recalls feature Test the following: Staff side /includes/circ-menu.inc /includes/circ-nav.inc /includes/members-menu.inc /admin/preferences/circulation.pref /circ/circulation-home.tt /circ/circulation.tt /circ/recalls_overdue.tt /circ/recalls_queue.tt /circ/recalls_waiting.tt /members/moremember.tt /members/recallshistory.tt OPAC /includes/usermenu.inc /opac-recall.tt /opac-recalls.tt /opac-user.tt /members/recallshistory.pl /opac/opac-detail.pl Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #255 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81215&action=edit Bug 19532: Recall pop up when checking in an item When checking in an item on the staff side, the staff member will see a pop up if there is a recall attached to that item. From here, they can confirm the recall, setting the status to 'Waiting' and updating the waitingdate. The item will still be checked in. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #256 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81216&action=edit Bug 19532: Send notice to user to return a recalled item When the recall is placed in the OPAC, a RETURN_RECALLED_ITEM notice is sent to the user who has the item checked out, with the updated due date. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #257 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81217&action=edit Bug 19532: Send notice to user to pickup recalled returned item Send a PICKUP_RECALLED_ITEM notice to the user who requested a recall when the item is checked in. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #258 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81218&action=edit Bug 19532: Flagging recall as 'old' when expired or cancelled Set 'old' flag to 1 if cancelling or expiring a recall Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #259 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81219&action=edit Bug 19532: Cronjob to check for overdue recalls This patch adds a check to the overdue_notices cronjob, so if any of the overdue issues are also recalls, the status will be set to O (overdue) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #260 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81220&action=edit Bug 19532: Tests for Koha/Recalls Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #261 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81221&action=edit Bug 19532: Nice message if no recalls for opac recalls history https://bugs.koha-community.org/show_bug.cgi?id=19523 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #262 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81222&action=edit Bug 19532: POD fix, renaming methods Tomas's comments: - renaming 'Class methods' to 'internal methods' - renaming 'borrower' and 'branch' methods to 'patron' and 'library' other comments are out of date with current patches and do not need to be actioned when testing, confirm all data still shows as expected and nothing is broken Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #263 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81223&action=edit Bug 19532: Extra fixes This patch addresses some of Liz's comments in Comment 37 - shows new due date on opac-recall.pl when the recall is requested - shows new due date on opac-recalls.pl recalls history - shows new due date on circ/recalls_queue.pl - syspref is default off - recalls tab on catalogue/detail.pl - show that there is a recall on an item on catalogue/detail.pl Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #264 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81224&action=edit Bug 19532: Notices for recalls The notices: -RETURN_RECALLED_ITEM -PICKUP_RECALLED_ITEM have been created and added to sample_notices.sql Changed tools/letter.pl to use recalls table Added notices to translated installers https://bugs.koha-community.org/show_bug.cgi?id=19523 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #265 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81225&action=edit Bug 19532: Extra fixes from Comment 68 This patch fixes the following: The db uppdate tries to insert after 'notes' in issuing rules, but this doesn't exist When placing recall I always get a warning: <p><strong>Warning</strong>: Your library does not allow recalls for x item types.</p> Cancelling recall from 'Recall history tab' doesn't work If patron has no recalls there is 'Patron has no current recalls' message at bottom of tabs on checkout and details tabs for patron When confirming a recall if the item is from another branch I get a transfer generated as well as confirming hold for recall Feature now checks if the recall branch is the same as the item holding branch when checking in item to determine if transfer is required On recalls awaiting pickup: need to update recall.borrower to recall.patron - causing internal server error When placing a recall - if I hit 'back' after confirming and confirm again I get a second recall on the same item Recalls queue should have waiting date information Recalls queue should have a way to hide cancelled, I would expect closed recalls to be hidden by default Recalls queue now hides old (cancelled/expired/finished) recalls by default and has a checkbox to toggle this When viewing a patrons account in the staff side we should see that a checkout has an active recall Checking out the recall doesn't seem to close the recall Added an 'F' status for finished/closed recalls Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Conflicts: Koha/Schema/Result/Borrower.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #266 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81226&action=edit Bug 19532 (follow-up) Update characterset for recalls table Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #267 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81227&action=edit Bug 19532 - Improve and refine recalls functionality Only allow 1 recall per item When checking in only check for holds if no reserves found Add a T/transferring status for recalls, only confirm them once arrived Improve message when checking in recall Fix clashing ids on recall-history Check if patron can hold item before allowing recall Prevent multiple recalls when pressing back button Select/fill only active recall when issuing To test: 1 - Repeat major test plan - verify all points 2 - Attempt to place multiple recallsusing back button, should fail 3 - Set all item level holds to not allowed, should not be able to place recall 4 - Check-in recall at branch other than destination, should be in transit 5 - Confirm at correct branch, should send message and get expiration date etc. 6 - Return to another branch, should eb in transit again 7 - Play with circ rules and verify only allowed patrons can place recall Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #268 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81228&action=edit Bug 19532 - Fixes to stop transfer recall modal from being displayed incorrectly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #269 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81229&action=edit Bug 19532 - Recalls for Course Reserves. This ptach fixes the 'Template process error Koha::Item->avail_for_recall' which is thrown when loading a Course pgae in opac-course-details.pl with course reserves which are currently issued. It also allows recalls to be placed from Course reserves Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #270 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81230&action=edit Bug 19532 - Fix for recall OPAC confirmation failing when recall circ rule is empty Sponsored-BY: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #271 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81231&action=edit Bug 19532 - Stopping an recalled item currently awaiting pickup from being able to be checked out to patrons other than the recall requester. Test plan: 1. Ensure 'UseRecalls' sypref is enabled and you have inputted values for recalls fields in the circulation rules (Administration->Circulation and fines rules) 2. Check item out to patron 1 3. Log into the OPAC as patron 2 and place a recall on the checked out item 4. Return the item and confirm the recall 5. In the staff client go to Circulation->Recalls queue, notice the recall has a status of 'Ready for pickup' 6. Try issuing the item to patron 3 and notice without this patch applied you can issue a recall awaiting pickup to a patron who did not place the recall. 7. Apply patch 8. Restart memcached and plack 9. Using a new item repeat steps 1,2,3,4,5,6 and notice you get a yellow message displayed stating: 'This item is awaiting pickup by another patron who recalled it.' The issuing has not taken place to a patron who is not the patron who placed the recall as the item is awaiting pickup by the recall requester. 10. Issue the item to patron 2 and notice the issuing takes place successfully Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #272 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81232&action=edit Bug 19532 - Make the Recall confirmation popup appear everytime a recalled item is put through returns until it is checked out to recall requester Previously the confirm recall popup was only displayed the first time the recalled item was out through returns. However it is useful for the Confirm recall popup to appear if the item is put through the returns multiple times due to library staff being interrupted. This ensures library staff are informed that the item has been recalled. Test plan: 1. Ensure 'UseRecalls' sypref is enabled and you have inputted values for recalls fields in the circulation rules (Administration->Circulation and fines rules) 2. Check item out to patron 1 3. Log into the OPAC as patron 2 and place a recall on the checked out item 4. Return the item and notice the 'Confirm recall' popup appears. Click confirm 5. Now check the item in again and notice the popup is not displayed this time. 6. Apply this patch 7. Restart memcached and plack 8. Using a new item repeat steps 2,3,4,5 and notice in step 5 the 'Confirm recall' popup is displayed this time. Click 'Confirm' 9. Check the item out to patron 2 10. Return the item and notice no popup is displayed. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #273 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81233&action=edit Bug 19532 - New RECALL_REQUESTER_DET notice and print option on confirm recall popup This patch adds a new notice RECALL_REQUESTER_DET which like HOLD_SLIP outlines borrower and item information so the item can be put aside for the requester. This patch also adds a 'Print and confirm' button to the 'Confirm recall' popup that appears when returning a recalled item. This functionality works the same as the 'Print and confirm' functionality for the Hold slip: A print modal popup will appear for the user to choose print settings, and choose to print or cancel. Test plan: 1. Ensure 'UseRecalls' sypref is enabled and you have inputted values for recalls fields in the circulation rules (Administration->Circulation and fines rules) 2. Check item out to patron 1 3. Log into the OPAC as patron 2 and place a recall on the checked out item 4. Return the item in the staff client 5. Notice there are only two buttons on the 'Confirm recall' popup which appears: 'Confirm' and 'Cancel' 6. Apply patch, run updatedatabase.pl (as there is a SQL atomicupdate file to be run), and restart memcached and plack 7. Using a new item repeat steps 2,3 8. In a new tab, in the staff client go to Circulation->Recalls queue, and notice the recall has a status of 'Requested' 8. Back in your first tab return the item and notice that a new button 'Print and confirm' is on the 'Confirm recall' popup. Select this button and notice two new popup windows appear: Browsers print window, and a window showing what the notice to be print looks like. 9. If you have a printer available print the notice. Otherwise you can look at what the notice would look like in the notice window, observing the notice outlines the following information: * Current date and time * Recall pickup branch * Borrowers first name and surname * Borrowers cardnumber, phonenumber, address, address2, city, zipcode, email * Recalled item title, author, barcode, callnumber. * Recall waiting date, and recall notes Some of these values will not be displayed on the notice if they are not set. For example the patron may not have set an address, or email. 10. After either printing the notice, or selecting 'Cancel' in the print window. Go back to your second tab and refresh the page and notice the status of the recall has changed to 'Ready for pickup' this shows the 'Print and confirm' button does actually confirm the recall. 11. Making sure the changes implemented in the previous commit (Bug 19532 - Make the Recall confirmation popup appear everytime a recalled item is put through returns) still work. Try returning the item again and notice the 'Confirm recall' popup with the 'Print and confirm' button is displayed again and you can choose to print the notice again if you want. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #274 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81234&action=edit Bug 19532: Fixing Internal Server Error thrown on C4/Circulation.pm Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #275 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81235&action=edit Bug 19532: Implemented check if recall status equals 'R' before recall popup is shown This stops the 'confirm recall' popup message being displayed upon item return when the item has a recall with any status other than 'R' (recalled). Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #276 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81236&action=edit Bug 19532: Added conditional to check the recall has a status = 'W' before setting it to closed This solves a bug I found that if the same borrower number and itemnumber combination occur more than once in the recalls database table then when the item is checked out to the patron who recalled the item then the recall is not updated to have a status of closed. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #277 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81237&action=edit Bug 19532: Fixed display of recall buttons on opac-course-details.pl Recall button now displayed on items in opac-course-details.pl which are issued to another user. No internal server error being thrown on courses with issued course reserves. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #278 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81238&action=edit Bug 19532: Stopping recalls awaiting pickup to be issued to patrons other than the patron who recalled. Also fixed the display of item status in the holdings table on detail.pl on staff client so it doesn't say an item has been recalled when the recall has the status of 'F' (fulfilled) or 'C' (cancelled) Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #279 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81239&action=edit Bug 19532: Amended the detail.pl call to retrieve recalls so now it retrieves recalls with the status of 'R' or 'W' This means the 'Item recalled by' text is displayed in the holdings table in detail.pl for items with a recall with the status of recalled or waiting. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #280 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81240&action=edit Bug 19532: Stopping recalled items (recall status='R') from being renewed Test plan: 1. Check out an item to a borrower and note the due date 2. Recall the item and note the updated due date 3. Try renewing the item and notice you can't. A message appears telling you the item has been recalled and cannot be renewed. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #281 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81241&action=edit Bug 19532: Fixed Internal Server error thrown upon returning recalled item Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #282 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81242&action=edit Bug 19532: Fix t/db_dependent/Koha/Recalls.t Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #283 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81243&action=edit Bug 19532: Stop item status='Available' for waiting recalls This patch alters the display of the item status in the staff client and OPAC so items which are waiting recalls are not shown in these interfaces with the status of 'available'. Waiting recalls are not available they are only available to the patron who recalled them. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #284 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81244&action=edit Bug 19532: Amended C4/Circulation->CanBookBeIssued() This function now checks for waiting recalls before checking for reserves on an item. If a recall record does exist and it was placed by the same borrower who is trying to check out the item then no check for reserves takes place because the waiting recall takes precedence. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #285 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81245&action=edit Bug 19532: Fixed missing variable declaration error Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #286 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81246&action=edit Bug 19532: Added missing conditional check so now item availability for recalled items on OPAC search results page is corrected On the OPAC now if an item is a waiting recall then it is shown as 'On reserve' rather than available. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #287 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81247&action=edit Bug 19532: Added ability to set Recall due date interval, and Recall pickup period to hours Previously you could only set a number of days a recalled item has to be returned (Recall due date interval (days)) and a number of days available for a recalled item to be picked up. For academic libraries which often loan high-demand items out by a certain number of hours being able to set the number of hours a borrower has to return a recalled item and for the recaller to pickup the waiting recall is important. This patch implement a check in C4::Overdue->CalcFine() if item is recalled. If the item has been recalled and is past the due date then use the recall_overdue_fine to calculate the appropriate fine to charge the patron, otherwise use the fines value in the issuingrules table Also implemented atomicupdate to change recalls waitingdate and expirationdate to datetime datatypes with associated template changes in the recalls reports to display the date and time of these recall values. Test plan: 1. Apply all other patches on bug 19532 (except this patch) 2. Set a fine charge interval period (if you do not have this field set in the circ rule then the fine will not be applied). 3. Set the 'Unit' of the circ rule to 'hours', 'Recall due date interval' = 1, recall overdue fune amount= 1, recall pickup period=1 4. Check out an item to borrower A and recall it in the OPAC by borrower B 5. In the database manually change the issues.date_due to 1 hour before the current time 6. From the Koha shell run './misc/cronjobs/fines.pl' 7. Notice the fine of 1 has been applied to the borrower for being 1 hour late in returning the recall 8. Return the item and confirm the recall. Manually change the waiting date to more than 1 hour before the current time and repeat step 6 running overdue_notices.pl 9. Notice the recall is overdue now Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #288 from Alex Buckley <alexbuckley@catalyst.net.nz> --- All done, and I have attached 6 additional patches fixing a few bugs and introducing new features such as the ability to set the Recall due date interval and Recall pickup period in the unit of hours (previously these fields were only in days). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #289 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- sha1 conflicts half way through applying.. then when attempting a patch -p1 I get patch ends i middle of file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81247|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81246|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81245|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81244|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81243|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81242|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81241|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81240|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81239|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81238|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81237|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81236|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81235|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81234|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81233|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81232|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81231|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81230|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81229|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81228|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81227|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81226|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81225|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81224|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81223|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81222|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81221|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81220|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81219|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81218|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81217|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81216|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81215|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81214|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81213|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81212|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81211|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81210|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81209|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81208|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81207|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81206|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81205|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81204|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78761|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78759|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78757|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78755|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #290 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81547&action=edit Bug 19532: Database updates Adding the recalls table and the old_recalls table. Sponsored-by: Catalyst IT Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #291 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81548&action=edit Bug 19532: Module files for Recall and OldRecall Koha/Recall.pm Koha/Recalls.pm Koha/Old/Recall.pm Koha/Old/Recalls.pm and the schema files for Recall and OldRecall. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #292 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81549&action=edit Bug 19532: Some DB fixes Removing the old_recalls table, as suggested in Comment 5 Renaming 'found' column to 'status' Adding 'old' column Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #293 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81550&action=edit Bug 19532: Some module fixes Removing files related to OldRecall Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #294 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81551&action=edit Bug 19532: Circulation rules Adding 3 new rules and columns to issuingrules - recall_due_date_interval - recall_overdue_fine - recall_shelf_time Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #295 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81552&action=edit Bug 19532: Recall an item in OPAC This patch: - adds the 'Recall' button to the item on it's detail page - adds ability to place a recall - the recall is stored in the recalls table - the due date for the checkout is updated to whatever has been set in the issuing rule under recall_due_date_interval - error messages for if the user isn't logged in, the user tries to place a recall on an item they have already recalled, or if storing the recall in the db fails for any reason Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #296 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81553&action=edit Bug 19532: Cancel recall and see recalls in OPAC This patch adds ability for user to cancel a recall They can also see their recalls in the user summary Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #297 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81554&action=edit Bug 19532: Show recalls on intranet side This patch - adds Recall tab to the Check out section of member account, and to the Details section of member account - Functionality to cancel recalls on staff side - Fixing cancel on OPAC side (before I was deleting the whole recall instead of cancelling) - Fixing validation when checking whether a recall can be placed on an item that has been recalled by this borrower before. If the old recall is expired or cancelled then they can make a recall again. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #298 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81555&action=edit Bug 19532: Fixing broken OPAC recalls table Forgot to add <tr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #299 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81556&action=edit Bug 19532: recalls history this patch - adds recalls history (similar to holds history) to OPAC and intranet - edits the tables in opac-user.pl (OPAC), moremember.pl and circulation.pl (staff) so that it only shows active recalls (recalls that have been requested or are waiting) - some extra datatables fixes Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #300 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81557&action=edit Bug 19532: Recalls queue This patch adds a recalls queue page to the circulation reports You can see all recalls made in the system, who requested them, their status and other relevant info. you can cancel individual or multiple recalls. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #301 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81558&action=edit Bug 19532: Overdue recalls report Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #302 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81559&action=edit Bug 19532: Recalls awaiting pickup report this patch adds reports for all recalls awaiting pickup, and recalls that have been waiting more than X days. a syspref, RecallsMaxPickUpDelay, is added to give a general max shelf time for recalls Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #303 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81560&action=edit Bug 19532: Only recall items checked out by other users ... shouldn't be able to recall items that are currently checked out by yourself. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #304 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81561&action=edit Bug 19532: UseRecalls syspref This patch adds a syspref to control the usability of the recalls feature Test the following: Staff side /includes/circ-menu.inc /includes/circ-nav.inc /includes/members-menu.inc /admin/preferences/circulation.pref /circ/circulation-home.tt /circ/circulation.tt /circ/recalls_overdue.tt /circ/recalls_queue.tt /circ/recalls_waiting.tt /members/moremember.tt /members/recallshistory.tt OPAC /includes/usermenu.inc /opac-recall.tt /opac-recalls.tt /opac-user.tt /members/recallshistory.pl /opac/opac-detail.pl Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #305 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81562&action=edit Bug 19532: Recall pop up when checking in an item When checking in an item on the staff side, the staff member will see a pop up if there is a recall attached to that item. From here, they can confirm the recall, setting the status to 'Waiting' and updating the waitingdate. The item will still be checked in. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #306 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81563&action=edit Bug 19532: Send notice to user to return a recalled item When the recall is placed in the OPAC, a RETURN_RECALLED_ITEM notice is sent to the user who has the item checked out, with the updated due date. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #307 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81564&action=edit Bug 19532: Send notice to user to pickup recalled returned item Send a PICKUP_RECALLED_ITEM notice to the user who requested a recall when the item is checked in. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #308 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81565&action=edit Bug 19532: Flagging recall as 'old' when expired or cancelled Set 'old' flag to 1 if cancelling or expiring a recall Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #309 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81566&action=edit Bug 19532: Cronjob to check for overdue recalls This patch adds a check to the overdue_notices cronjob, so if any of the overdue issues are also recalls, the status will be set to O (overdue) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #310 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81567&action=edit Bug 19532: Tests for Koha/Recalls Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #311 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81568&action=edit Bug 19532: Nice message if no recalls for opac recalls history https://bugs.koha-community.org/show_bug.cgi?id=19523 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #312 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81569&action=edit Bug 19532: POD fix, renaming methods Tomas's comments: - renaming 'Class methods' to 'internal methods' - renaming 'borrower' and 'branch' methods to 'patron' and 'library' other comments are out of date with current patches and do not need to be actioned when testing, confirm all data still shows as expected and nothing is broken Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #313 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81583&action=edit Bug 19532: Extra fixes This patch addresses some of Liz's comments in Comment 37 - shows new due date on opac-recall.pl when the recall is requested - shows new due date on opac-recalls.pl recalls history - shows new due date on circ/recalls_queue.pl - syspref is default off - recalls tab on catalogue/detail.pl - show that there is a recall on an item on catalogue/detail.pl Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #314 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81584&action=edit Bug 19532: Notices for recalls The notices: -RETURN_RECALLED_ITEM -PICKUP_RECALLED_ITEM have been created and added to sample_notices.sql Changed tools/letter.pl to use recalls table Added notices to translated installers https://bugs.koha-community.org/show_bug.cgi?id=19523 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #315 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81585&action=edit Bug 19532: Extra fixes from Comment 68 This patch fixes the following: The db uppdate tries to insert after 'notes' in issuing rules, but this doesn't exist When placing recall I always get a warning: <p><strong>Warning</strong>: Your library does not allow recalls for x item types.</p> Cancelling recall from 'Recall history tab' doesn't work If patron has no recalls there is 'Patron has no current recalls' message at bottom of tabs on checkout and details tabs for patron When confirming a recall if the item is from another branch I get a transfer generated as well as confirming hold for recall Feature now checks if the recall branch is the same as the item holding branch when checking in item to determine if transfer is required On recalls awaiting pickup: need to update recall.borrower to recall.patron - causing internal server error When placing a recall - if I hit 'back' after confirming and confirm again I get a second recall on the same item Recalls queue should have waiting date information Recalls queue should have a way to hide cancelled, I would expect closed recalls to be hidden by default Recalls queue now hides old (cancelled/expired/finished) recalls by default and has a checkbox to toggle this When viewing a patrons account in the staff side we should see that a checkout has an active recall Checking out the recall doesn't seem to close the recall Added an 'F' status for finished/closed recalls Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Conflicts: Koha/Schema/Result/Borrower.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #316 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81586&action=edit Bug 19532 (follow-up) Update characterset for recalls table Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #317 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81587&action=edit Bug 19532 - Improve and refine recalls functionality Only allow 1 recall per item When checking in only check for holds if no reserves found Add a T/transferring status for recalls, only confirm them once arrived Improve message when checking in recall Fix clashing ids on recall-history Check if patron can hold item before allowing recall Prevent multiple recalls when pressing back button Select/fill only active recall when issuing To test: 1 - Repeat major test plan - verify all points 2 - Attempt to place multiple recallsusing back button, should fail 3 - Set all item level holds to not allowed, should not be able to place recall 4 - Check-in recall at branch other than destination, should be in transit 5 - Confirm at correct branch, should send message and get expiration date etc. 6 - Return to another branch, should eb in transit again 7 - Play with circ rules and verify only allowed patrons can place recall Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #318 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81588&action=edit Bug 19532: Fixes and enhancements to recalls This implements the following fixes and enhancements: 1. Stopping a waiting recall from being able to be checked out to patrons other than the patron who placed the recall 2. Make the Recall confirmation popup appear everytime a recalled item is put through returns until it is checked out to recall requester 3. Introduce a new notice RECALL_REQUESTER_DET which outlines borrower and item information so the item can be put aside 4. Stop recalled items from being renewed 5. Stop display of 'Available' for waiting recalls 6. Check if recalls exist on an item before checking for reserves 7. Added ability to set Recall due date interval, and Recall pickup period in hours 8. Fix the 'Template process error Koha::Item->avail_for_recall' thrown on course page where a course reserve is currently issued Test plan: 1. Enable the UseRecalls syspref 2. Go to Circulation and Fines Rules. Put some numbers in the recalls fields (recall due date interval, recall overdue fine amount, recall pickup period) - the unit of recall due date interval and recall pickup period is either days or hours as set in the circ rule 'unit' field 3. Put a number in the RecallsMaxPickUpDelay syspref. This will be the default number of days or hours used if the recall pickup period isn't set in Step 2 4. Check out an item to a patron 5. Go to that item's detail page in the OPAC. Notice the holdings table says 'Checked out' 6. Log in to the OPAC with another patron and go back to that detail page. The holdings table should now have a Recall link next to the 'Checked out' text 7. Click the Recall button and confirm the Recall 8. Go to the user's opac summary and confirm there is now a Recalls tab, with the correct number of recalls (should be 1). 9. Test cancelling the recall by clicking Cancel. Confirm the recall has been cancelled. Repeat steps 6 and 7. 10. In the left navigation, there will also be a 'recalls history' tab. Click it. There should be a log, similar to reading history, with the cancelled recall and the new recall in it. Confirm all information is correct 11. Again, test cancelling the recall. Repeat steps 6 and 7. 12. In the staff interface, go to the logged in user's checkouts. Confirm you can see a new Recalls tab, with the active (not cancelled) recall in the table. Should be the same for the details tab also. 13. Test cancelling works for both of these again, and making new recalls again. 14. Check in the recalled item. You should see a pop up, asking to confirm the recall as waiting. Click confirm. 15. Go to the Circulation main page. You should see 3 new reports: recalls queue, overdue recalls and recalls awaiting pickup 16. Go to the recalls queue, confirm you can see an entire history of recalls at your library. Confirm cancel works when selecting checkboxes and clicking the multiple button. If you do this, you'll need to place the recall again and check the item in again 17. Go to recalls awaiting pickup. You should see the recall under the recalls waiting tab 18. in Mysql, set the waitingdate for your recall to be more than 'recall pickup period' days or hours (depends on what is set in the circ rule (unit) field) before present 19. Refresh the recalls awaiting pickup page. You should see the recall under the recalls waiting tab, and the recalls waiting more than X days/hours tab. 20. expire the recall. confirm this is expired by checking the recalls queue 21. place another recall, but do not check it in 22. in mysql, set the date_due of the checkout (issues table) to be at least 'recall due date interval' number of days or hours before today's date 23. run the overdue_notices.pl cronjob 24. go to the overdue recalls circ report and confirm your recall shows there 25. try cancelling the recall here also 26. in mysql, check the message_queue and confirm there have been the appropriate number of RETURN_RECALLED_ITEM and PICKUP_RECALLED_ITEM notices sent with the correct to and from addresses and other content 27. test t/db_dependent/Koha/Recalls.t 28. place another recall and check it in 29. Try checking the recall out to a different patron and confirm you are not able to check out a waiting recall to a different patron - This tests point #1 above 30. Check the same item in again and observe that the recall modal is displayed again and is displayed every time the item is checked in until the item is checked out to the patron who placed the recall - This tests point #2 above 31. Check the item in again and select the 'Print slip and confirm' and confirm the RECALL_REQUESTER_DET notice can be printed - This tests point #3 above 32. place a recall on an item and try to renew the item and confirm you are unable to renew recalled items - This tests point #4 above 33. Return the same item and confirm in the OPAC and staff client that the item is not shown as available - This tests point #5 above 34. Place a recall to one borrower then reserve the same item to a different borrower. Check the item in and confirm the recall modal is displayed not the reserve modal as recalls take precedence - This tests point #6 above 35. In circ and fine rules set a rules 'Fine charge interval period'=1 36. Set the 'Unit' of the circ rule to 'hours', 'Recall due date interval' = 1, 'Recall overdue fine amount'=1, 'Recall pickup period'=1 37. Check out an item to borrower A and recall it in the OPAC by borrower B 38. In the database manually change the issues.date_due to 1 hour before the current time 39. From the Koha shell run './misc/cronjobs/fines.pl' 40. Notice the fine of 1 has been applied to the borrower for being 1 hour late in returning the recall 41. Return the item and confirm the recall. Manually change the waiting date to more than 1 hour before the current time and run ./misc/cronjobs/overdue_notices.pl 42. Notice the recall is overdue now - Steps 35-42 test point #7 above 43. Enable 'UseCourseReserves' syspref 44. Check out a course reserve item to a borrower 45. In the OPAC navigate to the course page containing the issued course reserve and confirm the page loads successfully 46. Recall a course reserve and confirm the recall is successfully placed 47. Check in the recalled course reserve and confirm the recall - This tests point #8 above Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #319 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Rebased and re-attached to this bug report. Can you please re-test? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81588|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #320 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 81595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81595&action=edit Bug 19532: Fixes and enhancements to recalls This implements the following fixes and enhancements: * Stopping a waiting recall from being able to be checked out to patrons other than the patron who placed the recall * Make the Recall confirmation popup appear everytime a recalled item is put through returns until it is checked out to recall requester * Introduce a new notice RECALL_REQUESTER_DET which outlines borrower and item information so the item can be put aside * Stop recalled items from being renewed * Stop display of 'Available' for waiting recalls * Check if recalls exist on an item before checking for reserves * Added ability to set Recall due date interval, and Recall pickup period in hours * Fix the 'Template process error Koha::Item->avail_for_recall' thrown on course page where a course reserve is currently issued Test plan: 1. Repeat major test plan - verify all points 2. Place another recall and check it in 3. Try checking the recall out to a different patron and confirm you are not able to check out a waiting recall to a different patron 4. Check the same item in again and observe that the recall modal is displayed again and is displayed every time the item is checked in until the item is checked out to the patron who placed the recall 5. Check the item in again and select the 'Print slip and confirm' and confirm the RECALL_REQUESTER_DET notice can be printed 6. Place a recall on an item and try to renew the item and confirm you are unable to renew recalled items 7. Return the same item and confirm in the OPAC and staff client that the item is not shown as available 8. Place a recall to one borrower then reserve the same item to a different borrower. Check the item in and confirm the recall modal is displayed not the reserve modal as recalls take precedence 9. In circ and fine rules set a rules 'Fine charge interval period'=1 10. Set the 'Unit' of the circ rule to 'hours', 'Recall due date interval' = 1, 'Recall overdue fine amount'=1, 'Recall pickup period'=1 11. Check out an item to borrower A and recall it in the OPAC by borrower B 12. In the database manually change the issues.date_due to 1 hour before the current time 13. From the Koha shell run './misc/cronjobs/fines.pl' 14. Notice the fine of 1 has been applied to the borrower for being 1 hour late in returning the recall 15. Return the item and confirm the recall. Manually change the waiting date to more than 1 hour before the current time and run ./misc/cronjobs/overdue_notices.pl 16. Notice the recall is overdue now - Steps 9-16 test point #7 above 17. Enable 'UseCourseReserves' syspref 18. Check out a course reserve item to a borrower 19. In the OPAC navigate to the course page containing the issued course reserve and confirm the page loads successfully 20. Recall a course reserve and confirm recalls works for course reserves Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #321 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Applies now, thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #322 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81618&action=edit Bug 19532: (QA followup) Add missing TT filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #323 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm working on a number of QA followups.. to save the email spamming I'll upload the final set at the end of my work.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #324 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'll be keeping a github branch updated with my work: https://github.com/colinsc/koha/compare/master...PTFS-Europe:bug_19532_recal... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This new feature introduces release notes| |the ability for borrowers | |to place a recall on an | |item from the OPAC detail. | |Borrowers can see details | |of their requested recalls | |in the OPAC and can cancel | |the recall before it is | |returned. | | | |Librarians can | |view and administer the | |recalls in the Circulation | |interface of the staff | |client which displays a | |list of recalls, overdue | |recalls and recalls | |awaiting pickup. | | | |The | |amount of time the recalled | |item has to be returned and | |the amount of time it will | |wait for pickup can be set | |in circulation and fine | |rules in the unit of hours | |or days. | | | |After an item is | |recalled it cannot be | |renewed. When the item is | |returned the recall can be | |confirmed or cancelled. | | | |Recalls are marked as | |overdue by the | |overdue_notices.pl cronjob. Keywords|release-notes-needed | --- Comment #325 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Thanks Martin. I have added release notes to the bug report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81547|0 |1 is obsolete| | --- Comment #326 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81652&action=edit Bug 19532: Database updates Adding the recalls table and the old_recalls table. Sponsored-by: Catalyst IT Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81548|0 |1 is obsolete| | --- Comment #327 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81653&action=edit Bug 19532: Module files for Recall and OldRecall Koha/Recall.pm Koha/Recalls.pm Koha/Old/Recall.pm Koha/Old/Recalls.pm and the schema files for Recall and OldRecall. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81549|0 |1 is obsolete| | --- Comment #328 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81654&action=edit Bug 19532: Some DB fixes Removing the old_recalls table, as suggested in Comment 5 Renaming 'found' column to 'status' Adding 'old' column Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81550|0 |1 is obsolete| | --- Comment #329 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81655&action=edit Bug 19532: Some module fixes Removing files related to OldRecall Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81551|0 |1 is obsolete| | --- Comment #330 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81656&action=edit Bug 19532: Circulation rules Adding 3 new rules and columns to issuingrules - recall_due_date_interval - recall_overdue_fine - recall_shelf_time Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81552|0 |1 is obsolete| | --- Comment #331 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81657&action=edit Bug 19532: Recall an item in OPAC This patch: - adds the 'Recall' button to the item on it's detail page - adds ability to place a recall - the recall is stored in the recalls table - the due date for the checkout is updated to whatever has been set in the issuing rule under recall_due_date_interval - error messages for if the user isn't logged in, the user tries to place a recall on an item they have already recalled, or if storing the recall in the db fails for any reason Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81553|0 |1 is obsolete| | --- Comment #332 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81658&action=edit Bug 19532: Cancel recall and see recalls in OPAC This patch adds ability for user to cancel a recall They can also see their recalls in the user summary Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81554|0 |1 is obsolete| | --- Comment #333 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81659&action=edit Bug 19532: Show recalls on intranet side This patch - adds Recall tab to the Check out section of member account, and to the Details section of member account - Functionality to cancel recalls on staff side - Fixing cancel on OPAC side (before I was deleting the whole recall instead of cancelling) - Fixing validation when checking whether a recall can be placed on an item that has been recalled by this borrower before. If the old recall is expired or cancelled then they can make a recall again. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81555|0 |1 is obsolete| | --- Comment #334 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81660&action=edit Bug 19532: Fixing broken OPAC recalls table Forgot to add <tr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81556|0 |1 is obsolete| | --- Comment #335 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81661&action=edit Bug 19532: recalls history this patch - adds recalls history (similar to holds history) to OPAC and intranet - edits the tables in opac-user.pl (OPAC), moremember.pl and circulation.pl (staff) so that it only shows active recalls (recalls that have been requested or are waiting) - some extra datatables fixes Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81557|0 |1 is obsolete| | --- Comment #336 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81662&action=edit Bug 19532: Recalls queue This patch adds a recalls queue page to the circulation reports You can see all recalls made in the system, who requested them, their status and other relevant info. you can cancel individual or multiple recalls. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81558|0 |1 is obsolete| | --- Comment #337 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81663&action=edit Bug 19532: Overdue recalls report Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81559|0 |1 is obsolete| | --- Comment #338 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81664&action=edit Bug 19532: Recalls awaiting pickup report this patch adds reports for all recalls awaiting pickup, and recalls that have been waiting more than X days. a syspref, RecallsMaxPickUpDelay, is added to give a general max shelf time for recalls Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81560|0 |1 is obsolete| | --- Comment #339 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81665&action=edit Bug 19532: Only recall items checked out by other users ... shouldn't be able to recall items that are currently checked out by yourself. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81561|0 |1 is obsolete| | --- Comment #340 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81666&action=edit Bug 19532: UseRecalls syspref This patch adds a syspref to control the usability of the recalls feature Test the following: Staff side /includes/circ-menu.inc /includes/circ-nav.inc /includes/members-menu.inc /admin/preferences/circulation.pref /circ/circulation-home.tt /circ/circulation.tt /circ/recalls_overdue.tt /circ/recalls_queue.tt /circ/recalls_waiting.tt /members/moremember.tt /members/recallshistory.tt OPAC /includes/usermenu.inc /opac-recall.tt /opac-recalls.tt /opac-user.tt /members/recallshistory.pl /opac/opac-detail.pl Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81562|0 |1 is obsolete| | --- Comment #341 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81667&action=edit Bug 19532: Recall pop up when checking in an item When checking in an item on the staff side, the staff member will see a pop up if there is a recall attached to that item. From here, they can confirm the recall, setting the status to 'Waiting' and updating the waitingdate. The item will still be checked in. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81563|0 |1 is obsolete| | --- Comment #342 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81668&action=edit Bug 19532: Send notice to user to return a recalled item When the recall is placed in the OPAC, a RETURN_RECALLED_ITEM notice is sent to the user who has the item checked out, with the updated due date. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81564|0 |1 is obsolete| | --- Comment #343 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81669&action=edit Bug 19532: Send notice to user to pickup recalled returned item Send a PICKUP_RECALLED_ITEM notice to the user who requested a recall when the item is checked in. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81565|0 |1 is obsolete| | --- Comment #344 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81670&action=edit Bug 19532: Flagging recall as 'old' when expired or cancelled Set 'old' flag to 1 if cancelling or expiring a recall Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81566|0 |1 is obsolete| | --- Comment #345 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81671&action=edit Bug 19532: Cronjob to check for overdue recalls This patch adds a check to the overdue_notices cronjob, so if any of the overdue issues are also recalls, the status will be set to O (overdue) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81567|0 |1 is obsolete| | --- Comment #346 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81672&action=edit Bug 19532: Tests for Koha/Recalls Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81568|0 |1 is obsolete| | --- Comment #347 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81673&action=edit Bug 19532: Nice message if no recalls for opac recalls history https://bugs.koha-community.org/show_bug.cgi?id=19523 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81569|0 |1 is obsolete| | --- Comment #348 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81674&action=edit Bug 19532: POD fix, renaming methods Tomas's comments: - renaming 'Class methods' to 'internal methods' - renaming 'borrower' and 'branch' methods to 'patron' and 'library' other comments are out of date with current patches and do not need to be actioned when testing, confirm all data still shows as expected and nothing is broken Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81583|0 |1 is obsolete| | --- Comment #349 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81675&action=edit Bug 19532: Extra fixes This patch addresses some of Liz's comments in Comment 37 - shows new due date on opac-recall.pl when the recall is requested - shows new due date on opac-recalls.pl recalls history - shows new due date on circ/recalls_queue.pl - syspref is default off - recalls tab on catalogue/detail.pl - show that there is a recall on an item on catalogue/detail.pl Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81584|0 |1 is obsolete| | --- Comment #350 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81676&action=edit Bug 19532: Notices for recalls The notices: -RETURN_RECALLED_ITEM -PICKUP_RECALLED_ITEM have been created and added to sample_notices.sql Changed tools/letter.pl to use recalls table Added notices to translated installers https://bugs.koha-community.org/show_bug.cgi?id=19523 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81585|0 |1 is obsolete| | --- Comment #351 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81677&action=edit Bug 19532: Extra fixes from Comment 68 This patch fixes the following: The db uppdate tries to insert after 'notes' in issuing rules, but this doesn't exist When placing recall I always get a warning: <p><strong>Warning</strong>: Your library does not allow recalls for x item types.</p> Cancelling recall from 'Recall history tab' doesn't work If patron has no recalls there is 'Patron has no current recalls' message at bottom of tabs on checkout and details tabs for patron When confirming a recall if the item is from another branch I get a transfer generated as well as confirming hold for recall Feature now checks if the recall branch is the same as the item holding branch when checking in item to determine if transfer is required On recalls awaiting pickup: need to update recall.borrower to recall.patron - causing internal server error When placing a recall - if I hit 'back' after confirming and confirm again I get a second recall on the same item Recalls queue should have waiting date information Recalls queue should have a way to hide cancelled, I would expect closed recalls to be hidden by default Recalls queue now hides old (cancelled/expired/finished) recalls by default and has a checkbox to toggle this When viewing a patrons account in the staff side we should see that a checkout has an active recall Checking out the recall doesn't seem to close the recall Added an 'F' status for finished/closed recalls Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Conflicts: Koha/Schema/Result/Borrower.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #352 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81678&action=edit Bug 19532: (follow-up) Update characterset for recalls table Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #353 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81679&action=edit Bug 19532: Improve and refine recalls functionality Only allow 1 recall per item When checking in only check for holds if no reserves found Add a T/transferring status for recalls, only confirm them once arrived Improve message when checking in recall Fix clashing ids on recall-history Check if patron can hold item before allowing recall Prevent multiple recalls when pressing back button Select/fill only active recall when issuing To test: 1 - Repeat major test plan - verify all points 2 - Attempt to place multiple recallsusing back button, should fail 3 - Set all item level holds to not allowed, should not be able to place recall 4 - Check-in recall at branch other than destination, should be in transit 5 - Confirm at correct branch, should send message and get expiration date etc. 6 - Return to another branch, should eb in transit again 7 - Play with circ rules and verify only allowed patrons can place recall Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81595|0 |1 is obsolete| | --- Comment #354 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81680&action=edit Bug 19532: Fixes and enhancements to recalls This implements the following fixes and enhancements: * Stopping a waiting recall from being able to be checked out to patrons other than the patron who placed the recall * Make the Recall confirmation popup appear everytime a recalled item is put through returns until it is checked out to recall requester * Introduce a new notice RECALL_REQUESTER_DET which outlines borrower and item information so the item can be put aside * Stop recalled items from being renewed * Stop display of 'Available' for waiting recalls * Check if recalls exist on an item before checking for reserves * Added ability to set Recall due date interval, and Recall pickup period in hours * Fix the 'Template process error Koha::Item->avail_for_recall' thrown on course page where a course reserve is currently issued Test plan: 1. Repeat major test plan - verify all points 2. Place another recall and check it in 3. Try checking the recall out to a different patron and confirm you are not able to check out a waiting recall to a different patron 4. Check the same item in again and observe that the recall modal is displayed again and is displayed every time the item is checked in until the item is checked out to the patron who placed the recall 5. Check the item in again and select the 'Print slip and confirm' and confirm the RECALL_REQUESTER_DET notice can be printed 6. Place a recall on an item and try to renew the item and confirm you are unable to renew recalled items 7. Return the same item and confirm in the OPAC and staff client that the item is not shown as available 8. Place a recall to one borrower then reserve the same item to a different borrower. Check the item in and confirm the recall modal is displayed not the reserve modal as recalls take precedence 9. In circ and fine rules set a rules 'Fine charge interval period'=1 10. Set the 'Unit' of the circ rule to 'hours', 'Recall due date interval' = 1, 'Recall overdue fine amount'=1, 'Recall pickup period'=1 11. Check out an item to borrower A and recall it in the OPAC by borrower B 12. In the database manually change the issues.date_due to 1 hour before the current time 13. From the Koha shell run './misc/cronjobs/fines.pl' 14. Notice the fine of 1 has been applied to the borrower for being 1 hour late in returning the recall 15. Return the item and confirm the recall. Manually change the waiting date to more than 1 hour before the current time and run ./misc/cronjobs/overdue_notices.pl 16. Notice the recall is overdue now - Steps 9-16 test point #7 above 17. Enable 'UseCourseReserves' syspref 18. Check out a course reserve item to a borrower 19. In the OPAC navigate to the course page containing the issued course reserve and confirm the page loads successfully 20. Recall a course reserve and confirm recalls works for course reserves Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #355 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81681&action=edit Bug 19532: (QA follow-up) Add missing TT filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #356 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81682&action=edit Bug 19532: (QA follow-up) Use Asset plugin for css -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #357 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81683&action=edit Bug 19532: (QA follow-up) Fix collation in kohastructure.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #358 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've uploaded an updated patchset with some simple followups added. However, I've got a few code review comments, and I've not got to the full testing of the feature itself yet. I don't think this is likely to be ready for 18.11 personally, but it would be good to get the groundwork done to get it in at the beginning of the next cycle. Review: This really feels like it should be built atop the existing Holds/Reserves system. Everyone I've spoken to, to date, has been really surprised that it appears to be an entirely distinct feature. It also feels like allot of code was borrowed from reserves, leading to repetition. Putting that aside for now, however: 1) Please update the POD for C4::Circulation::transferbook to state how the functionality has changed 2) There is commented out code in the above routine which looks as though it needs more thought 3) Shouldn't the librarian be able to override a recalls at checkout the same way they can override a reserve (based on sysprefs I believe) 4) Please document the recalls status codes somewhere 5) C4::Circulation::AddReturn - There are superfluous DB calls here I believe 6) Reserves/Holds take precedence over Recalls during renewal, is that deliberate (everywhere else it seems to be the opposite way around) 7) Superfluous `use Data::Dumper` in C4::Letters 8) I couldn't work out from the code how this affects fines.. only that is does 9) I don't understand why you've changed Koha/Patron.pm 10) Superfluous `use Data::Dumper` in catalogue/detail.pl 11) Why 3 distinct DB hits in catalogue/detail.pl 12) circ/recall-pickup-slip.pl appears to contain unused imports 13) circ/recalls_overdue.pl, circ/recalls_queue.pl, circ/recalls_waiting all have references to Fast Cataloguing.. not sure why 14) Why the mix of filenames with underscores and hyphens? 15) circ/returns.pl has commented out code, leaving the feeling that it needs further thought 16) atomicupdate .sql files should be converted to .perl and use the template. 17) Rebase issue has resulted in SR_SLIP being contained within many of the sql files 18) All JS should be pushed to the bottom of the file now as per recent(ish) guidelines.. I think this has partially been done, but some cases have been missed. Lots of little things.. now I need to fully test the feature to really get to grips with why it's entirely distinct from Reserves. I wish there was a full RFC we could see and a Work In Progress branch for updating the manual. I'm struggling to pick out the whole modus operandi of this patch as it's not what anyone here understands 'recalls' to be. Hopefully, we can keep this moving along.. sorry it's not all good news, but I am keen to help get it moving again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Bob Birchall <bob@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob@calyx.net.au, | |clopez@dml.vic.edu.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Paul Thornton <paul.thornton@educampus.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.thornton@educampus.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Niamh <niamh.walker-headon@it-tallaght.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon@it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Laura Horgan <horganl@middlesex.mass.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |horganl@middlesex.mass.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23781 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 [Bug 23781] SMS and messaging preferences for recalls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Holly <hc@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc@interleaf.ie --- Comment #359 from Holly <hc@interleaf.ie> --- I work with a few sites that are very eager to be able to recall items. I wanted to check if there was any chance of some movement on this bug or if there is anything I can do to help with it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #360 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Hi Holly We have a few libraries that are using this recalls feature, plus many enhancements developed since. I will work on rebasing this throughout the year and catching master up to where our clients are at. Aleisha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #361 from Aleisha Amohia <aleisha@catalyst.net.nz> --- I will be working on this patch now. The current patches will be made obselete and fresh patches will be added over the next few weeks. A heads up - there will likely be lots of emails. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81586|0 |1 is obsolete| | Attachment #81587|0 |1 is obsolete| | Attachment #81618|0 |1 is obsolete| | Attachment #81652|0 |1 is obsolete| | Attachment #81653|0 |1 is obsolete| | Attachment #81654|0 |1 is obsolete| | Attachment #81655|0 |1 is obsolete| | Attachment #81656|0 |1 is obsolete| | Attachment #81657|0 |1 is obsolete| | Attachment #81658|0 |1 is obsolete| | Attachment #81659|0 |1 is obsolete| | Attachment #81660|0 |1 is obsolete| | Attachment #81661|0 |1 is obsolete| | Attachment #81662|0 |1 is obsolete| | Attachment #81663|0 |1 is obsolete| | Attachment #81664|0 |1 is obsolete| | Attachment #81665|0 |1 is obsolete| | Attachment #81666|0 |1 is obsolete| | Attachment #81667|0 |1 is obsolete| | Attachment #81668|0 |1 is obsolete| | Attachment #81669|0 |1 is obsolete| | Attachment #81670|0 |1 is obsolete| | Attachment #81671|0 |1 is obsolete| | Attachment #81672|0 |1 is obsolete| | Attachment #81673|0 |1 is obsolete| | Attachment #81674|0 |1 is obsolete| | Attachment #81675|0 |1 is obsolete| | Attachment #81676|0 |1 is obsolete| | Attachment #81677|0 |1 is obsolete| | Attachment #81678|0 |1 is obsolete| | Attachment #81679|0 |1 is obsolete| | Attachment #81680|0 |1 is obsolete| | Attachment #81681|0 |1 is obsolete| | Attachment #81682|0 |1 is obsolete| | Attachment #81683|0 |1 is obsolete| | --- Comment #362 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 103887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103887&action=edit Bug 19532: Database and installer stuff - recalls table - circulation rules: recalls allowed (total), recalls per record (count), on shelf recalls allowed, recall due date interval (day), recall overdue fine, recall shelf time/pickup period (day) - sysprefs: useRecalls, RecallsMaxPickUpDelay, RecallsLog - email notices: RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM, RECALL_REQUESTER_DET - user permission: recalls, manage_recalls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #363 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 103888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103888&action=edit Bug 19532: Updated schema files Including boolean attribute for recalls.old flag and recalls.item_level_recall flag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103888|0 |1 is obsolete| | --- Comment #364 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 103890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103890&action=edit Bug 19532: Updated schema files Including boolean attribute for recalls.old flag and recalls.item_level_recall flag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103887|0 |1 is obsolete| | --- Comment #365 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 103899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103899&action=edit Bug 19532: Database and installer stuff - recalls table - circulation rules: recalls allowed (total), recalls per record (count), on shelf recalls allowed, recall due date interval (day), recall overdue fine, recall shelf time/pickup period (day) - sysprefs: useRecalls, RecallsMaxPickUpDelay, RecallsLog - email notices: RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM, RECALL_REQUESTER_DET - user permission: recalls, manage_recalls - Recall and CancelRecall reasons for branch transfers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103890|0 |1 is obsolete| | --- Comment #366 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 103900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103900&action=edit Bug 19532: Updated schema files Including boolean attribute for recalls.old flag and recalls.item_level_recall flag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #367 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 103901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103901&action=edit Bug 19532: Recalls objects and tests Getter and setter methods and other object methods for Koha Recalls, plus tests for these -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103899|0 |1 is obsolete| | --- Comment #368 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 103999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103999&action=edit Bug 19532: Database and installer stuff - recalls table - circulation rules: recalls allowed (total), recalls per record (count), on shelf recalls allowed, recall due date interval (day), recall overdue fine, recall shelf time/pickup period (day) - sysprefs: useRecalls, RecallsMaxPickUpDelay, RecallsLog - email notices: RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM, RECALL_REQUESTER_DET - user permission: recalls, manage_recalls - Recall and CancelRecall reasons for branch transfers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103900|0 |1 is obsolete| | --- Comment #369 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104000&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #370 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104001&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103901|0 |1 is obsolete| | --- Comment #371 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104002&action=edit Bug 19532: Recalls objects and tests Getter and setter methods and other object methods for Koha Recalls, plus tests for these -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104002|0 |1 is obsolete| | --- Comment #372 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104005&action=edit Bug 19532: Recalls objects and tests Getter and setter methods and other object methods for Koha Recalls, plus tests for these -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #373 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104006&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation plus tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #374 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104007&action=edit Bug 19532: Other objects used in recalls feature * biblio->recalls * biblio->can_be_recalled * item->recall * item->can_be_recalled * item->can_set_waiting_recall * patron->recalls * tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103999|0 |1 is obsolete| | --- Comment #375 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104066&action=edit Bug 19532: Database and installer stuff - recalls table - circulation rules: recalls allowed (total), recalls per record (count), on shelf recalls allowed, recall due date interval (day), recall overdue fine, recall shelf time/pickup period (day) - sysprefs: useRecalls, RecallsMaxPickUpDelay, RecallsLog - email notices: RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM, RECALL_REQUESTER_DET - user permission: recalls, manage_recalls - Recall and CancelRecall reasons for branch transfers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104000|0 |1 is obsolete| | --- Comment #376 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104067&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104001|0 |1 is obsolete| | --- Comment #377 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104068&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104005|0 |1 is obsolete| | --- Comment #378 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104069&action=edit Bug 19532: Recalls objects and tests Getter and setter methods and other object methods for Koha Recalls, plus tests for these -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104006|0 |1 is obsolete| | --- Comment #379 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104070&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation plus tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104007|0 |1 is obsolete| | --- Comment #380 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104071&action=edit Bug 19532: Other objects used in recalls feature * biblio->recalls * biblio->can_be_recalled * item->recall * item->can_be_recalled * item->can_set_waiting_recall * patron->recalls * tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104069|0 |1 is obsolete| | --- Comment #381 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104246&action=edit Bug 19532: Recalls objects and tests Getter and setter methods and other object methods for Koha Recalls, plus tests for these -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104070|0 |1 is obsolete| | --- Comment #382 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104247&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation plus tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104071|0 |1 is obsolete| | --- Comment #383 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104248&action=edit Bug 19532: Other objects used in recalls feature * biblio->recalls * biblio->can_be_recalled * item->recall * item->can_be_recalled * item->can_set_waiting_recall * patron->recalls * tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #384 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104249&action=edit Bug 19532: Recalls on OPAC Placing an item-level or biblio-level recall Viewing current and past recalls Recalls work with course reserves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #385 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104250&action=edit Bug 19532: Recalls on intranet -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104066|0 |1 is obsolete| | --- Comment #386 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104322&action=edit Bug 19532: Database and installer stuff - recalls table - circulation rules: recalls allowed (total), recalls per record (count), on shelf recalls allowed, recall due date interval (day), recall overdue fine, recall shelf time/pickup period (day) - sysprefs: useRecalls, RecallsMaxPickUpDelay, RecallsLog - email notices: RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM, RECALL_REQUESTER_DET - user permission: recalls, manage_recalls - Recall and CancelRecall reasons for branch transfers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104067|0 |1 is obsolete| | --- Comment #387 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104323&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104068|0 |1 is obsolete| | --- Comment #388 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104324&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104246|0 |1 is obsolete| | --- Comment #389 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104325&action=edit Bug 19532: Recalls objects and tests Getter and setter methods and other object methods for Koha Recalls, plus tests for these -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104247|0 |1 is obsolete| | --- Comment #390 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104326&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation plus tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104248|0 |1 is obsolete| | --- Comment #391 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104327&action=edit Bug 19532: Other objects used in recalls feature * biblio->recalls * biblio->can_be_recalled * item->recall * item->can_be_recalled * item->can_set_waiting_recall * patron->recalls * tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104249|0 |1 is obsolete| | --- Comment #392 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104328&action=edit Bug 19532: Recalls on OPAC Placing an item-level or biblio-level recall Viewing current and past recalls for logged-in patron Recall course reserve items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104250|0 |1 is obsolete| | --- Comment #393 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104329&action=edit Bug 19532: Recalls on intranet -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104325|0 |1 is obsolete| | --- Comment #394 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104330&action=edit Bug 19532: Recalls objects and tests Getter and setter methods and other object methods for Koha Recalls, plus tests for these -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104326|0 |1 is obsolete| | --- Comment #395 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104331&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation plus tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104327|0 |1 is obsolete| | --- Comment #396 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104332&action=edit Bug 19532: Other objects used in recalls feature * biblio->recalls * biblio->can_be_recalled * item->recall * item->can_be_recalled * item->can_set_waiting_recall * patron->recalls * tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104328|0 |1 is obsolete| | --- Comment #397 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104333&action=edit Bug 19532: Recalls on OPAC Placing an item-level or biblio-level recall Viewing current and past recalls for logged-in patron Recall course reserve items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104329|0 |1 is obsolete| | --- Comment #398 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104334&action=edit Bug 19532: Recalls on intranet -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104333|0 |1 is obsolete| | --- Comment #399 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104335&action=edit Bug 19532: Recalls on OPAC Placing an item-level or biblio-level recall Viewing current and past recalls for logged-in patron Recall course reserve items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104334|0 |1 is obsolete| | --- Comment #400 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104336&action=edit Bug 19532: Recalls on intranet -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104322|0 |1 is obsolete| | --- Comment #401 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104391&action=edit Bug 19532: Database and installer stuff - recalls table - circulation rules: recalls allowed (total), recalls per record (count), on shelf recalls allowed, recall due date interval (day), recall overdue fine, recall shelf time/pickup period (day) - sysprefs: useRecalls, RecallsMaxPickUpDelay, RecallsLog - email notices: RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM, RECALL_REQUESTER_DET - user permission: recalls, manage_recalls - Recall and CancelRecall reasons for branch transfers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104323|0 |1 is obsolete| | --- Comment #402 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104392&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104324|0 |1 is obsolete| | --- Comment #403 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104393&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104330|0 |1 is obsolete| | --- Comment #404 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104394&action=edit Bug 19532: Recalls objects and tests Getter and setter methods and other object methods for Koha Recalls, plus tests for these -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104331|0 |1 is obsolete| | --- Comment #405 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104395&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation plus tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104332|0 |1 is obsolete| | --- Comment #406 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104396&action=edit Bug 19532: Other objects used in recalls feature * biblio->recalls * biblio->can_be_recalled * item->recall * item->can_be_recalled * item->can_set_waiting_recall * patron->recalls * tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104335|0 |1 is obsolete| | --- Comment #407 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104397&action=edit Bug 19532: Recalls on OPAC Placing an item-level or biblio-level recall Viewing current and past recalls for logged-in patron Recall course reserve items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104336|0 |1 is obsolete| | --- Comment #408 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104398&action=edit Bug 19532: Recalls on intranet -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104391|0 |1 is obsolete| | --- Comment #409 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104474&action=edit Bug 19532: Database and installer stuff - recalls table - circulation rules: recalls allowed (total), recalls per record (count), on shelf recalls allowed, recall due date interval (day), recall overdue fine, recall shelf time/pickup period (day) - sysprefs: useRecalls, RecallsMaxPickUpDelay, RecallsLog - email notices: RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM, RECALL_REQUESTER_DET - user permission: recalls, manage_recalls - Recall and CancelRecall reasons for branch transfers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104392|0 |1 is obsolete| | --- Comment #410 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104475&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104393|0 |1 is obsolete| | --- Comment #411 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104476&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104394|0 |1 is obsolete| | --- Comment #412 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104477&action=edit Bug 19532: Recalls objects and tests Getter and setter methods and other object methods for Koha Recalls, plus tests for these -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104395|0 |1 is obsolete| | --- Comment #413 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104478&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation plus tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104396|0 |1 is obsolete| | --- Comment #414 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104479&action=edit Bug 19532: Other objects used in recalls feature * biblio->recalls * biblio->can_be_recalled * item->recall * item->can_be_recalled * item->can_set_waiting_recall * patron->recalls * tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104397|0 |1 is obsolete| | --- Comment #415 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104480&action=edit Bug 19532: Recalls on OPAC Placing an item-level or biblio-level recall Viewing current and past recalls for logged-in patron Recall course reserve items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104398|0 |1 is obsolete| | --- Comment #416 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104481&action=edit Bug 19532: Recalls on intranet -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104474|0 |1 is obsolete| | --- Comment #417 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104545&action=edit Bug 19532: Database and installer stuff - recalls table - circulation rules: recalls allowed (total), recalls per record (count), on shelf recalls allowed, recall due date interval (day), recall overdue fine, recall shelf time/pickup period (day) - sysprefs: useRecalls, RecallsMaxPickUpDelay, RecallsLog - email notices: RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM, RECALL_REQUESTER_DET - user permission: recalls, manage_recalls - Recall and CancelRecall reasons for branch transfers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104475|0 |1 is obsolete| | --- Comment #418 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104546&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104476|0 |1 is obsolete| | --- Comment #419 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104547&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104477|0 |1 is obsolete| | --- Comment #420 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104548&action=edit Bug 19532: Recalls objects and tests Getter and setter methods and other object methods for Koha Recalls, plus tests for these -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104478|0 |1 is obsolete| | --- Comment #421 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104549&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation plus tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104479|0 |1 is obsolete| | --- Comment #422 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104550&action=edit Bug 19532: Other objects used in recalls feature * biblio->recalls * biblio->can_be_recalled * item->recall * item->can_be_recalled * item->can_set_waiting_recall * patron->recalls * tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104480|0 |1 is obsolete| | --- Comment #423 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104551&action=edit Bug 19532: Recalls on OPAC Placing an item-level or biblio-level recall Viewing current and past recalls for logged-in patron Recall course reserve items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104481|0 |1 is obsolete| | --- Comment #424 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104552&action=edit Bug 19532: Recalls on intranet -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104545|0 |1 is obsolete| | --- Comment #425 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104646&action=edit Bug 19532: Database and installer stuff - recalls table - circulation rules: recalls allowed (total), recalls per record (count), on shelf recalls allowed, recall due date interval (day), recall overdue fine, recall shelf time/pickup period (day) - sysprefs: useRecalls, RecallsMaxPickUpDelay, RecallsLog - email notices: RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM, RECALL_REQUESTER_DET - user permission: recalls, manage_recalls - Recall and CancelRecall reasons for branch transfers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104546|0 |1 is obsolete| | --- Comment #426 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104647&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104547|0 |1 is obsolete| | --- Comment #427 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104648&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104548|0 |1 is obsolete| | --- Comment #428 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104649&action=edit Bug 19532: Recalls objects and tests Getter and setter methods and other object methods for Koha Recalls, plus tests for these -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104549|0 |1 is obsolete| | --- Comment #429 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104650&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation plus tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104550|0 |1 is obsolete| | --- Comment #430 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104651&action=edit Bug 19532: Other objects used in recalls feature * biblio->recalls * biblio->can_be_recalled * item->recall * item->can_be_recalled * item->can_set_waiting_recall * patron->recalls * tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104551|0 |1 is obsolete| | --- Comment #431 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104652&action=edit Bug 19532: Recalls on OPAC Placing an item-level or biblio-level recall Viewing current and past recalls for logged-in patron Recall course reserve items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104552|0 |1 is obsolete| | --- Comment #432 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104653&action=edit Bug 19532: Recalls on intranet -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104646|0 |1 is obsolete| | --- Comment #433 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104722&action=edit Bug 19532: Database and installer stuff - recalls table - circulation rules: recalls allowed (total), recalls per record (count), on shelf recalls allowed, recall due date interval (day), recall overdue fine, recall shelf time/pickup period (day) - sysprefs: useRecalls, RecallsMaxPickUpDelay, RecallsLog - email notices: RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM, RECALL_REQUESTER_DET - user permission: recalls, manage_recalls - Recall and CancelRecall reasons for branch transfers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104647|0 |1 is obsolete| | --- Comment #434 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104723&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104648|0 |1 is obsolete| | --- Comment #435 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104724&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104649|0 |1 is obsolete| | --- Comment #436 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104725&action=edit Bug 19532: Recalls objects and tests Getter and setter methods and other object methods for Koha Recalls, plus tests for these -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104650|0 |1 is obsolete| | --- Comment #437 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104726&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation plus tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104651|0 |1 is obsolete| | --- Comment #438 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104727&action=edit Bug 19532: Other objects used in recalls feature * biblio->recalls * biblio->can_be_recalled * item->recall * item->can_be_recalled * item->can_set_waiting_recall * patron->recalls * tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104652|0 |1 is obsolete| | --- Comment #439 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104728&action=edit Bug 19532: Recalls on OPAC Placing an item-level or biblio-level recall Viewing current and past recalls for logged-in patron Recall course reserve items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104653|0 |1 is obsolete| | --- Comment #440 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104729&action=edit Bug 19532: Recalls on intranet -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104722|0 |1 is obsolete| | --- Comment #441 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104806&action=edit Bug 19532: Database and installer stuff - recalls table - circulation rules: recalls allowed (total), recalls per record (count), on shelf recalls allowed, recall due date interval (day), recall overdue fine, recall shelf time/pickup period (day) - sysprefs: useRecalls, RecallsMaxPickUpDelay, RecallsLog - email notices: RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM, RECALL_REQUESTER_DET - user permission: recalls, manage_recalls - Recall and CancelRecall reasons for branch transfers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104723|0 |1 is obsolete| | --- Comment #442 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104807&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104724|0 |1 is obsolete| | --- Comment #443 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104808&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104725|0 |1 is obsolete| | --- Comment #444 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104809&action=edit Bug 19532: Recalls objects and tests Getter and setter methods and other object methods for Koha Recalls, plus tests for these -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104726|0 |1 is obsolete| | --- Comment #445 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104810&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation plus tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104727|0 |1 is obsolete| | --- Comment #446 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104811&action=edit Bug 19532: Other objects used in recalls feature * biblio->recalls * biblio->can_be_recalled * item->recall * item->can_be_recalled * item->can_set_waiting_recall * patron->recalls * tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104728|0 |1 is obsolete| | --- Comment #447 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104812&action=edit Bug 19532: Recalls on OPAC Placing an item-level or biblio-level recall Viewing current and past recalls for logged-in patron Recall course reserve items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104729|0 |1 is obsolete| | --- Comment #448 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104813&action=edit Bug 19532: Recalls on intranet -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104806|0 |1 is obsolete| | --- Comment #449 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104814&action=edit Bug 19532: Database and installer stuff - recalls table - circulation rules: recalls allowed (total), recalls per record (count), on shelf recalls allowed, recall due date interval (day), recall overdue fine, recall shelf time/pickup period (day) - sysprefs: useRecalls, RecallsMaxPickUpDelay, RecallsLog - email notices: RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM, RECALL_REQUESTER_DET - user permission: recalls, manage_recalls - Recall and CancelRecall reasons for branch transfers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104807|0 |1 is obsolete| | --- Comment #450 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104815&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104808|0 |1 is obsolete| | --- Comment #451 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104816&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104809|0 |1 is obsolete| | --- Comment #452 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104817&action=edit Bug 19532: Recalls objects and tests Getter and setter methods and other object methods for Koha Recalls, plus tests for these -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104810|0 |1 is obsolete| | --- Comment #453 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104818&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation plus tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104811|0 |1 is obsolete| | --- Comment #454 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104819&action=edit Bug 19532: Other objects used in recalls feature * biblio->recalls * biblio->can_be_recalled * item->recall * item->can_be_recalled * item->can_set_waiting_recall * patron->recalls * tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104812|0 |1 is obsolete| | --- Comment #455 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104820&action=edit Bug 19532: Recalls on OPAC Placing an item-level or biblio-level recall Viewing current and past recalls for logged-in patron Recall course reserve items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104813|0 |1 is obsolete| | --- Comment #456 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104821&action=edit Bug 19532: Recalls on intranet -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104814|0 |1 is obsolete| | --- Comment #457 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104863&action=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104815|0 |1 is obsolete| | --- Comment #458 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104864&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104816|0 |1 is obsolete| | --- Comment #459 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104865&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104817|0 |1 is obsolete| | --- Comment #460 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104866&action=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104818|0 |1 is obsolete| | --- Comment #461 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104867&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104819|0 |1 is obsolete| | --- Comment #462 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104868&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104820|0 |1 is obsolete| | --- Comment #463 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104869&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104821|0 |1 is obsolete| | --- Comment #464 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104870&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, check in and set waiting, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, check in and set waiting, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, check in and set waiting, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, check in and set waiting, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, check in and set waiting, revert waiting status, mark overdue - log viewer and the general circulation of recalls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104870|0 |1 is obsolete| | --- Comment #465 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104902&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104863|0 |1 is obsolete| | --- Comment #466 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104903&action=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104864|0 |1 is obsolete| | --- Comment #467 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104904&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104865|0 |1 is obsolete| | --- Comment #468 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104905&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104866|0 |1 is obsolete| | --- Comment #469 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104906&action=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104867|0 |1 is obsolete| | --- Comment #470 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104907&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104868|0 |1 is obsolete| | --- Comment #471 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104908&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104869|0 |1 is obsolete| | --- Comment #472 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104909&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104902|0 |1 is obsolete| | --- Comment #473 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104910&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104903|0 |1 is obsolete| | --- Comment #474 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104913&action=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104904|0 |1 is obsolete| | --- Comment #475 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104914&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104905|0 |1 is obsolete| | --- Comment #476 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104915&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104906|0 |1 is obsolete| | --- Comment #477 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104916&action=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104907|0 |1 is obsolete| | --- Comment #478 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104917&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104908|0 |1 is obsolete| | --- Comment #479 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104918&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104909|0 |1 is obsolete| | --- Comment #480 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104919&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104910|0 |1 is obsolete| | --- Comment #481 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104920&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #482 from Aleisha Amohia <aleisha@catalyst.net.nz> --- == TEST PLAN FOR RECALLS == ADMINISTRATION 1. Apply all patches 2. Run database updates, update schema files and confirm everything applies cleanly 3. Run tests and confirm everything passes: t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t t/db_dependent/Stats.t t/db_dependent/Circulation/CalcFine.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Patron.t t/db_dependent/XSLT.t t/db_dependent/Search.t t/db_dependent/Holds.t t/db_dependent/Circulation/transferbook.t t/db_dependent/Circulation.t 4. Go to Administration -> system preferences. Find the UseRecalls system preference. It should be DISABLED. Confirm RecallsMaxPickUpDelay is set to 7 by default. 5. Go to Administration -> circulation rules. Confirm there are no recalls circulation rules showing. 6. Test a few circulation flows: checking out, placing a reserve, checking in, fulfilling a reserve, etc. Confirm everything works as normal. 7. Go to Administration -> system preferences. Enable the UseRecalls system preference. 8. Go to Administration -> circulation rules. Set the following rules: Recalls allowed (count) = 0 Recalls per record (count) = 0 On shelf recalls allowed ( If any unavailable / If all unavailable ) = If any unavailable Recall due date interval (days) = 3 Recall overdue fine amount = (something different to your normal fine amount) Recall pickup period (days) = 1 Throughout your testing, try with different combinations of these rules and itemtype / branchcode / categorycode. Also try with null values. Keep the circulation rules open in another tab so you can refer to and update these easily. You should also have at least one other tab open for the staff client, and a third tab open for the OPAC, for ease of testing. 9. Go to your account -> More -> Set permissions. Confirm the recalls permission is checked. 10. Set up a test user with OPAC login details (Borrower A). This could also be your own user, as long as you have OPAC login access. 11. Set up a test record (Biblio A) with at least two items (Item A and Item B) of the same item type (or an item type with the same recall circ rules). PLACING A RECALL 12. Log in to the OPAC as Borrower A. Do a catalogue search with a term that will return multiple results, including Biblio A. 13. Click on Biblio A. 14. Notice there is a 'Place recall' button on the sidebar menu. Click this button. There will be a message saying that there are no items to recall - this is because all items are available. 15. Check out Item A to another borrower (Borrower B). 16. Refresh the 'Place recall' page. You will still NOT be able to place a recall - this is because Recalls allowed = 0 and Recalls per record = 0. 17. Edit the circulation rules to have the following values: Recalls allowed (count) = 1 Recalls per record (count) = 1 18. Refresh the 'Place recall' page. You will now see the form to place a recall. BIBLIO-LEVEL RECALL, NO TRANSFER 19. Place a biblio-level recall. Pickup location: Branch A, the set branch when you are logged into the staff client Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 20. Confirm the recall is placed successfully. Confirm that the new due date displayed is correctly calculated to be today's date, plus 3 days (taken from the 'recall due date interval' circ rule) 21. In the staff client, look at Borrower B's account, and go to their Notices tab. Confirm they have received a 'Notification to return recalled item' notice. 22. Look at Borrower B's checkouts table. Notice the due date for their checkout has been adjusted, and there is now a note to say that the item was recalled and the due date adjusted. 23. Log in to the OPAC as Borrower B and go to your summary tab. Notice there is a note under their checkout to say the item had been recalled. 24. Log out of the OPAC and log back in as Borrower A. 25. Go to your summary tab. Confirm there is a Recalls tab with a count of 1. 26. Cancel the recall using the button. Confirm it cancels and the Recalls tab disappears. 27. Do a catalogue search with a term that will return multiple results, including Biblio A. 28. When the results load, notice there is a 'Place recall' button next to the 'Place hold' button. Click this 'Place recall' button. 29. Notice you are redirected straight to the form to place a recall. 30. Place a biblio-level recall again, following the steps in Step 19. 31. Go to your recalls history tab. Notice your first cancelled recall shows here. 32. Cancel the recall you just created, using the button. Confirm it cancels and you are redirected to your summary tab. 33. In the staff client, enable the UseCourseReserves system preference. 34. Go to the main menu, click Course Reserves. 35. Add a new course. (You may also have to define an authorised value for DEPARTMENT.) 36. Add Item A as a reserve to this course. 37. View Course Reserves in the OPAC. Click the course you just created. 38. Notice the reserve has a Recall button underneath it's 'Checked out' status. Click this button. 39. Place a biblio-level recall again, following the steps in Step 19. 40. Click the 'Place recall' link in the breadcrumbs. 41. Notice there is a message saying that you have reached the max number of recalls on this record. This is because Recalls allowed = 1 and Recalls per record = 1. 42. Edit the circulation rules to have the following values: Recalls allowed (count) = 10 Recalls per record (count) = 5 43. Refresh the 'Place recall' page. You will now see the form to place a recall. 44. Create another test record (Biblio B) with at least one item (Item C). 45. Find this record on the OPAC and place a biblio-level recall again, following the steps in Step 19. 46. In the staff client, go to Circulation -> Old recalls. You should be able to see your two cancelled recalls. 47. Go to Circulation -> Recalls queue. Your current recalls should show here. 48. Use the 'Select all' checkbox to select all recalls. 49. Cancel the recalls using the 'Cancel selected recalls' button. 50. Go to the OPAC and place a biblio-level recall on Biblio A again, following the steps in Step 19. 51. In the staff client, check in Item A, which should still be checked out to Borrower B. 52. A box should pop-up asking you to confirm Borrower A's recall. Click ignore. 53. Click the link to go view Biblio A's details in the catalogue. 54. Click the recalls tab. Notice Borrower A's recall is displayed, and shows it is still Requested (has not been confirmed waiting). 55. Check in Item A again. This time, confirm the recall as waiting using the "Confirm recall" button. 56. Go to Borrower A's Notices tab. Confirm there is a notice "Recalled item awaiting pickup". 57. Go to Borrower A's checkouts. Notice there is a recalls tab. Confirm the recall is showing as "Ready for pickup". 58. Click the 'Actions' dropdown. Click the "Revert waiting" button. The page should show that the status is revert to Requested without reloading. 59. This time, check in Item B. The recall confirmation box should show again, because this a biblio-level recall that any recallable item under Biblio A can fill. Click the "Print slip and confirm" button. 60. Check the slip that is generated. Confirm it contains Borrower A's correct details, and the details of the recall are correct. 61. Go to Circulation -> Recalls awaiting pickup. Confirm the recall is now waiting and shows in this list. (You could also try this with Item B having a different item type to Item A, and circ rules not allowing Item B's item type to have recalls. When checking in Item A, it should not trigger the recall box). 62. Go to Borrower A's checkouts. Check out Item B. 63. Confirm the checkout is successful and the recall is removed from the Recalls tab. 64. Go to Circulation -> Old recalls. The fulfilled recall should show. 65. Check in Item B. BIBLIO-LEVEL RECALL, TRANSFER REQUIRED 66. Check out Item A to Borrower B. 67. Log in to the OPAC as Borrower A. 68. Find Biblio A and place a biblio-level recall. Pickup location: Branch B, a different branch from your logged in branch. This recall will require a transfer. Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 69. In the staff client, check in Item A at Branch A. Notice the box that pops up shows that a transfer is required. 70. Click "confirm recall and transfer" and confirm the transfer. 71. Go to your account and click the Recalls tab. 72. Confirm the recall status now shows the item is in transit to Branch B. 73. In the drop-down top-right of your window, select 'Set library'. 74. Set your library to Branch B. 75. Go to Circulation -> Transfers to receive. Notice that the recall is showing here. 76. Click 'Cancel transfer'. 77. Go to Circulation -> Recalls queue 78. Confirm the recall status has been reverted to Requested. 79. Set your library back to Branch A. 80. Check in Item A and trigger the transfer. 81. Set your library back to Branch B. 82. Check in Item A at Branch B. 83. When the 'Recall found' box pops up, click Ignore. 84. Go to Circulation -> Recalls to pull. The recall should show here, with a button to "Cancel recall and return to: Branch A" 85. Click the button to cancel the recall. 86. Repeat Steps 66-70. 87. Check in Item A at Branch B. Confirm the recall as waiting. 88. Check out Item A to Borrower A to fulfill the recall. 89. Set your library back to Branch A and check in Item A. ITEM-LEVEL RECALL, NO TRANSFER 90. Go to Administration -> circulation rules. Set the following rules: On shelf recalls allowed ( If any unavailable / If all unavailable ) = If all unavailable 91. Check out Item A to Borrower B. 92. Log in to the OPAC as Borrower A and go to Biblio A. 93. Click the 'Place recall' button. Confirm there is a message that there are no items to recall. This is because On shelf recalls allowed = If all unavailable, and there is still one item (Item B) available. 94. In the staff client, edit Item B to have a withdrawn, item lost or not for loan status. 95. Refresh the 'Place recall' page. Confirm you can now see the form to place a recall. 96. Place an item-level recall. Pickup location: Branch A. Recall not needed after (expiration date): whatever you want Select 'recall a specific item' Item B will not be selectable, and Item A should be selected by default. Click confirm 97. In the staff client, edit Item B and remove the lost or missing status. 98. Check in Item B. Confirm the recall box does not pop up, because it cannot fill the item-level recall. 99. Check in Item A. Confirm the recall as waiting. 100. Go to Circulation -> Recalls awaiting pickup 101. Expire the recall. Confirm it expires as expected. ITEM-LEVEL RECALL, TRANSFER REQUIRED 102. Repeat steps 91 to 95. 103. Place an item-level recall. Pickup location: Branch B, we will require a transfer. Recall not needed after (expiration date): whatever you want Select 'recall a specific item' Item B will not be selectable, and Item A should be selected by default. Click confirm 104. In the staff client, check in Item A. Confirm the recall and trigger the transfer. 105. Set your library to Branch B and check in Item A. 106. Confirm the recall as waiting. 107. Check out Item A to Borrower A and fulfill the recall. 108. Set your library back to Branch A and check in Item A. CRONJOBS: EXPIRING RECALL 109. Check out Item A to Borrower B. 110. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 111. In your terminal, enter mysql and edit the expiration date of your recall to be before today UPDATE recalls SET expirationdate = NOW()-2 WHERE recall_id = X; 112. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 113. Go to Borrower A's account and go to the Recalls history tab 114. Confirm the recall has been expired because the current date surpassed the specified expiration date 115. Check out Item A to Borrower B. 116. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 117. In the staff client, check in Item A and confirm the recall as waiting. 118. In your terminal, enter mysql and edit the waiting date of your recall to be before today UPDATE recalls SET waitingdate = NOW()-2 WHERE recall_id = X; 119. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 120. Go to Borrower A's account and go to the Recalls history tab 121. Confirm the recall has been expired because the recall had been waiting for more days than the Recall pickup period 122. Go to Administration -> circulation rules. Set the following rules: Recall pickup period (days) = 0 123. Set the RecallsMaxPickUpDelay system preference = 1. 124. Check out Item A to Borrower B. 125. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 126. In the staff client, check in Item A and confirm the recall as waiting. 127. In your terminal, enter mysql and edit the waiting date of your recall to be before today UPDATE recalls SET waitingdate = NOW()-2 WHERE recall_id = X; 128. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 129. Go to Borrower A's account and go to the Recalls history tab 130. Confirm the recall has been expired because the recall had been waiting for more days than the RecallsMaxPickUpDelay syspref CRONJOBS: OVERDUE RECALL 131. Check out Item A to Borrower B 132. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 133. In your terminal, enter mysql and edit the due date of the checkout to Borrower B to be before today UPDATE issues SET date_due = NOW()-2 WHERE issue_id = X; 134. Run the overdue cronjob from within your shell perl misc/cronjobs/recall/overdue_recalls.pl 135. Go to Circulation -> Overdue recalls 136. Confirm your recall is showing here now as the recall has been marked Overdue CIRCULATION 137. Check in Item A. 138. When the recall box pops up, click Ignore. 139. Check out Item A to Borrower B. You should see a yellow confirmation box, saying that another borrower has recalled the item you are trying to check out. 140. Click "No don't check out" and confirm the item isn't checked out and the recall remains. 141. Repeat Step 139. 142. Click "Yes check out" and confirm the item is checked out and the recall remains. 143. When Borrower B's checkout table loads, confirm that you cannot renew or check in the item from the Checkouts table because there is a 'Recalled' link which takes you to the recalls tab for that biblio. 144. Repeat Steps 137-139. 145. Select "Cancel recall" and click "Yes check out" and confirm the item is checked out and the recall has been cancelled. 146. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 147. Check in Item A. Confirm the recall as waiting. 148. Check out Item A to Borrower B. You should see a yellow confirmation box, saying that that another borrower has recalled the item that you are trying to check out. 149. Select "Revert waiting status" and click "Yes check out" and confirm the item is checked out and the recall status has reverted to requested. OTHER 150. In your terminal, enter mysql and edit the due date of the checkout to Borrower B to be before today UPDATE issues SET date_due = NOW()-2 WHERE issue_id = X; 151. Go to Borrower A's recalls and click the Actions dropdown. 152. Click "Mark as overdue" and confirm the recall is marked as overdue manually. 153. Go to Tools -> Log Viewer. Check only the Recalls module, and leave all other parameters, and click Submit. 154. Confirm all of the recalls actions that have been made are correctly logged. Note: recalls messaging preferences are introduced in Bug 23781. The recall feature is fully documented at: https://wiki.koha-community.org/wiki/Catalyst_IT_Recalls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Large patch Priority|P3 |P1 - high Text to go in the|This new feature introduces |This new feature introduces release notes|the ability for borrowers |the ability for borrowers |to place a recall on an |to place a recall on an |item from the OPAC detail. |item from the OPAC detail. |Borrowers can see details |Borrowers can see details |of their requested recalls |of their requested recalls |in the OPAC and can cancel |in the OPAC and can cancel |the recall before it is |the recall before it is |returned. |returned. | | |Librarians can |Librarians can |view and administer the |view and administer the |recalls in the Circulation |recalls in the Circulation |interface of the staff |interface of the staff |client which displays a |client which displays a |list of recalls, overdue |list of recalls, overdue |recalls and recalls |recalls, recalls awaiting |awaiting pickup. |pickup, recalls to pull, | |and old recalls. |The | |amount of time the recalled |The |item has to be returned and |amount of time the recalled |the amount of time it will |item has to be returned and |wait for pickup can be set |the amount of time it will |in circulation and fine |wait for pickup can be set |rules in the unit of hours |in circulation and fine |or days. |rules in the unit of days. | | |After an item is |After an item is recalled |recalled it cannot be |it cannot be renewed. When |renewed. When the item is |the item is returned the |returned the recall can be |recall can be confirmed or |confirmed or cancelled. |cancelled. | | |Recalls are marked as |Recalls are |overdue by the |marked as overdue by the |overdue_notices.pl cronjob. |overdue_recalls.pl cronjob | |or expired by the | |expired_recalls.pl cronjob. Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104916|0 |1 is obsolete| | --- Comment #483 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104988&action=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104917|0 |1 is obsolete| | --- Comment #484 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104989&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104918|0 |1 is obsolete| | --- Comment #485 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104990&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104919|0 |1 is obsolete| | --- Comment #486 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104991&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104920|0 |1 is obsolete| | --- Comment #487 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104992&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 BASE Library Consortium <baselibrary.consortium@nhs.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baselibrary.consortium@nhs. | |net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104991|0 |1 is obsolete| | --- Comment #488 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 106268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106268&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104992|0 |1 is obsolete| | --- Comment #489 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 106269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106269&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104913|0 |1 is obsolete| | --- Comment #490 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 106371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106371&action=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104914|0 |1 is obsolete| | --- Comment #491 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 106372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106372&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104915|0 |1 is obsolete| | --- Comment #492 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 106373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106373&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104988|0 |1 is obsolete| | --- Comment #493 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 106374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106374&action=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104989|0 |1 is obsolete| | --- Comment #494 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 106375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106375&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104990|0 |1 is obsolete| | --- Comment #495 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 106376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106376&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106268|0 |1 is obsolete| | --- Comment #496 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 106377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106377&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106269|0 |1 is obsolete| | --- Comment #497 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 106378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106378&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls Test plan in Comment 482. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #498 from Owen Leonard <oleonard@myacpl.org> --- I ran into a problem at step 70, checking in a recalled item which requires a transfer and clicking "confirm recall and transfer." The dialog disappears as expected but then I'm shown another modal, the regular transfer dialog which is shown when an item is checked in at the wrong branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #499 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Owen Leonard from comment #498)
I ran into a problem at step 70, checking in a recalled item which requires a transfer and clicking "confirm recall and transfer." The dialog disappears as expected but then I'm shown another modal, the regular transfer dialog which is shown when an item is checked in at the wrong branch.
Hey Owen, I am seeing this problem too but for some reason I'm really struggling with not getting that second dialog to pop up, and to hide to 'Item not checked out' alert box behind the modals. Do you have any ideas? All the code to look at is in C4/Circulation.pm in AddReturn, or in circ/returns.pl. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106371|0 |1 is obsolete| | --- Comment #500 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 106810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106810&action=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106372|0 |1 is obsolete| | --- Comment #501 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 106811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106811&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106373|0 |1 is obsolete| | --- Comment #502 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 106812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106812&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106374|0 |1 is obsolete| | --- Comment #503 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 106813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106813&action=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106375|0 |1 is obsolete| | --- Comment #504 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 106814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106814&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106376|0 |1 is obsolete| | --- Comment #505 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 106815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106815&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106377|0 |1 is obsolete| | --- Comment #506 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 106816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106816&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106378|0 |1 is obsolete| | --- Comment #507 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 106817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106817&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls Test plan in Comment 482. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106817|0 |1 is obsolete| | --- Comment #508 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 106857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106857&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls Test plan in Comment 482. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #509 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Owen Leonard from comment #498)
I ran into a problem at step 70, checking in a recalled item which requires a transfer and clicking "confirm recall and transfer." The dialog disappears as expected but then I'm shown another modal, the regular transfer dialog which is shown when an item is checked in at the wrong branch.
Believe I've fixed this, should be good to test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #510 from Owen Leonard <oleonard@myacpl.org> --- Okay, I've made it through the whole test plan (whew!) and ran into a couple more issues: 1. Checking in an item which has a recall, I click "confirm." Check it in again, click "confirm," and I get an error: Can't call method "itemnumber" on an undefined value at /kohadevbox/koha/Koha/Recall.pm line 348 2. I picked a title with two items and checked each one out to different patrons. I then placed a couple of holds on bibliographic record. Then I requested a biblio-level recall on the title. When I check in one of the items and confirm the recall I get an error: Can't call method "unblessed" on an undefined value at /kohadevbox/koha/Koha/Recall.pm line 266. If I check it in again I get two modal dialogs: One for the recall and one for the hold. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106810|0 |1 is obsolete| | --- Comment #511 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 107198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107198&action=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106811|0 |1 is obsolete| | --- Comment #512 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 107199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107199&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106812|0 |1 is obsolete| | --- Comment #513 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 107200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107200&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106813|0 |1 is obsolete| | --- Comment #514 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 107201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107201&action=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106814|0 |1 is obsolete| | --- Comment #515 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 107202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107202&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106815|0 |1 is obsolete| | --- Comment #516 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 107203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107203&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106816|0 |1 is obsolete| | --- Comment #517 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 107204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107204&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106857|0 |1 is obsolete| | --- Comment #518 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 107205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107205&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls Test plan in Comment 482. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #519 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Owen Leonard from comment #510)
Okay, I've made it through the whole test plan (whew!) and ran into a couple more issues:
1. Checking in an item which has a recall, I click "confirm." Check it in again, click "confirm," and I get an error:
Can't call method "itemnumber" on an undefined value at /kohadevbox/koha/Koha/Recall.pm line 348
2. I picked a title with two items and checked each one out to different patrons. I then placed a couple of holds on bibliographic record. Then I requested a biblio-level recall on the title. When I check in one of the items and confirm the recall I get an error:
Can't call method "unblessed" on an undefined value at /kohadevbox/koha/Koha/Recall.pm line 266.
If I check it in again I get two modal dialogs: One for the recall and one for the hold.
Thank you for testing Owen, I've now fixed these problems. Ready to test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107198|0 |1 is obsolete| | --- Comment #520 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 107807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107807&action=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107199|0 |1 is obsolete| | --- Comment #521 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 107808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107808&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107200|0 |1 is obsolete| | --- Comment #522 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 107809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107809&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107201|0 |1 is obsolete| | --- Comment #523 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 107810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107810&action=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107202|0 |1 is obsolete| | --- Comment #524 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 107811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107811&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107203|0 |1 is obsolete| | --- Comment #525 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 107812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107812&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107204|0 |1 is obsolete| | --- Comment #526 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 107813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107813&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107205|0 |1 is obsolete| | --- Comment #527 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 107814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107814&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls Test plan in Comment 482. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #528 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Some work should be done according to QA tools: C4/Circulation.pm FAIL critic # Variables::ProhibitConditionalDeclarations: Got 2 violation(s). C4/Overdues.pm FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). koha-tmpl/intranet-tmpl/prog/en/modules/recalls/recalls_waiting.ttforbidden pattern: Attribute type should not be used for script tags (bug 20053) (line 158) koha-tmpl/intranet-tmpl/prog/js/recalls.js Untranslatable string found (Are you sure you want to remove this recall?) - See coding guideline JS5 Untranslatable string found (The recall may have already been cancelled. Please refresh the page.) - See coding guideline JS5 Untranslatable string found (Cancelled) - See coding guideline JS5 Untranslatable string found (Are you sure you want to expire this recall?) - See coding guideline JS5 Untranslatable string found (The recall may have already been expired. Please refresh the page.) - See coding guideline JS5 Untranslatable string found (Expired) - See coding guideline JS5 Untranslatable string found (Are you sure you want to revert the waiting status of this recall?) - See coding guideline JS5 Untranslatable string found (The recall waiting status may have already been reverted. Please refresh the page.) - See coding guideline JS5 Untranslatable string found (Status updated) - See coding guideline JS5 Untranslatable string found (Are you sure you want to mark this recall as overdue?) - See coding guideline JS5 Untranslatable string found (The recall may have already been marked as overdue. Please refresh the page.) - See coding guideline JS5 Untranslatable string found (Marked overdue) - See coding guideline JS5 Untranslatable string found (Are you sure you want to remove this recall and return the item to it's home library?) - See coding guideline JS5 Untranslatable string found (The recall may have already been removed. Please refresh the page.) - See coding guideline JS5 Untranslatable string found (Cancelled) - See coding guideline JS5 Untranslatable string found (Are you sure you want to remove the selected recall(s)?) - See coding guideline JS5 Untranslatable string found (Please make a selection.) - See coding guideline JS5 misc/cronjobs/recalls/expire_recalls.pl Code before strictures are enabled at line 20, column 1. See page 429 of PBP. misc/cronjobs/recalls/overdue_recalls.pl Code before strictures are enabled at line 20, column 1. See page 429 of PBP. svc/checkouts # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107807|0 |1 is obsolete| | --- Comment #529 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 107918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107918&action=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107808|0 |1 is obsolete| | --- Comment #530 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 107919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107919&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107809|0 |1 is obsolete| | --- Comment #531 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 107920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107920&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107810|0 |1 is obsolete| | --- Comment #532 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 107921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107921&action=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107811|0 |1 is obsolete| | --- Comment #533 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 107922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107922&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107812|0 |1 is obsolete| | --- Comment #534 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 107923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107923&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107813|0 |1 is obsolete| | --- Comment #535 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 107924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107924&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107814|0 |1 is obsolete| | --- Comment #536 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 107925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107925&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls Test plan in Comment 482. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #537 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Marcel de Rooy from comment #528)
Some work should be done according to QA tools:
Believe these are all fixed. Ready to test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107918|0 |1 is obsolete| | --- Comment #538 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 108222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108222&action=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107919|0 |1 is obsolete| | --- Comment #539 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 108223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108223&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107920|0 |1 is obsolete| | --- Comment #540 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 108224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108224&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107921|0 |1 is obsolete| | --- Comment #541 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 108225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108225&action=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107922|0 |1 is obsolete| | --- Comment #542 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 108226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108226&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107923|0 |1 is obsolete| | --- Comment #543 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 108227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108227&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107924|0 |1 is obsolete| | --- Comment #544 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 108228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108228&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107925|0 |1 is obsolete| | --- Comment #545 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 108229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108229&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls Test plan in Comment 482. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108227|0 |1 is obsolete| | --- Comment #546 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 108980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108980&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108228|0 |1 is obsolete| | --- Comment #547 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 108981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108981&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108229|0 |1 is obsolete| | --- Comment #548 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 108982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108982&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls Test plan in Comment 482. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #549 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Rebased "Other objects used in recalls feature" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #550 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- t/db_dependent/Koha/Recall.t .. Variable "@items" is not imported at /usr/share/koha/Koha/Biblio.pm line 856. (Did you mean &items instead?) Global symbol "@items" requires explicit package name (did you forget to declare "my @items"?) at /usr/share/koha/Koha/Biblio.pm line 856. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #551 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Same for t/db_dependent/Koha/Recalls.t t/db_dependent/Stats.t t/db_dependent/Circulation/CalcFine.t Well etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108225|0 |1 is obsolete| | --- Comment #552 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109306&action=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108226|0 |1 is obsolete| | --- Comment #553 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109307&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108980|0 |1 is obsolete| | --- Comment #554 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109308&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108981|0 |1 is obsolete| | --- Comment #555 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109309&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108982|0 |1 is obsolete| | --- Comment #556 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109310&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls Test plan in Comment 482. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108222|0 |1 is obsolete| | --- Comment #557 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109311&action=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108223|0 |1 is obsolete| | --- Comment #558 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109312&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108224|0 |1 is obsolete| | --- Comment #559 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109313&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109306|0 |1 is obsolete| | --- Comment #560 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109314&action=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109307|0 |1 is obsolete| | --- Comment #561 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109315&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109308|0 |1 is obsolete| | --- Comment #562 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109316&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109309|0 |1 is obsolete| | --- Comment #563 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109317&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109310|0 |1 is obsolete| | --- Comment #564 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109318&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls Test plan in Comment 482. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #565 from Owen Leonard <oleonard@myacpl.org> --- This did not apply for me. :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109312|0 |1 is obsolete| | --- Comment #566 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109463&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109313|0 |1 is obsolete| | --- Comment #567 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109464&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109314|0 |1 is obsolete| | --- Comment #568 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109465&action=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109315|0 |1 is obsolete| | --- Comment #569 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109466&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109316|0 |1 is obsolete| | --- Comment #570 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109467&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109317|0 |1 is obsolete| | --- Comment #571 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109468&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109318|0 |1 is obsolete| | --- Comment #572 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109469&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls Test plan in Comment 482. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #573 from Owen Leonard <oleonard@myacpl.org> --- I get an error when I click "Print slip and confirm" on a checked-in recall. The URL in the location bar is: /cgi-bin/koha/recalls/recall_pickup_slip.pl?recall_id= The error is: Can't call method "itemnumber" on an undefined value at /kohadevbox/koha/recalls/recall_pickup_slip.pl line 42 When I check out the recalled item to the patron who requested it the recall is not cleared. It still shows up under the "Recalls" tab on the patrons account, saying "Ready for pickup." When I run "perl misc/cronjobs/recalls/expire_recalls.pl" it doesn't seem to do anything :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109311|0 |1 is obsolete| | --- Comment #574 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109775&action=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109463|0 |1 is obsolete| | --- Comment #575 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109776&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109464|0 |1 is obsolete| | --- Comment #576 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109777&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109465|0 |1 is obsolete| | --- Comment #577 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109778&action=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109466|0 |1 is obsolete| | --- Comment #578 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109779&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109467|0 |1 is obsolete| | --- Comment #579 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109780&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109468|0 |1 is obsolete| | --- Comment #580 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109781&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109469|0 |1 is obsolete| | --- Comment #581 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109782&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls Test plan in Comment 482. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109780|0 |1 is obsolete| | --- Comment #582 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109783&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109781|0 |1 is obsolete| | --- Comment #583 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109784&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109782|0 |1 is obsolete| | --- Comment #584 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 109785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109785&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls Test plan in Comment 482. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #585 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Owen Leonard from comment #573)
I get an error when I click "Print slip and confirm" on a checked-in recall. The URL in the location bar is:
/cgi-bin/koha/recalls/recall_pickup_slip.pl?recall_id=
The error is:
Can't call method "itemnumber" on an undefined value at /kohadevbox/koha/recalls/recall_pickup_slip.pl line 42
When I check out the recalled item to the patron who requested it the recall is not cleared. It still shows up under the "Recalls" tab on the patrons account, saying "Ready for pickup."
When I run "perl misc/cronjobs/recalls/expire_recalls.pl" it doesn't seem to do anything :(
Hi Owen, thanks for testing. I have fixed the first two errors, however the expire_recalls.pl cronjob seems to work as expected for me. Perhaps check that the expiration date is set to before today (you'll need to adjust in the db manually) and try running? I believe this is good to test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Henry Bolshaw <bolshawh@parliament.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh@parliament.uk --- Comment #586 from Henry Bolshaw <bolshawh@parliament.uk> --- Hi Aleisha, this is a really exciting feature that I'm looking forward to testing! I think there must have been some changes to the schema recently because I'm getting a merge conflict when I try and apply the Updated schema files patch. Applying: Bug 19532: Updated schema files Using index info to reconstruct a base tree... M Koha/Schema/Result/Branch.pm M Koha/Schema/Result/Item.pm Falling back to patching base and 3-way merge... Auto-merging Koha/Schema/Result/Item.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Item.pm Auto-merging Koha/Schema/Result/Branch.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Branch.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Henry Bolshaw <bolshawh@parliament.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109775|0 |1 is obsolete| | --- Comment #587 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 111199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111199&action=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109776|0 |1 is obsolete| | --- Comment #588 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 111200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111200&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109777|0 |1 is obsolete| | --- Comment #589 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 111201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111201&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109778|0 |1 is obsolete| | --- Comment #590 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 111202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111202&action=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109779|0 |1 is obsolete| | --- Comment #591 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 111203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111203&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109783|0 |1 is obsolete| | --- Comment #592 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 111204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111204&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109784|0 |1 is obsolete| | --- Comment #593 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 111205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111205&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109785|0 |1 is obsolete| | --- Comment #594 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 111206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111206&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls Test plan in Comment 482. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Henry Bolshaw <bolshawh@parliament.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #595 from Henry Bolshaw <bolshawh@parliament.uk> --- After applying the patches, I'm getting an error trace page when viewing some patron pages: "The method Koha::Patron->recalls is not covered by tests!" This happens when I navigate to a patron on cgi-bin/koha/members/moremember.pl and cgi-bin/koha/circ/circulation.pl I thought this was possibly something I'd set up incorrectly in Koha Testing docker but I'm getting the same error with the sandboxes. On KTD the value for Confirm RecallsMaxPickUpDelay was empty rather than 7 but on the sandboxes it was set to 7 by default as expected. When I ran the tests on KTD I also got some errors: FAIL Koha/Schema/Result/Recall.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc FAIL forbidden patterns forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 15) There were also several instances of this error: FAIL forbidden patterns forbidden pattern: Script permissions is authnotrequired => 0, it could be correct for an OPAC script if it is was you really want error (bug 24663) (line 30) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111199|0 |1 is obsolete| | --- Comment #596 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 112316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112316&action=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111200|0 |1 is obsolete| | --- Comment #597 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 112317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112317&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111201|0 |1 is obsolete| | --- Comment #598 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 112321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112321&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111202|0 |1 is obsolete| | --- Comment #599 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 112322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112322&action=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111203|0 |1 is obsolete| | --- Comment #600 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 112323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112323&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111204|0 |1 is obsolete| | --- Comment #601 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 112324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112324&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111205|0 |1 is obsolete| | --- Comment #602 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 112325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112325&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111206|0 |1 is obsolete| | --- Comment #603 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 112326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112326&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls Test plan in Comment 482. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #604 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 112346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112346&action=edit Bug 19532: (follow-up) aria-hidden attr on OPAC, and more - removing authnotrequired flag from scripts - fixing opac buttons - chmod +x for recalls test files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #605 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 112472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112472&action=edit Bug 19532: (follow-up) Fixing failing CalcFine.t test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #606 from David Nind <david@davidnind.com> --- Created attachment 112491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112491&action=edit Screenshots - Your account screens display issues for recalls (2020-10-26) Hi Aleisha. I've got to the end of step 65 so far, and here are the two items I've noticed: 1. In the OPAC under your account, the your recalls history pages don't display correctly. The menu options under your account take up the whole width of the screen, and the your recalls history lists, forms and messages appear at the bottom of the page. I've attached screenshots so you can see what Imean. 2. When setting up an item for a course reserve (steps 33-36) an error occurs when listing items for a course reserve in the staff interface. I've created bug 26819 for this as it occurs on master before the recalls patches are applied, but does not occur on 20.05.x. An item is actually added to the course reserve, and you can view it in the OPAC to successfully complete these steps. The good news is that all the tests now pass (apart from the one false positive when running the qa scripts). David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #607 from David Nind <david@davidnind.com> --- Created attachment 112540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112540&action=edit Error trace - step 84 - circulation - recalls to pull Hi Aleisha. I'm now up to step 136, and here are two additional things noted: - Step 84: Circulation > Recalls to pull - get error trace when I try to access the page (file with error trace attached) - Step 118: had to use UPDATE recalls SET waitingdate = NOW() - interval 5 day WHERE recall_id = X; (using MariaDb, so not sure if this makes a difference). - I can't seem to get Circulation to work as expected (steps 137-149). I will have another go. . Step 143: the item is not renewable, but I can't see a "Recalled link". . Step 145: recall is not cancelled, and remains checked out. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112316|0 |1 is obsolete| | --- Comment #608 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 112612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112612&action=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112317|0 |1 is obsolete| | --- Comment #609 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 112613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112613&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112321|0 |1 is obsolete| | --- Comment #610 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 112614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112614&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112322|0 |1 is obsolete| | --- Comment #611 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 112615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112615&action=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112323|0 |1 is obsolete| | --- Comment #612 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 112616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112616&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112324|0 |1 is obsolete| | --- Comment #613 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 112617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112617&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112325|0 |1 is obsolete| | --- Comment #614 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 112618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112618&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112326|0 |1 is obsolete| | --- Comment #615 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 112619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112619&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls Test plan in Comment 482. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112346|0 |1 is obsolete| | --- Comment #616 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 112620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112620&action=edit Bug 19532: (follow-up) aria-hidden attr on OPAC, and more - removing authnotrequired flag from scripts - fixing opac buttons - chmod +x for recalls test files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112472|0 |1 is obsolete| | --- Comment #617 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 112621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112621&action=edit Bug 19532: (follow-up) Fixing failing CalcFine.t test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #618 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 112622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112622&action=edit Bug 19532: (follow-up) Fixing OPAC display and staff client errors - fixes the displays of opac-recalls.pl and opac-recall.pl - fix the error on Recalls to pull page - fix JS error preventing Recalled link from showing in checkouts table - fix cancelling of recall when checking out item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #619 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Thanks so much for your detailed comments David! (In reply to David Nind from comment #606)
1. In the OPAC under your account, the your recalls history pages don't display correctly. The menu options under your account take up the whole width of the screen, and the your recalls history lists, forms and messages appear at the bottom of the page. I've attached screenshots so you can see what Imean.
fixed
2. When setting up an item for a course reserve (steps 33-36) an error occurs when listing items for a course reserve in the staff interface. I've created bug 26819 for this as it occurs on master before the recalls patches are applied, but does not occur on 20.05.x. An item is actually added to the course reserve, and you can view it in the OPAC to successfully complete these steps.
I couldn't reproduce this problem but even so, I guess this is not a problem with Bug 19532 and there's nothing for me to do here.
- Step 84: Circulation > Recalls to pull - get error trace when I try to access the page (file with error trace attached)
fixed
- Step 118: had to use UPDATE recalls SET waitingdate = NOW() - interval 5 day WHERE recall_id = X; (using MariaDb, so not sure if this makes a difference).
yes good catch, the query I provided in the test plan doesn't work. please use this one instead!
- I can't seem to get Circulation to work as expected (steps 137-149). I will have another go. . Step 143: the item is not renewable, but I can't see a "Recalled link". . Step 145: recall is not cancelled, and remains checked out.
both fixed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #620 from David Nind <david@davidnind.com> --- Thanks Aleisha! I haven't gone through the whole test plan again, but this seems to have resolved things. However, when retesting BIBLIO-LEVEL RECALL, TRANSFER REQUIRED (steps 66-89) I can't seem to get the basic recall working properly - after checking out to Borrower A it is still showing as ready for pickup on the recall tab: 1. Check out Item A to Borrower B. 2. Log in to the OPAC as Borrower A. 3. Find Biblio A and place a biblio-level recall. 4. Item A checked in and recall confirmed - shows as ready for pickup. 5. After checking out Item A to Borrower A to fullfill the recall it is showing as: - OPAC for biblio: Checked out + On hold for Item A - your summary - checked out tab: message showing "The item has been recalled. Please return by the new due date." - your summary - recalls tab: showing as Ready for pickup - staff interface > patron account for Borrower A: item checked out to Borrower A under checkouts tab, recall showing as ready for pickup under recalls tab - still shows as ready for pickup under recalls queue and recalls awaiting pickup David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Needs Signoff |Patch doesn't apply --- Comment #621 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
2. Run database updates, update schema files and confirm everything applies cleanly
"update schema files" => the dbic command right? No diff after running, is that expected? Since last master pushes, patches don't applies anymore. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #622 from David Nind <david@davidnind.com> --- That's right - run the dbic command (if using koha-testing-docker). There were changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112613|0 |1 is obsolete| | --- Comment #623 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 113195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113195&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112614|0 |1 is obsolete| | --- Comment #624 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 113196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113196&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112615|0 |1 is obsolete| | --- Comment #625 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 113197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113197&action=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112616|0 |1 is obsolete| | --- Comment #626 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 113198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113198&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112617|0 |1 is obsolete| | --- Comment #627 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 113199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113199&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112618|0 |1 is obsolete| | --- Comment #628 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 113200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113200&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112619|0 |1 is obsolete| | --- Comment #629 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 113201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113201&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls == TEST PLAN FOR RECALLS == ADMINISTRATION 1. Apply all patches 2. Run database updates, update schema files and confirm everything applies cleanly 3. Run tests and confirm everything passes: t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t t/db_dependent/Stats.t t/db_dependent/Circulation/CalcFine.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Patron.t t/db_dependent/XSLT.t t/db_dependent/Search.t t/db_dependent/Holds.t t/db_dependent/Circulation/transferbook.t t/db_dependent/Circulation.t 4. Go to Administration -> system preferences. Find the UseRecalls system preference. It should be DISABLED. Confirm RecallsMaxPickUpDelay is set to 7 by default. 5. Go to Administration -> circulation rules. Confirm there are no recalls circulation rules showing. 6. Test a few circulation flows: checking out, placing a reserve, checking in, fulfilling a reserve, etc. Confirm everything works as normal. 7. Go to Administration -> system preferences. Enable the UseRecalls system preference. 8. Go to Administration -> circulation rules. Set the following rules: Recalls allowed (count) = 0 Recalls per record (count) = 0 On shelf recalls allowed ( If any unavailable / If all unavailable ) = If any unavailable Recall due date interval (days) = 3 Recall overdue fine amount = (something different to your normal fine amount) Recall pickup period (days) = 1 Throughout your testing, try with different combinations of these rules and itemtype / branchcode / categorycode. Also try with null values. Keep the circulation rules open in another tab so you can refer to and update these easily. You should also have at least one other tab open for the staff client, and a third tab open for the OPAC, for ease of testing. 9. Go to your account -> More -> Set permissions. Confirm the recalls permission is checked. 10. Set up a test user with OPAC login details (Borrower A). This could also be your own user, as long as you have OPAC login access. 11. Set up a test record (Biblio A) with at least two items (Item A and Item B) of the same item type (or an item type with the same recall circ rules). PLACING A RECALL 12. Log in to the OPAC as Borrower A. Do a catalogue search with a term that will return multiple results, including Biblio A. 13. Click on Biblio A. 14. Notice there is a 'Place recall' button on the sidebar menu. Click this button. There will be a message saying that there are no items to recall - this is because all items are available. 15. Check out Item A to another borrower (Borrower B). 16. Refresh the 'Place recall' page. You will still NOT be able to place a recall - this is because Recalls allowed = 0 and Recalls per record = 0. 17. Edit the circulation rules to have the following values: Recalls allowed (count) = 1 Recalls per record (count) = 1 18. Refresh the 'Place recall' page. You will now see the form to place a recall. BIBLIO-LEVEL RECALL, NO TRANSFER 19. Place a biblio-level recall. Pickup location: Branch A, the set branch when you are logged into the staff client Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 20. Confirm the recall is placed successfully. Confirm that the new due date displayed is correctly calculated to be today's date, plus 3 days (taken from the 'recall due date interval' circ rule) 21. In the staff client, look at Borrower B's account, and go to their Notices tab. Confirm they have received a 'Notification to return recalled item' notice. 22. Look at Borrower B's checkouts table. Notice the due date for their checkout has been adjusted, and there is now a note to say that the item was recalled and the due date adjusted. 23. Log in to the OPAC as Borrower B and go to your summary tab. Notice there is a note under their checkout to say the item had been recalled. 24. Log out of the OPAC and log back in as Borrower A. 25. Go to your summary tab. Confirm there is a Recalls tab with a count of 1. 26. Cancel the recall using the button. Confirm it cancels and the Recalls tab disappears. 27. Do a catalogue search with a term that will return multiple results, including Biblio A. 28. When the results load, notice there is a 'Place recall' button next to the 'Place hold' button. Click this 'Place recall' button. 29. Notice you are redirected straight to the form to place a recall. 30. Place a biblio-level recall again, following the steps in Step 19. 31. Go to your recalls history tab. Notice your first cancelled recall shows here. 32. Cancel the recall you just created, using the button. Confirm it cancels and you are redirected to your summary tab. 33. In the staff client, enable the UseCourseReserves system preference. 34. Go to the main menu, click Course Reserves. 35. Add a new course. (You may also have to define an authorised value for DEPARTMENT.) 36. Add Item A as a reserve to this course. 37. View Course Reserves in the OPAC. Click the course you just created. 38. Notice the reserve has a Recall button underneath it's 'Checked out' status. Click this button. 39. Place a biblio-level recall again, following the steps in Step 19. 40. Click the 'Place recall' link in the breadcrumbs. 41. Notice there is a message saying that you have reached the max number of recalls on this record. This is because Recalls allowed = 1 and Recalls per record = 1. 42. Edit the circulation rules to have the following values: Recalls allowed (count) = 10 Recalls per record (count) = 5 43. Refresh the 'Place recall' page. You will now see the form to place a recall. 44. Create another test record (Biblio B) with at least one item (Item C). 45. Find this record on the OPAC and place a biblio-level recall again, following the steps in Step 19. 46. In the staff client, go to Circulation -> Old recalls. You should be able to see your two cancelled recalls. 47. Go to Circulation -> Recalls queue. Your current recalls should show here. 48. Use the 'Select all' checkbox to select all recalls. 49. Cancel the recalls using the 'Cancel selected recalls' button. 50. Go to the OPAC and place a biblio-level recall on Biblio A again, following the steps in Step 19. 51. In the staff client, check in Item A, which should still be checked out to Borrower B. 52. A box should pop-up asking you to confirm Borrower A's recall. Click ignore. 53. Click the link to go view Biblio A's details in the catalogue. 54. Click the recalls tab. Notice Borrower A's recall is displayed, and shows it is still Requested (has not been confirmed waiting). 55. Check in Item A again. This time, confirm the recall as waiting using the "Confirm recall" button. 56. Go to Borrower A's Notices tab. Confirm there is a notice "Recalled item awaiting pickup". 57. Go to Borrower A's checkouts. Notice there is a recalls tab. Confirm the recall is showing as "Ready for pickup". 58. Click the 'Actions' dropdown. Click the "Revert waiting" button. The page should show that the status is revert to Requested without reloading. 59. This time, check in Item B. The recall confirmation box should show again, because this a biblio-level recall that any recallable item under Biblio A can fill. Click the "Print slip and confirm" button. 60. Check the slip that is generated. Confirm it contains Borrower A's correct details, and the details of the recall are correct. 61. Go to Circulation -> Recalls awaiting pickup. Confirm the recall is now waiting and shows in this list. (You could also try this with Item B having a different item type to Item A, and circ rules not allowing Item B's item type to have recalls. When checking in Item A, it should not trigger the recall box). 62. Go to Borrower A's checkouts. Check out Item B. 63. Confirm the checkout is successful and the recall is removed from the Recalls tab. 64. Go to Circulation -> Old recalls. The fulfilled recall should show. 65. Check in Item B. BIBLIO-LEVEL RECALL, TRANSFER REQUIRED 66. Check out Item A to Borrower B. 67. Log in to the OPAC as Borrower A. 68. Find Biblio A and place a biblio-level recall. Pickup location: Branch B, a different branch from your logged in branch. This recall will require a transfer. Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 69. In the staff client, check in Item A at Branch A. Notice the box that pops up shows that a transfer is required. 70. Click "confirm recall and transfer" and confirm the transfer. 71. Go to your account and click the Recalls tab. 72. Confirm the recall status now shows the item is in transit to Branch B. 73. In the drop-down top-right of your window, select 'Set library'. 74. Set your library to Branch B. 75. Go to Circulation -> Transfers to receive. Notice that the recall is showing here. 76. Click 'Cancel transfer'. 77. Go to Circulation -> Recalls queue 78. Confirm the recall status has been reverted to Requested. 79. Set your library back to Branch A. 80. Check in Item A and trigger the transfer. 81. Set your library back to Branch B. 82. Check in Item A at Branch B. 83. When the 'Recall found' box pops up, click Ignore. 84. Go to Circulation -> Recalls to pull. The recall should show here, with a button to "Cancel recall and return to: Branch A" 85. Click the button to cancel the recall. 86. Repeat Steps 66-70. 87. Check in Item A at Branch B. Confirm the recall as waiting. 88. Check out Item A to Borrower A to fulfill the recall. 89. Set your library back to Branch A and check in Item A. ITEM-LEVEL RECALL, NO TRANSFER 90. Go to Administration -> circulation rules. Set the following rules: On shelf recalls allowed ( If any unavailable / If all unavailable ) = If all unavailable 91. Check out Item A to Borrower B. 92. Log in to the OPAC as Borrower A and go to Biblio A. 93. Click the 'Place recall' button. Confirm there is a message that there are no items to recall. This is because On shelf recalls allowed = If all unavailable, and there is still one item (Item B) available. 94. In the staff client, edit Item B to have a withdrawn, item lost or not for loan status. 95. Refresh the 'Place recall' page. Confirm you can now see the form to place a recall. 96. Place an item-level recall. Pickup location: Branch A. Recall not needed after (expiration date): whatever you want Select 'recall a specific item' Item B will not be selectable, and Item A should be selected by default. Click confirm 97. In the staff client, edit Item B and remove the lost or missing status. 98. Check in Item B. Confirm the recall box does not pop up, because it cannot fill the item-level recall. 99. Check in Item A. Confirm the recall as waiting. 100. Go to Circulation -> Recalls awaiting pickup 101. Expire the recall. Confirm it expires as expected. ITEM-LEVEL RECALL, TRANSFER REQUIRED 102. Repeat steps 91 to 95. 103. Place an item-level recall. Pickup location: Branch B, we will require a transfer. Recall not needed after (expiration date): whatever you want Select 'recall a specific item' Item B will not be selectable, and Item A should be selected by default. Click confirm 104. In the staff client, check in Item A. Confirm the recall and trigger the transfer. 105. Set your library to Branch B and check in Item A. 106. Confirm the recall as waiting. 107. Check out Item A to Borrower A and fulfill the recall. 108. Set your library back to Branch A and check in Item A. CRONJOBS: EXPIRING RECALL 109. Check out Item A to Borrower B. 110. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 111. In your terminal, enter mysql and edit the expiration date of your recall to be before today UPDATE recalls SET expirationdate = NOW()-2 WHERE recall_id = X; 112. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 113. Go to Borrower A's account and go to the Recalls history tab 114. Confirm the recall has been expired because the current date surpassed the specified expiration date 115. Check out Item A to Borrower B. 116. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 117. In the staff client, check in Item A and confirm the recall as waiting. 118. In your terminal, enter mysql and edit the waiting date of your recall to be before today UPDATE recalls SET waitingdate = NOW() - interval 5 day WHERE recall_id = X; 119. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 120. Go to Borrower A's account and go to the Recalls history tab 121. Confirm the recall has been expired because the recall had been waiting for more days than the Recall pickup period 122. Go to Administration -> circulation rules. Set the following rules: Recall pickup period (days) = 0 123. Set the RecallsMaxPickUpDelay system preference = 1. 124. Check out Item A to Borrower B. 125. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 126. In the staff client, check in Item A and confirm the recall as waiting. 127. In your terminal, enter mysql and edit the waiting date of your recall to be before today UPDATE recalls SET waitingdate = NOW()-2 WHERE recall_id = X; 128. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 129. Go to Borrower A's account and go to the Recalls history tab 130. Confirm the recall has been expired because the recall had been waiting for more days than the RecallsMaxPickUpDelay syspref CRONJOBS: OVERDUE RECALL 131. Check out Item A to Borrower B 132. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 133. In your terminal, enter mysql and edit the due date of the checkout to Borrower B to be before today UPDATE issues SET date_due = NOW()-2 WHERE issue_id = X; 134. Run the overdue cronjob from within your shell perl misc/cronjobs/recall/overdue_recalls.pl 135. Go to Circulation -> Overdue recalls 136. Confirm your recall is showing here now as the recall has been marked Overdue CIRCULATION 137. Check in Item A. 138. When the recall box pops up, click Ignore. 139. Check out Item A to Borrower B. You should see a yellow confirmation box, saying that another borrower has recalled the item you are trying to check out. 140. Click "No don't check out" and confirm the item isn't checked out and the recall remains. 141. Repeat Step 139. 142. Click "Yes check out" and confirm the item is checked out and the recall remains. 143. When Borrower B's checkout table loads, confirm that you cannot renew or check in the item from the Checkouts table because there is a 'Recalled' link which takes you to the recalls tab for that biblio. 144. Repeat Steps 137-139. 145. Select "Cancel recall" and click "Yes check out" and confirm the item is checked out and the recall has been cancelled. 146. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 147. Check in Item A. Confirm the recall as waiting. 148. Check out Item A to Borrower B. You should see a yellow confirmation box, saying that that another borrower has recalled the item that you are trying to check out. 149. Select "Revert waiting status" and click "Yes check out" and confirm the item is checked out and the recall status has reverted to requested. OTHER 150. In your terminal, enter mysql and edit the due date of the checkout to Borrower B to be before today UPDATE issues SET date_due = NOW()-2 WHERE issue_id = X; 151. Go to Borrower A's recalls and click the Actions dropdown. 152. Click "Mark as overdue" and confirm the recall is marked as overdue manually. 153. Go to Tools -> Log Viewer. Check only the Recalls module, and leave all other parameters, and click Submit. 154. Confirm all of the recalls actions that have been made are correctly logged. Note: recalls messaging preferences are introduced in Bug 23781. The recall feature is fully documented at: https://wiki.koha-community.org/wiki/Catalyst_IT_Recalls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112620|0 |1 is obsolete| | --- Comment #630 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 113202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113202&action=edit Bug 19532: (follow-up) aria-hidden attr on OPAC, and more - removing authnotrequired flag from scripts - fixing opac buttons - chmod +x for recalls test files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112621|0 |1 is obsolete| | --- Comment #631 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 113203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113203&action=edit Bug 19532: (follow-up) Fixing failing CalcFine.t test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112622|0 |1 is obsolete| | --- Comment #632 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 113204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113204&action=edit Bug 19532: (follow-up) Fixing OPAC display and staff client errors - fixes the displays of opac-recalls.pl and opac-recall.pl - fix the error on Recalls to pull page - fix JS error preventing Recalled link from showing in checkouts table - fix cancelling of recall when checking out item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #633 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 113205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113205&action=edit Bug 19532: (follow-up) Fix undef recall_id preventing fulfillment of recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #634 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Thanks David and Victor, I have rebased and fixed the bug that David mentioned, ready again for testing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #635 from David Nind <david@davidnind.com> --- Hi Aleisha. I went through the test plan again, ran the tests, and ran the qa scripts. 1. Test plan: there is only one minor item that isn't working as expected - I noted previously, but didn't report it. I think it is pretty minor, so could wait. Step 58. Need to refresh the page to see the change in status (from ready for pickup TO Requested). 2. Tests: one test fails for prove -v t/db_dependent/Koha/Recalls.t not ok 19 - Recall fulfilled with move_recall # Failed test 'Recall fulfilled with move_recall' # at t/db_dependent/Koha/Recalls.t line 173. # Looks like you failed 1 test of 19. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/19 subtests Test Summary Report ------------------- t/db_dependent/Koha/Recalls.t (Wstat: 256 Tests: 19 Failed: 1) Failed test: 19 Non-zero exit status: 1 Files=1, Tests=19, 3 wallclock secs ( 0.02 usr 0.01 sys + 2.75 cusr 0.26 csys = 3.04 CPU) Result: FAIL 3. QA scripts: I ran the qa scripts (not something I normally do) I've put the output from the test fail and qa output here: http://paste.koha-community.org/26033 David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112612|0 |1 is obsolete| | --- Comment #636 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 113286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113286&action=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113195|0 |1 is obsolete| | --- Comment #637 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 113287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113287&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113196|0 |1 is obsolete| | --- Comment #638 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 113288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113288&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113197|0 |1 is obsolete| | --- Comment #639 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 113289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113289&action=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113198|0 |1 is obsolete| | --- Comment #640 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 113290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113290&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113199|0 |1 is obsolete| | --- Comment #641 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 113291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113291&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113200|0 |1 is obsolete| | --- Comment #642 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 113292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113292&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113201|0 |1 is obsolete| | --- Comment #643 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 113293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113293&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls == TEST PLAN FOR RECALLS == ADMINISTRATION 1. Apply all patches 2. Run database updates, update schema files and confirm everything applies cleanly 3. Run tests and confirm everything passes: t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t t/db_dependent/Stats.t t/db_dependent/Circulation/CalcFine.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Patron.t t/db_dependent/XSLT.t t/db_dependent/Search.t t/db_dependent/Holds.t t/db_dependent/Circulation/transferbook.t t/db_dependent/Circulation.t 4. Go to Administration -> system preferences. Find the UseRecalls system preference. It should be DISABLED. Confirm RecallsMaxPickUpDelay is set to 7 by default. 5. Go to Administration -> circulation rules. Confirm there are no recalls circulation rules showing. 6. Test a few circulation flows: checking out, placing a reserve, checking in, fulfilling a reserve, etc. Confirm everything works as normal. 7. Go to Administration -> system preferences. Enable the UseRecalls system preference. 8. Go to Administration -> circulation rules. Set the following rules: Recalls allowed (count) = 0 Recalls per record (count) = 0 On shelf recalls allowed ( If any unavailable / If all unavailable ) = If any unavailable Recall due date interval (days) = 3 Recall overdue fine amount = (something different to your normal fine amount) Recall pickup period (days) = 1 Throughout your testing, try with different combinations of these rules and itemtype / branchcode / categorycode. Also try with null values. Keep the circulation rules open in another tab so you can refer to and update these easily. You should also have at least one other tab open for the staff client, and a third tab open for the OPAC, for ease of testing. 9. Go to your account -> More -> Set permissions. Confirm the recalls permission is checked. 10. Set up a test user with OPAC login details (Borrower A). This could also be your own user, as long as you have OPAC login access. 11. Set up a test record (Biblio A) with at least two items (Item A and Item B) of the same item type (or an item type with the same recall circ rules). PLACING A RECALL 12. Log in to the OPAC as Borrower A. Do a catalogue search with a term that will return multiple results, including Biblio A. 13. Click on Biblio A. 14. Notice there is a 'Place recall' button on the sidebar menu. Click this button. There will be a message saying that there are no items to recall - this is because all items are available. 15. Check out Item A to another borrower (Borrower B). 16. Refresh the 'Place recall' page. You will still NOT be able to place a recall - this is because Recalls allowed = 0 and Recalls per record = 0. 17. Edit the circulation rules to have the following values: Recalls allowed (count) = 1 Recalls per record (count) = 1 18. Refresh the 'Place recall' page. You will now see the form to place a recall. BIBLIO-LEVEL RECALL, NO TRANSFER 19. Place a biblio-level recall. Pickup location: Branch A, the set branch when you are logged into the staff client Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 20. Confirm the recall is placed successfully. Confirm that the new due date displayed is correctly calculated to be today's date, plus 3 days (taken from the 'recall due date interval' circ rule) 21. In the staff client, look at Borrower B's account, and go to their Notices tab. Confirm they have received a 'Notification to return recalled item' notice. 22. Look at Borrower B's checkouts table. Notice the due date for their checkout has been adjusted, and there is now a note to say that the item was recalled and the due date adjusted. 23. Log in to the OPAC as Borrower B and go to your summary tab. Notice there is a note under their checkout to say the item had been recalled. 24. Log out of the OPAC and log back in as Borrower A. 25. Go to your summary tab. Confirm there is a Recalls tab with a count of 1. 26. Cancel the recall using the button. Confirm it cancels and the Recalls tab disappears. 27. Do a catalogue search with a term that will return multiple results, including Biblio A. 28. When the results load, notice there is a 'Place recall' button next to the 'Place hold' button. Click this 'Place recall' button. 29. Notice you are redirected straight to the form to place a recall. 30. Place a biblio-level recall again, following the steps in Step 19. 31. Go to your recalls history tab. Notice your first cancelled recall shows here. 32. Cancel the recall you just created, using the button. Confirm it cancels and you are redirected to your summary tab. 33. In the staff client, enable the UseCourseReserves system preference. 34. Go to the main menu, click Course Reserves. 35. Add a new course. (You may also have to define an authorised value for DEPARTMENT.) 36. Add Item A as a reserve to this course. 37. View Course Reserves in the OPAC. Click the course you just created. 38. Notice the reserve has a Recall button underneath it's 'Checked out' status. Click this button. 39. Place a biblio-level recall again, following the steps in Step 19. 40. Click the 'Place recall' link in the breadcrumbs. 41. Notice there is a message saying that you have reached the max number of recalls on this record. This is because Recalls allowed = 1 and Recalls per record = 1. 42. Edit the circulation rules to have the following values: Recalls allowed (count) = 10 Recalls per record (count) = 5 43. Refresh the 'Place recall' page. You will now see the form to place a recall. 44. Create another test record (Biblio B) with at least one item (Item C). 45. Find this record on the OPAC and place a biblio-level recall again, following the steps in Step 19. 46. In the staff client, go to Circulation -> Old recalls. You should be able to see your two cancelled recalls. 47. Go to Circulation -> Recalls queue. Your current recalls should show here. 48. Use the 'Select all' checkbox to select all recalls. 49. Cancel the recalls using the 'Cancel selected recalls' button. 50. Go to the OPAC and place a biblio-level recall on Biblio A again, following the steps in Step 19. 51. In the staff client, check in Item A, which should still be checked out to Borrower B. 52. A box should pop-up asking you to confirm Borrower A's recall. Click ignore. 53. Click the link to go view Biblio A's details in the catalogue. 54. Click the recalls tab. Notice Borrower A's recall is displayed, and shows it is still Requested (has not been confirmed waiting). 55. Check in Item A again. This time, confirm the recall as waiting using the "Confirm recall" button. 56. Go to Borrower A's Notices tab. Confirm there is a notice "Recalled item awaiting pickup". 57. Go to Borrower A's checkouts. Notice there is a recalls tab. Confirm the recall is showing as "Ready for pickup". 58. Click the 'Actions' dropdown. Click the "Revert waiting" button. The page should show a message that the waiting status has been reverted, without reloading. 59. This time, check in Item B. The recall confirmation box should show again, because this a biblio-level recall that any recallable item under Biblio A can fill. Click the "Print slip and confirm" button. 60. Check the slip that is generated. Confirm it contains Borrower A's correct details, and the details of the recall are correct. 61. Go to Circulation -> Recalls awaiting pickup. Confirm the recall is now waiting and shows in this list. (You could also try this with Item B having a different item type to Item A, and circ rules not allowing Item B's item type to have recalls. When checking in Item A, it should not trigger the recall box). 62. Go to Borrower A's checkouts. Check out Item B. 63. Confirm the checkout is successful and the recall is removed from the Recalls tab. 64. Go to Circulation -> Old recalls. The fulfilled recall should show. 65. Check in Item B. BIBLIO-LEVEL RECALL, TRANSFER REQUIRED 66. Check out Item A to Borrower B. 67. Log in to the OPAC as Borrower A. 68. Find Biblio A and place a biblio-level recall. Pickup location: Branch B, a different branch from your logged in branch. This recall will require a transfer. Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 69. In the staff client, check in Item A at Branch A. Notice the box that pops up shows that a transfer is required. 70. Click "confirm recall and transfer" and confirm the transfer. 71. Go to your account and click the Recalls tab. 72. Confirm the recall status now shows the item is in transit to Branch B. 73. In the drop-down top-right of your window, select 'Set library'. 74. Set your library to Branch B. 75. Go to Circulation -> Transfers to receive. Notice that the recall is showing here. 76. Click 'Cancel transfer'. 77. Go to Circulation -> Recalls queue 78. Confirm the recall status has been reverted to Requested. 79. Set your library back to Branch A. 80. Check in Item A and trigger the transfer. 81. Set your library back to Branch B. 82. Check in Item A at Branch B. 83. When the 'Recall found' box pops up, click Ignore. 84. Go to Circulation -> Recalls to pull. The recall should show here, with a button to "Cancel recall and return to: Branch A" 85. Click the button to cancel the recall. 86. Repeat Steps 66-70. 87. Check in Item A at Branch B. Confirm the recall as waiting. 88. Check out Item A to Borrower A to fulfill the recall. 89. Set your library back to Branch A and check in Item A. ITEM-LEVEL RECALL, NO TRANSFER 90. Go to Administration -> circulation rules. Set the following rules: On shelf recalls allowed ( If any unavailable / If all unavailable ) = If all unavailable 91. Check out Item A to Borrower B. 92. Log in to the OPAC as Borrower A and go to Biblio A. 93. Click the 'Place recall' button. Confirm there is a message that there are no items to recall. This is because On shelf recalls allowed = If all unavailable, and there is still one item (Item B) available. 94. In the staff client, edit Item B to have a withdrawn, item lost or not for loan status. 95. Refresh the 'Place recall' page. Confirm you can now see the form to place a recall. 96. Place an item-level recall. Pickup location: Branch A. Recall not needed after (expiration date): whatever you want Select 'recall a specific item' Item B will not be selectable, and Item A should be selected by default. Click confirm 97. In the staff client, edit Item B and remove the lost or missing status. 98. Check in Item B. Confirm the recall box does not pop up, because it cannot fill the item-level recall. 99. Check in Item A. Confirm the recall as waiting. 100. Go to Circulation -> Recalls awaiting pickup 101. Expire the recall. Confirm it expires as expected. ITEM-LEVEL RECALL, TRANSFER REQUIRED 102. Repeat steps 91 to 95. 103. Place an item-level recall. Pickup location: Branch B, we will require a transfer. Recall not needed after (expiration date): whatever you want Select 'recall a specific item' Item B will not be selectable, and Item A should be selected by default. Click confirm 104. In the staff client, check in Item A. Confirm the recall and trigger the transfer. 105. Set your library to Branch B and check in Item A. 106. Confirm the recall as waiting. 107. Check out Item A to Borrower A and fulfill the recall. 108. Set your library back to Branch A and check in Item A. CRONJOBS: EXPIRING RECALL 109. Check out Item A to Borrower B. 110. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 111. In your terminal, enter mysql and edit the expiration date of your recall to be before today UPDATE recalls SET expirationdate = NOW()-2 WHERE recall_id = X; 112. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 113. Go to Borrower A's account and go to the Recalls history tab 114. Confirm the recall has been expired because the current date surpassed the specified expiration date 115. Check out Item A to Borrower B. 116. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 117. In the staff client, check in Item A and confirm the recall as waiting. 118. In your terminal, enter mysql and edit the waiting date of your recall to be before today UPDATE recalls SET waitingdate = NOW() - interval 5 day WHERE recall_id = X; 119. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 120. Go to Borrower A's account and go to the Recalls history tab 121. Confirm the recall has been expired because the recall had been waiting for more days than the Recall pickup period 122. Go to Administration -> circulation rules. Set the following rules: Recall pickup period (days) = 0 123. Set the RecallsMaxPickUpDelay system preference = 1. 124. Check out Item A to Borrower B. 125. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 126. In the staff client, check in Item A and confirm the recall as waiting. 127. In your terminal, enter mysql and edit the waiting date of your recall to be before today UPDATE recalls SET waitingdate = NOW()-2 WHERE recall_id = X; 128. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 129. Go to Borrower A's account and go to the Recalls history tab 130. Confirm the recall has been expired because the recall had been waiting for more days than the RecallsMaxPickUpDelay syspref CRONJOBS: OVERDUE RECALL 131. Check out Item A to Borrower B 132. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 133. In your terminal, enter mysql and edit the due date of the checkout to Borrower B to be before today UPDATE issues SET date_due = NOW()-2 WHERE issue_id = X; 134. Run the overdue cronjob from within your shell perl misc/cronjobs/recall/overdue_recalls.pl 135. Go to Circulation -> Overdue recalls 136. Confirm your recall is showing here now as the recall has been marked Overdue CIRCULATION 137. Check in Item A. 138. When the recall box pops up, click Ignore. 139. Check out Item A to Borrower B. You should see a yellow confirmation box, saying that another borrower has recalled the item you are trying to check out. 140. Click "No don't check out" and confirm the item isn't checked out and the recall remains. 141. Repeat Step 139. 142. Click "Yes check out" and confirm the item is checked out and the recall remains. 143. When Borrower B's checkout table loads, confirm that you cannot renew or check in the item from the Checkouts table because there is a 'Recalled' link which takes you to the recalls tab for that biblio. 144. Repeat Steps 137-139. 145. Select "Cancel recall" and click "Yes check out" and confirm the item is checked out and the recall has been cancelled. 146. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 147. Check in Item A. Confirm the recall as waiting. 148. Check out Item A to Borrower B. You should see a yellow confirmation box, saying that that another borrower has recalled the item that you are trying to check out. 149. Select "Revert waiting status" and click "Yes check out" and confirm the item is checked out and the recall status has reverted to requested. OTHER 150. In your terminal, enter mysql and edit the due date of the checkout to Borrower B to be before today UPDATE issues SET date_due = NOW()-2 WHERE issue_id = X; 151. Go to Borrower A's recalls and click the Actions dropdown. 152. Click "Mark as overdue" and confirm the recall is marked as overdue manually. 153. Go to Tools -> Log Viewer. Check only the Recalls module, and leave all other parameters, and click Submit. 154. Confirm all of the recalls actions that have been made are correctly logged. Note: recalls messaging preferences are introduced in Bug 23781. The recall feature is fully documented at: https://wiki.koha-community.org/wiki/Catalyst_IT_Recalls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113202|0 |1 is obsolete| | --- Comment #644 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 113294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113294&action=edit Bug 19532: (follow-up) aria-hidden attr on OPAC, and more - removing authnotrequired flag from scripts - fixing opac buttons - chmod +x for recalls test files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113203|0 |1 is obsolete| | --- Comment #645 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 113295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113295&action=edit Bug 19532: (follow-up) Fixing failing CalcFine.t test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113204|0 |1 is obsolete| | --- Comment #646 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 113296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113296&action=edit Bug 19532: (follow-up) Fixing OPAC display and staff client errors - fixes the displays of opac-recalls.pl and opac-recall.pl - fix the error on Recalls to pull page - fix JS error preventing Recalled link from showing in checkouts table - fix cancelling of recall when checking out item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113205|0 |1 is obsolete| | --- Comment #647 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 113297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113297&action=edit Bug 19532: (follow-up) Fix undef recall_id preventing fulfillment of recall -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #648 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 113298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113298&action=edit Bug 19532: (follow-up) Fixing tests and QA tools And making reverted ajax message clearer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | --- Comment #649 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am sorry Aleisha, this one missed the line for 20.11. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #650 from David Nind <david@davidnind.com> --- Hi Aleisha. I was too slow 8-(... Hopefully 21.05! All the tests now pass! However, when I go to Administration > Patrons and circulation > Circulation and fines rules (after applying the patches, database update, dbic, and restart_all) I now get a trace error, which starts with: Could not compile /kohadevbox/koha/admin/smart-rules.pl: syntax error at /kohadevbox/koha/admin/smart-rules.pl line 343, near ">>" Global symbol "$bor" requires explicit package name (did you forget to declare "my $bor"?) at /kohadevbox/koha/admin/smart-rules.pl line 348. Global symbol "$bor" requires explicit package name (did you forget to declare "my $bor"?) at /kohadevbox/koha/admin/smart-rules.pl line 348. Global symbol "$itemtype" requires explicit package name (did you forget to declare "my $itemtype"?) at /kohadevbox/koha/admin/smart-rules.pl line 349. Global symbol "$itemtype" requires explicit package name (did you forget to declare "my $itemtype"?) at /kohadevbox/koha/admin/smart-rules.pl line 349. Global symbol "$br" requires explicit package name (did you forget to declare "my $br"?) at /kohadevbox/koha/admin/smart-rules.pl line 350. Global symbol "$br" requires explicit package name (did you forget to declare "my $br"?) at /kohadevbox/koha/admin/smart-rules.pl line 350. Global symbol "$rules" requires explicit package name (did you forget to declare "my $rules"?) at /kohadevbox/koha/admin/smart-rules.pl line 351. syntax error at /kohadevbox/koha/admin/smart-rules.pl line 356, near "elsif" Can't redeclare "my" in "my" at /kohadevbox/koha/admin/smart-rules.pl line 358, near "" /kohadevbox/koha/admin/smart-rules.pl has too many errors. at /usr/share/perl5/CGI/Compile.pm line 132 in CGI::Compile::compile at /usr/share/perl5/CGI/Compile.pm line 132 129: my $code = $self->_eval($eval); 130: my $exception = $@; 131: 132: die "Could not compile $script: $exception" if $exception; 133: 134: sub { 135: my @args = @_; There is also a QA fail: ... OK Makefile.PL FAIL admin/smart-rules.pl FAIL valid Number found where operator expected (Do you need to predeclare Bug?) "my" variable $input masks earlier declaration in same scope syntax error Global symbol "$bor" requires explicit package name (did you forget to declare "my $bor"?) Global symbol "$bor" requires explicit package name (did you forget to declare "my $bor"?) Global symbol "$itemtype" requires explicit package name (did you forget to declare "my $itemtype"?) Global symbol "$itemtype" requires explicit package name (did you forget to declare "my $itemtype"?) Global symbol "$br" requires explicit package name (did you forget to declare "my $br"?) Global symbol "$br" requires explicit package name (did you forget to declare "my $br"?) Global symbol "$rules" requires explicit package name (did you forget to declare "my $rules"?) syntax error Can't redeclare "my" in "my" admin/smart-rules.pl has too many errors. OK catalogue/detail.pl ... David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #651 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 113335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113335&action=edit Bug 19532: (follow-up) Remove bad merge conflict markers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113286|0 |1 is obsolete| | --- Comment #652 from David Nind <david@davidnind.com> --- Created attachment 113351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113351&action=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113287|0 |1 is obsolete| | --- Comment #653 from David Nind <david@davidnind.com> --- Created attachment 113352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113352&action=edit Bug 19532: Updated schema files Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113288|0 |1 is obsolete| | --- Comment #654 from David Nind <david@davidnind.com> --- Created attachment 113353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113353&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113289|0 |1 is obsolete| | --- Comment #655 from David Nind <david@davidnind.com> --- Created attachment 113354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113354&action=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113290|0 |1 is obsolete| | --- Comment #656 from David Nind <david@davidnind.com> --- Created attachment 113355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113355&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113291|0 |1 is obsolete| | --- Comment #657 from David Nind <david@davidnind.com> --- Created attachment 113356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113356&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113292|0 |1 is obsolete| | --- Comment #658 from David Nind <david@davidnind.com> --- Created attachment 113357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113357&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113293|0 |1 is obsolete| | --- Comment #659 from David Nind <david@davidnind.com> --- Created attachment 113358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113358&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls == TEST PLAN FOR RECALLS == ADMINISTRATION 1. Apply all patches 2. Run database updates, update schema files and confirm everything applies cleanly 3. Run tests and confirm everything passes: t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t t/db_dependent/Stats.t t/db_dependent/Circulation/CalcFine.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Patron.t t/db_dependent/XSLT.t t/db_dependent/Search.t t/db_dependent/Holds.t t/db_dependent/Circulation/transferbook.t t/db_dependent/Circulation.t 4. Go to Administration -> system preferences. Find the UseRecalls system preference. It should be DISABLED. Confirm RecallsMaxPickUpDelay is set to 7 by default. 5. Go to Administration -> circulation rules. Confirm there are no recalls circulation rules showing. 6. Test a few circulation flows: checking out, placing a reserve, checking in, fulfilling a reserve, etc. Confirm everything works as normal. 7. Go to Administration -> system preferences. Enable the UseRecalls system preference. 8. Go to Administration -> circulation rules. Set the following rules: Recalls allowed (count) = 0 Recalls per record (count) = 0 On shelf recalls allowed ( If any unavailable / If all unavailable ) = If any unavailable Recall due date interval (days) = 3 Recall overdue fine amount = (something different to your normal fine amount) Recall pickup period (days) = 1 Throughout your testing, try with different combinations of these rules and itemtype / branchcode / categorycode. Also try with null values. Keep the circulation rules open in another tab so you can refer to and update these easily. You should also have at least one other tab open for the staff client, and a third tab open for the OPAC, for ease of testing. 9. Go to your account -> More -> Set permissions. Confirm the recalls permission is checked. 10. Set up a test user with OPAC login details (Borrower A). This could also be your own user, as long as you have OPAC login access. 11. Set up a test record (Biblio A) with at least two items (Item A and Item B) of the same item type (or an item type with the same recall circ rules). PLACING A RECALL 12. Log in to the OPAC as Borrower A. Do a catalogue search with a term that will return multiple results, including Biblio A. 13. Click on Biblio A. 14. Notice there is a 'Place recall' button on the sidebar menu. Click this button. There will be a message saying that there are no items to recall - this is because all items are available. 15. Check out Item A to another borrower (Borrower B). 16. Refresh the 'Place recall' page. You will still NOT be able to place a recall - this is because Recalls allowed = 0 and Recalls per record = 0. 17. Edit the circulation rules to have the following values: Recalls allowed (count) = 1 Recalls per record (count) = 1 18. Refresh the 'Place recall' page. You will now see the form to place a recall. BIBLIO-LEVEL RECALL, NO TRANSFER 19. Place a biblio-level recall. Pickup location: Branch A, the set branch when you are logged into the staff client Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 20. Confirm the recall is placed successfully. Confirm that the new due date displayed is correctly calculated to be today's date, plus 3 days (taken from the 'recall due date interval' circ rule) 21. In the staff client, look at Borrower B's account, and go to their Notices tab. Confirm they have received a 'Notification to return recalled item' notice. 22. Look at Borrower B's checkouts table. Notice the due date for their checkout has been adjusted, and there is now a note to say that the item was recalled and the due date adjusted. 23. Log in to the OPAC as Borrower B and go to your summary tab. Notice there is a note under their checkout to say the item had been recalled. 24. Log out of the OPAC and log back in as Borrower A. 25. Go to your summary tab. Confirm there is a Recalls tab with a count of 1. 26. Cancel the recall using the button. Confirm it cancels and the Recalls tab disappears. 27. Do a catalogue search with a term that will return multiple results, including Biblio A. 28. When the results load, notice there is a 'Place recall' button next to the 'Place hold' button. Click this 'Place recall' button. 29. Notice you are redirected straight to the form to place a recall. 30. Place a biblio-level recall again, following the steps in Step 19. 31. Go to your recalls history tab. Notice your first cancelled recall shows here. 32. Cancel the recall you just created, using the button. Confirm it cancels and you are redirected to your summary tab. 33. In the staff client, enable the UseCourseReserves system preference. 34. Go to the main menu, click Course Reserves. 35. Add a new course. (You may also have to define an authorised value for DEPARTMENT.) 36. Add Item A as a reserve to this course. 37. View Course Reserves in the OPAC. Click the course you just created. 38. Notice the reserve has a Recall button underneath it's 'Checked out' status. Click this button. 39. Place a biblio-level recall again, following the steps in Step 19. 40. Click the 'Place recall' link in the breadcrumbs. 41. Notice there is a message saying that you have reached the max number of recalls on this record. This is because Recalls allowed = 1 and Recalls per record = 1. 42. Edit the circulation rules to have the following values: Recalls allowed (count) = 10 Recalls per record (count) = 5 43. Refresh the 'Place recall' page. You will now see the form to place a recall. 44. Create another test record (Biblio B) with at least one item (Item C). 45. Find this record on the OPAC and place a biblio-level recall again, following the steps in Step 19. 46. In the staff client, go to Circulation -> Old recalls. You should be able to see your two cancelled recalls. 47. Go to Circulation -> Recalls queue. Your current recalls should show here. 48. Use the 'Select all' checkbox to select all recalls. 49. Cancel the recalls using the 'Cancel selected recalls' button. 50. Go to the OPAC and place a biblio-level recall on Biblio A again, following the steps in Step 19. 51. In the staff client, check in Item A, which should still be checked out to Borrower B. 52. A box should pop-up asking you to confirm Borrower A's recall. Click ignore. 53. Click the link to go view Biblio A's details in the catalogue. 54. Click the recalls tab. Notice Borrower A's recall is displayed, and shows it is still Requested (has not been confirmed waiting). 55. Check in Item A again. This time, confirm the recall as waiting using the "Confirm recall" button. 56. Go to Borrower A's Notices tab. Confirm there is a notice "Recalled item awaiting pickup". 57. Go to Borrower A's checkouts. Notice there is a recalls tab. Confirm the recall is showing as "Ready for pickup". 58. Click the 'Actions' dropdown. Click the "Revert waiting" button. The page should show a message that the waiting status has been reverted, without reloading. 59. This time, check in Item B. The recall confirmation box should show again, because this a biblio-level recall that any recallable item under Biblio A can fill. Click the "Print slip and confirm" button. 60. Check the slip that is generated. Confirm it contains Borrower A's correct details, and the details of the recall are correct. 61. Go to Circulation -> Recalls awaiting pickup. Confirm the recall is now waiting and shows in this list. (You could also try this with Item B having a different item type to Item A, and circ rules not allowing Item B's item type to have recalls. When checking in Item A, it should not trigger the recall box). 62. Go to Borrower A's checkouts. Check out Item B. 63. Confirm the checkout is successful and the recall is removed from the Recalls tab. 64. Go to Circulation -> Old recalls. The fulfilled recall should show. 65. Check in Item B. BIBLIO-LEVEL RECALL, TRANSFER REQUIRED 66. Check out Item A to Borrower B. 67. Log in to the OPAC as Borrower A. 68. Find Biblio A and place a biblio-level recall. Pickup location: Branch B, a different branch from your logged in branch. This recall will require a transfer. Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 69. In the staff client, check in Item A at Branch A. Notice the box that pops up shows that a transfer is required. 70. Click "confirm recall and transfer" and confirm the transfer. 71. Go to your account and click the Recalls tab. 72. Confirm the recall status now shows the item is in transit to Branch B. 73. In the drop-down top-right of your window, select 'Set library'. 74. Set your library to Branch B. 75. Go to Circulation -> Transfers to receive. Notice that the recall is showing here. 76. Click 'Cancel transfer'. 77. Go to Circulation -> Recalls queue 78. Confirm the recall status has been reverted to Requested. 79. Set your library back to Branch A. 80. Check in Item A and trigger the transfer. 81. Set your library back to Branch B. 82. Check in Item A at Branch B. 83. When the 'Recall found' box pops up, click Ignore. 84. Go to Circulation -> Recalls to pull. The recall should show here, with a button to "Cancel recall and return to: Branch A" 85. Click the button to cancel the recall. 86. Repeat Steps 66-70. 87. Check in Item A at Branch B. Confirm the recall as waiting. 88. Check out Item A to Borrower A to fulfill the recall. 89. Set your library back to Branch A and check in Item A. ITEM-LEVEL RECALL, NO TRANSFER 90. Go to Administration -> circulation rules. Set the following rules: On shelf recalls allowed ( If any unavailable / If all unavailable ) = If all unavailable 91. Check out Item A to Borrower B. 92. Log in to the OPAC as Borrower A and go to Biblio A. 93. Click the 'Place recall' button. Confirm there is a message that there are no items to recall. This is because On shelf recalls allowed = If all unavailable, and there is still one item (Item B) available. 94. In the staff client, edit Item B to have a withdrawn, item lost or not for loan status. 95. Refresh the 'Place recall' page. Confirm you can now see the form to place a recall. 96. Place an item-level recall. Pickup location: Branch A. Recall not needed after (expiration date): whatever you want Select 'recall a specific item' Item B will not be selectable, and Item A should be selected by default. Click confirm 97. In the staff client, edit Item B and remove the lost or missing status. 98. Check in Item B. Confirm the recall box does not pop up, because it cannot fill the item-level recall. 99. Check in Item A. Confirm the recall as waiting. 100. Go to Circulation -> Recalls awaiting pickup 101. Expire the recall. Confirm it expires as expected. ITEM-LEVEL RECALL, TRANSFER REQUIRED 102. Repeat steps 91 to 95. 103. Place an item-level recall. Pickup location: Branch B, we will require a transfer. Recall not needed after (expiration date): whatever you want Select 'recall a specific item' Item B will not be selectable, and Item A should be selected by default. Click confirm 104. In the staff client, check in Item A. Confirm the recall and trigger the transfer. 105. Set your library to Branch B and check in Item A. 106. Confirm the recall as waiting. 107. Check out Item A to Borrower A and fulfill the recall. 108. Set your library back to Branch A and check in Item A. CRONJOBS: EXPIRING RECALL 109. Check out Item A to Borrower B. 110. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 111. In your terminal, enter mysql and edit the expiration date of your recall to be before today UPDATE recalls SET expirationdate = NOW()-2 WHERE recall_id = X; 112. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 113. Go to Borrower A's account and go to the Recalls history tab 114. Confirm the recall has been expired because the current date surpassed the specified expiration date 115. Check out Item A to Borrower B. 116. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 117. In the staff client, check in Item A and confirm the recall as waiting. 118. In your terminal, enter mysql and edit the waiting date of your recall to be before today UPDATE recalls SET waitingdate = NOW() - interval 5 day WHERE recall_id = X; 119. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 120. Go to Borrower A's account and go to the Recalls history tab 121. Confirm the recall has been expired because the recall had been waiting for more days than the Recall pickup period 122. Go to Administration -> circulation rules. Set the following rules: Recall pickup period (days) = 0 123. Set the RecallsMaxPickUpDelay system preference = 1. 124. Check out Item A to Borrower B. 125. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 126. In the staff client, check in Item A and confirm the recall as waiting. 127. In your terminal, enter mysql and edit the waiting date of your recall to be before today UPDATE recalls SET waitingdate = NOW()-2 WHERE recall_id = X; 128. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 129. Go to Borrower A's account and go to the Recalls history tab 130. Confirm the recall has been expired because the recall had been waiting for more days than the RecallsMaxPickUpDelay syspref CRONJOBS: OVERDUE RECALL 131. Check out Item A to Borrower B 132. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 133. In your terminal, enter mysql and edit the due date of the checkout to Borrower B to be before today UPDATE issues SET date_due = NOW()-2 WHERE issue_id = X; 134. Run the overdue cronjob from within your shell perl misc/cronjobs/recall/overdue_recalls.pl 135. Go to Circulation -> Overdue recalls 136. Confirm your recall is showing here now as the recall has been marked Overdue CIRCULATION 137. Check in Item A. 138. When the recall box pops up, click Ignore. 139. Check out Item A to Borrower B. You should see a yellow confirmation box, saying that another borrower has recalled the item you are trying to check out. 140. Click "No don't check out" and confirm the item isn't checked out and the recall remains. 141. Repeat Step 139. 142. Click "Yes check out" and confirm the item is checked out and the recall remains. 143. When Borrower B's checkout table loads, confirm that you cannot renew or check in the item from the Checkouts table because there is a 'Recalled' link which takes you to the recalls tab for that biblio. 144. Repeat Steps 137-139. 145. Select "Cancel recall" and click "Yes check out" and confirm the item is checked out and the recall has been cancelled. 146. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 147. Check in Item A. Confirm the recall as waiting. 148. Check out Item A to Borrower B. You should see a yellow confirmation box, saying that that another borrower has recalled the item that you are trying to check out. 149. Select "Revert waiting status" and click "Yes check out" and confirm the item is checked out and the recall status has reverted to requested. OTHER 150. In your terminal, enter mysql and edit the due date of the checkout to Borrower B to be before today UPDATE issues SET date_due = NOW()-2 WHERE issue_id = X; 151. Go to Borrower A's recalls and click the Actions dropdown. 152. Click "Mark as overdue" and confirm the recall is marked as overdue manually. 153. Go to Tools -> Log Viewer. Check only the Recalls module, and leave all other parameters, and click Submit. 154. Confirm all of the recalls actions that have been made are correctly logged. Note: recalls messaging preferences are introduced in Bug 23781. The recall feature is fully documented at: https://wiki.koha-community.org/wiki/Catalyst_IT_Recalls Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113294|0 |1 is obsolete| | --- Comment #660 from David Nind <david@davidnind.com> --- Created attachment 113359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113359&action=edit Bug 19532: (follow-up) aria-hidden attr on OPAC, and more - removing authnotrequired flag from scripts - fixing opac buttons - chmod +x for recalls test files Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113295|0 |1 is obsolete| | --- Comment #661 from David Nind <david@davidnind.com> --- Created attachment 113361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113361&action=edit Bug 19532: (follow-up) Fixing failing CalcFine.t test Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113296|0 |1 is obsolete| | --- Comment #662 from David Nind <david@davidnind.com> --- Created attachment 113362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113362&action=edit Bug 19532: (follow-up) Fixing OPAC display and staff client errors - fixes the displays of opac-recalls.pl and opac-recall.pl - fix the error on Recalls to pull page - fix JS error preventing Recalled link from showing in checkouts table - fix cancelling of recall when checking out item Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113297|0 |1 is obsolete| | --- Comment #663 from David Nind <david@davidnind.com> --- Created attachment 113363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113363&action=edit Bug 19532: (follow-up) Fix undef recall_id preventing fulfillment of recall Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113298|0 |1 is obsolete| | --- Comment #664 from David Nind <david@davidnind.com> --- Created attachment 113364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113364&action=edit Bug 19532: (follow-up) Fixing tests and QA tools And making reverted ajax message clearer Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113335|0 |1 is obsolete| | --- Comment #665 from David Nind <david@davidnind.com> --- Created attachment 113365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113365&action=edit Bug 19532: (follow-up) Remove bad merge conflict markers Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #666 from David Nind <david@davidnind.com> --- My notes from testing. Tests and qa script ~~~~~~~~~~~~~~~~~~~ All tests pass! prove t/db_dependent/Koha/Recall.t prove t/db_dependent/Koha/Recalls.t prove t/db_dependent/Stats.t prove t/db_dependent/Koha/Item.t prove t/db_dependent/Koha/Biblio.t prove t/db_dependent/Koha/Patron.t prove t/db_dependent/XSLT.t prove t/db_dependent/Search.t prove t/db_dependent/Holds.t prove t/db_dependent/Circulation/transferbook.t prove t/db_dependent/Circulation.t prove t/db_dependent/Circulation/CalcFine.t The only QA script error (qa -v 2) is a false positive accoriding to kidclamp: http://irc.koha-community.org/koha/2020-10-24#i_2300062 FAIL Koha/Schema/Result/Recall.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 Accounts and records used ~~~~~~~~~~~~~~~~~~~~~~~~~ Borrower A (created as new): My Name, 12345, myname, Policy10 Borrower B (login and password changed for Henry): henry, Policy10 Biblio A: - Record with two items - Effective perl programming (139, items 296 (Item A) and 297 (Item C)) - Barcodes: Item A 39999000005776 and Item B 39999000005790 Biblio B: - Record with at least one item - Lady Susan ; The Watsons ; Sanditon (283, item 627 (Item C)) - Barcode: Item C 39999000012392 Branch A: Centerville Branch B: Midway Clarification/notes for specific steps of the test plan ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ See Comment #659 for the full test plan. 33-36. Note that when placing a course reserve you get an error when listing items for a course in the staff interface - bug 26819 was created, this problem existed on master before the recalls patches were applied but does not occur on 20.05.x. 45. Clarification: need to check Item C out to a patron before placing the recall. 111: UPDATE recalls SET expirationdate = NOW() - interval 2 day WHERE recall_id = X; 127: UPDATE recalls SET waitingdate = NOW() - interval 2 day WHERE recall_id = X; 133: UPDATE issues SET date_due = NOW() - interval 2 day WHERE issue_id = X; 134: Script path should be recalls (not recall): perl misc/cronjobs/recalls/overdue_recalls.pl 150: UPDATE issues SET date_due = NOW() - interval 2 day WHERE issue_id = X; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #667 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Thank you so much for such thorough testing, David! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113351|0 |1 is obsolete| | --- Comment #668 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 113430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113430&action=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #669 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 113431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113431&action=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113431|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113430|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #670 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 113432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113432&action=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113352|0 |1 is obsolete| | --- Comment #671 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 113433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113433&action=edit Bug 19532: Updated schema files Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113353|0 |1 is obsolete| | --- Comment #672 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 113434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113434&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113354|0 |1 is obsolete| | --- Comment #673 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 113435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113435&action=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113355|0 |1 is obsolete| | --- Comment #674 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 113436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113436&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113356|0 |1 is obsolete| | --- Comment #675 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 113437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113437&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113357|0 |1 is obsolete| | --- Comment #676 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 113438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113438&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113358|0 |1 is obsolete| | --- Comment #677 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 113439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113439&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls == TEST PLAN FOR RECALLS == ADMINISTRATION 1. Apply all patches 2. Run database updates, update schema files and confirm everything applies cleanly 3. Run tests and confirm everything passes: t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t t/db_dependent/Stats.t t/db_dependent/Circulation/CalcFine.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Patron.t t/db_dependent/XSLT.t t/db_dependent/Search.t t/db_dependent/Holds.t t/db_dependent/Circulation/transferbook.t t/db_dependent/Circulation.t 4. Go to Administration -> system preferences. Find the UseRecalls system preference. It should be DISABLED. Confirm RecallsMaxPickUpDelay is set to 7 by default. 5. Go to Administration -> circulation rules. Confirm there are no recalls circulation rules showing. 6. Test a few circulation flows: checking out, placing a reserve, checking in, fulfilling a reserve, etc. Confirm everything works as normal. 7. Go to Administration -> system preferences. Enable the UseRecalls system preference. 8. Go to Administration -> circulation rules. Set the following rules: Recalls allowed (count) = 0 Recalls per record (count) = 0 On shelf recalls allowed ( If any unavailable / If all unavailable ) = If any unavailable Recall due date interval (days) = 3 Recall overdue fine amount = (something different to your normal fine amount) Recall pickup period (days) = 1 Throughout your testing, try with different combinations of these rules and itemtype / branchcode / categorycode. Also try with null values. Keep the circulation rules open in another tab so you can refer to and update these easily. You should also have at least one other tab open for the staff client, and a third tab open for the OPAC, for ease of testing. 9. Go to your account -> More -> Set permissions. Confirm the recalls permission is checked. 10. Set up a test user with OPAC login details (Borrower A). This could also be your own user, as long as you have OPAC login access. 11. Set up a test record (Biblio A) with at least two items (Item A and Item B) of the same item type (or an item type with the same recall circ rules). PLACING A RECALL 12. Log in to the OPAC as Borrower A. Do a catalogue search with a term that will return multiple results, including Biblio A. 13. Click on Biblio A. 14. Notice there is a 'Place recall' button on the sidebar menu. Click this button. There will be a message saying that there are no items to recall - this is because all items are available. 15. Check out Item A to another borrower (Borrower B). 16. Refresh the 'Place recall' page. You will still NOT be able to place a recall - this is because Recalls allowed = 0 and Recalls per record = 0. 17. Edit the circulation rules to have the following values: Recalls allowed (count) = 1 Recalls per record (count) = 1 18. Refresh the 'Place recall' page. You will now see the form to place a recall. BIBLIO-LEVEL RECALL, NO TRANSFER 19. Place a biblio-level recall. Pickup location: Branch A, the set branch when you are logged into the staff client Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 20. Confirm the recall is placed successfully. Confirm that the new due date displayed is correctly calculated to be today's date, plus 3 days (taken from the 'recall due date interval' circ rule) 21. In the staff client, look at Borrower B's account, and go to their Notices tab. Confirm they have received a 'Notification to return recalled item' notice. 22. Look at Borrower B's checkouts table. Notice the due date for their checkout has been adjusted, and there is now a note to say that the item was recalled and the due date adjusted. 23. Log in to the OPAC as Borrower B and go to your summary tab. Notice there is a note under their checkout to say the item had been recalled. 24. Log out of the OPAC and log back in as Borrower A. 25. Go to your summary tab. Confirm there is a Recalls tab with a count of 1. 26. Cancel the recall using the button. Confirm it cancels and the Recalls tab disappears. 27. Do a catalogue search with a term that will return multiple results, including Biblio A. 28. When the results load, notice there is a 'Place recall' button next to the 'Place hold' button. Click this 'Place recall' button. 29. Notice you are redirected straight to the form to place a recall. 30. Place a biblio-level recall again, following the steps in Step 19. 31. Go to your recalls history tab. Notice your first cancelled recall shows here. 32. Cancel the recall you just created, using the button. Confirm it cancels and you are redirected to your summary tab. 33. In the staff client, enable the UseCourseReserves system preference. 34. Go to the main menu, click Course Reserves. 35. Add a new course. (You may also have to define an authorised value for DEPARTMENT.) 36. Add Item A as a reserve to this course. 37. View Course Reserves in the OPAC. Click the course you just created. 38. Notice the reserve has a Recall button underneath it's 'Checked out' status. Click this button. 39. Place a biblio-level recall again, following the steps in Step 19. 40. Click the 'Place recall' link in the breadcrumbs. 41. Notice there is a message saying that you have reached the max number of recalls on this record. This is because Recalls allowed = 1 and Recalls per record = 1. 42. Edit the circulation rules to have the following values: Recalls allowed (count) = 10 Recalls per record (count) = 5 43. Refresh the 'Place recall' page. You will now see the form to place a recall. 44. Create another test record (Biblio B) with at least one item (Item C). 45. Find this record on the OPAC and place a biblio-level recall again, following the steps in Step 19. 46. In the staff client, go to Circulation -> Old recalls. You should be able to see your two cancelled recalls. 47. Go to Circulation -> Recalls queue. Your current recalls should show here. 48. Use the 'Select all' checkbox to select all recalls. 49. Cancel the recalls using the 'Cancel selected recalls' button. 50. Go to the OPAC and place a biblio-level recall on Biblio A again, following the steps in Step 19. 51. In the staff client, check in Item A, which should still be checked out to Borrower B. 52. A box should pop-up asking you to confirm Borrower A's recall. Click ignore. 53. Click the link to go view Biblio A's details in the catalogue. 54. Click the recalls tab. Notice Borrower A's recall is displayed, and shows it is still Requested (has not been confirmed waiting). 55. Check in Item A again. This time, confirm the recall as waiting using the "Confirm recall" button. 56. Go to Borrower A's Notices tab. Confirm there is a notice "Recalled item awaiting pickup". 57. Go to Borrower A's checkouts. Notice there is a recalls tab. Confirm the recall is showing as "Ready for pickup". 58. Click the 'Actions' dropdown. Click the "Revert waiting" button. The page should show a message that the waiting status has been reverted, without reloading. 59. This time, check in Item B. The recall confirmation box should show again, because this a biblio-level recall that any recallable item under Biblio A can fill. Click the "Print slip and confirm" button. 60. Check the slip that is generated. Confirm it contains Borrower A's correct details, and the details of the recall are correct. 61. Go to Circulation -> Recalls awaiting pickup. Confirm the recall is now waiting and shows in this list. (You could also try this with Item B having a different item type to Item A, and circ rules not allowing Item B's item type to have recalls. When checking in Item A, it should not trigger the recall box). 62. Go to Borrower A's checkouts. Check out Item B. 63. Confirm the checkout is successful and the recall is removed from the Recalls tab. 64. Go to Circulation -> Old recalls. The fulfilled recall should show. 65. Check in Item B. BIBLIO-LEVEL RECALL, TRANSFER REQUIRED 66. Check out Item A to Borrower B. 67. Log in to the OPAC as Borrower A. 68. Find Biblio A and place a biblio-level recall. Pickup location: Branch B, a different branch from your logged in branch. This recall will require a transfer. Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 69. In the staff client, check in Item A at Branch A. Notice the box that pops up shows that a transfer is required. 70. Click "confirm recall and transfer" and confirm the transfer. 71. Go to your account and click the Recalls tab. 72. Confirm the recall status now shows the item is in transit to Branch B. 73. In the drop-down top-right of your window, select 'Set library'. 74. Set your library to Branch B. 75. Go to Circulation -> Transfers to receive. Notice that the recall is showing here. 76. Click 'Cancel transfer'. 77. Go to Circulation -> Recalls queue 78. Confirm the recall status has been reverted to Requested. 79. Set your library back to Branch A. 80. Check in Item A and trigger the transfer. 81. Set your library back to Branch B. 82. Check in Item A at Branch B. 83. When the 'Recall found' box pops up, click Ignore. 84. Go to Circulation -> Recalls to pull. The recall should show here, with a button to "Cancel recall and return to: Branch A" 85. Click the button to cancel the recall. 86. Repeat Steps 66-70. 87. Check in Item A at Branch B. Confirm the recall as waiting. 88. Check out Item A to Borrower A to fulfill the recall. 89. Set your library back to Branch A and check in Item A. ITEM-LEVEL RECALL, NO TRANSFER 90. Go to Administration -> circulation rules. Set the following rules: On shelf recalls allowed ( If any unavailable / If all unavailable ) = If all unavailable 91. Check out Item A to Borrower B. 92. Log in to the OPAC as Borrower A and go to Biblio A. 93. Click the 'Place recall' button. Confirm there is a message that there are no items to recall. This is because On shelf recalls allowed = If all unavailable, and there is still one item (Item B) available. 94. In the staff client, edit Item B to have a withdrawn, item lost or not for loan status. 95. Refresh the 'Place recall' page. Confirm you can now see the form to place a recall. 96. Place an item-level recall. Pickup location: Branch A. Recall not needed after (expiration date): whatever you want Select 'recall a specific item' Item B will not be selectable, and Item A should be selected by default. Click confirm 97. In the staff client, edit Item B and remove the lost or missing status. 98. Check in Item B. Confirm the recall box does not pop up, because it cannot fill the item-level recall. 99. Check in Item A. Confirm the recall as waiting. 100. Go to Circulation -> Recalls awaiting pickup 101. Expire the recall. Confirm it expires as expected. ITEM-LEVEL RECALL, TRANSFER REQUIRED 102. Repeat steps 91 to 95. 103. Place an item-level recall. Pickup location: Branch B, we will require a transfer. Recall not needed after (expiration date): whatever you want Select 'recall a specific item' Item B will not be selectable, and Item A should be selected by default. Click confirm 104. In the staff client, check in Item A. Confirm the recall and trigger the transfer. 105. Set your library to Branch B and check in Item A. 106. Confirm the recall as waiting. 107. Check out Item A to Borrower A and fulfill the recall. 108. Set your library back to Branch A and check in Item A. CRONJOBS: EXPIRING RECALL 109. Check out Item A to Borrower B. 110. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 111. In your terminal, enter mysql and edit the expiration date of your recall to be before today UPDATE recalls SET expirationdate = NOW()-2 WHERE recall_id = X; 112. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 113. Go to Borrower A's account and go to the Recalls history tab 114. Confirm the recall has been expired because the current date surpassed the specified expiration date 115. Check out Item A to Borrower B. 116. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 117. In the staff client, check in Item A and confirm the recall as waiting. 118. In your terminal, enter mysql and edit the waiting date of your recall to be before today UPDATE recalls SET waitingdate = NOW() - interval 5 day WHERE recall_id = X; 119. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 120. Go to Borrower A's account and go to the Recalls history tab 121. Confirm the recall has been expired because the recall had been waiting for more days than the Recall pickup period 122. Go to Administration -> circulation rules. Set the following rules: Recall pickup period (days) = 0 123. Set the RecallsMaxPickUpDelay system preference = 1. 124. Check out Item A to Borrower B. 125. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 126. In the staff client, check in Item A and confirm the recall as waiting. 127. In your terminal, enter mysql and edit the waiting date of your recall to be before today UPDATE recalls SET waitingdate = NOW()-2 WHERE recall_id = X; 128. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 129. Go to Borrower A's account and go to the Recalls history tab 130. Confirm the recall has been expired because the recall had been waiting for more days than the RecallsMaxPickUpDelay syspref CRONJOBS: OVERDUE RECALL 131. Check out Item A to Borrower B 132. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 133. In your terminal, enter mysql and edit the due date of the checkout to Borrower B to be before today UPDATE issues SET date_due = NOW()-2 WHERE issue_id = X; 134. Run the overdue cronjob from within your shell perl misc/cronjobs/recall/overdue_recalls.pl 135. Go to Circulation -> Overdue recalls 136. Confirm your recall is showing here now as the recall has been marked Overdue CIRCULATION 137. Check in Item A. 138. When the recall box pops up, click Ignore. 139. Check out Item A to Borrower B. You should see a yellow confirmation box, saying that another borrower has recalled the item you are trying to check out. 140. Click "No don't check out" and confirm the item isn't checked out and the recall remains. 141. Repeat Step 139. 142. Click "Yes check out" and confirm the item is checked out and the recall remains. 143. When Borrower B's checkout table loads, confirm that you cannot renew or check in the item from the Checkouts table because there is a 'Recalled' link which takes you to the recalls tab for that biblio. 144. Repeat Steps 137-139. 145. Select "Cancel recall" and click "Yes check out" and confirm the item is checked out and the recall has been cancelled. 146. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 147. Check in Item A. Confirm the recall as waiting. 148. Check out Item A to Borrower B. You should see a yellow confirmation box, saying that that another borrower has recalled the item that you are trying to check out. 149. Select "Revert waiting status" and click "Yes check out" and confirm the item is checked out and the recall status has reverted to requested. OTHER 150. In your terminal, enter mysql and edit the due date of the checkout to Borrower B to be before today UPDATE issues SET date_due = NOW()-2 WHERE issue_id = X; 151. Go to Borrower A's recalls and click the Actions dropdown. 152. Click "Mark as overdue" and confirm the recall is marked as overdue manually. 153. Go to Tools -> Log Viewer. Check only the Recalls module, and leave all other parameters, and click Submit. 154. Confirm all of the recalls actions that have been made are correctly logged. Note: recalls messaging preferences are introduced in Bug 23781. The recall feature is fully documented at: https://wiki.koha-community.org/wiki/Catalyst_IT_Recalls Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113359|0 |1 is obsolete| | --- Comment #678 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 113440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113440&action=edit Bug 19532: (follow-up) aria-hidden attr on OPAC, and more - removing authnotrequired flag from scripts - fixing opac buttons - chmod +x for recalls test files Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113361|0 |1 is obsolete| | --- Comment #679 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 113441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113441&action=edit Bug 19532: (follow-up) Fixing failing CalcFine.t test Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113362|0 |1 is obsolete| | --- Comment #680 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 113442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113442&action=edit Bug 19532: (follow-up) Fixing OPAC display and staff client errors - fixes the displays of opac-recalls.pl and opac-recall.pl - fix the error on Recalls to pull page - fix JS error preventing Recalled link from showing in checkouts table - fix cancelling of recall when checking out item Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113363|0 |1 is obsolete| | --- Comment #681 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 113443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113443&action=edit Bug 19532: (follow-up) Fix undef recall_id preventing fulfillment of recall Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113364|0 |1 is obsolete| | --- Comment #682 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 113444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113444&action=edit Bug 19532: (follow-up) Fixing tests and QA tools And making reverted ajax message clearer Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113365|0 |1 is obsolete| | --- Comment #683 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 113445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113445&action=edit Bug 19532: (follow-up) Remove bad merge conflict markers Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #684 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Rebase done for running the test suite passes, it passes :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #685 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This must be very frustrating, but PNA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113432|0 |1 is obsolete| | --- Comment #686 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 116121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116121&action=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113433|0 |1 is obsolete| | --- Comment #687 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 116122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116122&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113434|0 |1 is obsolete| | --- Comment #688 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 116123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116123&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113435|0 |1 is obsolete| | --- Comment #689 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 116124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116124&action=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113436|0 |1 is obsolete| | --- Comment #690 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 116125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116125&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113437|0 |1 is obsolete| | --- Comment #691 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 116126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116126&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113438|0 |1 is obsolete| | --- Comment #692 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 116127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116127&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113439|0 |1 is obsolete| | --- Comment #693 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 116128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116128&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls == TEST PLAN FOR RECALLS == ADMINISTRATION 1. Apply all patches 2. Run database updates, update schema files and confirm everything applies cleanly 3. Run tests and confirm everything passes: t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t t/db_dependent/Stats.t t/db_dependent/Circulation/CalcFine.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Patron.t t/db_dependent/XSLT.t t/db_dependent/Search.t t/db_dependent/Holds.t t/db_dependent/Circulation/transferbook.t t/db_dependent/Circulation.t 4. Go to Administration -> system preferences. Find the UseRecalls system preference. It should be DISABLED. Confirm RecallsMaxPickUpDelay is set to 7 by default. 5. Go to Administration -> circulation rules. Confirm there are no recalls circulation rules showing. 6. Test a few circulation flows: checking out, placing a reserve, checking in, fulfilling a reserve, etc. Confirm everything works as normal. 7. Go to Administration -> system preferences. Enable the UseRecalls system preference. 8. Go to Administration -> circulation rules. Set the following rules: Recalls allowed (count) = 0 Recalls per record (count) = 0 On shelf recalls allowed ( If any unavailable / If all unavailable ) = If any unavailable Recall due date interval (days) = 3 Recall overdue fine amount = (something different to your normal fine amount) Recall pickup period (days) = 1 Throughout your testing, try with different combinations of these rules and itemtype / branchcode / categorycode. Also try with null values. Keep the circulation rules open in another tab so you can refer to and update these easily. You should also have at least one other tab open for the staff client, and a third tab open for the OPAC, for ease of testing. 9. Go to your account -> More -> Set permissions. Confirm the recalls permission is checked. 10. Set up a test user with OPAC login details (Borrower A). This could also be your own user, as long as you have OPAC login access. 11. Set up a test record (Biblio A) with at least two items (Item A and Item B) of the same item type (or an item type with the same recall circ rules). PLACING A RECALL 12. Log in to the OPAC as Borrower A. Do a catalogue search with a term that will return multiple results, including Biblio A. 13. Click on Biblio A. 14. Notice there is a 'Place recall' button on the sidebar menu. Click this button. There will be a message saying that there are no items to recall - this is because all items are available. 15. Check out Item A to another borrower (Borrower B). 16. Refresh the 'Place recall' page. You will still NOT be able to place a recall - this is because Recalls allowed = 0 and Recalls per record = 0. 17. Edit the circulation rules to have the following values: Recalls allowed (count) = 1 Recalls per record (count) = 1 18. Refresh the 'Place recall' page. You will now see the form to place a recall. BIBLIO-LEVEL RECALL, NO TRANSFER 19. Place a biblio-level recall. Pickup location: Branch A, the set branch when you are logged into the staff client Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 20. Confirm the recall is placed successfully. Confirm that the new due date displayed is correctly calculated to be today's date, plus 3 days (taken from the 'recall due date interval' circ rule) 21. In the staff client, look at Borrower B's account, and go to their Notices tab. Confirm they have received a 'Notification to return recalled item' notice. 22. Look at Borrower B's checkouts table. Notice the due date for their checkout has been adjusted, and there is now a note to say that the item was recalled and the due date adjusted. 23. Log in to the OPAC as Borrower B and go to your summary tab. Notice there is a note under their checkout to say the item had been recalled. 24. Log out of the OPAC and log back in as Borrower A. 25. Go to your summary tab. Confirm there is a Recalls tab with a count of 1. 26. Cancel the recall using the button. Confirm it cancels and the Recalls tab disappears. 27. Do a catalogue search with a term that will return multiple results, including Biblio A. 28. When the results load, notice there is a 'Place recall' button next to the 'Place hold' button. Click this 'Place recall' button. 29. Notice you are redirected straight to the form to place a recall. 30. Place a biblio-level recall again, following the steps in Step 19. 31. Go to your recalls history tab. Notice your first cancelled recall shows here. 32. Cancel the recall you just created, using the button. Confirm it cancels and you are redirected to your summary tab. 33. In the staff client, enable the UseCourseReserves system preference. 34. Go to the main menu, click Course Reserves. 35. Add a new course. (You may also have to define an authorised value for DEPARTMENT.) 36. Add Item A as a reserve to this course. 37. View Course Reserves in the OPAC. Click the course you just created. 38. Notice the reserve has a Recall button underneath it's 'Checked out' status. Click this button. 39. Place a biblio-level recall again, following the steps in Step 19. 40. Click the 'Place recall' link in the breadcrumbs. 41. Notice there is a message saying that you have reached the max number of recalls on this record. This is because Recalls allowed = 1 and Recalls per record = 1. 42. Edit the circulation rules to have the following values: Recalls allowed (count) = 10 Recalls per record (count) = 5 43. Refresh the 'Place recall' page. You will now see the form to place a recall. 44. Create another test record (Biblio B) with at least one item (Item C). 45. Find this record on the OPAC and place a biblio-level recall again, following the steps in Step 19. 46. In the staff client, go to Circulation -> Old recalls. You should be able to see your two cancelled recalls. 47. Go to Circulation -> Recalls queue. Your current recalls should show here. 48. Use the 'Select all' checkbox to select all recalls. 49. Cancel the recalls using the 'Cancel selected recalls' button. 50. Go to the OPAC and place a biblio-level recall on Biblio A again, following the steps in Step 19. 51. In the staff client, check in Item A, which should still be checked out to Borrower B. 52. A box should pop-up asking you to confirm Borrower A's recall. Click ignore. 53. Click the link to go view Biblio A's details in the catalogue. 54. Click the recalls tab. Notice Borrower A's recall is displayed, and shows it is still Requested (has not been confirmed waiting). 55. Check in Item A again. This time, confirm the recall as waiting using the "Confirm recall" button. 56. Go to Borrower A's Notices tab. Confirm there is a notice "Recalled item awaiting pickup". 57. Go to Borrower A's checkouts. Notice there is a recalls tab. Confirm the recall is showing as "Ready for pickup". 58. Click the 'Actions' dropdown. Click the "Revert waiting" button. The page should show a message that the waiting status has been reverted, without reloading. 59. This time, check in Item B. The recall confirmation box should show again, because this a biblio-level recall that any recallable item under Biblio A can fill. Click the "Print slip and confirm" button. 60. Check the slip that is generated. Confirm it contains Borrower A's correct details, and the details of the recall are correct. 61. Go to Circulation -> Recalls awaiting pickup. Confirm the recall is now waiting and shows in this list. (You could also try this with Item B having a different item type to Item A, and circ rules not allowing Item B's item type to have recalls. When checking in Item A, it should not trigger the recall box). 62. Go to Borrower A's checkouts. Check out Item B. 63. Confirm the checkout is successful and the recall is removed from the Recalls tab. 64. Go to Circulation -> Old recalls. The fulfilled recall should show. 65. Check in Item B. BIBLIO-LEVEL RECALL, TRANSFER REQUIRED 66. Check out Item A to Borrower B. 67. Log in to the OPAC as Borrower A. 68. Find Biblio A and place a biblio-level recall. Pickup location: Branch B, a different branch from your logged in branch. This recall will require a transfer. Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 69. In the staff client, check in Item A at Branch A. Notice the box that pops up shows that a transfer is required. 70. Click "confirm recall and transfer" and confirm the transfer. 71. Go to your account and click the Recalls tab. 72. Confirm the recall status now shows the item is in transit to Branch B. 73. In the drop-down top-right of your window, select 'Set library'. 74. Set your library to Branch B. 75. Go to Circulation -> Transfers to receive. Notice that the recall is showing here. 76. Click 'Cancel transfer'. 77. Go to Circulation -> Recalls queue 78. Confirm the recall status has been reverted to Requested. 79. Set your library back to Branch A. 80. Check in Item A and trigger the transfer. 81. Set your library back to Branch B. 82. Check in Item A at Branch B. 83. When the 'Recall found' box pops up, click Ignore. 84. Go to Circulation -> Recalls to pull. The recall should show here, with a button to "Cancel recall and return to: Branch A" 85. Click the button to cancel the recall. 86. Repeat Steps 66-70. 87. Check in Item A at Branch B. Confirm the recall as waiting. 88. Check out Item A to Borrower A to fulfill the recall. 89. Set your library back to Branch A and check in Item A. ITEM-LEVEL RECALL, NO TRANSFER 90. Go to Administration -> circulation rules. Set the following rules: On shelf recalls allowed ( If any unavailable / If all unavailable ) = If all unavailable 91. Check out Item A to Borrower B. 92. Log in to the OPAC as Borrower A and go to Biblio A. 93. Click the 'Place recall' button. Confirm there is a message that there are no items to recall. This is because On shelf recalls allowed = If all unavailable, and there is still one item (Item B) available. 94. In the staff client, edit Item B to have a withdrawn, item lost or not for loan status. 95. Refresh the 'Place recall' page. Confirm you can now see the form to place a recall. 96. Place an item-level recall. Pickup location: Branch A. Recall not needed after (expiration date): whatever you want Select 'recall a specific item' Item B will not be selectable, and Item A should be selected by default. Click confirm 97. In the staff client, edit Item B and remove the lost or missing status. 98. Check in Item B. Confirm the recall box does not pop up, because it cannot fill the item-level recall. 99. Check in Item A. Confirm the recall as waiting. 100. Go to Circulation -> Recalls awaiting pickup 101. Expire the recall. Confirm it expires as expected. ITEM-LEVEL RECALL, TRANSFER REQUIRED 102. Repeat steps 91 to 95. 103. Place an item-level recall. Pickup location: Branch B, we will require a transfer. Recall not needed after (expiration date): whatever you want Select 'recall a specific item' Item B will not be selectable, and Item A should be selected by default. Click confirm 104. In the staff client, check in Item A. Confirm the recall and trigger the transfer. 105. Set your library to Branch B and check in Item A. 106. Confirm the recall as waiting. 107. Check out Item A to Borrower A and fulfill the recall. 108. Set your library back to Branch A and check in Item A. CRONJOBS: EXPIRING RECALL 109. Check out Item A to Borrower B. 110. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 111. In your terminal, enter mysql and edit the expiration date of your recall to be before today UPDATE recalls SET expirationdate = NOW()-2 WHERE recall_id = X; 112. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 113. Go to Borrower A's account and go to the Recalls history tab 114. Confirm the recall has been expired because the current date surpassed the specified expiration date 115. Check out Item A to Borrower B. 116. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 117. In the staff client, check in Item A and confirm the recall as waiting. 118. In your terminal, enter mysql and edit the waiting date of your recall to be before today UPDATE recalls SET waitingdate = NOW() - interval 5 day WHERE recall_id = X; 119. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 120. Go to Borrower A's account and go to the Recalls history tab 121. Confirm the recall has been expired because the recall had been waiting for more days than the Recall pickup period 122. Go to Administration -> circulation rules. Set the following rules: Recall pickup period (days) = 0 123. Set the RecallsMaxPickUpDelay system preference = 1. 124. Check out Item A to Borrower B. 125. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 126. In the staff client, check in Item A and confirm the recall as waiting. 127. In your terminal, enter mysql and edit the waiting date of your recall to be before today UPDATE recalls SET waitingdate = NOW()-2 WHERE recall_id = X; 128. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 129. Go to Borrower A's account and go to the Recalls history tab 130. Confirm the recall has been expired because the recall had been waiting for more days than the RecallsMaxPickUpDelay syspref CRONJOBS: OVERDUE RECALL 131. Check out Item A to Borrower B 132. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 133. In your terminal, enter mysql and edit the due date of the checkout to Borrower B to be before today UPDATE issues SET date_due = NOW()-2 WHERE issue_id = X; 134. Run the overdue cronjob from within your shell perl misc/cronjobs/recall/overdue_recalls.pl 135. Go to Circulation -> Overdue recalls 136. Confirm your recall is showing here now as the recall has been marked Overdue CIRCULATION 137. Check in Item A. 138. When the recall box pops up, click Ignore. 139. Check out Item A to Borrower B. You should see a yellow confirmation box, saying that another borrower has recalled the item you are trying to check out. 140. Click "No don't check out" and confirm the item isn't checked out and the recall remains. 141. Repeat Step 139. 142. Click "Yes check out" and confirm the item is checked out and the recall remains. 143. When Borrower B's checkout table loads, confirm that you cannot renew or check in the item from the Checkouts table because there is a 'Recalled' link which takes you to the recalls tab for that biblio. 144. Repeat Steps 137-139. 145. Select "Cancel recall" and click "Yes check out" and confirm the item is checked out and the recall has been cancelled. 146. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 147. Check in Item A. Confirm the recall as waiting. 148. Check out Item A to Borrower B. You should see a yellow confirmation box, saying that that another borrower has recalled the item that you are trying to check out. 149. Select "Revert waiting status" and click "Yes check out" and confirm the item is checked out and the recall status has reverted to requested. OTHER 150. In your terminal, enter mysql and edit the due date of the checkout to Borrower B to be before today UPDATE issues SET date_due = NOW()-2 WHERE issue_id = X; 151. Go to Borrower A's recalls and click the Actions dropdown. 152. Click "Mark as overdue" and confirm the recall is marked as overdue manually. 153. Go to Tools -> Log Viewer. Check only the Recalls module, and leave all other parameters, and click Submit. 154. Confirm all of the recalls actions that have been made are correctly logged. Note: recalls messaging preferences are introduced in Bug 23781. The recall feature is fully documented at: https://wiki.koha-community.org/wiki/Catalyst_IT_Recalls Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113440|0 |1 is obsolete| | --- Comment #694 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 116129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116129&action=edit Bug 19532: (follow-up) aria-hidden attr on OPAC, and more - removing authnotrequired flag from scripts - fixing opac buttons - chmod +x for recalls test files Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113441|0 |1 is obsolete| | --- Comment #695 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 116130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116130&action=edit Bug 19532: (follow-up) Fixing failing CalcFine.t test Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113442|0 |1 is obsolete| | --- Comment #696 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 116131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116131&action=edit Bug 19532: (follow-up) Fixing OPAC display and staff client errors - fixes the displays of opac-recalls.pl and opac-recall.pl - fix the error on Recalls to pull page - fix JS error preventing Recalled link from showing in checkouts table - fix cancelling of recall when checking out item Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113443|0 |1 is obsolete| | --- Comment #697 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 116132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116132&action=edit Bug 19532: (follow-up) Fix undef recall_id preventing fulfillment of recall Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113444|0 |1 is obsolete| | --- Comment #698 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 116133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116133&action=edit Bug 19532: (follow-up) Fixing tests and QA tools And making reverted ajax message clearer Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113445|0 |1 is obsolete| | --- Comment #699 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 116134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116134&action=edit Bug 19532: (follow-up) Remove bad merge conflict markers Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #700 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Switching back to Signed Off as was the status before recent rebasing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116121|0 |1 is obsolete| | --- Comment #701 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 118267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118267&action=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116122|0 |1 is obsolete| | --- Comment #702 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 118268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118268&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116123|0 |1 is obsolete| | --- Comment #703 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 118269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118269&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116124|0 |1 is obsolete| | --- Comment #704 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 118270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118270&action=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116125|0 |1 is obsolete| | --- Comment #705 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 118271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118271&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116126|0 |1 is obsolete| | --- Comment #706 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 118272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118272&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116127|0 |1 is obsolete| | --- Comment #707 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 118273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118273&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116128|0 |1 is obsolete| | --- Comment #708 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 118274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118274&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls == TEST PLAN FOR RECALLS == ADMINISTRATION 1. Apply all patches 2. Run database updates, update schema files and confirm everything applies cleanly 3. Run tests and confirm everything passes: t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t t/db_dependent/Stats.t t/db_dependent/Circulation/CalcFine.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Patron.t t/db_dependent/XSLT.t t/db_dependent/Search.t t/db_dependent/Holds.t t/db_dependent/Circulation/transferbook.t t/db_dependent/Circulation.t 4. Go to Administration -> system preferences. Find the UseRecalls system preference. It should be DISABLED. Confirm RecallsMaxPickUpDelay is set to 7 by default. 5. Go to Administration -> circulation rules. Confirm there are no recalls circulation rules showing. 6. Test a few circulation flows: checking out, placing a reserve, checking in, fulfilling a reserve, etc. Confirm everything works as normal. 7. Go to Administration -> system preferences. Enable the UseRecalls system preference. 8. Go to Administration -> circulation rules. Set the following rules: Recalls allowed (count) = 0 Recalls per record (count) = 0 On shelf recalls allowed ( If any unavailable / If all unavailable ) = If any unavailable Recall due date interval (days) = 3 Recall overdue fine amount = (something different to your normal fine amount) Recall pickup period (days) = 1 Throughout your testing, try with different combinations of these rules and itemtype / branchcode / categorycode. Also try with null values. Keep the circulation rules open in another tab so you can refer to and update these easily. You should also have at least one other tab open for the staff client, and a third tab open for the OPAC, for ease of testing. 9. Go to your account -> More -> Set permissions. Confirm the recalls permission is checked. 10. Set up a test user with OPAC login details (Borrower A). This could also be your own user, as long as you have OPAC login access. 11. Set up a test record (Biblio A) with at least two items (Item A and Item B) of the same item type (or an item type with the same recall circ rules). PLACING A RECALL 12. Log in to the OPAC as Borrower A. Do a catalogue search with a term that will return multiple results, including Biblio A. 13. Click on Biblio A. 14. Notice there is a 'Place recall' button on the sidebar menu. Click this button. There will be a message saying that there are no items to recall - this is because all items are available. 15. Check out Item A to another borrower (Borrower B). 16. Refresh the 'Place recall' page. You will still NOT be able to place a recall - this is because Recalls allowed = 0 and Recalls per record = 0. 17. Edit the circulation rules to have the following values: Recalls allowed (count) = 1 Recalls per record (count) = 1 18. Refresh the 'Place recall' page. You will now see the form to place a recall. BIBLIO-LEVEL RECALL, NO TRANSFER 19. Place a biblio-level recall. Pickup location: Branch A, the set branch when you are logged into the staff client Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 20. Confirm the recall is placed successfully. Confirm that the new due date displayed is correctly calculated to be today's date, plus 3 days (taken from the 'recall due date interval' circ rule) 21. In the staff client, look at Borrower B's account, and go to their Notices tab. Confirm they have received a 'Notification to return recalled item' notice. 22. Look at Borrower B's checkouts table. Notice the due date for their checkout has been adjusted, and there is now a note to say that the item was recalled and the due date adjusted. 23. Log in to the OPAC as Borrower B and go to your summary tab. Notice there is a note under their checkout to say the item had been recalled. 24. Log out of the OPAC and log back in as Borrower A. 25. Go to your summary tab. Confirm there is a Recalls tab with a count of 1. 26. Cancel the recall using the button. Confirm it cancels and the Recalls tab disappears. 27. Do a catalogue search with a term that will return multiple results, including Biblio A. 28. When the results load, notice there is a 'Place recall' button next to the 'Place hold' button. Click this 'Place recall' button. 29. Notice you are redirected straight to the form to place a recall. 30. Place a biblio-level recall again, following the steps in Step 19. 31. Go to your recalls history tab. Notice your first cancelled recall shows here. 32. Cancel the recall you just created, using the button. Confirm it cancels and you are redirected to your summary tab. 33. In the staff client, enable the UseCourseReserves system preference. 34. Go to the main menu, click Course Reserves. 35. Add a new course. (You may also have to define an authorised value for DEPARTMENT.) 36. Add Item A as a reserve to this course. 37. View Course Reserves in the OPAC. Click the course you just created. 38. Notice the reserve has a Recall button underneath it's 'Checked out' status. Click this button. 39. Place a biblio-level recall again, following the steps in Step 19. 40. Click the 'Place recall' link in the breadcrumbs. 41. Notice there is a message saying that you have reached the max number of recalls on this record. This is because Recalls allowed = 1 and Recalls per record = 1. 42. Edit the circulation rules to have the following values: Recalls allowed (count) = 10 Recalls per record (count) = 5 43. Refresh the 'Place recall' page. You will now see the form to place a recall. 44. Create another test record (Biblio B) with at least one item (Item C). 45. Find this record on the OPAC and place a biblio-level recall again, following the steps in Step 19. 46. In the staff client, go to Circulation -> Old recalls. You should be able to see your two cancelled recalls. 47. Go to Circulation -> Recalls queue. Your current recalls should show here. 48. Use the 'Select all' checkbox to select all recalls. 49. Cancel the recalls using the 'Cancel selected recalls' button. 50. Go to the OPAC and place a biblio-level recall on Biblio A again, following the steps in Step 19. 51. In the staff client, check in Item A, which should still be checked out to Borrower B. 52. A box should pop-up asking you to confirm Borrower A's recall. Click ignore. 53. Click the link to go view Biblio A's details in the catalogue. 54. Click the recalls tab. Notice Borrower A's recall is displayed, and shows it is still Requested (has not been confirmed waiting). 55. Check in Item A again. This time, confirm the recall as waiting using the "Confirm recall" button. 56. Go to Borrower A's Notices tab. Confirm there is a notice "Recalled item awaiting pickup". 57. Go to Borrower A's checkouts. Notice there is a recalls tab. Confirm the recall is showing as "Ready for pickup". 58. Click the 'Actions' dropdown. Click the "Revert waiting" button. The page should show a message that the waiting status has been reverted, without reloading. 59. This time, check in Item B. The recall confirmation box should show again, because this a biblio-level recall that any recallable item under Biblio A can fill. Click the "Print slip and confirm" button. 60. Check the slip that is generated. Confirm it contains Borrower A's correct details, and the details of the recall are correct. 61. Go to Circulation -> Recalls awaiting pickup. Confirm the recall is now waiting and shows in this list. (You could also try this with Item B having a different item type to Item A, and circ rules not allowing Item B's item type to have recalls. When checking in Item A, it should not trigger the recall box). 62. Go to Borrower A's checkouts. Check out Item B. 63. Confirm the checkout is successful and the recall is removed from the Recalls tab. 64. Go to Circulation -> Old recalls. The fulfilled recall should show. 65. Check in Item B. BIBLIO-LEVEL RECALL, TRANSFER REQUIRED 66. Check out Item A to Borrower B. 67. Log in to the OPAC as Borrower A. 68. Find Biblio A and place a biblio-level recall. Pickup location: Branch B, a different branch from your logged in branch. This recall will require a transfer. Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 69. In the staff client, check in Item A at Branch A. Notice the box that pops up shows that a transfer is required. 70. Click "confirm recall and transfer" and confirm the transfer. 71. Go to your account and click the Recalls tab. 72. Confirm the recall status now shows the item is in transit to Branch B. 73. In the drop-down top-right of your window, select 'Set library'. 74. Set your library to Branch B. 75. Go to Circulation -> Transfers to receive. Notice that the recall is showing here. 76. Click 'Cancel transfer'. 77. Go to Circulation -> Recalls queue 78. Confirm the recall status has been reverted to Requested. 79. Set your library back to Branch A. 80. Check in Item A and trigger the transfer. 81. Set your library back to Branch B. 82. Check in Item A at Branch B. 83. When the 'Recall found' box pops up, click Ignore. 84. Go to Circulation -> Recalls to pull. The recall should show here, with a button to "Cancel recall and return to: Branch A" 85. Click the button to cancel the recall. 86. Repeat Steps 66-70. 87. Check in Item A at Branch B. Confirm the recall as waiting. 88. Check out Item A to Borrower A to fulfill the recall. 89. Set your library back to Branch A and check in Item A. ITEM-LEVEL RECALL, NO TRANSFER 90. Go to Administration -> circulation rules. Set the following rules: On shelf recalls allowed ( If any unavailable / If all unavailable ) = If all unavailable 91. Check out Item A to Borrower B. 92. Log in to the OPAC as Borrower A and go to Biblio A. 93. Click the 'Place recall' button. Confirm there is a message that there are no items to recall. This is because On shelf recalls allowed = If all unavailable, and there is still one item (Item B) available. 94. In the staff client, edit Item B to have a withdrawn, item lost or not for loan status. 95. Refresh the 'Place recall' page. Confirm you can now see the form to place a recall. 96. Place an item-level recall. Pickup location: Branch A. Recall not needed after (expiration date): whatever you want Select 'recall a specific item' Item B will not be selectable, and Item A should be selected by default. Click confirm 97. In the staff client, edit Item B and remove the lost or missing status. 98. Check in Item B. Confirm the recall box does not pop up, because it cannot fill the item-level recall. 99. Check in Item A. Confirm the recall as waiting. 100. Go to Circulation -> Recalls awaiting pickup 101. Expire the recall. Confirm it expires as expected. ITEM-LEVEL RECALL, TRANSFER REQUIRED 102. Repeat steps 91 to 95. 103. Place an item-level recall. Pickup location: Branch B, we will require a transfer. Recall not needed after (expiration date): whatever you want Select 'recall a specific item' Item B will not be selectable, and Item A should be selected by default. Click confirm 104. In the staff client, check in Item A. Confirm the recall and trigger the transfer. 105. Set your library to Branch B and check in Item A. 106. Confirm the recall as waiting. 107. Check out Item A to Borrower A and fulfill the recall. 108. Set your library back to Branch A and check in Item A. CRONJOBS: EXPIRING RECALL 109. Check out Item A to Borrower B. 110. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 111. In your terminal, enter mysql and edit the expiration date of your recall to be before today UPDATE recalls SET expirationdate = NOW()-2 WHERE recall_id = X; 112. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 113. Go to Borrower A's account and go to the Recalls history tab 114. Confirm the recall has been expired because the current date surpassed the specified expiration date 115. Check out Item A to Borrower B. 116. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 117. In the staff client, check in Item A and confirm the recall as waiting. 118. In your terminal, enter mysql and edit the waiting date of your recall to be before today UPDATE recalls SET waitingdate = NOW() - interval 5 day WHERE recall_id = X; 119. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 120. Go to Borrower A's account and go to the Recalls history tab 121. Confirm the recall has been expired because the recall had been waiting for more days than the Recall pickup period 122. Go to Administration -> circulation rules. Set the following rules: Recall pickup period (days) = 0 123. Set the RecallsMaxPickUpDelay system preference = 1. 124. Check out Item A to Borrower B. 125. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 126. In the staff client, check in Item A and confirm the recall as waiting. 127. In your terminal, enter mysql and edit the waiting date of your recall to be before today UPDATE recalls SET waitingdate = NOW()-2 WHERE recall_id = X; 128. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 129. Go to Borrower A's account and go to the Recalls history tab 130. Confirm the recall has been expired because the recall had been waiting for more days than the RecallsMaxPickUpDelay syspref CRONJOBS: OVERDUE RECALL 131. Check out Item A to Borrower B 132. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 133. In your terminal, enter mysql and edit the due date of the checkout to Borrower B to be before today UPDATE issues SET date_due = NOW()-2 WHERE issue_id = X; 134. Run the overdue cronjob from within your shell perl misc/cronjobs/recall/overdue_recalls.pl 135. Go to Circulation -> Overdue recalls 136. Confirm your recall is showing here now as the recall has been marked Overdue CIRCULATION 137. Check in Item A. 138. When the recall box pops up, click Ignore. 139. Check out Item A to Borrower B. You should see a yellow confirmation box, saying that another borrower has recalled the item you are trying to check out. 140. Click "No don't check out" and confirm the item isn't checked out and the recall remains. 141. Repeat Step 139. 142. Click "Yes check out" and confirm the item is checked out and the recall remains. 143. When Borrower B's checkout table loads, confirm that you cannot renew or check in the item from the Checkouts table because there is a 'Recalled' link which takes you to the recalls tab for that biblio. 144. Repeat Steps 137-139. 145. Select "Cancel recall" and click "Yes check out" and confirm the item is checked out and the recall has been cancelled. 146. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 147. Check in Item A. Confirm the recall as waiting. 148. Check out Item A to Borrower B. You should see a yellow confirmation box, saying that that another borrower has recalled the item that you are trying to check out. 149. Select "Revert waiting status" and click "Yes check out" and confirm the item is checked out and the recall status has reverted to requested. OTHER 150. In your terminal, enter mysql and edit the due date of the checkout to Borrower B to be before today UPDATE issues SET date_due = NOW()-2 WHERE issue_id = X; 151. Go to Borrower A's recalls and click the Actions dropdown. 152. Click "Mark as overdue" and confirm the recall is marked as overdue manually. 153. Go to Tools -> Log Viewer. Check only the Recalls module, and leave all other parameters, and click Submit. 154. Confirm all of the recalls actions that have been made are correctly logged. Note: recalls messaging preferences are introduced in Bug 23781. The recall feature is fully documented at: https://wiki.koha-community.org/wiki/Catalyst_IT_Recalls Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116129|0 |1 is obsolete| | --- Comment #709 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 118275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118275&action=edit Bug 19532: (follow-up) aria-hidden attr on OPAC, and more - removing authnotrequired flag from scripts - fixing opac buttons - chmod +x for recalls test files Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116130|0 |1 is obsolete| | --- Comment #710 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 118276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118276&action=edit Bug 19532: (follow-up) Fixing failing CalcFine.t test Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116131|0 |1 is obsolete| | --- Comment #711 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 118277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118277&action=edit Bug 19532: (follow-up) Fixing OPAC display and staff client errors - fixes the displays of opac-recalls.pl and opac-recall.pl - fix the error on Recalls to pull page - fix JS error preventing Recalled link from showing in checkouts table - fix cancelling of recall when checking out item Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116132|0 |1 is obsolete| | --- Comment #712 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 118278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118278&action=edit Bug 19532: (follow-up) Fix undef recall_id preventing fulfillment of recall Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116133|0 |1 is obsolete| | --- Comment #713 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 118279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118279&action=edit Bug 19532: (follow-up) Fixing tests and QA tools And making reverted ajax message clearer Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116134|0 |1 is obsolete| | --- Comment #714 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 118280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118280&action=edit Bug 19532: (follow-up) Remove bad merge conflict markers Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #715 from Nick Clemens <nick@bywatersolutions.com> --- Notices and DB update conflicts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118267|0 |1 is obsolete| | Attachment #118280|0 |1 is obsolete| | --- Comment #716 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 122993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122993&action=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118268|0 |1 is obsolete| | --- Comment #717 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 122994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122994&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118269|0 |1 is obsolete| | --- Comment #718 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 122995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122995&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118270|0 |1 is obsolete| | --- Comment #719 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 122996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122996&action=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118271|0 |1 is obsolete| | --- Comment #720 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 122997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122997&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118272|0 |1 is obsolete| | --- Comment #721 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 122998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122998&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118273|0 |1 is obsolete| | --- Comment #722 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 122999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122999&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118274|0 |1 is obsolete| | --- Comment #723 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 123000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123000&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls == TEST PLAN FOR RECALLS == ADMINISTRATION 1. Apply all patches 2. Run database updates, update schema files and confirm everything applies cleanly 3. Run tests and confirm everything passes: t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t t/db_dependent/Stats.t t/db_dependent/Circulation/CalcFine.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Patron.t t/db_dependent/XSLT.t t/db_dependent/Search.t t/db_dependent/Holds.t t/db_dependent/Circulation/transferbook.t t/db_dependent/Circulation.t 4. Go to Administration -> system preferences. Find the UseRecalls system preference. It should be DISABLED. Confirm RecallsMaxPickUpDelay is set to 7 by default. 5. Go to Administration -> circulation rules. Confirm there are no recalls circulation rules showing. 6. Test a few circulation flows: checking out, placing a reserve, checking in, fulfilling a reserve, etc. Confirm everything works as normal. 7. Go to Administration -> system preferences. Enable the UseRecalls system preference. 8. Go to Administration -> circulation rules. Set the following rules: Recalls allowed (count) = 0 Recalls per record (count) = 0 On shelf recalls allowed ( If any unavailable / If all unavailable ) = If any unavailable Recall due date interval (days) = 3 Recall overdue fine amount = (something different to your normal fine amount) Recall pickup period (days) = 1 Throughout your testing, try with different combinations of these rules and itemtype / branchcode / categorycode. Also try with null values. Keep the circulation rules open in another tab so you can refer to and update these easily. You should also have at least one other tab open for the staff client, and a third tab open for the OPAC, for ease of testing. 9. Go to your account -> More -> Set permissions. Confirm the recalls permission is checked. 10. Set up a test user with OPAC login details (Borrower A). This could also be your own user, as long as you have OPAC login access. 11. Set up a test record (Biblio A) with at least two items (Item A and Item B) of the same item type (or an item type with the same recall circ rules). PLACING A RECALL 12. Log in to the OPAC as Borrower A. Do a catalogue search with a term that will return multiple results, including Biblio A. 13. Click on Biblio A. 14. Notice there is a 'Place recall' button on the sidebar menu. Click this button. There will be a message saying that there are no items to recall - this is because all items are available. 15. Check out Item A to another borrower (Borrower B). 16. Refresh the 'Place recall' page. You will still NOT be able to place a recall - this is because Recalls allowed = 0 and Recalls per record = 0. 17. Edit the circulation rules to have the following values: Recalls allowed (count) = 1 Recalls per record (count) = 1 18. Refresh the 'Place recall' page. You will now see the form to place a recall. BIBLIO-LEVEL RECALL, NO TRANSFER 19. Place a biblio-level recall. Pickup location: Branch A, the set branch when you are logged into the staff client Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 20. Confirm the recall is placed successfully. Confirm that the new due date displayed is correctly calculated to be today's date, plus 3 days (taken from the 'recall due date interval' circ rule) 21. In the staff client, look at Borrower B's account, and go to their Notices tab. Confirm they have received a 'Notification to return recalled item' notice. 22. Look at Borrower B's checkouts table. Notice the due date for their checkout has been adjusted, and there is now a note to say that the item was recalled and the due date adjusted. 23. Log in to the OPAC as Borrower B and go to your summary tab. Notice there is a note under their checkout to say the item had been recalled. 24. Log out of the OPAC and log back in as Borrower A. 25. Go to your summary tab. Confirm there is a Recalls tab with a count of 1. 26. Cancel the recall using the button. Confirm it cancels and the Recalls tab disappears. 27. Do a catalogue search with a term that will return multiple results, including Biblio A. 28. When the results load, notice there is a 'Place recall' button next to the 'Place hold' button. Click this 'Place recall' button. 29. Notice you are redirected straight to the form to place a recall. 30. Place a biblio-level recall again, following the steps in Step 19. 31. Go to your recalls history tab. Notice your first cancelled recall shows here. 32. Cancel the recall you just created, using the button. Confirm it cancels and you are redirected to your summary tab. 33. In the staff client, enable the UseCourseReserves system preference. 34. Go to the main menu, click Course Reserves. 35. Add a new course. (You may also have to define an authorised value for DEPARTMENT.) 36. Add Item A as a reserve to this course. 37. View Course Reserves in the OPAC. Click the course you just created. 38. Notice the reserve has a Recall button underneath it's 'Checked out' status. Click this button. 39. Place a biblio-level recall again, following the steps in Step 19. 40. Click the 'Place recall' link in the breadcrumbs. 41. Notice there is a message saying that you have reached the max number of recalls on this record. This is because Recalls allowed = 1 and Recalls per record = 1. 42. Edit the circulation rules to have the following values: Recalls allowed (count) = 10 Recalls per record (count) = 5 43. Refresh the 'Place recall' page. You will now see the form to place a recall. 44. Create another test record (Biblio B) with at least one item (Item C). 45. Find this record on the OPAC and place a biblio-level recall again, following the steps in Step 19. 46. In the staff client, go to Circulation -> Old recalls. You should be able to see your two cancelled recalls. 47. Go to Circulation -> Recalls queue. Your current recalls should show here. 48. Use the 'Select all' checkbox to select all recalls. 49. Cancel the recalls using the 'Cancel selected recalls' button. 50. Go to the OPAC and place a biblio-level recall on Biblio A again, following the steps in Step 19. 51. In the staff client, check in Item A, which should still be checked out to Borrower B. 52. A box should pop-up asking you to confirm Borrower A's recall. Click ignore. 53. Click the link to go view Biblio A's details in the catalogue. 54. Click the recalls tab. Notice Borrower A's recall is displayed, and shows it is still Requested (has not been confirmed waiting). 55. Check in Item A again. This time, confirm the recall as waiting using the "Confirm recall" button. 56. Go to Borrower A's Notices tab. Confirm there is a notice "Recalled item awaiting pickup". 57. Go to Borrower A's checkouts. Notice there is a recalls tab. Confirm the recall is showing as "Ready for pickup". 58. Click the 'Actions' dropdown. Click the "Revert waiting" button. The page should show a message that the waiting status has been reverted, without reloading. 59. This time, check in Item B. The recall confirmation box should show again, because this a biblio-level recall that any recallable item under Biblio A can fill. Click the "Print slip and confirm" button. 60. Check the slip that is generated. Confirm it contains Borrower A's correct details, and the details of the recall are correct. 61. Go to Circulation -> Recalls awaiting pickup. Confirm the recall is now waiting and shows in this list. (You could also try this with Item B having a different item type to Item A, and circ rules not allowing Item B's item type to have recalls. When checking in Item A, it should not trigger the recall box). 62. Go to Borrower A's checkouts. Check out Item B. 63. Confirm the checkout is successful and the recall is removed from the Recalls tab. 64. Go to Circulation -> Old recalls. The fulfilled recall should show. 65. Check in Item B. BIBLIO-LEVEL RECALL, TRANSFER REQUIRED 66. Check out Item A to Borrower B. 67. Log in to the OPAC as Borrower A. 68. Find Biblio A and place a biblio-level recall. Pickup location: Branch B, a different branch from your logged in branch. This recall will require a transfer. Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 69. In the staff client, check in Item A at Branch A. Notice the box that pops up shows that a transfer is required. 70. Click "confirm recall and transfer" and confirm the transfer. 71. Go to your account and click the Recalls tab. 72. Confirm the recall status now shows the item is in transit to Branch B. 73. In the drop-down top-right of your window, select 'Set library'. 74. Set your library to Branch B. 75. Go to Circulation -> Transfers to receive. Notice that the recall is showing here. 76. Click 'Cancel transfer'. 77. Go to Circulation -> Recalls queue 78. Confirm the recall status has been reverted to Requested. 79. Set your library back to Branch A. 80. Check in Item A and trigger the transfer. 81. Set your library back to Branch B. 82. Check in Item A at Branch B. 83. When the 'Recall found' box pops up, click Ignore. 84. Go to Circulation -> Recalls to pull. The recall should show here, with a button to "Cancel recall and return to: Branch A" 85. Click the button to cancel the recall. 86. Repeat Steps 66-70. 87. Check in Item A at Branch B. Confirm the recall as waiting. 88. Check out Item A to Borrower A to fulfill the recall. 89. Set your library back to Branch A and check in Item A. ITEM-LEVEL RECALL, NO TRANSFER 90. Go to Administration -> circulation rules. Set the following rules: On shelf recalls allowed ( If any unavailable / If all unavailable ) = If all unavailable 91. Check out Item A to Borrower B. 92. Log in to the OPAC as Borrower A and go to Biblio A. 93. Click the 'Place recall' button. Confirm there is a message that there are no items to recall. This is because On shelf recalls allowed = If all unavailable, and there is still one item (Item B) available. 94. In the staff client, edit Item B to have a withdrawn, item lost or not for loan status. 95. Refresh the 'Place recall' page. Confirm you can now see the form to place a recall. 96. Place an item-level recall. Pickup location: Branch A. Recall not needed after (expiration date): whatever you want Select 'recall a specific item' Item B will not be selectable, and Item A should be selected by default. Click confirm 97. In the staff client, edit Item B and remove the lost or missing status. 98. Check in Item B. Confirm the recall box does not pop up, because it cannot fill the item-level recall. 99. Check in Item A. Confirm the recall as waiting. 100. Go to Circulation -> Recalls awaiting pickup 101. Expire the recall. Confirm it expires as expected. ITEM-LEVEL RECALL, TRANSFER REQUIRED 102. Repeat steps 91 to 95. 103. Place an item-level recall. Pickup location: Branch B, we will require a transfer. Recall not needed after (expiration date): whatever you want Select 'recall a specific item' Item B will not be selectable, and Item A should be selected by default. Click confirm 104. In the staff client, check in Item A. Confirm the recall and trigger the transfer. 105. Set your library to Branch B and check in Item A. 106. Confirm the recall as waiting. 107. Check out Item A to Borrower A and fulfill the recall. 108. Set your library back to Branch A and check in Item A. CRONJOBS: EXPIRING RECALL 109. Check out Item A to Borrower B. 110. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 111. In your terminal, enter mysql and edit the expiration date of your recall to be before today UPDATE recalls SET expirationdate = NOW()-2 WHERE recall_id = X; 112. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 113. Go to Borrower A's account and go to the Recalls history tab 114. Confirm the recall has been expired because the current date surpassed the specified expiration date 115. Check out Item A to Borrower B. 116. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 117. In the staff client, check in Item A and confirm the recall as waiting. 118. In your terminal, enter mysql and edit the waiting date of your recall to be before today UPDATE recalls SET waitingdate = NOW() - interval 5 day WHERE recall_id = X; 119. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 120. Go to Borrower A's account and go to the Recalls history tab 121. Confirm the recall has been expired because the recall had been waiting for more days than the Recall pickup period 122. Go to Administration -> circulation rules. Set the following rules: Recall pickup period (days) = 0 123. Set the RecallsMaxPickUpDelay system preference = 1. 124. Check out Item A to Borrower B. 125. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 126. In the staff client, check in Item A and confirm the recall as waiting. 127. In your terminal, enter mysql and edit the waiting date of your recall to be before today UPDATE recalls SET waitingdate = NOW()-2 WHERE recall_id = X; 128. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 129. Go to Borrower A's account and go to the Recalls history tab 130. Confirm the recall has been expired because the recall had been waiting for more days than the RecallsMaxPickUpDelay syspref CRONJOBS: OVERDUE RECALL 131. Check out Item A to Borrower B 132. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 133. In your terminal, enter mysql and edit the due date of the checkout to Borrower B to be before today UPDATE issues SET date_due = NOW()-2 WHERE issue_id = X; 134. Run the overdue cronjob from within your shell perl misc/cronjobs/recall/overdue_recalls.pl 135. Go to Circulation -> Overdue recalls 136. Confirm your recall is showing here now as the recall has been marked Overdue CIRCULATION 137. Check in Item A. 138. When the recall box pops up, click Ignore. 139. Check out Item A to Borrower B. You should see a yellow confirmation box, saying that another borrower has recalled the item you are trying to check out. 140. Click "No don't check out" and confirm the item isn't checked out and the recall remains. 141. Repeat Step 139. 142. Click "Yes check out" and confirm the item is checked out and the recall remains. 143. When Borrower B's checkout table loads, confirm that you cannot renew or check in the item from the Checkouts table because there is a 'Recalled' link which takes you to the recalls tab for that biblio. 144. Repeat Steps 137-139. 145. Select "Cancel recall" and click "Yes check out" and confirm the item is checked out and the recall has been cancelled. 146. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 147. Check in Item A. Confirm the recall as waiting. 148. Check out Item A to Borrower B. You should see a yellow confirmation box, saying that that another borrower has recalled the item that you are trying to check out. 149. Select "Revert waiting status" and click "Yes check out" and confirm the item is checked out and the recall status has reverted to requested. OTHER 150. In your terminal, enter mysql and edit the due date of the checkout to Borrower B to be before today UPDATE issues SET date_due = NOW()-2 WHERE issue_id = X; 151. Go to Borrower A's recalls and click the Actions dropdown. 152. Click "Mark as overdue" and confirm the recall is marked as overdue manually. 153. Go to Tools -> Log Viewer. Check only the Recalls module, and leave all other parameters, and click Submit. 154. Confirm all of the recalls actions that have been made are correctly logged. Note: recalls messaging preferences are introduced in Bug 23781. The recall feature is fully documented at: https://wiki.koha-community.org/wiki/Catalyst_IT_Recalls Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118275|0 |1 is obsolete| | --- Comment #724 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 123001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123001&action=edit Bug 19532: (follow-up) aria-hidden attr on OPAC, and more - removing authnotrequired flag from scripts - fixing opac buttons - chmod +x for recalls test files Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118276|0 |1 is obsolete| | --- Comment #725 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 123002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123002&action=edit Bug 19532: (follow-up) Fixing failing CalcFine.t test Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118277|0 |1 is obsolete| | --- Comment #726 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 123003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123003&action=edit Bug 19532: (follow-up) Fixing OPAC display and staff client errors - fixes the displays of opac-recalls.pl and opac-recall.pl - fix the error on Recalls to pull page - fix JS error preventing Recalled link from showing in checkouts table - fix cancelling of recall when checking out item Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118278|0 |1 is obsolete| | --- Comment #727 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 123004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123004&action=edit Bug 19532: (follow-up) Fix undef recall_id preventing fulfillment of recall Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118279|0 |1 is obsolete| | --- Comment #728 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 123005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123005&action=edit Bug 19532: (follow-up) Fixing tests and QA tools And making reverted ajax message clearer Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Hannah Co <hannah.co@northwestu.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hannah.co@northwestu.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #729 from David Nind <david@davidnind.com> --- Hi Aleisha. Patches no longer apply 8-(... Note: I will make it a priority for me to review and sign-off once it applies again. It would be nice to get all your hard work into master (finally!). Applying: Bug 19532: Database and installer stuff Using index info to reconstruct a base tree... M C4/Auth.pm M Koha/CirculationRules.pm M Makefile.PL M admin/smart-rules.pl M installer/data/mysql/en/mandatory/sample_notices.yml A installer/data/mysql/fr-CA/obligatoire/sample_notices.sql M installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql M installer/data/mysql/kohastructure.sql M installer/data/mysql/mandatory/sysprefs.sql M installer/data/mysql/mandatory/userpermissions.sql A installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql M koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref M koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc CONFLICT (modify/delete): installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql deleted in HEAD and modified in Bug 19532: Database and installer stuff. Version Bug 19532: Database and installer stuff of installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql left in tree. Auto-merging installer/data/mysql/mandatory/userpermissions.sql Auto-merging installer/data/mysql/mandatory/sysprefs.sql Auto-merging installer/data/mysql/kohastructure.sql Auto-merging installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql CONFLICT (content): Merge conflict in installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql CONFLICT (modify/delete): installer/data/mysql/fr-CA/obligatoire/sample_notices.sql deleted in HEAD and modified in Bug 19532: Database and installer stuff. Version Bug 19532: Database and installer stuff of installer/data/mysql/fr-CA/obligatoire/sample_notices.sql left in tree. Auto-merging installer/data/mysql/en/mandatory/sample_notices.yml Auto-merging admin/smart-rules.pl Auto-merging Makefile.PL Auto-merging Koha/CirculationRules.pm Auto-merging C4/Auth.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 19532: Database and installer stuff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122993|0 |1 is obsolete| | --- Comment #730 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 126244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126244&action=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122994|0 |1 is obsolete| | --- Comment #731 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 126245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126245&action=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122995|0 |1 is obsolete| | --- Comment #732 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 126246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126246&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122996|0 |1 is obsolete| | --- Comment #733 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 126247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126247&action=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122997|0 |1 is obsolete| | --- Comment #734 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 126248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126248&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122998|0 |1 is obsolete| | --- Comment #735 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 126249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126249&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122999|0 |1 is obsolete| | --- Comment #736 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 126250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126250&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123000|0 |1 is obsolete| | --- Comment #737 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 126251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126251&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls == TEST PLAN FOR RECALLS == ADMINISTRATION 1. Apply all patches 2. Run database updates, update schema files and confirm everything applies cleanly 3. Run tests and confirm everything passes: t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t t/db_dependent/Stats.t t/db_dependent/Circulation/CalcFine.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Patron.t t/db_dependent/XSLT.t t/db_dependent/Search.t t/db_dependent/Holds.t t/db_dependent/Circulation/transferbook.t t/db_dependent/Circulation.t 4. Go to Administration -> system preferences. Find the UseRecalls system preference. It should be DISABLED. Confirm RecallsMaxPickUpDelay is set to 7 by default. 5. Go to Administration -> circulation rules. Confirm there are no recalls circulation rules showing. 6. Test a few circulation flows: checking out, placing a reserve, checking in, fulfilling a reserve, etc. Confirm everything works as normal. 7. Go to Administration -> system preferences. Enable the UseRecalls system preference. 8. Go to Administration -> circulation rules. Set the following rules: Recalls allowed (count) = 0 Recalls per record (count) = 0 On shelf recalls allowed ( If any unavailable / If all unavailable ) = If any unavailable Recall due date interval (days) = 3 Recall overdue fine amount = (something different to your normal fine amount) Recall pickup period (days) = 1 Throughout your testing, try with different combinations of these rules and itemtype / branchcode / categorycode. Also try with null values. Keep the circulation rules open in another tab so you can refer to and update these easily. You should also have at least one other tab open for the staff client, and a third tab open for the OPAC, for ease of testing. 9. Go to your account -> More -> Set permissions. Confirm the recalls permission is checked. 10. Set up a test user with OPAC login details (Borrower A). This could also be your own user, as long as you have OPAC login access. 11. Set up a test record (Biblio A) with at least two items (Item A and Item B) of the same item type (or an item type with the same recall circ rules). PLACING A RECALL 12. Log in to the OPAC as Borrower A. Do a catalogue search with a term that will return multiple results, including Biblio A. 13. Click on Biblio A. 14. Notice there is a 'Place recall' button on the sidebar menu. Click this button. There will be a message saying that there are no items to recall - this is because all items are available. 15. Check out Item A to another borrower (Borrower B). 16. Refresh the 'Place recall' page. You will still NOT be able to place a recall - this is because Recalls allowed = 0 and Recalls per record = 0. 17. Edit the circulation rules to have the following values: Recalls allowed (count) = 1 Recalls per record (count) = 1 18. Refresh the 'Place recall' page. You will now see the form to place a recall. BIBLIO-LEVEL RECALL, NO TRANSFER 19. Place a biblio-level recall. Pickup location: Branch A, the set branch when you are logged into the staff client Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 20. Confirm the recall is placed successfully. Confirm that the new due date displayed is correctly calculated to be today's date, plus 3 days (taken from the 'recall due date interval' circ rule) 21. In the staff client, look at Borrower B's account, and go to their Notices tab. Confirm they have received a 'Notification to return recalled item' notice. 22. Look at Borrower B's checkouts table. Notice the due date for their checkout has been adjusted, and there is now a note to say that the item was recalled and the due date adjusted. 23. Log in to the OPAC as Borrower B and go to your summary tab. Notice there is a note under their checkout to say the item had been recalled. 24. Log out of the OPAC and log back in as Borrower A. 25. Go to your summary tab. Confirm there is a Recalls tab with a count of 1. 26. Cancel the recall using the button. Confirm it cancels and the Recalls tab disappears. 27. Do a catalogue search with a term that will return multiple results, including Biblio A. 28. When the results load, notice there is a 'Place recall' button next to the 'Place hold' button. Click this 'Place recall' button. 29. Notice you are redirected straight to the form to place a recall. 30. Place a biblio-level recall again, following the steps in Step 19. 31. Go to your recalls history tab. Notice your first cancelled recall shows here. 32. Cancel the recall you just created, using the button. Confirm it cancels and you are redirected to your summary tab. 33. In the staff client, enable the UseCourseReserves system preference. 34. Go to the main menu, click Course Reserves. 35. Add a new course. (You may also have to define an authorised value for DEPARTMENT.) 36. Add Item A as a reserve to this course. 37. View Course Reserves in the OPAC. Click the course you just created. 38. Notice the reserve has a Recall button underneath it's 'Checked out' status. Click this button. 39. Place a biblio-level recall again, following the steps in Step 19. 40. Click the 'Place recall' link in the breadcrumbs. 41. Notice there is a message saying that you have reached the max number of recalls on this record. This is because Recalls allowed = 1 and Recalls per record = 1. 42. Edit the circulation rules to have the following values: Recalls allowed (count) = 10 Recalls per record (count) = 5 43. Refresh the 'Place recall' page. You will now see the form to place a recall. 44. Create another test record (Biblio B) with at least one item (Item C). 45. Find this record on the OPAC and place a biblio-level recall again, following the steps in Step 19. 46. In the staff client, go to Circulation -> Old recalls. You should be able to see your two cancelled recalls. 47. Go to Circulation -> Recalls queue. Your current recalls should show here. 48. Use the 'Select all' checkbox to select all recalls. 49. Cancel the recalls using the 'Cancel selected recalls' button. 50. Go to the OPAC and place a biblio-level recall on Biblio A again, following the steps in Step 19. 51. In the staff client, check in Item A, which should still be checked out to Borrower B. 52. A box should pop-up asking you to confirm Borrower A's recall. Click ignore. 53. Click the link to go view Biblio A's details in the catalogue. 54. Click the recalls tab. Notice Borrower A's recall is displayed, and shows it is still Requested (has not been confirmed waiting). 55. Check in Item A again. This time, confirm the recall as waiting using the "Confirm recall" button. 56. Go to Borrower A's Notices tab. Confirm there is a notice "Recalled item awaiting pickup". 57. Go to Borrower A's checkouts. Notice there is a recalls tab. Confirm the recall is showing as "Ready for pickup". 58. Click the 'Actions' dropdown. Click the "Revert waiting" button. The page should show a message that the waiting status has been reverted, without reloading. 59. This time, check in Item B. The recall confirmation box should show again, because this a biblio-level recall that any recallable item under Biblio A can fill. Click the "Print slip and confirm" button. 60. Check the slip that is generated. Confirm it contains Borrower A's correct details, and the details of the recall are correct. 61. Go to Circulation -> Recalls awaiting pickup. Confirm the recall is now waiting and shows in this list. (You could also try this with Item B having a different item type to Item A, and circ rules not allowing Item B's item type to have recalls. When checking in Item A, it should not trigger the recall box). 62. Go to Borrower A's checkouts. Check out Item B. 63. Confirm the checkout is successful and the recall is removed from the Recalls tab. 64. Go to Circulation -> Old recalls. The fulfilled recall should show. 65. Check in Item B. BIBLIO-LEVEL RECALL, TRANSFER REQUIRED 66. Check out Item A to Borrower B. 67. Log in to the OPAC as Borrower A. 68. Find Biblio A and place a biblio-level recall. Pickup location: Branch B, a different branch from your logged in branch. This recall will require a transfer. Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 69. In the staff client, check in Item A at Branch A. Notice the box that pops up shows that a transfer is required. 70. Click "confirm recall and transfer" and confirm the transfer. 71. Go to your account and click the Recalls tab. 72. Confirm the recall status now shows the item is in transit to Branch B. 73. In the drop-down top-right of your window, select 'Set library'. 74. Set your library to Branch B. 75. Go to Circulation -> Transfers to receive. Notice that the recall is showing here. 76. Click 'Cancel transfer'. 77. Go to Circulation -> Recalls queue 78. Confirm the recall status has been reverted to Requested. 79. Set your library back to Branch A. 80. Check in Item A and trigger the transfer. 81. Set your library back to Branch B. 82. Check in Item A at Branch B. 83. When the 'Recall found' box pops up, click Ignore. 84. Go to Circulation -> Recalls to pull. The recall should show here, with a button to "Cancel recall and return to: Branch A" 85. Click the button to cancel the recall. 86. Repeat Steps 66-70. 87. Check in Item A at Branch B. Confirm the recall as waiting. 88. Check out Item A to Borrower A to fulfill the recall. 89. Set your library back to Branch A and check in Item A. ITEM-LEVEL RECALL, NO TRANSFER 90. Go to Administration -> circulation rules. Set the following rules: On shelf recalls allowed ( If any unavailable / If all unavailable ) = If all unavailable 91. Check out Item A to Borrower B. 92. Log in to the OPAC as Borrower A and go to Biblio A. 93. Click the 'Place recall' button. Confirm there is a message that there are no items to recall. This is because On shelf recalls allowed = If all unavailable, and there is still one item (Item B) available. 94. In the staff client, edit Item B to have a withdrawn, item lost or not for loan status. 95. Refresh the 'Place recall' page. Confirm you can now see the form to place a recall. 96. Place an item-level recall. Pickup location: Branch A. Recall not needed after (expiration date): whatever you want Select 'recall a specific item' Item B will not be selectable, and Item A should be selected by default. Click confirm 97. In the staff client, edit Item B and remove the lost or missing status. 98. Check in Item B. Confirm the recall box does not pop up, because it cannot fill the item-level recall. 99. Check in Item A. Confirm the recall as waiting. 100. Go to Circulation -> Recalls awaiting pickup 101. Expire the recall. Confirm it expires as expected. ITEM-LEVEL RECALL, TRANSFER REQUIRED 102. Repeat steps 91 to 95. 103. Place an item-level recall. Pickup location: Branch B, we will require a transfer. Recall not needed after (expiration date): whatever you want Select 'recall a specific item' Item B will not be selectable, and Item A should be selected by default. Click confirm 104. In the staff client, check in Item A. Confirm the recall and trigger the transfer. 105. Set your library to Branch B and check in Item A. 106. Confirm the recall as waiting. 107. Check out Item A to Borrower A and fulfill the recall. 108. Set your library back to Branch A and check in Item A. CRONJOBS: EXPIRING RECALL 109. Check out Item A to Borrower B. 110. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 111. In your terminal, enter mysql and edit the expiration date of your recall to be before today UPDATE recalls SET expirationdate = NOW()-2 WHERE recall_id = X; 112. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 113. Go to Borrower A's account and go to the Recalls history tab 114. Confirm the recall has been expired because the current date surpassed the specified expiration date 115. Check out Item A to Borrower B. 116. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 117. In the staff client, check in Item A and confirm the recall as waiting. 118. In your terminal, enter mysql and edit the waiting date of your recall to be before today UPDATE recalls SET waitingdate = NOW() - interval 5 day WHERE recall_id = X; 119. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 120. Go to Borrower A's account and go to the Recalls history tab 121. Confirm the recall has been expired because the recall had been waiting for more days than the Recall pickup period 122. Go to Administration -> circulation rules. Set the following rules: Recall pickup period (days) = 0 123. Set the RecallsMaxPickUpDelay system preference = 1. 124. Check out Item A to Borrower B. 125. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 126. In the staff client, check in Item A and confirm the recall as waiting. 127. In your terminal, enter mysql and edit the waiting date of your recall to be before today UPDATE recalls SET waitingdate = NOW()-2 WHERE recall_id = X; 128. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 129. Go to Borrower A's account and go to the Recalls history tab 130. Confirm the recall has been expired because the recall had been waiting for more days than the RecallsMaxPickUpDelay syspref CRONJOBS: OVERDUE RECALL 131. Check out Item A to Borrower B 132. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 133. In your terminal, enter mysql and edit the due date of the checkout to Borrower B to be before today UPDATE issues SET date_due = NOW()-2 WHERE issue_id = X; 134. Run the overdue cronjob from within your shell perl misc/cronjobs/recall/overdue_recalls.pl 135. Go to Circulation -> Overdue recalls 136. Confirm your recall is showing here now as the recall has been marked Overdue CIRCULATION 137. Check in Item A. 138. When the recall box pops up, click Ignore. 139. Check out Item A to Borrower B. You should see a yellow confirmation box, saying that another borrower has recalled the item you are trying to check out. 140. Click "No don't check out" and confirm the item isn't checked out and the recall remains. 141. Repeat Step 139. 142. Click "Yes check out" and confirm the item is checked out and the recall remains. 143. When Borrower B's checkout table loads, confirm that you cannot renew or check in the item from the Checkouts table because there is a 'Recalled' link which takes you to the recalls tab for that biblio. 144. Repeat Steps 137-139. 145. Select "Cancel recall" and click "Yes check out" and confirm the item is checked out and the recall has been cancelled. 146. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 147. Check in Item A. Confirm the recall as waiting. 148. Check out Item A to Borrower B. You should see a yellow confirmation box, saying that that another borrower has recalled the item that you are trying to check out. 149. Select "Revert waiting status" and click "Yes check out" and confirm the item is checked out and the recall status has reverted to requested. OTHER 150. In your terminal, enter mysql and edit the due date of the checkout to Borrower B to be before today UPDATE issues SET date_due = NOW()-2 WHERE issue_id = X; 151. Go to Borrower A's recalls and click the Actions dropdown. 152. Click "Mark as overdue" and confirm the recall is marked as overdue manually. 153. Go to Tools -> Log Viewer. Check only the Recalls module, and leave all other parameters, and click Submit. 154. Confirm all of the recalls actions that have been made are correctly logged. Note: recalls messaging preferences are introduced in Bug 23781. The recall feature is fully documented at: https://wiki.koha-community.org/wiki/Catalyst_IT_Recalls Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123001|0 |1 is obsolete| | --- Comment #738 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 126252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126252&action=edit Bug 19532: (follow-up) aria-hidden attr on OPAC, and more - removing authnotrequired flag from scripts - fixing opac buttons - chmod +x for recalls test files Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123002|0 |1 is obsolete| | --- Comment #739 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 126253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126253&action=edit Bug 19532: (follow-up) Fixing failing CalcFine.t test Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123003|0 |1 is obsolete| | --- Comment #740 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 126254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126254&action=edit Bug 19532: (follow-up) Fixing OPAC display and staff client errors - fixes the displays of opac-recalls.pl and opac-recall.pl - fix the error on Recalls to pull page - fix JS error preventing Recalled link from showing in checkouts table - fix cancelling of recall when checking out item Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123004|0 |1 is obsolete| | --- Comment #741 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 126255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126255&action=edit Bug 19532: (follow-up) Fix undef recall_id preventing fulfillment of recall Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123005|0 |1 is obsolete| | --- Comment #742 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 126256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126256&action=edit Bug 19532: (follow-up) Fixing tests and QA tools And making reverted ajax message clearer Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #743 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 126257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126257&action=edit Bug 19532: (follow-up) Fix calls and syspref settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #744 from David Nind <david@davidnind.com> --- Hi Aleisha. I started around Friday, but didn't get very far...
From what I can recall (pun intended!), these tests failed:
prove t/db_dependent/Koha/Recall.t prove t/db_dependent/Koha/Recalls.t Today (Monday), the patch no longer applies: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 19532: Database and installer stuff Applying: Bug 19532: Updated schema files Applying: Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall Applying: Bug 19532: Recalls objects and tests Applying: Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation Applying: Bug 19532: Other objects used in recalls feature Applying: Bug 19532: Recalls on OPAC Applying: Bug 19532: Recalls on intranet Using index info to reconstruct a base tree... M circ/circulation.pl M koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging circ/circulation.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 19532: Recalls on intranet -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126251|0 |1 is obsolete| | --- Comment #745 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 126453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126453&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls == TEST PLAN FOR RECALLS == ADMINISTRATION 1. Apply all patches 2. Run database updates, update schema files and confirm everything applies cleanly 3. Run tests and confirm everything passes: t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t t/db_dependent/Stats.t t/db_dependent/Circulation/CalcFine.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Patron.t t/db_dependent/XSLT.t t/db_dependent/Search.t t/db_dependent/Holds.t t/db_dependent/Circulation/transferbook.t t/db_dependent/Circulation.t 4. Go to Administration -> system preferences. Find the UseRecalls system preference. It should be DISABLED. Confirm RecallsMaxPickUpDelay is set to 7 by default. 5. Go to Administration -> circulation rules. Confirm there are no recalls circulation rules showing. 6. Test a few circulation flows: checking out, placing a reserve, checking in, fulfilling a reserve, etc. Confirm everything works as normal. 7. Go to Administration -> system preferences. Enable the UseRecalls system preference. 8. Go to Administration -> circulation rules. Set the following rules: Recalls allowed (count) = 0 Recalls per record (count) = 0 On shelf recalls allowed ( If any unavailable / If all unavailable ) = If any unavailable Recall due date interval (days) = 3 Recall overdue fine amount = (something different to your normal fine amount) Recall pickup period (days) = 1 Throughout your testing, try with different combinations of these rules and itemtype / branchcode / categorycode. Also try with null values. Keep the circulation rules open in another tab so you can refer to and update these easily. You should also have at least one other tab open for the staff client, and a third tab open for the OPAC, for ease of testing. 9. Go to your account -> More -> Set permissions. Confirm the recalls permission is checked. 10. Set up a test user with OPAC login details (Borrower A). This could also be your own user, as long as you have OPAC login access. 11. Set up a test record (Biblio A) with at least two items (Item A and Item B) of the same item type (or an item type with the same recall circ rules). PLACING A RECALL 12. Log in to the OPAC as Borrower A. Do a catalogue search with a term that will return multiple results, including Biblio A. 13. Click on Biblio A. 14. Notice there is a 'Place recall' button on the sidebar menu. Click this button. There will be a message saying that there are no items to recall - this is because all items are available. 15. Check out Item A to another borrower (Borrower B). 16. Refresh the 'Place recall' page. You will still NOT be able to place a recall - this is because Recalls allowed = 0 and Recalls per record = 0. 17. Edit the circulation rules to have the following values: Recalls allowed (count) = 1 Recalls per record (count) = 1 18. Refresh the 'Place recall' page. You will now see the form to place a recall. BIBLIO-LEVEL RECALL, NO TRANSFER 19. Place a biblio-level recall. Pickup location: Branch A, the set branch when you are logged into the staff client Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 20. Confirm the recall is placed successfully. Confirm that the new due date displayed is correctly calculated to be today's date, plus 3 days (taken from the 'recall due date interval' circ rule) 21. In the staff client, look at Borrower B's account, and go to their Notices tab. Confirm they have received a 'Notification to return recalled item' notice. 22. Look at Borrower B's checkouts table. Notice the due date for their checkout has been adjusted, and there is now a note to say that the item was recalled and the due date adjusted. 23. Log in to the OPAC as Borrower B and go to your summary tab. Notice there is a note under their checkout to say the item had been recalled. 24. Log out of the OPAC and log back in as Borrower A. 25. Go to your summary tab. Confirm there is a Recalls tab with a count of 1. 26. Cancel the recall using the button. Confirm it cancels and the Recalls tab disappears. 27. Do a catalogue search with a term that will return multiple results, including Biblio A. 28. When the results load, notice there is a 'Place recall' button next to the 'Place hold' button. Click this 'Place recall' button. 29. Notice you are redirected straight to the form to place a recall. 30. Place a biblio-level recall again, following the steps in Step 19. 31. Go to your recalls history tab. Notice your first cancelled recall shows here. 32. Cancel the recall you just created, using the button. Confirm it cancels and you are redirected to your summary tab. 33. In the staff client, enable the UseCourseReserves system preference. 34. Go to the main menu, click Course Reserves. 35. Add a new course. (You may also have to define an authorised value for DEPARTMENT.) 36. Add Item A as a reserve to this course. 37. View Course Reserves in the OPAC. Click the course you just created. 38. Notice the reserve has a Recall button underneath it's 'Checked out' status. Click this button. 39. Place a biblio-level recall again, following the steps in Step 19. 40. Click the 'Place recall' link in the breadcrumbs. 41. Notice there is a message saying that you have reached the max number of recalls on this record. This is because Recalls allowed = 1 and Recalls per record = 1. 42. Edit the circulation rules to have the following values: Recalls allowed (count) = 10 Recalls per record (count) = 5 43. Refresh the 'Place recall' page. You will now see the form to place a recall. 44. Create another test record (Biblio B) with at least one item (Item C). 45. Find this record on the OPAC and place a biblio-level recall again, following the steps in Step 19. 46. In the staff client, go to Circulation -> Old recalls. You should be able to see your two cancelled recalls. 47. Go to Circulation -> Recalls queue. Your current recalls should show here. 48. Use the 'Select all' checkbox to select all recalls. 49. Cancel the recalls using the 'Cancel selected recalls' button. 50. Go to the OPAC and place a biblio-level recall on Biblio A again, following the steps in Step 19. 51. In the staff client, check in Item A, which should still be checked out to Borrower B. 52. A box should pop-up asking you to confirm Borrower A's recall. Click ignore. 53. Click the link to go view Biblio A's details in the catalogue. 54. Click the recalls tab. Notice Borrower A's recall is displayed, and shows it is still Requested (has not been confirmed waiting). 55. Check in Item A again. This time, confirm the recall as waiting using the "Confirm recall" button. 56. Go to Borrower A's Notices tab. Confirm there is a notice "Recalled item awaiting pickup". 57. Go to Borrower A's checkouts. Notice there is a recalls tab. Confirm the recall is showing as "Ready for pickup". 58. Click the 'Actions' dropdown. Click the "Revert waiting" button. The page should show a message that the waiting status has been reverted, without reloading. 59. This time, check in Item B. The recall confirmation box should show again, because this a biblio-level recall that any recallable item under Biblio A can fill. Click the "Print slip and confirm" button. 60. Check the slip that is generated. Confirm it contains Borrower A's correct details, and the details of the recall are correct. 61. Go to Circulation -> Recalls awaiting pickup. Confirm the recall is now waiting and shows in this list. (You could also try this with Item B having a different item type to Item A, and circ rules not allowing Item B's item type to have recalls. When checking in Item A, it should not trigger the recall box). 62. Go to Borrower A's checkouts. Check out Item B. 63. Confirm the checkout is successful and the recall is removed from the Recalls tab. 64. Go to Circulation -> Old recalls. The fulfilled recall should show. 65. Check in Item B. BIBLIO-LEVEL RECALL, TRANSFER REQUIRED 66. Check out Item A to Borrower B. 67. Log in to the OPAC as Borrower A. 68. Find Biblio A and place a biblio-level recall. Pickup location: Branch B, a different branch from your logged in branch. This recall will require a transfer. Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 69. In the staff client, check in Item A at Branch A. Notice the box that pops up shows that a transfer is required. 70. Click "confirm recall and transfer" and confirm the transfer. 71. Go to your account and click the Recalls tab. 72. Confirm the recall status now shows the item is in transit to Branch B. 73. In the drop-down top-right of your window, select 'Set library'. 74. Set your library to Branch B. 75. Go to Circulation -> Transfers to receive. Notice that the recall is showing here. 76. Click 'Cancel transfer'. 77. Go to Circulation -> Recalls queue 78. Confirm the recall status has been reverted to Requested. 79. Set your library back to Branch A. 80. Check in Item A and trigger the transfer. 81. Set your library back to Branch B. 82. Check in Item A at Branch B. 83. When the 'Recall found' box pops up, click Ignore. 84. Go to Circulation -> Recalls to pull. The recall should show here, with a button to "Cancel recall and return to: Branch A" 85. Click the button to cancel the recall. 86. Repeat Steps 66-70. 87. Check in Item A at Branch B. Confirm the recall as waiting. 88. Check out Item A to Borrower A to fulfill the recall. 89. Set your library back to Branch A and check in Item A. ITEM-LEVEL RECALL, NO TRANSFER 90. Go to Administration -> circulation rules. Set the following rules: On shelf recalls allowed ( If any unavailable / If all unavailable ) = If all unavailable 91. Check out Item A to Borrower B. 92. Log in to the OPAC as Borrower A and go to Biblio A. 93. Click the 'Place recall' button. Confirm there is a message that there are no items to recall. This is because On shelf recalls allowed = If all unavailable, and there is still one item (Item B) available. 94. In the staff client, edit Item B to have a withdrawn, item lost or not for loan status. 95. Refresh the 'Place recall' page. Confirm you can now see the form to place a recall. 96. Place an item-level recall. Pickup location: Branch A. Recall not needed after (expiration date): whatever you want Select 'recall a specific item' Item B will not be selectable, and Item A should be selected by default. Click confirm 97. In the staff client, edit Item B and remove the lost or missing status. 98. Check in Item B. Confirm the recall box does not pop up, because it cannot fill the item-level recall. 99. Check in Item A. Confirm the recall as waiting. 100. Go to Circulation -> Recalls awaiting pickup 101. Expire the recall. Confirm it expires as expected. ITEM-LEVEL RECALL, TRANSFER REQUIRED 102. Repeat steps 91 to 95. 103. Place an item-level recall. Pickup location: Branch B, we will require a transfer. Recall not needed after (expiration date): whatever you want Select 'recall a specific item' Item B will not be selectable, and Item A should be selected by default. Click confirm 104. In the staff client, check in Item A. Confirm the recall and trigger the transfer. 105. Set your library to Branch B and check in Item A. 106. Confirm the recall as waiting. 107. Check out Item A to Borrower A and fulfill the recall. 108. Set your library back to Branch A and check in Item A. CRONJOBS: EXPIRING RECALL 109. Check out Item A to Borrower B. 110. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 111. In your terminal, enter mysql and edit the expiration date of your recall to be before today UPDATE recalls SET expirationdate = NOW()-2 WHERE recall_id = X; 112. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 113. Go to Borrower A's account and go to the Recalls history tab 114. Confirm the recall has been expired because the current date surpassed the specified expiration date 115. Check out Item A to Borrower B. 116. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 117. In the staff client, check in Item A and confirm the recall as waiting. 118. In your terminal, enter mysql and edit the waiting date of your recall to be before today UPDATE recalls SET waitingdate = NOW() - interval 5 day WHERE recall_id = X; 119. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 120. Go to Borrower A's account and go to the Recalls history tab 121. Confirm the recall has been expired because the recall had been waiting for more days than the Recall pickup period 122. Go to Administration -> circulation rules. Set the following rules: Recall pickup period (days) = 0 123. Set the RecallsMaxPickUpDelay system preference = 1. 124. Check out Item A to Borrower B. 125. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 126. In the staff client, check in Item A and confirm the recall as waiting. 127. In your terminal, enter mysql and edit the waiting date of your recall to be before today UPDATE recalls SET waitingdate = NOW()-2 WHERE recall_id = X; 128. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 129. Go to Borrower A's account and go to the Recalls history tab 130. Confirm the recall has been expired because the recall had been waiting for more days than the RecallsMaxPickUpDelay syspref CRONJOBS: OVERDUE RECALL 131. Check out Item A to Borrower B 132. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 133. In your terminal, enter mysql and edit the due date of the checkout to Borrower B to be before today UPDATE issues SET date_due = NOW()-2 WHERE issue_id = X; 134. Run the overdue cronjob from within your shell perl misc/cronjobs/recall/overdue_recalls.pl 135. Go to Circulation -> Overdue recalls 136. Confirm your recall is showing here now as the recall has been marked Overdue CIRCULATION 137. Check in Item A. 138. When the recall box pops up, click Ignore. 139. Check out Item A to Borrower B. You should see a yellow confirmation box, saying that another borrower has recalled the item you are trying to check out. 140. Click "No don't check out" and confirm the item isn't checked out and the recall remains. 141. Repeat Step 139. 142. Click "Yes check out" and confirm the item is checked out and the recall remains. 143. When Borrower B's checkout table loads, confirm that you cannot renew or check in the item from the Checkouts table because there is a 'Recalled' link which takes you to the recalls tab for that biblio. 144. Repeat Steps 137-139. 145. Select "Cancel recall" and click "Yes check out" and confirm the item is checked out and the recall has been cancelled. 146. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 147. Check in Item A. Confirm the recall as waiting. 148. Check out Item A to Borrower B. You should see a yellow confirmation box, saying that that another borrower has recalled the item that you are trying to check out. 149. Select "Revert waiting status" and click "Yes check out" and confirm the item is checked out and the recall status has reverted to requested. OTHER 150. In your terminal, enter mysql and edit the due date of the checkout to Borrower B to be before today UPDATE issues SET date_due = NOW()-2 WHERE issue_id = X; 151. Go to Borrower A's recalls and click the Actions dropdown. 152. Click "Mark as overdue" and confirm the recall is marked as overdue manually. 153. Go to Tools -> Log Viewer. Check only the Recalls module, and leave all other parameters, and click Submit. 154. Confirm all of the recalls actions that have been made are correctly logged. Note: recalls messaging preferences are introduced in Bug 23781. The recall feature is fully documented at: https://wiki.koha-community.org/wiki/Catalyst_IT_Recalls Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126252|0 |1 is obsolete| | --- Comment #746 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 126454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126454&action=edit Bug 19532: (follow-up) aria-hidden attr on OPAC, and more - removing authnotrequired flag from scripts - fixing opac buttons - chmod +x for recalls test files Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126253|0 |1 is obsolete| | --- Comment #747 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 126455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126455&action=edit Bug 19532: (follow-up) Fixing failing CalcFine.t test Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126254|0 |1 is obsolete| | --- Comment #748 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 126456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126456&action=edit Bug 19532: (follow-up) Fixing OPAC display and staff client errors - fixes the displays of opac-recalls.pl and opac-recall.pl - fix the error on Recalls to pull page - fix JS error preventing Recalled link from showing in checkouts table - fix cancelling of recall when checking out item Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126255|0 |1 is obsolete| | --- Comment #749 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 126457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126457&action=edit Bug 19532: (follow-up) Fix undef recall_id preventing fulfillment of recall Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126256|0 |1 is obsolete| | --- Comment #750 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 126458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126458&action=edit Bug 19532: (follow-up) Fixing tests and QA tools And making reverted ajax message clearer Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126257|0 |1 is obsolete| | --- Comment #751 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 126459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126459&action=edit Bug 19532: (follow-up) Fix calls and syspref settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #752 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 126460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126460&action=edit Bug 19532: (follow-up) Fixing tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #753 from David Nind <david@davidnind.com> --- Thanks Aleisha! Patches now apply and tests all pass - on with going through the test plan.... David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #754 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Fingers crossed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126460|0 |1 is obsolete| | --- Comment #755 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 126469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126469&action=edit Bug 19532: (follow-up) Fixing tests and can_be_recalled checks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126469|0 |1 is obsolete| | --- Comment #756 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 126470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126470&action=edit Bug 19532: (follow-up) Fixing tests and can_be_recalled checks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #757 from David Nind <david@davidnind.com> --- Hi Aleisha, I finally finished running through the test plan! Two items where I had issues: 1. Steps 61 + 100: I get an error trace when accessing Circulation > Recalls awaiting pickup (http://127.0.0.1:8081/cgi-bin/koha/recalls/recalls_waiting.pl), see partial details below. 2. Error when running expiry cronjob (perl misc/cronjobs/recalls/expire_recalls.pl): . Step 112: - Undefined subroutine &main::dt_from_string called at misc/cronjobs/recalls/expire_recalls.pl line 42. - Recall not expired - still showing as 'Requested' . Step 118: - Undefined subroutine &main::dt_from_string called at misc/cronjobs/recalls/expire_recalls.pl line 53. - Recall not expired - still showing as 'Ready for pickup' . Step 128: - Undefined subroutine &main::dt_from_string called at misc/cronjobs/recalls/expire_recalls.pl line 53. - Recall not expired - still showing as 'Ready for pickup' David Error trace - recalls_waiting.pl ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_recalls_recalls_waiting_2epl::dt_from_string called at /kohadevbox/koha/recalls/recalls_waiting.pl line 58 in (eval) at /kohadevbox/koha/recalls/recalls_waiting.pl line 58 55: my $borrower = Koha::Patrons->find( $loggedinuser ); 56: my @over; 57: my $maxdelay = C4::Context->preference('RecallsMaxPickUpDelay') || 7; 58: my $today = dt_from_string(); 59: foreach my $r ( @recalls ){ 60: my $lastwaitingday = dt_from_string( $r->waitingdate )->add( days => $maxdelay ); 61: if ( $today > $lastwaitingday ){ in CGI::Compile::ROOT::kohadevbox_koha_recalls_recalls_waiting_2epl::__ANON__ at /kohadevbox/koha/recalls/recalls_waiting.pl line 2 1: #!/usr/bin/perl 2: 3: # Copyright 2020 Aleisha Amohia <aleisha@catalyst.net.nz> 4: # 5: # This file is part of Koha. Show function arguments in CGI::Compile::ROOT::kohadevbox_koha_recalls_recalls_waiting_2epl::recalls_waiting_2epl at /usr/share/perl5/CGI/Compile.pm line 151 148: # this is necessary for MSWin32 149: my $orig_warn = $SIG{__WARN__} || sub { warn(@_) }; 150: local $SIG{__WARN__} = sub { $orig_warn->(@_) unless $_[0] =~ /^No such signal/ }; 151: $code->($self, $data, $path, $dir, \@args) 152: }; 153: }; 154: in CGI::Emulate::PSGI::__ANON__ at /usr/share/perl5/CGI/Emulate/PSGI.pm line 30 27: local *STDOUT = $stdout; 28: local *STDERR = $env->{'psgi.errors'}; 29: 30: $code->(); 31: } 32: } 33: .... Notes for myself - SQL queries ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ - Step 111: SQL should be: UPDATE recalls SET expirationdate = NOW() - interval 2 day WHERE recall_id = X; - Step 127: SQL should be: UPDATE recalls SET waitingdate = NOW() - interval 2 day WHERE recall_id = X; - Step 133: SQL should be: UPDATE issues SET date_due = NOW() - interval 2 day WHERE issue_id = X; - Step 134: Script path should be recalls (not recall): perl misc/cronjobs/recalls/overdue_recalls.pl - Step 150: SQL should be: UPDATE issues SET date_due = NOW() - interval 2 day WHERE issue_id = X; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126459|0 |1 is obsolete| | Attachment #126470|0 |1 is obsolete| | --- Comment #758 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 126565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126565&action=edit Bug 19532: (follow-up) Fix calls, tests, syspref settings, checks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #759 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to David Nind from comment #757)
Hi Aleisha, I finally finished running through the test plan!
Two items where I had issues:
Thanks David, I've attached a commit that hopefully fixes these! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126244|0 |1 is obsolete| | --- Comment #760 from David Nind <david@davidnind.com> --- Created attachment 126566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126566&action=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126245|0 |1 is obsolete| | --- Comment #761 from David Nind <david@davidnind.com> --- Created attachment 126568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126568&action=edit Bug 19532: Updated schema files Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126246|0 |1 is obsolete| | --- Comment #762 from David Nind <david@davidnind.com> --- Created attachment 126569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126569&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126247|0 |1 is obsolete| | --- Comment #763 from David Nind <david@davidnind.com> --- Created attachment 126570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126570&action=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126248|0 |1 is obsolete| | --- Comment #764 from David Nind <david@davidnind.com> --- Created attachment 126571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126571&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126249|0 |1 is obsolete| | --- Comment #765 from David Nind <david@davidnind.com> --- Created attachment 126572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126572&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126250|0 |1 is obsolete| | --- Comment #766 from David Nind <david@davidnind.com> --- Created attachment 126573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126573&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126453|0 |1 is obsolete| | --- Comment #767 from David Nind <david@davidnind.com> --- Created attachment 126574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126574&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls == TEST PLAN FOR RECALLS == ADMINISTRATION 1. Apply all patches 2. Run database updates, update schema files and confirm everything applies cleanly 3. Run tests and confirm everything passes: t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t t/db_dependent/Stats.t t/db_dependent/Circulation/CalcFine.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Patron.t t/db_dependent/XSLT.t t/db_dependent/Search.t t/db_dependent/Holds.t t/db_dependent/Circulation/transferbook.t t/db_dependent/Circulation.t 4. Go to Administration -> system preferences. Find the UseRecalls system preference. It should be DISABLED. Confirm RecallsMaxPickUpDelay is set to 7 by default. 5. Go to Administration -> circulation rules. Confirm there are no recalls circulation rules showing. 6. Test a few circulation flows: checking out, placing a reserve, checking in, fulfilling a reserve, etc. Confirm everything works as normal. 7. Go to Administration -> system preferences. Enable the UseRecalls system preference. 8. Go to Administration -> circulation rules. Set the following rules: Recalls allowed (count) = 0 Recalls per record (count) = 0 On shelf recalls allowed ( If any unavailable / If all unavailable ) = If any unavailable Recall due date interval (days) = 3 Recall overdue fine amount = (something different to your normal fine amount) Recall pickup period (days) = 1 Throughout your testing, try with different combinations of these rules and itemtype / branchcode / categorycode. Also try with null values. Keep the circulation rules open in another tab so you can refer to and update these easily. You should also have at least one other tab open for the staff client, and a third tab open for the OPAC, for ease of testing. 9. Go to your account -> More -> Set permissions. Confirm the recalls permission is checked. 10. Set up a test user with OPAC login details (Borrower A). This could also be your own user, as long as you have OPAC login access. 11. Set up a test record (Biblio A) with at least two items (Item A and Item B) of the same item type (or an item type with the same recall circ rules). PLACING A RECALL 12. Log in to the OPAC as Borrower A. Do a catalogue search with a term that will return multiple results, including Biblio A. 13. Click on Biblio A. 14. Notice there is a 'Place recall' button on the sidebar menu. Click this button. There will be a message saying that there are no items to recall - this is because all items are available. 15. Check out Item A to another borrower (Borrower B). 16. Refresh the 'Place recall' page. You will still NOT be able to place a recall - this is because Recalls allowed = 0 and Recalls per record = 0. 17. Edit the circulation rules to have the following values: Recalls allowed (count) = 1 Recalls per record (count) = 1 18. Refresh the 'Place recall' page. You will now see the form to place a recall. BIBLIO-LEVEL RECALL, NO TRANSFER 19. Place a biblio-level recall. Pickup location: Branch A, the set branch when you are logged into the staff client Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 20. Confirm the recall is placed successfully. Confirm that the new due date displayed is correctly calculated to be today's date, plus 3 days (taken from the 'recall due date interval' circ rule) 21. In the staff client, look at Borrower B's account, and go to their Notices tab. Confirm they have received a 'Notification to return recalled item' notice. 22. Look at Borrower B's checkouts table. Notice the due date for their checkout has been adjusted, and there is now a note to say that the item was recalled and the due date adjusted. 23. Log in to the OPAC as Borrower B and go to your summary tab. Notice there is a note under their checkout to say the item had been recalled. 24. Log out of the OPAC and log back in as Borrower A. 25. Go to your summary tab. Confirm there is a Recalls tab with a count of 1. 26. Cancel the recall using the button. Confirm it cancels and the Recalls tab disappears. 27. Do a catalogue search with a term that will return multiple results, including Biblio A. 28. When the results load, notice there is a 'Place recall' button next to the 'Place hold' button. Click this 'Place recall' button. 29. Notice you are redirected straight to the form to place a recall. 30. Place a biblio-level recall again, following the steps in Step 19. 31. Go to your recalls history tab. Notice your first cancelled recall shows here. 32. Cancel the recall you just created, using the button. Confirm it cancels and you are redirected to your summary tab. 33. In the staff client, enable the UseCourseReserves system preference. 34. Go to the main menu, click Course Reserves. 35. Add a new course. (You may also have to define an authorised value for DEPARTMENT.) 36. Add Item A as a reserve to this course. 37. View Course Reserves in the OPAC. Click the course you just created. 38. Notice the reserve has a Recall button underneath it's 'Checked out' status. Click this button. 39. Place a biblio-level recall again, following the steps in Step 19. 40. Click the 'Place recall' link in the breadcrumbs. 41. Notice there is a message saying that you have reached the max number of recalls on this record. This is because Recalls allowed = 1 and Recalls per record = 1. 42. Edit the circulation rules to have the following values: Recalls allowed (count) = 10 Recalls per record (count) = 5 43. Refresh the 'Place recall' page. You will now see the form to place a recall. 44. Create another test record (Biblio B) with at least one item (Item C). 45. Find this record on the OPAC and place a biblio-level recall again, following the steps in Step 19. 46. In the staff client, go to Circulation -> Old recalls. You should be able to see your two cancelled recalls. 47. Go to Circulation -> Recalls queue. Your current recalls should show here. 48. Use the 'Select all' checkbox to select all recalls. 49. Cancel the recalls using the 'Cancel selected recalls' button. 50. Go to the OPAC and place a biblio-level recall on Biblio A again, following the steps in Step 19. 51. In the staff client, check in Item A, which should still be checked out to Borrower B. 52. A box should pop-up asking you to confirm Borrower A's recall. Click ignore. 53. Click the link to go view Biblio A's details in the catalogue. 54. Click the recalls tab. Notice Borrower A's recall is displayed, and shows it is still Requested (has not been confirmed waiting). 55. Check in Item A again. This time, confirm the recall as waiting using the "Confirm recall" button. 56. Go to Borrower A's Notices tab. Confirm there is a notice "Recalled item awaiting pickup". 57. Go to Borrower A's checkouts. Notice there is a recalls tab. Confirm the recall is showing as "Ready for pickup". 58. Click the 'Actions' dropdown. Click the "Revert waiting" button. The page should show a message that the waiting status has been reverted, without reloading. 59. This time, check in Item B. The recall confirmation box should show again, because this a biblio-level recall that any recallable item under Biblio A can fill. Click the "Print slip and confirm" button. 60. Check the slip that is generated. Confirm it contains Borrower A's correct details, and the details of the recall are correct. 61. Go to Circulation -> Recalls awaiting pickup. Confirm the recall is now waiting and shows in this list. (You could also try this with Item B having a different item type to Item A, and circ rules not allowing Item B's item type to have recalls. When checking in Item A, it should not trigger the recall box). 62. Go to Borrower A's checkouts. Check out Item B. 63. Confirm the checkout is successful and the recall is removed from the Recalls tab. 64. Go to Circulation -> Old recalls. The fulfilled recall should show. 65. Check in Item B. BIBLIO-LEVEL RECALL, TRANSFER REQUIRED 66. Check out Item A to Borrower B. 67. Log in to the OPAC as Borrower A. 68. Find Biblio A and place a biblio-level recall. Pickup location: Branch B, a different branch from your logged in branch. This recall will require a transfer. Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 69. In the staff client, check in Item A at Branch A. Notice the box that pops up shows that a transfer is required. 70. Click "confirm recall and transfer" and confirm the transfer. 71. Go to your account and click the Recalls tab. 72. Confirm the recall status now shows the item is in transit to Branch B. 73. In the drop-down top-right of your window, select 'Set library'. 74. Set your library to Branch B. 75. Go to Circulation -> Transfers to receive. Notice that the recall is showing here. 76. Click 'Cancel transfer'. 77. Go to Circulation -> Recalls queue 78. Confirm the recall status has been reverted to Requested. 79. Set your library back to Branch A. 80. Check in Item A and trigger the transfer. 81. Set your library back to Branch B. 82. Check in Item A at Branch B. 83. When the 'Recall found' box pops up, click Ignore. 84. Go to Circulation -> Recalls to pull. The recall should show here, with a button to "Cancel recall and return to: Branch A" 85. Click the button to cancel the recall. 86. Repeat Steps 66-70. 87. Check in Item A at Branch B. Confirm the recall as waiting. 88. Check out Item A to Borrower A to fulfill the recall. 89. Set your library back to Branch A and check in Item A. ITEM-LEVEL RECALL, NO TRANSFER 90. Go to Administration -> circulation rules. Set the following rules: On shelf recalls allowed ( If any unavailable / If all unavailable ) = If all unavailable 91. Check out Item A to Borrower B. 92. Log in to the OPAC as Borrower A and go to Biblio A. 93. Click the 'Place recall' button. Confirm there is a message that there are no items to recall. This is because On shelf recalls allowed = If all unavailable, and there is still one item (Item B) available. 94. In the staff client, edit Item B to have a withdrawn, item lost or not for loan status. 95. Refresh the 'Place recall' page. Confirm you can now see the form to place a recall. 96. Place an item-level recall. Pickup location: Branch A. Recall not needed after (expiration date): whatever you want Select 'recall a specific item' Item B will not be selectable, and Item A should be selected by default. Click confirm 97. In the staff client, edit Item B and remove the lost or missing status. 98. Check in Item B. Confirm the recall box does not pop up, because it cannot fill the item-level recall. 99. Check in Item A. Confirm the recall as waiting. 100. Go to Circulation -> Recalls awaiting pickup 101. Expire the recall. Confirm it expires as expected. ITEM-LEVEL RECALL, TRANSFER REQUIRED 102. Repeat steps 91 to 95. 103. Place an item-level recall. Pickup location: Branch B, we will require a transfer. Recall not needed after (expiration date): whatever you want Select 'recall a specific item' Item B will not be selectable, and Item A should be selected by default. Click confirm 104. In the staff client, check in Item A. Confirm the recall and trigger the transfer. 105. Set your library to Branch B and check in Item A. 106. Confirm the recall as waiting. 107. Check out Item A to Borrower A and fulfill the recall. 108. Set your library back to Branch A and check in Item A. CRONJOBS: EXPIRING RECALL 109. Check out Item A to Borrower B. 110. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 111. In your terminal, enter mysql and edit the expiration date of your recall to be before today UPDATE recalls SET expirationdate = NOW()-2 WHERE recall_id = X; 112. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 113. Go to Borrower A's account and go to the Recalls history tab 114. Confirm the recall has been expired because the current date surpassed the specified expiration date 115. Check out Item A to Borrower B. 116. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 117. In the staff client, check in Item A and confirm the recall as waiting. 118. In your terminal, enter mysql and edit the waiting date of your recall to be before today UPDATE recalls SET waitingdate = NOW() - interval 5 day WHERE recall_id = X; 119. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 120. Go to Borrower A's account and go to the Recalls history tab 121. Confirm the recall has been expired because the recall had been waiting for more days than the Recall pickup period 122. Go to Administration -> circulation rules. Set the following rules: Recall pickup period (days) = 0 123. Set the RecallsMaxPickUpDelay system preference = 1. 124. Check out Item A to Borrower B. 125. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 126. In the staff client, check in Item A and confirm the recall as waiting. 127. In your terminal, enter mysql and edit the waiting date of your recall to be before today UPDATE recalls SET waitingdate = NOW()-2 WHERE recall_id = X; 128. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 129. Go to Borrower A's account and go to the Recalls history tab 130. Confirm the recall has been expired because the recall had been waiting for more days than the RecallsMaxPickUpDelay syspref CRONJOBS: OVERDUE RECALL 131. Check out Item A to Borrower B 132. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 133. In your terminal, enter mysql and edit the due date of the checkout to Borrower B to be before today UPDATE issues SET date_due = NOW()-2 WHERE issue_id = X; 134. Run the overdue cronjob from within your shell perl misc/cronjobs/recall/overdue_recalls.pl 135. Go to Circulation -> Overdue recalls 136. Confirm your recall is showing here now as the recall has been marked Overdue CIRCULATION 137. Check in Item A. 138. When the recall box pops up, click Ignore. 139. Check out Item A to Borrower B. You should see a yellow confirmation box, saying that another borrower has recalled the item you are trying to check out. 140. Click "No don't check out" and confirm the item isn't checked out and the recall remains. 141. Repeat Step 139. 142. Click "Yes check out" and confirm the item is checked out and the recall remains. 143. When Borrower B's checkout table loads, confirm that you cannot renew or check in the item from the Checkouts table because there is a 'Recalled' link which takes you to the recalls tab for that biblio. 144. Repeat Steps 137-139. 145. Select "Cancel recall" and click "Yes check out" and confirm the item is checked out and the recall has been cancelled. 146. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 147. Check in Item A. Confirm the recall as waiting. 148. Check out Item A to Borrower B. You should see a yellow confirmation box, saying that that another borrower has recalled the item that you are trying to check out. 149. Select "Revert waiting status" and click "Yes check out" and confirm the item is checked out and the recall status has reverted to requested. OTHER 150. In your terminal, enter mysql and edit the due date of the checkout to Borrower B to be before today UPDATE issues SET date_due = NOW()-2 WHERE issue_id = X; 151. Go to Borrower A's recalls and click the Actions dropdown. 152. Click "Mark as overdue" and confirm the recall is marked as overdue manually. 153. Go to Tools -> Log Viewer. Check only the Recalls module, and leave all other parameters, and click Submit. 154. Confirm all of the recalls actions that have been made are correctly logged. Note: recalls messaging preferences are introduced in Bug 23781. The recall feature is fully documented at: https://wiki.koha-community.org/wiki/Catalyst_IT_Recalls Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126454|0 |1 is obsolete| | --- Comment #768 from David Nind <david@davidnind.com> --- Created attachment 126575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126575&action=edit Bug 19532: (follow-up) aria-hidden attr on OPAC, and more - removing authnotrequired flag from scripts - fixing opac buttons - chmod +x for recalls test files Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126455|0 |1 is obsolete| | --- Comment #769 from David Nind <david@davidnind.com> --- Created attachment 126576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126576&action=edit Bug 19532: (follow-up) Fixing failing CalcFine.t test Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126456|0 |1 is obsolete| | --- Comment #770 from David Nind <david@davidnind.com> --- Created attachment 126577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126577&action=edit Bug 19532: (follow-up) Fixing OPAC display and staff client errors - fixes the displays of opac-recalls.pl and opac-recall.pl - fix the error on Recalls to pull page - fix JS error preventing Recalled link from showing in checkouts table - fix cancelling of recall when checking out item Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126457|0 |1 is obsolete| | --- Comment #771 from David Nind <david@davidnind.com> --- Created attachment 126578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126578&action=edit Bug 19532: (follow-up) Fix undef recall_id preventing fulfillment of recall Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126458|0 |1 is obsolete| | --- Comment #772 from David Nind <david@davidnind.com> --- Created attachment 126579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126579&action=edit Bug 19532: (follow-up) Fixing tests and QA tools And making reverted ajax message clearer Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126565|0 |1 is obsolete| | --- Comment #773 from David Nind <david@davidnind.com> --- Created attachment 126580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126580&action=edit Bug 19532: (follow-up) Fix calls, tests, syspref settings, checks Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #774 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- The many-to-many relationship 'ordernumbers' is trying to create a utility method called set_ordernumbers. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. FAIL C4/InstallAuth.pm FAIL pod *** WARNING: line containing nothing but whitespace in paragraph in file C4/InstallAuth.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #775 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Having (serious) doubts if we should add these methods to the plural object: + my ( $recall, $due_interval, $due_date ) = Koha::Recalls->add_recall({ + patron => $patron_object, + biblio => $biblio_object, + branchcode => $branchcode, + item => $item_object, + expirationdate => $expirationdate, + interface => 'OPAC', + }); +=head3 move_recall + + my $message = Koha::Recalls->move_recall({ + recall_id = $recall_id, + action => $action, + itemnumber => $itemnumber, + borrowernumber => $borrowernumber, + }); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #776 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Koha/Recall.pm | 476 ++++++++++++++++++++++++++++++++++ Koha/Recalls.pm | 212 +++++++++++++++ Koha/Schema/Result/Recall.pm | 38 +++ Dont put Schema files in a regular patch please! Forbidden! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #777 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- XSLT module + if ( $recalls->count ) { + # recalls take priority over holds + $status = 'Waiting'; + } Hmm. Are we lifting here on a hold status and report things like that in the opac results ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #778 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- FAIL Koha/Recall.pm FAIL valid Bareword "dt_from_string" not allowed while "strict subs" in use Bareword "dt_from_string" not allowed while "strict subs" in use Koha/Recall.pm had compilation errors. FAIL Koha/Recalls.pm FAIL valid Bareword "dt_from_string" not allowed while "strict subs" in use Bareword "dt_from_string" not allowed while "strict subs" in use Compilation failed in require FAIL t/db_dependent/Koha/Recall.t FAIL file permissions File must have the exec flag FAIL valid Bareword "dt_from_string" not allowed while "strict subs" in use Bareword "dt_from_string" not allowed while "strict subs" in use Bareword "dt_from_string" not allowed while "strict subs" in use Bareword "dt_from_string" not allowed while "strict subs" in use t/db_dependent/Koha/Recall.t had compilation errors. FAIL t/db_dependent/Koha/Recalls.t FAIL file permissions File must have the exec flag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #779 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- FAIL C4/Overdues.pm FAIL valid Bareword "dt_from_string" not allowed while "strict subs" in use Bareword "dt_from_string" not allowed while "strict subs" in use FAIL misc/cronjobs/recalls/expire_recalls.pl FAIL valid Bareword "dt_from_string" not allowed while "strict subs" in use Bareword "dt_from_string" not allowed while "strict subs" in use Compilation failed in require Compilation failed in require BEGIN failed--compilation aborted FAIL misc/cronjobs/recalls/overdue_recalls.pl FAIL valid Bareword "dt_from_string" not allowed while "strict subs" in use Bareword "dt_from_string" not allowed while "strict subs" in use FAIL t/db_dependent/Circulation/CalcFine.t FAIL valid Bareword "dt_from_string" not allowed while "strict subs" in use Bareword "dt_from_string" not allowed while "strict subs" in use -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #780 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc FAIL forbidden patterns forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 15) FAIL valid_template Attempt to reload Koha/Template/Plugin/Biblio.pm aborted. Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl5/5.28/Template/Plugins.pm line 206. FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt OK filters FAIL forbidden patterns forbidden pattern: Don't use the title-string class for sorting (bug 27934) (line 33) FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt OK filters FAIL forbidden patterns forbidden pattern: Don't use the title-string class for sorting (bug 27934) (line 777) FAIL opac/opac-recall.pl FAIL critic Subroutine "new" called using indirect syntax at line 26, column 13. See page 349 of PBP. FAIL forbidden patterns forbidden pattern: Script permissions is authnotrequired => 0, it could be correct for an OPAC script if it is was you really want error (bug 24663) (line 32) FAIL valid Bareword "dt_from_string" not allowed while "strict subs" in use Bareword "dt_from_string" not allowed while "strict subs" in use -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #781 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I planned to run qa tools on every patch. But I would recommend that you would have done the same. It is just too much.. So just pasting the last few, and leaving it there. FAIL svc/recall FAIL critic Subroutine "new" called using indirect syntax at line 30, column 13. See page 349 of PBP. OK file permissions OK forbidden patterns OK git manipulation OK pod SKIP spelling FAIL valid Bareword "dt_from_string" not allowed while "strict subs" in use Bareword "dt_from_string" not allowed while "strict subs" in use FAIL recalls/request.pl OK critic OK file permissions FAIL forbidden patterns forbidden pattern: Script permissions is authnotrequired => 0, it could be correct for an OPAC script if it is was you really want error (bug 24663) (line 33) OK git manipulation OK pod SKIP spelling FAIL valid Bareword "dt_from_string" not allowed while "strict subs" in use Bareword "dt_from_string" not allowed while "strict subs" in use FAIL recalls/recalls_waiting.pl FAIL critic Subroutine "new" called using indirect syntax at line 28, column 13. See page 349 of PBP. OK file permissions FAIL forbidden patterns forbidden pattern: Script permissions is authnotrequired => 0, it could be correct for an OPAC script if it is was you really want error (bug 24663) (line 34) OK git manipulation OK pod SKIP spelling FAIL valid Bareword "dt_from_string" not allowed while "strict subs" in use Bareword "dt_from_string" not allowed while "strict subs" in use -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #782 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- + $.ajax({ + url: '/cgi-bin/koha/svc/recall', + type: 'POST', + dataType: 'json', + data: ajaxData, + }) This is the old way of things. (Ok, historical patches.) No API ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #783 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- All appreciation for your hard work and perseverance. This feature will be welcomed by many libraries. So it is great that you share it. I am just stumbling over its size. It might be a reason why this patch set takes so long too. Just picking the largest patches: 7 files changed, 1093 insertions(+), 1 deletion(-) 16 files changed, 1153 insertions(+), 12 deletions(-) 15 files changed, 665 insertions(+), 4 deletions(-) 44 files changed, 2090 insertions(+), 12 deletions(-) We're adding over 5000 lines here on one report. Clearly, this report should have broken down in several reports under an omnibus (imho). Certainly, making a good split is (much) more work for you. But how much time did you spend on rebasing the whole thing over and over again? How should we do a good QA job when adding so much code. I did a "diagonal" QA now. Few comments, asked a few questions now. Most looks good to me. But I cant do a full QA in some hours on such large patches. My intuition tells me that there will be quite a few bugs coming in now. And at a bad time, since we are close to release date.. Note that I am not asking you to split it up now. But perhaps we should define some guidelines on handling this kind of larger developments, making it easier to push well split portions and allowing still 'unused' code to go in already when there is a community commitment to finish the job? Since we need more people to test this code, I am putting the status back to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #784 from Aleisha Amohia <aleisha@catalyst.net.nz> --- I understand where you're coming from, I know the size is massive, but honestly it's a bit frustrating to pick that apart now. If you look back, I first attached a much simpler iteration of recalls, but everyone scope creeped it while the clients we developed it for were happily using it and sponsoring further enhancements. This would have been avoided if it had been accepted in it's simpler state by the community, when it was a lot easier to QA. It's obviously since grown to become a fully fledged feature. I can't reasonably keep maintaining it for our clients for years while upstream requires me to rebase it every few weeks and it still won't get pushed to main. At this point I would prefer if the QA team just gave me guidance on what I need to do to get this in to upstream Koha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #785 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Aleisha Amohia from comment #784)
I understand where you're coming from, I know the size is massive, but honestly it's a bit frustrating to pick that apart now.
Agreed, and thats certainly not what I was saying.
I can't reasonably keep maintaining it for our clients for years while upstream requires me to rebase it every few weeks and it still won't get pushed to main.
Very clear. What you did already, is amazing. You cant go on like this.
At this point I would prefer if the QA team just gave me guidance on what I need to do to get this in to upstream Koha.
We do need some coordination to get a patch of this size in. Note also that as e.g. comment358 shows the fundamentals of this design were questioned by Martin and maybe others. I understand that this remark was too late in the process. But this implies convincing (part of) the QA team also. If we do, it seems already too late to push this into 21.11. So it should be done early after that release (imho). I am putting this on the development meeting agenda for Oct 27 14 UTC (bad for NZL). Will also ask the QA manager for coordination. Cant do much more as single QAer ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #786 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Marcel de Rooy from comment #781)
I planned to run qa tools on every patch. But I would recommend that you would have done the same. It is just too much..
wouldn't this raise errors fixed in followup? You mean for each commit, checkout on it, run the qa tool on last commit, right? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #787 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Victor Grousset/tuxayo from comment #786)
(In reply to Marcel de Rooy from comment #781)
I planned to run qa tools on every patch. But I would recommend that you would have done the same. It is just too much..
wouldn't this raise errors fixed in followup? You mean for each commit, checkout on it, run the qa tool on last commit, right?
Surely. Whats fixed, is fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #788 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Hi all How did the meeting go and what was decided for this bug? Thanks Aleisha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #789 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Aleisha Amohia from comment #788)
How did the meeting go and what was decided for this bug?
Here a few important remarks from IRC: 14:37 Joubu it's too late for 21.11 and we have plenty of things to focus on 14:37 cait1 it doesn't quite work as academics expect it 14:41 cait1 so maybe we could agree on making this a priority after release? 14:42 cait1 #agreed marcelr, fridolin and cait to look at recalls for QA after 21.11 release 14:44 cait1 i think they are moderated [recalls] 14:44 cait1 what we are looking for later might be unmoderated 14:45 ashimema either way.. lets attack it as a group at the beginning of the next cycle. So we had consensus about proceeding on recalls in its current form in view of time elapsed shortly after release. I have a recalls branch now too, might be fixing a few things too already. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #790 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The moderated/unmoderated got a bit confusing (my fault), but the summary about us teaming up on this once 21.11 is out the door is correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #791 from Aleisha Amohia <aleisha@catalyst.net.nz> --- I've developed this further for a university library so I have patches that would possibly help it to work more in the way that academic libraries might expect? I'll contact you all about progressing with this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #792 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Aleisha Amohia from comment #791)
I've developed this further for a university library so I have patches that would possibly help it to work more in the way that academic libraries might expect?
I'll contact you all about progressing with this.
Hi Aleisha, I volunteered to work on this at the beginning of this cycle, but have to admit, I still have to start digging into it. Any additional information is very welcome :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734 [Bug 29734] [OMNIBUS] Recalls for Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Laura Horgan <horganl@middlesex.mass.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|horganl@middlesex.mass.edu | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126566|0 |1 is obsolete| | --- Comment #793 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 129305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129305&action=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126568|0 |1 is obsolete| | --- Comment #794 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 129306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129306&action=edit Bug 19532: Updated schema files Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126569|0 |1 is obsolete| | --- Comment #795 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 129307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129307&action=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126570|0 |1 is obsolete| | --- Comment #796 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 129308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129308&action=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126571|0 |1 is obsolete| | --- Comment #797 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 129309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129309&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126572|0 |1 is obsolete| | --- Comment #798 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 129310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129310&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126573|0 |1 is obsolete| | --- Comment #799 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 129311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129311&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126574|0 |1 is obsolete| | --- Comment #800 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 129312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129312&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls == TEST PLAN FOR RECALLS == ADMINISTRATION 1. Apply all patches 2. Run database updates, update schema files and confirm everything applies cleanly 3. Run tests and confirm everything passes: t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t t/db_dependent/Stats.t t/db_dependent/Circulation/CalcFine.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Patron.t t/db_dependent/XSLT.t t/db_dependent/Search.t t/db_dependent/Holds.t t/db_dependent/Circulation/transferbook.t t/db_dependent/Circulation.t 4. Go to Administration -> system preferences. Find the UseRecalls system preference. It should be DISABLED. Confirm RecallsMaxPickUpDelay is set to 7 by default. 5. Go to Administration -> circulation rules. Confirm there are no recalls circulation rules showing. 6. Test a few circulation flows: checking out, placing a reserve, checking in, fulfilling a reserve, etc. Confirm everything works as normal. 7. Go to Administration -> system preferences. Enable the UseRecalls system preference. 8. Go to Administration -> circulation rules. Set the following rules: Recalls allowed (count) = 0 Recalls per record (count) = 0 On shelf recalls allowed ( If any unavailable / If all unavailable ) = If any unavailable Recall due date interval (days) = 3 Recall overdue fine amount = (something different to your normal fine amount) Recall pickup period (days) = 1 Throughout your testing, try with different combinations of these rules and itemtype / branchcode / categorycode. Also try with null values. Keep the circulation rules open in another tab so you can refer to and update these easily. You should also have at least one other tab open for the staff client, and a third tab open for the OPAC, for ease of testing. 9. Go to your account -> More -> Set permissions. Confirm the recalls permission is checked. 10. Set up a test user with OPAC login details (Borrower A). This could also be your own user, as long as you have OPAC login access. 11. Set up a test record (Biblio A) with at least two items (Item A and Item B) of the same item type (or an item type with the same recall circ rules). PLACING A RECALL 12. Log in to the OPAC as Borrower A. Do a catalogue search with a term that will return multiple results, including Biblio A. 13. Click on Biblio A. 14. Notice there is a 'Place recall' button on the sidebar menu. Click this button. There will be a message saying that there are no items to recall - this is because all items are available. 15. Check out Item A to another borrower (Borrower B). 16. Refresh the 'Place recall' page. You will still NOT be able to place a recall - this is because Recalls allowed = 0 and Recalls per record = 0. 17. Edit the circulation rules to have the following values: Recalls allowed (count) = 1 Recalls per record (count) = 1 18. Refresh the 'Place recall' page. You will now see the form to place a recall. BIBLIO-LEVEL RECALL, NO TRANSFER 19. Place a biblio-level recall. Pickup location: Branch A, the set branch when you are logged into the staff client Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 20. Confirm the recall is placed successfully. Confirm that the new due date displayed is correctly calculated to be today's date, plus 3 days (taken from the 'recall due date interval' circ rule) 21. In the staff client, look at Borrower B's account, and go to their Notices tab. Confirm they have received a 'Notification to return recalled item' notice. 22. Look at Borrower B's checkouts table. Notice the due date for their checkout has been adjusted, and there is now a note to say that the item was recalled and the due date adjusted. 23. Log in to the OPAC as Borrower B and go to your summary tab. Notice there is a note under their checkout to say the item had been recalled. 24. Log out of the OPAC and log back in as Borrower A. 25. Go to your summary tab. Confirm there is a Recalls tab with a count of 1. 26. Cancel the recall using the button. Confirm it cancels and the Recalls tab disappears. 27. Do a catalogue search with a term that will return multiple results, including Biblio A. 28. When the results load, notice there is a 'Place recall' button next to the 'Place hold' button. Click this 'Place recall' button. 29. Notice you are redirected straight to the form to place a recall. 30. Place a biblio-level recall again, following the steps in Step 19. 31. Go to your recalls history tab. Notice your first cancelled recall shows here. 32. Cancel the recall you just created, using the button. Confirm it cancels and you are redirected to your summary tab. 33. In the staff client, enable the UseCourseReserves system preference. 34. Go to the main menu, click Course Reserves. 35. Add a new course. (You may also have to define an authorised value for DEPARTMENT.) 36. Add Item A as a reserve to this course. 37. View Course Reserves in the OPAC. Click the course you just created. 38. Notice the reserve has a Recall button underneath it's 'Checked out' status. Click this button. 39. Place a biblio-level recall again, following the steps in Step 19. 40. Click the 'Place recall' link in the breadcrumbs. 41. Notice there is a message saying that you have reached the max number of recalls on this record. This is because Recalls allowed = 1 and Recalls per record = 1. 42. Edit the circulation rules to have the following values: Recalls allowed (count) = 10 Recalls per record (count) = 5 43. Refresh the 'Place recall' page. You will now see the form to place a recall. 44. Create another test record (Biblio B) with at least one item (Item C). 45. Find this record on the OPAC and place a biblio-level recall again, following the steps in Step 19. 46. In the staff client, go to Circulation -> Old recalls. You should be able to see your two cancelled recalls. 47. Go to Circulation -> Recalls queue. Your current recalls should show here. 48. Use the 'Select all' checkbox to select all recalls. 49. Cancel the recalls using the 'Cancel selected recalls' button. 50. Go to the OPAC and place a biblio-level recall on Biblio A again, following the steps in Step 19. 51. In the staff client, check in Item A, which should still be checked out to Borrower B. 52. A box should pop-up asking you to confirm Borrower A's recall. Click ignore. 53. Click the link to go view Biblio A's details in the catalogue. 54. Click the recalls tab. Notice Borrower A's recall is displayed, and shows it is still Requested (has not been confirmed waiting). 55. Check in Item A again. This time, confirm the recall as waiting using the "Confirm recall" button. 56. Go to Borrower A's Notices tab. Confirm there is a notice "Recalled item awaiting pickup". 57. Go to Borrower A's checkouts. Notice there is a recalls tab. Confirm the recall is showing as "Ready for pickup". 58. Click the 'Actions' dropdown. Click the "Revert waiting" button. The page should show a message that the waiting status has been reverted, without reloading. 59. This time, check in Item B. The recall confirmation box should show again, because this a biblio-level recall that any recallable item under Biblio A can fill. Click the "Print slip and confirm" button. 60. Check the slip that is generated. Confirm it contains Borrower A's correct details, and the details of the recall are correct. 61. Go to Circulation -> Recalls awaiting pickup. Confirm the recall is now waiting and shows in this list. (You could also try this with Item B having a different item type to Item A, and circ rules not allowing Item B's item type to have recalls. When checking in Item A, it should not trigger the recall box). 62. Go to Borrower A's checkouts. Check out Item B. 63. Confirm the checkout is successful and the recall is removed from the Recalls tab. 64. Go to Circulation -> Old recalls. The fulfilled recall should show. 65. Check in Item B. BIBLIO-LEVEL RECALL, TRANSFER REQUIRED 66. Check out Item A to Borrower B. 67. Log in to the OPAC as Borrower A. 68. Find Biblio A and place a biblio-level recall. Pickup location: Branch B, a different branch from your logged in branch. This recall will require a transfer. Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 69. In the staff client, check in Item A at Branch A. Notice the box that pops up shows that a transfer is required. 70. Click "confirm recall and transfer" and confirm the transfer. 71. Go to your account and click the Recalls tab. 72. Confirm the recall status now shows the item is in transit to Branch B. 73. In the drop-down top-right of your window, select 'Set library'. 74. Set your library to Branch B. 75. Go to Circulation -> Transfers to receive. Notice that the recall is showing here. 76. Click 'Cancel transfer'. 77. Go to Circulation -> Recalls queue 78. Confirm the recall status has been reverted to Requested. 79. Set your library back to Branch A. 80. Check in Item A and trigger the transfer. 81. Set your library back to Branch B. 82. Check in Item A at Branch B. 83. When the 'Recall found' box pops up, click Ignore. 84. Go to Circulation -> Recalls to pull. The recall should show here, with a button to "Cancel recall and return to: Branch A" 85. Click the button to cancel the recall. 86. Repeat Steps 66-70. 87. Check in Item A at Branch B. Confirm the recall as waiting. 88. Check out Item A to Borrower A to fulfill the recall. 89. Set your library back to Branch A and check in Item A. ITEM-LEVEL RECALL, NO TRANSFER 90. Go to Administration -> circulation rules. Set the following rules: On shelf recalls allowed ( If any unavailable / If all unavailable ) = If all unavailable 91. Check out Item A to Borrower B. 92. Log in to the OPAC as Borrower A and go to Biblio A. 93. Click the 'Place recall' button. Confirm there is a message that there are no items to recall. This is because On shelf recalls allowed = If all unavailable, and there is still one item (Item B) available. 94. In the staff client, edit Item B to have a withdrawn, item lost or not for loan status. 95. Refresh the 'Place recall' page. Confirm you can now see the form to place a recall. 96. Place an item-level recall. Pickup location: Branch A. Recall not needed after (expiration date): whatever you want Select 'recall a specific item' Item B will not be selectable, and Item A should be selected by default. Click confirm 97. In the staff client, edit Item B and remove the lost or missing status. 98. Check in Item B. Confirm the recall box does not pop up, because it cannot fill the item-level recall. 99. Check in Item A. Confirm the recall as waiting. 100. Go to Circulation -> Recalls awaiting pickup 101. Expire the recall. Confirm it expires as expected. ITEM-LEVEL RECALL, TRANSFER REQUIRED 102. Repeat steps 91 to 95. 103. Place an item-level recall. Pickup location: Branch B, we will require a transfer. Recall not needed after (expiration date): whatever you want Select 'recall a specific item' Item B will not be selectable, and Item A should be selected by default. Click confirm 104. In the staff client, check in Item A. Confirm the recall and trigger the transfer. 105. Set your library to Branch B and check in Item A. 106. Confirm the recall as waiting. 107. Check out Item A to Borrower A and fulfill the recall. 108. Set your library back to Branch A and check in Item A. CRONJOBS: EXPIRING RECALL 109. Check out Item A to Borrower B. 110. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 111. In your terminal, enter mysql and edit the expiration date of your recall to be before today UPDATE recalls SET expirationdate = NOW()-2 WHERE recall_id = X; 112. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 113. Go to Borrower A's account and go to the Recalls history tab 114. Confirm the recall has been expired because the current date surpassed the specified expiration date 115. Check out Item A to Borrower B. 116. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 117. In the staff client, check in Item A and confirm the recall as waiting. 118. In your terminal, enter mysql and edit the waiting date of your recall to be before today UPDATE recalls SET waitingdate = NOW() - interval 5 day WHERE recall_id = X; 119. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 120. Go to Borrower A's account and go to the Recalls history tab 121. Confirm the recall has been expired because the recall had been waiting for more days than the Recall pickup period 122. Go to Administration -> circulation rules. Set the following rules: Recall pickup period (days) = 0 123. Set the RecallsMaxPickUpDelay system preference = 1. 124. Check out Item A to Borrower B. 125. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 126. In the staff client, check in Item A and confirm the recall as waiting. 127. In your terminal, enter mysql and edit the waiting date of your recall to be before today UPDATE recalls SET waitingdate = NOW()-2 WHERE recall_id = X; 128. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 129. Go to Borrower A's account and go to the Recalls history tab 130. Confirm the recall has been expired because the recall had been waiting for more days than the RecallsMaxPickUpDelay syspref CRONJOBS: OVERDUE RECALL 131. Check out Item A to Borrower B 132. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 133. In your terminal, enter mysql and edit the due date of the checkout to Borrower B to be before today UPDATE issues SET date_due = NOW()-2 WHERE issue_id = X; 134. Run the overdue cronjob from within your shell perl misc/cronjobs/recall/overdue_recalls.pl 135. Go to Circulation -> Overdue recalls 136. Confirm your recall is showing here now as the recall has been marked Overdue CIRCULATION 137. Check in Item A. 138. When the recall box pops up, click Ignore. 139. Check out Item A to Borrower B. You should see a yellow confirmation box, saying that another borrower has recalled the item you are trying to check out. 140. Click "No don't check out" and confirm the item isn't checked out and the recall remains. 141. Repeat Step 139. 142. Click "Yes check out" and confirm the item is checked out and the recall remains. 143. When Borrower B's checkout table loads, confirm that you cannot renew or check in the item from the Checkouts table because there is a 'Recalled' link which takes you to the recalls tab for that biblio. 144. Repeat Steps 137-139. 145. Select "Cancel recall" and click "Yes check out" and confirm the item is checked out and the recall has been cancelled. 146. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 147. Check in Item A. Confirm the recall as waiting. 148. Check out Item A to Borrower B. You should see a yellow confirmation box, saying that that another borrower has recalled the item that you are trying to check out. 149. Select "Revert waiting status" and click "Yes check out" and confirm the item is checked out and the recall status has reverted to requested. OTHER 150. In your terminal, enter mysql and edit the due date of the checkout to Borrower B to be before today UPDATE issues SET date_due = NOW()-2 WHERE issue_id = X; 151. Go to Borrower A's recalls and click the Actions dropdown. 152. Click "Mark as overdue" and confirm the recall is marked as overdue manually. 153. Go to Tools -> Log Viewer. Check only the Recalls module, and leave all other parameters, and click Submit. 154. Confirm all of the recalls actions that have been made are correctly logged. Note: recalls messaging preferences are introduced in Bug 23781. The recall feature is fully documented at: https://wiki.koha-community.org/wiki/Catalyst_IT_Recalls Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126575|0 |1 is obsolete| | --- Comment #801 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 129313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129313&action=edit Bug 19532: (follow-up) aria-hidden attr on OPAC, and more - removing authnotrequired flag from scripts - fixing opac buttons - chmod +x for recalls test files Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126576|0 |1 is obsolete| | --- Comment #802 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 129314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129314&action=edit Bug 19532: (follow-up) Fixing failing CalcFine.t test Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126577|0 |1 is obsolete| | --- Comment #803 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 129315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129315&action=edit Bug 19532: (follow-up) Fixing OPAC display and staff client errors - fixes the displays of opac-recalls.pl and opac-recall.pl - fix the error on Recalls to pull page - fix JS error preventing Recalled link from showing in checkouts table - fix cancelling of recall when checking out item Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126578|0 |1 is obsolete| | --- Comment #804 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 129316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129316&action=edit Bug 19532: (follow-up) Fix undef recall_id preventing fulfillment of recall Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126579|0 |1 is obsolete| | --- Comment #805 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 129317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129317&action=edit Bug 19532: (follow-up) Fixing tests and QA tools And making reverted ajax message clearer Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126580|0 |1 is obsolete| | --- Comment #806 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 129318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129318&action=edit Bug 19532: (follow-up) Fix calls, tests, syspref settings, checks Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #807 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 129319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129319&action=edit Bug 19532: (QA follow-up) Enable XSLT statuses translation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #808 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I rebased what we had. Didnt check yet. Katrin, Fridolin, Aleisha, David, Victor: When can we work on this patch set this month? Would be handy to plan our actions now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #809 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #808)
I rebased what we had. Didnt check yet.
Katrin, Fridolin, Aleisha, David, Victor: When can we work on this patch set this month? Would be handy to plan our actions now.
+1 Time is sparse, but I'll try to make it work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #810 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #809)
(In reply to Marcel de Rooy from comment #808)
I rebased what we had. Didnt check yet.
Katrin, Fridolin, Aleisha, David, Victor: When can we work on this patch set this month? Would be handy to plan our actions now.
+1
Time is sparse, but I'll try to make it work.
Thanks Katrin. And the others? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #811 from Fridolin Somers <fridolin.somers@biblibre.com> --- Sure, I'm in. At first look code looks pretty mature. I'll listen to QA team. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #812 from Aleisha Amohia <aleisha@catalyst.net.nz> --- I started rewriting before Christmas but couldn't get it sorted in time. Will try to pick up again this week or next. Trying to work out the best way to split everything out. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #813 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Aleisha Amohia from comment #812)
I started rewriting before Christmas but couldn't get it sorted in time. Will try to pick up again this week or next. Trying to work out the best way to split everything out.
Thanks for responding. In order to prevent misunderstandings, are you talking about the current patches or development on top of this patch set? If you are talking about the current set, it would be useless for us to work further on it when you will be rewriting it. Please confirm! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #814 from Aleisha Amohia <aleisha@catalyst.net.nz> --- I am talking about the current patchset. My understanding was that as the patches currently are, they are too big and daunting to effectively test and QA. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org