[Bug 22452] New: 'Caracters' is typo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Bug ID: 22452 Summary: 'Caracters' is typo Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- in mana related templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |josef.moravec@gmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86029&action=edit Bug 22452: Fix typo caracters -> characters There is typo in modal where you can add a comment to mana Test plan: 1) Create subscription from Mana 2) On subscription detail page: report mistake > other a modal is shown --> without patch it reads 'Please enter a new commment (max 35 caracters)' --> with patch it reads 'Please enter a new commment (max 35 characters)' 3) The same in mana search resultss and in reports -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com --- Comment #2 from Michal Denar <black23@gmail.com> --- HI Josef, patch works like charm. But what about typo "commment". Please make fix for this. http://prntscr.com/mu94gv Thank you -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86029|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86220&action=edit Bug 22452: Fix typos in add mana comment modals There are typos in modal where you can add a comment to mana: 'caracters' should be 'characters' 'commment' should be 'comment' Test plan: 1) Create subscription from Mana 2) On subscription detail page: report mistake > other a modal is shown --> without patch it reads 'Please enter a new commment (max 35 caracters)' --> with patch it reads 'Please enter a new comment (max 35 characters)' 3) The same in mana search resultss and in reports -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|'Caracters' is typo |Typos in add a comment to | |Mana modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86220|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 86242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86242&action=edit Bug 22452: Fix typos in add mana comment modals There are typos in modal where you can add a comment to mana: 'caracters' should be 'characters' 'commment' should be 'comment' Test plan: 1) Create subscription from Mana 2) On subscription detail page: report mistake > other a modal is shown --> without patch it reads 'Please enter a new commment (max 35 caracters)' --> with patch it reads 'Please enter a new comment (max 35 characters)' 3) The same in mana search resultss and in reports Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86242|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 86339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86339&action=edit Bug 22452: Fix typos in add mana comment modals There are typos in modal where you can add a comment to mana: 'caracters' should be 'characters' 'commment' should be 'comment' Test plan: 1) Create subscription from Mana 2) On subscription detail page: report mistake > other a modal is shown --> without patch it reads 'Please enter a new commment (max 35 caracters)' --> with patch it reads 'Please enter a new comment (max 35 characters)' 3) The same in mana search resultss and in reports Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17047 CC| |martin.renvoize@ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 [Bug 17047] Mana Knowledge Base : share data -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- New feature not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22746 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22746 [Bug 22746] Another typo found in mana-subscription-search-result.inc (Mana KB) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org