[Bug 15199] New: t/db_dependent/Review.t should not depend on existing data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15199 Bug ID: 15199 Summary: t/db_dependent/Review.t should not depend on existing data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: tomascohen@gmail.com QA Contact: gmcharlt@gmail.com It currently depends on existing patrons and categories. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15199 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15199 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 44909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44909&action=edit Bug 15199: t/db_dependent/Review.t should not depend on existing data This patch makes the tests create a branch and a patron category instead of searching for them on the DB. To test: - Apply the patch on current master - Run $ prove t/db_dependent/Review.t => SUCCESS: Tests pass - Sign off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15199 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15199 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44909|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 44912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44912&action=edit [SIGNED-OFF]Bug 15199: t/db_dependent/Review.t should not depend on existing data This patch makes the tests create a branch and a patron category instead of searching for them on the DB. To test: - Apply the patch on current master - Run $ prove t/db_dependent/Review.t => SUCCESS: Tests pass - Sign off Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> All test pass successful -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15199 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15199 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15199 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44912|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 44942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44942&action=edit [PASSED QA] Bug 15199: t/db_dependent/Review.t should not depend on existing data This patch makes the tests create a branch and a patron category instead of searching for them on the DB. To test: - Apply the patch on current master - Run $ prove t/db_dependent/Review.t => SUCCESS: Tests pass - Sign off Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> All test pass successful Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15199 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org