[Bug 41477] New: Show barcode of item in the action logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41477 Bug ID: 41477 Summary: Show barcode of item in the action logs Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Currently when displaying an item in the log viewer for 'cataloguing' modifications we display text/link like: Item 972 from Bibliographic record 438 Librarians tend to use the barcode as the unique ID of the record, and we should display this info so they can more easily identify the items. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41477 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41477 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 190621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190621&action=edit Bug 41477: Handle deleted items We have a variable 'object_found' - without this we assume the item has been deleted To test: 1 - Delete one of the items you modified, note the itemnumber 2 - Click the 'Modification log' tab - you don't see this item 3 - Search using the itemnumber in 'Object' field 4 - You have empty barcode field and broken links 5 - Apply this patch 6 - Reload 7 - You see the itemnumber and a note that it has been deleted -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41477 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41477 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roman.dolny@jezuici.pl Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- kohadev-koha@kohadevbox:koha(bug_41477)$ git bz apply 41477 Bug 41477 - Show barcode of item in the action logs 190621 - Bug 41477: Handle deleted items Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 41477: Handle deleted items error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt). error: could not build fake ancestor Patch failed at 0001 Bug 41477: Handle deleted items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41477 --- Comment #3 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 190667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190667&action=edit Bug 41477: Display barcode for items in cataloguing action logs This patch displays the barcode, already passed to the template, when viewing modification logs for items. To test: 1 - Find a biblio 2 - Add or edit some items on the biblio 3 - Edit them again to ensure we have some data 4 - Click 'Modification log' tab on the left in biblio view 5 - See items are displayed only by itemnumber 6 - Apply patch 7 - Reload 8 - Now you see the current barcode for the item 9 - Use itemnumber of one of the items as the 'Object' and search 10 - Verify you still see barcode info -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41477 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190621|0 |1 is obsolete| | --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 190668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190668&action=edit Bug 41477: Handle deleted items We have a variable 'object_found' - without this we assume the item has been deleted To test: 1 - Delete one of the items you modified, note the itemnumber 2 - Click the 'Modification log' tab - you don't see this item 3 - Search using the itemnumber in 'Object' field 4 - You have empty barcode field and broken links 5 - Apply this patch 6 - Reload 7 - You see the itemnumber and a note that it has been deleted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41477 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41477 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Roman Dolny <roman.dolny@jezuici.pl> --- QA unhappy - log below. Space character needed twice, before "<span": line 283: Barcode:<span line 293: Itemnumber:<span kohadev-koha@kohadevbox:koha(bug_41477)$ qa Tag v25.05.00-1 found in /kohadevbox/koha — checking out branch main in /kohadevbox/qa-test-tools Already on 'main' Your branch is up to date with 'origin/main'. testing 2 commit(s) (applied to 7776239 '6c Bug 41432: Prefetch items and borr') Processing files [RUNNING] koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt [error] ID0H0orrxh.tt: SyntaxError: Void elements do not have end tags "br" (2:93) [error] 1 | [error] > 2 | Barcode:<span class="barcode">#~189~#</span></br> [error] | ^^^^^ [error] 3 | <a [error] 4 | href="/cgi-bin/koha/catalogue/moredetail.pl?item=#~190~#&biblionumber=#~191~#&bi=#~192~##item#~193~#" [FAIL] koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt Result: [FAIL] koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt FAIL filters missing_filter at line 293 ( Itemnumber:<span class="itemnumber">[% loopro.object %]</span></br>) FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt` Processing additional checks PASS! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41477 --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 191190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191190&action=edit Bug 41477: (follow-up) Fix QA filters and line breaks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41477 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191190|0 |1 is obsolete| | --- Comment #7 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 191191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191191&action=edit Bug 41477: (follow-up) Fix QA filters and line breaks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41477 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41477 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41477 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41477 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190667|0 |1 is obsolete| | Attachment #190668|0 |1 is obsolete| | Attachment #191191|0 |1 is obsolete| | --- Comment #8 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 191598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191598&action=edit Bug 41477: Display barcode for items in cataloguing action logs This patch displays the barcode, already passed to the template, when viewing modification logs for items. To test: 1 - Find a biblio 2 - Add or edit some items on the biblio 3 - Edit them again to ensure we have some data 4 - Click 'Modification log' tab on the left in biblio view 5 - See items are displayed only by itemnumber 6 - Apply patch 7 - Reload 8 - Now you see the current barcode for the item 9 - Use itemnumber of one of the items as the 'Object' and search 10 - Verify you still see barcode info Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41477 --- Comment #9 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 191599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191599&action=edit Bug 41477: Handle deleted items We have a variable 'object_found' - without this we assume the item has been deleted To test: 1 - Delete one of the items you modified, note the itemnumber 2 - Click the 'Modification log' tab - you don't see this item 3 - Search using the itemnumber in 'Object' field 4 - You have empty barcode field and broken links 5 - Apply this patch 6 - Reload 7 - You see the itemnumber and a note that it has been deleted Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41477 --- Comment #10 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 191600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191600&action=edit Bug 41477: (follow-up) Fix QA filters and line breaks Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41477 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41477 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191598|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41477 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191599|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41477 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191600|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41477 --- Comment #11 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 198311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198311&action=edit Bug 41477: Display barcode for items in cataloguing action logs This patch displays the barcode, already passed to the template, when viewing modification logs for items. To test: 1 - Find a biblio 2 - Add or edit some items on the biblio 3 - Edit them again to ensure we have some data 4 - Click 'Modification log' tab on the left in biblio view 5 - See items are displayed only by itemnumber 6 - Apply patch 7 - Reload 8 - Now you see the current barcode for the item 9 - Use itemnumber of one of the items as the 'Object' and search 10 - Verify you still see barcode info Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41477 --- Comment #12 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 198312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198312&action=edit Bug 41477: Handle deleted items We have a variable 'object_found' - without this we assume the item has been deleted To test: 1 - Delete one of the items you modified, note the itemnumber 2 - Click the 'Modification log' tab - you don't see this item 3 - Search using the itemnumber in 'Object' field 4 - You have empty barcode field and broken links 5 - Apply this patch 6 - Reload 7 - You see the itemnumber and a note that it has been deleted Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41477 --- Comment #13 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 198313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198313&action=edit Bug 41477: (follow-up) Fix QA filters and line breaks Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41477 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org