[Bug 32293] New: Terminology: Some budgets are not defined in item records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32293 Bug ID: 32293 Summary: Terminology: Some budgets are not defined in item records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org The error message should use 'funds' not 'budgets': koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js: alert( __("Some budgets are not defined in item records") ) I think that this one appears when you try to add orders from a staged file, but leave the fund empty. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32293 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32293 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 146188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146188&action=edit Bug 32293: Fix terminology in warning when creating orders from staged file When you are ordering from a staged file and the fund is missing, there is a warning: Some budgets are not defined in item records Budgets shoudl be funds here. To test: * Add a new basket * Add an order from a staged file or from a file * Leave the fund values of some selected items empty * Make sure default fund entry is also empty * Warning message should be triggered on saving * Apply patch, repeat, verify it is correct now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32293 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32888 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is currently an issue in bug 32888 that means we can no longer trigger that warning/message as it just uses the first fund found. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32888 [Bug 32888] Ordering from staged records will use first fund from list when none was set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32293 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32293 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32293 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146188|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 146358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146358&action=edit Bug 32293: Fix terminology in warning when creating orders from staged file When you are ordering from a staged file and the fund is missing, there is a warning: Some budgets are not defined in item records Budgets shoudl be funds here. To test: * Add a new basket * Add an order from a staged file or from a file * Leave the fund values of some selected items empty * Make sure default fund entry is also empty * Warning message should be triggered on saving * Apply patch, repeat, verify it is correct now. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32293 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- As the warning can't be triggered until there is a patch for bug 32888, I tested by reviewing the diff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32293 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32293 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146358|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147240&action=edit Bug 32293: Fix terminology in warning when creating orders from staged file When you are ordering from a staged file and the fund is missing, there is a warning: Some budgets are not defined in item records Budgets shoudl be funds here. To test: * Add a new basket * Add an order from a staged file or from a file * Leave the fund values of some selected items empty * Make sure default fund entry is also empty * Warning message should be triggered on saving * Apply patch, repeat, verify it is correct now. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32293 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32293 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32293 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.04 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32293 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32293 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org