[Bug 7201] New: Hold to pull sreport needs extra fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7201 Bug #: 7201 Summary: Hold to pull sreport needs extra fields Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation AssignedTo: kyle.m.hall@gmail.com ReportedBy: srdjan@catalyst.net.nz QAContact: ian.walls@bywatersolutions.com CC: gmcharlt@gmail.com Currently when a periodical has been requested no indication is given of what issue the patron wants. Could you please make it so that the vol field displays, and also the location. In many respects the ' Holds awaiting pickup' is perfect, except for the vol field which is missing there too. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7201 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|kyle.m.hall@gmail.com |srdjan@catalyst.net.nz --- Comment #1 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-11-09 07:34:27 UTC --- Created attachment 6264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6264 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7201 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff Change sponsored?|--- |Sponsored -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7201 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch Status|Needs Signoff |Failed QA --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2011-11-11 15:58:14 UTC --- The copy number is showing, not the volume number field. 952$h is serial enumeration/volume and 952$t is copy number. I'm not sure if we want both to show - but we certainly want $h to show which is what the original request was for. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7201 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6264|0 |1 is obsolete| | --- Comment #3 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-11-15 03:04:35 UTC --- Created attachment 6309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6309 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7201 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff --- Comment #4 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-11-15 03:06:47 UTC --- Actually the original request was for the copy number, just wasn't formulated properly, and I copied it blindly. Serves me right. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7201 --- Comment #5 from Nicole C. Engard <nengard@gmail.com> 2011-11-16 05:38:16 UTC --- Srdjan, Does that mean your new patch should show the enumeration/volume? Cause I'm still not seeing it. Is there a test plan for this patch? Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7201 --- Comment #6 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-11-16 06:46:51 UTC --- Yes, it should show enumeration/volume together with hold number, if enumeration/volume exists on "Holds to Pull" (circ/pendingreserves.pl), "Holds Queue" (circ/view_holdsqueue.pl) and "Holds awaiting pickup" (circ/waitingreserves.pl) reports. As well as copy number. There's no test plan, just confirmation new fields are visible and no issues introduced. Can you please tell us where is enumeration/volume missing? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7201 --- Comment #7 from Nicole C. Engard <nengard@gmail.com> 2011-11-16 15:38:55 UTC --- Created attachment 6318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6318 copy number blank Srdjan, I think I figured out what's wrong (at least why I didn't see things). The Vol info looks like it might be in the call number column instead of the copy/vol column. If that's the way it's supposed to be just let me know. See attached. See in the attached file that the copy number field has numbers for the first two, but the third actually has no copy number in the marc, but it does have an enumeration and that's not showing in that column, it looks like it might be in the call number column. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7201 --- Comment #8 from Nicole C. Engard <nengard@gmail.com> 2011-11-16 15:39:24 UTC --- Created attachment 6319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6319 hold here is the hold line on the bib record - showing the vol info is there. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7201 --- Comment #9 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-11-16 23:07:26 UTC --- I'm not sure whether it is supposed to be like that, it was suggested to put it there. I'm just a developer :) I do vaguely remember though that we put it in the same place elsewhere in the system. If you think it is confusing, or there's a better way of displaying it I'm happy to move it, that is not a big deal. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7201 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Hold to pull sreport needs |Hold to pull report needs |extra fields |extra fields -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7201 Gaetan Boisson <gaetan.boisson@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson@biblibre.com --- Comment #10 from Gaetan Boisson <gaetan.boisson@biblibre.com> 2012-02-03 14:39:54 UTC --- Just tested. The patch works as expected, that is that the volume information is displayed in the callnumber column. I would think it makes more sense to have it in the copynumber column. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7201 --- Comment #11 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2012-02-06 00:52:47 UTC --- That's fine, I can move it. Do you want to wait for some more comments first? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7201 --- Comment #12 from Gaetan Boisson <gaetan.boisson@biblibre.com> 2012-02-06 08:32:27 UTC --- I would rather see it in the copynumber column indeed, because the call number could be the same for different issues of the same serial, which could make things confusing. Also i have rarely seen copynumber used so far. More input would definitely be nice though! Nicole what do you think is best? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7201 --- Comment #13 from Nicole C. Engard <nengard@gmail.com> 2012-02-08 11:46:41 UTC --- I would say that it doesn't belong in the call number column either, but copy number and serial enumeration are two different things. I think if it goes in to the copy number column then the column should be relabeled as 'Copy No/Enumeration' so that people are clear that it's showing two fields of data. Or it should go in to a new column altogether. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7201 --- Comment #14 from Gaetan Boisson <gaetan.boisson@biblibre.com> 2012-02-08 12:17:49 UTC --- Thanks for your input Nicole. Creating a new column could be the best option here imho. But having copynumber renamed to copynumber/enumeration would be perfectly fine with me and probably much easier to implement. Srdjan, you decide i guess ;) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7201 --- Comment #15 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2012-02-08 23:24:53 UTC --- It will take me a couple of years to understand the business enough to make competent decisions, but usually i go for the best if I can, so new column it will be. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7201 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6309|0 |1 is obsolete| | Attachment #6318|0 |1 is obsolete| | Attachment #6319|0 |1 is obsolete| | --- Comment #16 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2012-02-09 00:33:21 UTC --- Created attachment 7519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7519 patch I'm not sure why we placed enumchron next to the call number in the first place... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7201 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7519|0 |1 is obsolete| | --- Comment #17 from Liz Rea <wizzyrea@gmail.com> 2012-02-09 15:50:16 UTC --- Created attachment 7535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7535 bug_7201: Holds reports: add copynumber and enumchron Signed-off-by: Liz Rea <wizzyrea@gmail.com> Data is there and correct - very helpful patch, thanks! passes prove t xt t/db_dependent in line with current master failures. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7201 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7201 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #18 from Ian Walls <koha.sekjal@gmail.com> 2012-02-16 16:50:04 UTC --- I would argue that enumerated chronology and copynumber could live happily in a single column, as they are usually exclusive (books tend to have multiple copies, serials tend to have vol/issues). Having both columns will likely create some unused space in the report, but that's an aesthetics issue to be resolved in a subsequent patch. The functionality here looks good, and passes QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7201 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_6 --- Comment #19 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-17 09:58:41 UTC --- patch pushed with a tiny follow-up fixing some indentation mistakes -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7201 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #20 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This fix was included in the 3.6.x branch prior to 3.6.4. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org